Skip to contentSkip to conversation

drm/i915/bdw: Add BDW support in the i915 debugfs entry

PATCH In review [email protected] 2 participants 2 messages Aug 20, 2014 – Aug 26, 2014

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915/bdw: Add BDW support in the i915 debugfs entry

From: Vedang Patel <[email protected]>

The patch introduces fixes for the debugfs attributes emitted by the i915 driver for GEN8. Currently, it is not emitting the correct
attributes which include the status of RC6 states.

Change-Id Ib2068a0cac9a5wq3f228e547fa1a097ad369d242df
---
 drivers/gpu/drm/i915/i915_debugfs.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/i915_debugfs.c +1 -1
index 850fa59..2296a22 100644
@@ -1329,7 +1329,7 @@ static int i915_drpc_info(struct seq_file *m, void *unused)
 
 	if (IS_VALLEYVIEW(dev))
 		return vlv_drpc_info(m);
-	else if (IS_GEN6(dev) || IS_GEN7(dev))
+	else if (IS_GEN6(dev) || IS_GEN7(dev) || IS_GEN8(dev))
 		return gen6_drpc_info(m);
 	else
 		return ironlake_drpc_info(m);
Signature · 1 line
1.7.9.5
#1 lore raw
Quoted 17 lines · On Wed, Aug 20, 2014 at 12:04:31PM -0700, [email protected] wrote:

From: Vedang Patel <[email protected]>

The patch introduces fixes for the debugfs attributes emitted by the i915 driver for GEN8. Currently, it is not emitting the correct
attributes which include the status of RC6 states.

Change-Id Ib2068a0cac9a5wq3f228e547fa1a097ad369d242df
---
 drivers/gpu/drm/i915/i915_debugfs.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/i915_debugfs.c +0 -0
index 850fa59..2296a22 100644

drivers/gpu/drm/i915/i915_debugfs.c static int i915_drpc_info(struct seq_file *m, void *unused) · line 1332

Quoted 5 lines
drivers/gpu/drm/i915/i915_debugfs.c +1 -1
@@ -1329,7 +1329,7 @@ static int i915_drpc_info(struct seq_file *m, void *unused)
 
 	if (IS_VALLEYVIEW(dev))
 		return vlv_drpc_info(m);
-	else if (IS_GEN6(dev) || IS_GEN7(dev))
+	else if (IS_GEN6(dev) || IS_GEN7(dev) || IS_GEN8(dev))

I think an INTEL_INFO(dev)->gen >= 6 check here looks better and is more future proof. Can you please update the patch accordingly?

Thanks, Daniel

Quoted 10 lines
drivers/gpu/drm/i915/i915_debugfs.c +0 -0
 		return gen6_drpc_info(m);
 	else
 		return ironlake_drpc_info(m);
Signature · 6 lines
1.7.9.5

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 3 lines
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch