Skip to contentSkip to conversation

arm: dts: omap3: Add #iommu-cells to isp iommu

PATCH Superseded Sebastian Reichel 2 participants 2 messages Mar 30, 2015 Device tree bindings

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Sebastian Reichel

author
#0 lore raw

PATCH 1/1 arm: dts: omap3: Add #iommu-cells to isp iommu

Add missing #iommu-cells property to the image signal processor's iommu node. This fixes the binding (property is required according to the generic iommu binding) and removes the following kernel warning triggered once the iommu node is referenced:

[    0.647521] /ocp/isp@480bc000: could not get #iommu-cells for /ocp/mmu@480bd400
Signed-off-by Sebastian Reichel <[email protected]>
Cc Sakari Ailus <[email protected]>
Cc Laurent Pinchart <[email protected]>
---
 arch/arm/boot/dts/omap3.dtsi | 1 +
 1 file changed, 1 insertion(+)
arch/arm/boot/dts/omap3.dtsi +1 -0
index fe0b293..77751ef 100644
@@ -440,6 +440,7 @@
 		};
 
 		mmu_isp: mmu@480bd400 {
+			#iommu-cells = <0>;
 			compatible = "ti,omap2-iommu";
 			reg = <0x480bd400 0x80>;
 			interrupts = <24>;
Signature · 1 line
2.1.4
#1 lore raw

Hi Sebastian,

Quoted 19 lines · Sebastian Reichel

Add missing #iommu-cells property to the image signal processor's iommu node. This fixes the binding (property is required according to the generic iommu binding) and removes the following kernel warning triggered once the iommu node is referenced:

[    0.647521] /ocp/isp@480bc000: could not get #iommu-cells for /ocp/mmu@480bd400
Signed-off-by Sebastian Reichel <[email protected]>
Cc Sakari Ailus <[email protected]>
Cc Laurent Pinchart <[email protected]>
---
 arch/arm/boot/dts/omap3.dtsi | 1 +
 1 file changed, 1 insertion(+)
arch/arm/boot/dts/omap3.dtsi +0 -0
index fe0b293..77751ef 100644

arch/arm/boot/dts/omap3.dtsi line 443

Quoted 4 lines
arch/arm/boot/dts/omap3.dtsi +1 -0
@@ -440,6 +440,7 @@
 		};
 
 		mmu_isp: mmu@480bd400 {
+			#iommu-cells = <0>;

Could you add one for mmu_iva below, too, please?

Quoted 3 lines
arch/arm/boot/dts/omap3.dtsi +0 -0
 			compatible = "ti,omap2-iommu";
 			reg = <0x480bd400 0x80>;
 			interrupts = <24>;
Signature · 4 lines
Kind regards,

Sakari Ailus
e-mail: [email protected]	XMPP: [email protected]