Skip to contentSkip to conversation

arm: dts: omap3: Add #iommu-cells to isp and iva iommu

PATCH In review Sebastian Reichel 3 participants 3 messages Mar 31, 2015 – May 4, 2015 Device tree bindings

lore
Share & tools
lore

Sebastian Reichel

author
#0 lore raw

PATCH v2 1/1 arm: dts: omap3: Add #iommu-cells to isp and iva iommu

Add missing #iommu-cells property to the isp and iva iommu nodes. This fixes the binding (property is required according to the generic iommu binding) and removes the following kernel warning triggered once the iommu nodes are referenced:

[    0.647521] /ocp/isp@480bc000: could not get #iommu-cells for /ocp/mmu@480bd400
Signed-off-by Sebastian Reichel <[email protected]>
Cc Sakari Ailus <[email protected]>
Cc Laurent Pinchart <[email protected]>

---
Changes since PATCHv1:

* Also add property to mmu_iva

---
 arch/arm/boot/dts/omap3.dtsi | 2 ++
 1 file changed, 2 insertions(+)
arch/arm/boot/dts/omap3.dtsi +2 -0
index fe0b293..eb96cf9 100644
@@ -440,6 +440,7 @@
 		};
 
 		mmu_isp: mmu@480bd400 {
+			#iommu-cells = <0>;
 			compatible = "ti,omap2-iommu";
 			reg = <0x480bd400 0x80>;
 			interrupts = <24>;

@@ -448,6 +449,7 @@
 		};
 
 		mmu_iva: mmu@5d000000 {
+			#iommu-cells = <0>;
 			compatible = "ti,omap2-iommu";
 			reg = <0x5d000000 0x80>;
 			interrupts = <28>;
Signature · 1 line
2.1.4
Acked-by on v2 1/1
#1 lore raw
Quoted 10 lines · Sebastian Reichel

Add missing #iommu-cells property to the isp and iva iommu nodes. This fixes the binding (property is required according to the generic iommu binding) and removes the following kernel warning triggered once the iommu nodes are referenced:

[    0.647521] /ocp/isp@480bc000: could not get #iommu-cells for /ocp/mmu@480bd400
Signed-off-by Sebastian Reichel <[email protected]>
Cc Sakari Ailus <[email protected]>
Cc Laurent Pinchart <[email protected]>

Thanks!

Acked-by Sakari Ailus <[email protected]>
Signature · 2 lines
Sakari Ailus
e-mail: [email protected]	XMPP: [email protected]
#2 lore raw
Quoted 8 lines · Sakari Ailus
Quoted 7 lines · Sebastian Reichel

Add missing #iommu-cells property to the isp and iva iommu nodes. This fixes the binding (property is required according to the generic iommu binding) and removes the following kernel warning triggered once the iommu nodes are referenced:

[    0.647521] /ocp/isp@480bc000: could not get #iommu-cells for /ocp/mmu@480bd400
Quoted 7 lines
Quoted 3 lines
Signed-off-by Sebastian Reichel <[email protected]>
Cc Sakari Ailus <[email protected]>
Cc Laurent Pinchart <[email protected]>

Thanks!

Acked-by Sakari Ailus <[email protected]>

Applying into omap-for-v4.1/fixes thanks.

Tony