Crystalcove (CRC) PMIC based panel and pwm control
Subsystems (6)
cover Crystalcove (CRC) PMIC based panel and pwm control
Hi All,
On some of the BYT devices, for DSI panels, the panel enable/disable signals and backlight control are done using the Crystalcove PMIC. This series provides support for the same and has been reviewed earlier on -
http://lists.freedesktop.org/archives/intel-gfx/2015-March/061908.html
This series addresses the review comments with two of the patches already merged in linux-next as -
http://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=e189ca56d91bbf1d3fe2f88ab6858bf919d42adf
http://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=c264f1110d27185f8531602f5fce400a6bbce946
Basically following are implemented -
1. GPIO control for panel enable/disable with GFX device as consumer
2. New PWM chip driver added for CRC PMIC based backlight control
3. i915 is modified to use the CRC gpio chip and the CRC PWM chip to do backlight control. This is now added in the generic panel backlight control infrastructure
All these patches have been tested on AsusT100 and working fine using /sys/class/backlight/intel_backlight interface.
Patches are also verified on android-x86 tree for AsusT100.
Regards
Shobhit
Shobhit Kumar (8):
drivers/gpio/gpiolib: Add support for removing registered consumer
lookup table
drivers/pwm/core: Add support to remove registered consumer lookup
tables
drivers/mfd: Add lookup table for Panel Control as GPIO signal drivers/mfd: Add PWM cell device for Crystalcove PMIC drivers/mfd: ADD PWM lookup table for CRC PMIC based PWM drivers/pwm: Add Crystalcove (CRC) PWM driver
drm/i915: Use the CRC gpio for panel enable/disable drm/i915: Backlight control using CRC PMIC based PWM driver
drivers/gpio/gpiolib.c | 13 +++ drivers/gpu/drm/i915/intel_drv.h | 5 ++ drivers/gpu/drm/i915/intel_dsi.c | 38 ++++++++- drivers/gpu/drm/i915/intel_dsi.h | 6 ++ drivers/gpu/drm/i915/intel_panel.c | 92 ++++++++++++++++++-- drivers/mfd/intel_soc_pmic_core.c | 29 +++++++ drivers/mfd/intel_soc_pmic_crc.c | 3 + drivers/pwm/Kconfig | 7 ++ drivers/pwm/Makefile | 1 + drivers/pwm/core.c | 17 ++++ drivers/pwm/pwm-crc.c | 171 +++++++++++++++++++++++++++++++++++++ include/linux/gpio/machine.h | 1 + include/linux/pwm.h | 5 ++ 13 files changed, 381 insertions(+), 7 deletions(-) create mode 100644 drivers/pwm/pwm-crc.c
Signature · 6 lines
2.1.0 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 1/8 drivers/gpio/gpiolib: Add support for removing registered consumer lookup table
In case we unload and load a driver module again that is registering a lookup table, without this it will result in multiple entries. Provide an option to remove the lookup table on driver unload
v2: Ccing maintainers
--- drivers/gpio/gpiolib.c | 13 +++++++++++++ include/linux/gpio/machine.h | 1 + 2 files changed, 14 insertions(+)
drivers/gpio/gpiolib.c +13 -0
@@ -1658,6 +1658,19 @@ void gpiod_add_lookup_table(struct gpiod_lookup_table *table)mutex_unlock (&gpio_lookup_lock); } +/** +* gpiod_remove_lookup_table() - unregister GPIO device consumers +* @table: table of consumers to unregister +*/ +void gpiod_remove_lookup_table (struct gpiod_lookup_table *table) +{ +mutex_lock (&gpio_lookup_lock); + +list_del (&table->list); + +mutex_unlock (&gpio_lookup_lock); +} +static struct gpio_desc *of_find_gpio (struct device *dev,const char *con_id,unsigned int idx,enum gpio_lookup_flags *flags)
include/linux/gpio/machine.h +1 -0
@@ -57,5 +57,6 @@ struct gpiod_lookup_table { }void gpiod_add_lookup_table (struct gpiod_lookup_table *table); +void gpiod_remove_lookup_table (struct gpiod_lookup_table *table);#endif /* __LINUX_GPIO_MACHINE_H */
Signature · 1 line
2.1.0
PATCH 2/8 drivers/pwm/core: Add support to remove registered consumer lookup tables
In reply to Shobhit KumarIn case some drivers are unloading, they can remove lookup tables which they would have registered during their load time to avoid redundant entries if loaded again
v2: Ccing maintainers
--- drivers/pwm/core.c | 17 +++++++++++++++++ include/linux/pwm.h | 5 +++++ 2 files changed, 22 insertions(+)
drivers/pwm/core.c +17 -0
@@ -586,6 +586,23 @@ void pwm_add_table(struct pwm_lookup *table, size_t num) }/** +* pwm_remove_table() - un-register PWM device consumers +* @table: array of consumers to un-register +* @num: number of consumers in table +*/ +void pwm_remove_table (struct pwm_lookup *table,size_t num) +{ +mutex_lock (&pwm_lookup_lock); + +while (num--) { +list_del (&table->list); + table++; + } + +mutex_unlock (&pwm_lookup_lock); +} + +/** * pwm_get() - look up and request a PWM device * @dev: device for PWM consumer * @con_id: consumer name
include/linux/pwm.h +5 -0
@@ -290,10 +290,15 @@ struct pwm_lookup {#if IS_ENABLED (CONFIG_PWM )void pwm_add_table (struct pwm_lookup *table,size_t num); +void pwm_remove_table (struct pwm_lookup *table,size_t num);#else static inline void pwm_add_table (struct pwm_lookup *table,size_t num) { } + +static inline void pwm_remove_table (struct pwm_lookup *table,size_t num) +{ +}#endif #ifdef CONFIG_PWM_SYSFS
Signature · 1 line
2.1.0
PATCH 3/8 drivers/mfd: Add lookup table for Panel Control as GPIO signal
In reply to Shobhit KumarOn some Intel SoC platforms, the panel enable/disable signals are controlled by CRC PMIC. Add those control as a new GPIO in a lookup table for gpio-crystalcove chip during CRC driver load
v2: Make the lookup table static (Thierry)
Remove the lookup table during driver remove (Thierry)
--- drivers/mfd/intel_soc_pmic_core.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+)
drivers/mfd/intel_soc_pmic_core.c +17 -0
@@ -24,8 +24,19 @@#include <linux/acpi.h> #include <linux/regmap.h> #include <linux/mfd/intel_soc_pmic.h> +#include <linux/gpio/machine.h> #include "intel_soc_pmic_core.h" +/* Lookup table for the Panel Enable/Disable line as GPIO signals */ +static struct gpiod_lookup_table panel_gpio_table = { +/* Intel GFX is consumer */ + .dev_id ="0000:00:02.0" , + .table = { +/* Panel EN/DISABLE */ +GPIO_LOOKUP ("gpio_crystalcove" ,94 ,"panel" ,GPIO_ACTIVE_HIGH ), + }, +}; +static int intel_soc_pmic_find_gpio_irq (struct device *dev) {struct gpio_desc *desc;
@@ -85,6 +96,9 @@ static int intel_soc_pmic_i2c_probe(struct i2c_client *i2c,if (ret)dev_warn (dev,"Can't enable IRQ as wake source: %d\n" , ret); +/* Add lookup table binding for Panel Control to the GPIO Chip */ +gpiod_add_lookup_table (&panel_gpio_table); + ret =mfd_add_devices (dev,-1 , config->cell_dev, config->n_cell_devs,NULL ,0 ,regmap_irq_get_domain (pmic->irq_chip_data));
@@ -104,6 +118,9 @@ static int intel_soc_pmic_i2c_remove(struct i2c_client *i2c)regmap_del_irq_chip (pmic->irq, pmic->irq_chip_data); +/* Remove lookup table for Panel Control from the GPIO Chip */ +gpiod_remove_lookup_table (&panel_gpio_table); +mfd_remove_devices (&i2c->dev);return 0 ;
Signature · 1 line
2.1.0
PATCH 4/8 drivers/mfd: Add PWM cell device for Crystalcove PMIC
In reply to Shobhit KumarNeeded for PWM control suuported by the PMIC
--- drivers/mfd/intel_soc_pmic_crc.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/mfd/intel_soc_pmic_crc.c +3 -0
@@ -109,6 +109,9 @@ static struct mfd_cell crystal_cove_dev[] = { { .name = "crystal_cove_pmic", }, + { + .name = "crystal_cove_pwm", + }, }; static const struct regmap_config crystal_cove_regmap_config = {
Signature · 6 lines
2.1.0 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 5/8 drivers/mfd: ADD PWM lookup table for CRC PMIC based PWM
In reply to Shobhit KumarOn some BYT PLatform the PWM is controlled using CRC PMIC. Add a lookup entry for the same to be used by the consumer (Intel GFX)
v2: Remove the lookup table on driver unload (Thierry)
--- drivers/mfd/intel_soc_pmic_core.c | 12 ++++++++++++ 1 file changed, 12 insertions(+)
drivers/mfd/intel_soc_pmic_core.c +12 -0
@@ -25,6 +25,7 @@#include <linux/regmap.h> #include <linux/mfd/intel_soc_pmic.h> #include <linux/gpio/machine.h> +#include <linux/pwm.h> #include "intel_soc_pmic_core.h" /* Lookup table for the Panel Enable/Disable line as GPIO signals */
@@ -37,6 +38,11 @@ static struct gpiod_lookup_table panel_gpio_table = { }, }; +/* PWM consumed by the Intel GFX */ +static struct pwm_lookup crc_pwm_lookup[] = { +PWM_LOOKUP ("crystal_cove_pwm" ,0 ,"0000:00:02.0" ,"pwm_backlight" ,0 ,PWM_POLARITY_NORMAL ), +}; +static int intel_soc_pmic_find_gpio_irq (struct device *dev) {struct gpio_desc *desc;
@@ -99,6 +105,9 @@ static int intel_soc_pmic_i2c_probe(struct i2c_client *i2c,/* Add lookup table binding for Panel Control to the GPIO Chip */ gpiod_add_lookup_table (&panel_gpio_table); +/* Add lookup table for crc-pwm */ +pwm_add_table (crc_pwm_lookup,ARRAY_SIZE (crc_pwm_lookup)); + ret =mfd_add_devices (dev,-1 , config->cell_dev, config->n_cell_devs,NULL ,0 ,regmap_irq_get_domain (pmic->irq_chip_data));
@@ -121,6 +130,9 @@ static int intel_soc_pmic_i2c_remove(struct i2c_client *i2c)/* Remove lookup table for Panel Control from the GPIO Chip */ gpiod_remove_lookup_table (&panel_gpio_table); +/* remove crc-pwm lookup table */ +pwm_remove_table (crc_pwm_lookup,ARRAY_SIZE (crc_pwm_lookup)); +mfd_remove_devices (&i2c->dev);return 0 ;
Signature · 6 lines
2.1.0 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 6/8 drivers/pwm: Add Crystalcove (CRC) PWM driver
In reply to Shobhit KumarThe Crystalcove PMIC controls PWM signals and this driver exports that capability as a PWM chip driver. This is platform device implementtaion of the drivers/mfd cell device for CRC PMIC
v2: Use the existing config callback with duty_ns and period_ns(Thierry)
--- drivers/pwm/Kconfig | 7 +++ drivers/pwm/Makefile | 1 + drivers/pwm/pwm-crc.c | 171 ++++++++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 179 insertions(+) create mode 100644 drivers/pwm/pwm-crc.c
drivers/pwm/Kconfig +7 -0
@@ -183,6 +183,13 @@ config PWM_LPC32XX To compile this driver as a module, choose M here: the module will be called pwm-lpc32xx. +config PWM_CRC + bool "Intel Crystalcove (CRC) PWM support" + depends on X86 && INTEL_SOC_PMIC + help + Generic PWM framework driver for Crystalcove (CRC) PMIC based PWM + control. + config PWM_LPSS tristate "Intel LPSS PWM support" depends on X86
drivers/pwm/Makefile +1 -0
@@ -35,3 +35,4 @@ obj-$(CONFIG_PWM_TIPWMSS) += pwm-tipwmss.o obj-$(CONFIG_PWM_TWL) += pwm-twl.o obj-$(CONFIG_PWM_TWL_LED) += pwm-twl-led.o obj-$(CONFIG_PWM_VT8500) += pwm-vt8500.o +obj-$(CONFIG_PWM_CRC) += pwm-crc.o
drivers/pwm/pwm-crc.c new file +171 -0
171 lines not on this page · raw message
Signature · 6 lines
2.1.0 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 7/8 drm/i915: Use the CRC gpio for panel enable/disable
In reply to Shobhit KumarThe CRC (Crystal Cove) PMIC, controls the panel enable and disable signals for BYT for dsi panels. This is indicated in the VBT fields. Use that to initialize and use GPIO based control for these signals.
v2: Use the newer gpiod interface(Alexandre)
v3: Remove the redundant checks and unused code (Ville)
--- drivers/gpu/drm/i915/intel_dsi.c | 32 ++++++++++++++++++++++++++++++-- drivers/gpu/drm/i915/intel_dsi.h | 6 ++++++ 2 files changed, 36 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/intel_dsi.c +30 -2
@@ -31,6 +31,7 @@#include <drm/drm_panel.h> #include <drm/drm_mipi_dsi.h> #include <linux/slab.h> +#include <linux/gpio/consumer.h> #include "i915_drv.h" #include "intel_drv.h" #include "intel_dsi.h"
@@ -415,6 +416,12 @@ static void intel_dsi_pre_enable(struct intel_encoder *encoder)DRM_DEBUG_KMS ("\n" ); +/* Panel Enable over CRC PMIC */ +if (intel_dsi->gpio_panel) +gpiod_set_value_cansleep (intel_dsi->gpio_panel,1 ); + +msleep (intel_dsi->panel_on_delay); +/* Disable DPOunit clock gating, can stall pipe * and we need DPLL REFA always enabled */ tmp =I915_READ (DPLL (pipe));
@@ -432,8 +439,6 @@ static void intel_dsi_pre_enable(struct intel_encoder *encoder)/* put device in ready state */ intel_dsi_device_ready (encoder); -msleep (intel_dsi->panel_on_delay); -drm_panel_prepare (intel_dsi->panel);for_each_dsi_port (port, intel_dsi->ports)
@@ -576,6 +581,10 @@ static void intel_dsi_post_disable(struct intel_encoder *encoder)msleep (intel_dsi->panel_off_delay);msleep (intel_dsi->panel_pwr_cycle_delay); + +/* Panel Disable over CRC PMIC */ +if (intel_dsi->gpio_panel) +gpiod_set_value_cansleep (intel_dsi->gpio_panel,0 ); } static bool intel_dsi_get_hw_state(struct intel_encoder *encoder,
@@ -955,6 +964,11 @@ static void intel_dsi_encoder_destroy(struct drm_encoder *encoder)/* XXX: Logically this call belongs in the panel driver. */ drm_panel_remove (intel_dsi->panel); } + +/* dispose of the gpios */ +if (intel_dsi->gpio_panel) +gpiod_put (intel_dsi->gpio_panel); +intel_encoder_destroy (encoder); }
@@ -1071,6 +1085,20 @@ void intel_dsi_init(struct drm_device *dev) goto err; } +/* +* In case of BYT with CRC PMIC, we need to use GPIO for +* Panel control. +*/ +if (dev_priv->vbt.dsi.config->pwm_blc ==PPS_BLC_PMIC ) { + intel_dsi->gpio_panel = +gpiod_get (dev->dev,"panel" ,GPIOD_OUT_HIGH ); + +if (IS_ERR (intel_dsi->gpio_panel)) { +DRM_ERROR ("Failed to own gpio for panel control\n" ); + intel_dsi->gpio_panel =NULL ; + } + } + intel_encoder->type =INTEL_OUTPUT_DSI ; intel_encoder->cloneable =0 ; drm_connector_init(dev, connector, &intel_dsi_connector_funcs,
drivers/gpu/drm/i915/intel_dsi.h +6 -0
@@ -29,6 +29,9 @@#include <drm/drm_mipi_dsi.h> #include "intel_drv.h" +#define PPS_BLC_PMIC 0 +#define PPS_BLC_SOC 1 +/* Dual Link support */ #define DSI_DUAL_LINK_NONE 0#define DSI_DUAL_LINK_FRONT_BACK 1
@@ -42,6 +45,9 @@ struct intel_dsi {struct drm_panel *panel;struct intel_dsi_host *dsi_hosts[I915_MAX_PORTS ]; +/* GPIO Desc for CRC based Panel control */ +struct gpio_desc *gpio_panel; +struct intel_connector *attached_connector;/* bit mask of ports being driven */
Signature · 6 lines
2.1.0 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 8/8 drm/i915: Backlight control using CRC PMIC based PWM driver
In reply to Shobhit KumarUse the CRC PWM device in intel_panel.c and add new MIPI backlight specififc callbacks
v2: Modify to use pwm_config callback
--- drivers/gpu/drm/i915/intel_drv.h | 5 +++ drivers/gpu/drm/i915/intel_dsi.c | 6 +++ drivers/gpu/drm/i915/intel_panel.c | 92 +++++++++++++++++++++++++++++++++++--- 3 files changed, 98 insertions(+), 5 deletions(-)
drivers/gpu/drm/i915/intel_drv.h +5 -0
@@ -182,7 +182,12 @@ struct intel_panel {bool enabled;bool combination_mode;/* gen 2/4 only */ bool active_low_pwm; + +/* PWM chip */ +struct pwm_device *pwm; +struct backlight_device *device; + } backlight;void (*backlight_power)(struct intel_connector *,bool enable);
drivers/gpu/drm/i915/intel_dsi.c +6 -0
@@ -402,6 +402,8 @@ static void intel_dsi_enable(struct intel_encoder *encoder)intel_dsi_port_enable (encoder); } + +intel_panel_enable_backlight (intel_dsi->attached_connector); }static void intel_dsi_pre_enable (struct intel_encoder *encoder)
@@ -466,6 +468,8 @@ static void intel_dsi_pre_disable(struct intel_encoder *encoder)DRM_DEBUG_KMS ("\n" ); +intel_panel_disable_backlight (intel_dsi->attached_connector); +if (is_vid_mode (intel_dsi)) {/* Send Shutdown command to the panel in LP mode */ for_each_dsi_port (port, intel_dsi->ports)
@@ -1132,6 +1136,8 @@ void intel_dsi_init(struct drm_device *dev) }intel_panel_init (&intel_connector->panel, fixed_mode,NULL ); +intel_panel_setup_backlight (connector, + (intel_encoder->crtc_mask = (1 <<PIPE_A )) ?PIPE_A :PIPE_B );return ;
drivers/gpu/drm/i915/intel_panel.c +87 -5
142 lines not on this page · raw message
Signature · 6 lines
2.1.0 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH 5/8] drivers/mfd: ADD PWM lookup table for CRC PMIC based PWM
In reply to Shobhit KumarQuoted 5 lines · Shobhit Kumar
On some BYT PLatform the PWM is controlled using CRC PMIC. Add a lookup entry for the same to be used by the consumer (Intel GFX)
v2: Remove the lookup table on driver unload (Thierry)
Quoted 8 lines
CC Samuel Ortiz <[email protected]>Cc Linus Walleij <[email protected]>Cc Alexandre Courbot <[email protected]>Cc Thierry Reding <[email protected]>Signed-off-by Shobhit Kumar <[email protected]>--- drivers/mfd/intel_soc_pmic_core.c | 12 ++++++++++++ 1 file changed, 12 insertions(+)
How do you expect this set to be managed?
Quoted 44 lines
drivers/mfd/intel_soc_pmic_core.c +12
-0@@ -25,6 +25,7 @@#include <linux/regmap.h> #include <linux/mfd/intel_soc_pmic.h> #include <linux/gpio/machine.h> +#include <linux/pwm.h> #include "intel_soc_pmic_core.h" /* Lookup table for the Panel Enable/Disable line as GPIO signals */ @@ -37,6 +38,11 @@ static struct gpiod_lookup_table panel_gpio_table = { }, }; +/* PWM consumed by the Intel GFX */ +static struct pwm_lookup crc_pwm_lookup[] = { +PWM_LOOKUP ("crystal_cove_pwm" ,0 ,"0000:00:02.0" ,"pwm_backlight" ,0 ,PWM_POLARITY_NORMAL ), +}; +static int intel_soc_pmic_find_gpio_irq (struct device *dev) {struct gpio_desc *desc;@@ -99,6 +105,9 @@ static int intel_soc_pmic_i2c_probe(struct i2c_client *i2c,/* Add lookup table binding for Panel Control to the GPIO Chip */ gpiod_add_lookup_table (&panel_gpio_table); +/* Add lookup table for crc-pwm */ +pwm_add_table (crc_pwm_lookup,ARRAY_SIZE (crc_pwm_lookup)); + ret =mfd_add_devices (dev,-1 , config->cell_dev, config->n_cell_devs,NULL ,0 ,regmap_irq_get_domain (pmic->irq_chip_data));@@ -121,6 +130,9 @@ static int intel_soc_pmic_i2c_remove(struct i2c_client *i2c)/* Remove lookup table for Panel Control from the GPIO Chip */ gpiod_remove_lookup_table (&panel_gpio_table); +/* remove crc-pwm lookup table */ +pwm_remove_table (crc_pwm_lookup,ARRAY_SIZE (crc_pwm_lookup)); +mfd_remove_devices (&i2c->dev);return 0 ;
Signature · 4 lines
Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
Re: [PATCH 4/8] drivers/mfd: Add PWM cell device for Crystalcove PMIC
In reply to Shobhit KumarQuoted 10 lines · Shobhit Kumar
Needed for PWM control suuported by the PMIC
CC Samuel Ortiz <[email protected]>Cc Linus Walleij <[email protected]>Cc Alexandre Courbot <[email protected]>Cc Thierry Reding <[email protected]>Signed-off-by Shobhit Kumar <[email protected]>--- drivers/mfd/intel_soc_pmic_crc.c | 3 +++ 1 file changed, 3 insertions(+)
For my own reference:
Quoted 14 lines
drivers/mfd/intel_soc_pmic_crc.c +3
-0@@ -109,6 +109,9 @@ static struct mfd_cell crystal_cove_dev[] = { { .name = "crystal_cove_pmic", }, + { + .name = "crystal_cove_pwm", + }, }; static const struct regmap_config crystal_cove_regmap_config = {
Signature · 8 lines
Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 3/8] drivers/mfd: Add lookup table for Panel Control as GPIO signal
In reply to Shobhit KumarQuoted 7 lines · Shobhit Kumar
On some Intel SoC platforms, the panel enable/disable signals are controlled by CRC PMIC. Add those control as a new GPIO in a lookup table for gpio-crystalcove chip during CRC driver load
v2: Make the lookup table static (Thierry)
Remove the lookup table during driver remove (Thierry)
Quoted 8 lines
CC Samuel Ortiz <[email protected]>Cc Linus Walleij <[email protected]>Cc Alexandre Courbot <[email protected]>Cc Thierry Reding <[email protected]>Signed-off-by Shobhit Kumar <[email protected]>--- drivers/mfd/intel_soc_pmic_core.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+)
I have no idea what this stuff is, but it looks plausible.
For my own reference:
Quoted 44 lines
drivers/mfd/intel_soc_pmic_core.c +17
-0@@ -24,8 +24,19 @@#include <linux/acpi.h> #include <linux/regmap.h> #include <linux/mfd/intel_soc_pmic.h> +#include <linux/gpio/machine.h> #include "intel_soc_pmic_core.h" +/* Lookup table for the Panel Enable/Disable line as GPIO signals */ +static struct gpiod_lookup_table panel_gpio_table = { +/* Intel GFX is consumer */ + .dev_id ="0000:00:02.0" , + .table = { +/* Panel EN/DISABLE */ +GPIO_LOOKUP ("gpio_crystalcove" ,94 ,"panel" ,GPIO_ACTIVE_HIGH ), + }, +}; +static int intel_soc_pmic_find_gpio_irq (struct device *dev) {struct gpio_desc *desc;@@ -85,6 +96,9 @@ static int intel_soc_pmic_i2c_probe(struct i2c_client *i2c,if (ret)dev_warn (dev,"Can't enable IRQ as wake source: %d\n" , ret); +/* Add lookup table binding for Panel Control to the GPIO Chip */ +gpiod_add_lookup_table (&panel_gpio_table); + ret =mfd_add_devices (dev,-1 , config->cell_dev, config->n_cell_devs,NULL ,0 ,regmap_irq_get_domain (pmic->irq_chip_data));@@ -104,6 +118,9 @@ static int intel_soc_pmic_i2c_remove(struct i2c_client *i2c)regmap_del_irq_chip (pmic->irq, pmic->irq_chip_data); +/* Remove lookup table for Panel Control from the GPIO Chip */ +gpiod_remove_lookup_table (&panel_gpio_table); +mfd_remove_devices (&i2c->dev);return 0 ;
Signature · 4 lines
Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
Re: [PATCH 3/8] drivers/mfd: Add lookup table for Panel Control as GPIO signal
In reply to Shobhit KumarBy the way, your subject lines are messed up.
They should adhere to the conventions laid down by the Maintainers.
git log --oneline -- drivers/<subsystem>
Quoted 60 lines
On some Intel SoC platforms, the panel enable/disable signals are controlled by CRC PMIC. Add those control as a new GPIO in a lookup table for gpio-crystalcove chip during CRC driver load
v2: Make the lookup table static (Thierry)
Remove the lookup table during driver remove (Thierry)CC Samuel Ortiz <[email protected]>Cc Linus Walleij <[email protected]>Cc Alexandre Courbot <[email protected]>Cc Thierry Reding <[email protected]>Signed-off-by Shobhit Kumar <[email protected]>--- drivers/mfd/intel_soc_pmic_core.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+)drivers/mfd/intel_soc_pmic_core.c +17
-0@@ -24,8 +24,19 @@#include <linux/acpi.h> #include <linux/regmap.h> #include <linux/mfd/intel_soc_pmic.h> +#include <linux/gpio/machine.h> #include "intel_soc_pmic_core.h" +/* Lookup table for the Panel Enable/Disable line as GPIO signals */ +static struct gpiod_lookup_table panel_gpio_table = { +/* Intel GFX is consumer */ + .dev_id ="0000:00:02.0" , + .table = { +/* Panel EN/DISABLE */ +GPIO_LOOKUP ("gpio_crystalcove" ,94 ,"panel" ,GPIO_ACTIVE_HIGH ), + }, +}; +static int intel_soc_pmic_find_gpio_irq (struct device *dev) {struct gpio_desc *desc;@@ -85,6 +96,9 @@ static int intel_soc_pmic_i2c_probe(struct i2c_client *i2c,if (ret)dev_warn (dev,"Can't enable IRQ as wake source: %d\n" , ret); +/* Add lookup table binding for Panel Control to the GPIO Chip */ +gpiod_add_lookup_table (&panel_gpio_table); + ret =mfd_add_devices (dev,-1 , config->cell_dev, config->n_cell_devs,NULL ,0 ,regmap_irq_get_domain (pmic->irq_chip_data));@@ -104,6 +118,9 @@ static int intel_soc_pmic_i2c_remove(struct i2c_client *i2c)regmap_del_irq_chip (pmic->irq, pmic->irq_chip_data); +/* Remove lookup table for Panel Control from the GPIO Chip */ +gpiod_remove_lookup_table (&panel_gpio_table); +mfd_remove_devices (&i2c->dev);return 0 ;
Signature · 8 lines
Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 3/8] drivers/mfd: Add lookup table for Panel Control as GPIO signal
In reply to Lee JonesQuoted 18 lines · Lee Jones
Quoted 7 lines · Shobhit Kumar
On some Intel SoC platforms, the panel enable/disable signals are controlled by CRC PMIC. Add those control as a new GPIO in a lookup table for gpio-crystalcove chip during CRC driver load
v2: Make the lookup table static (Thierry)
Remove the lookup table during driver remove (Thierry)Quoted 8 lines
CC Samuel Ortiz <[email protected]>Cc Linus Walleij <[email protected]>Cc Alexandre Courbot <[email protected]>Cc Thierry Reding <[email protected]>Signed-off-by Shobhit Kumar <[email protected]>--- drivers/mfd/intel_soc_pmic_core.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+)
Quoted 1 line
I have no idea what this stuff is, but it looks plausible.
The CRC PMIC controls the panel enable/disable signal using one of GPIO like lines. It was agreed by Linus Walleij to go this way. The matching crystalcove gpio changes are already merged in Linux next as -
http://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=e189ca56d91bbf1d3fe2f88ab6858bf919d42adf
This just adds a consumer lookup table for the gpio. Since we do not have a DT or board files, and since this was part of CRC driver, just added the lookup table during CRC driver load itself. Same is done for PWM in a later patch.
Regards
Shobhit
Quoted 49 lines
For my own reference:
Acked-by Lee Jones <[email protected]>Quoted 44 lines
drivers/mfd/intel_soc_pmic_core.c +17
-0@@ -24,8 +24,19 @@#include <linux/acpi.h> #include <linux/regmap.h> #include <linux/mfd/intel_soc_pmic.h> +#include <linux/gpio/machine.h> #include "intel_soc_pmic_core.h" +/* Lookup table for the Panel Enable/Disable line as GPIO signals */ +static struct gpiod_lookup_table panel_gpio_table = { +/* Intel GFX is consumer */ + .dev_id ="0000:00:02.0" , + .table = { +/* Panel EN/DISABLE */ +GPIO_LOOKUP ("gpio_crystalcove" ,94 ,"panel" ,GPIO_ACTIVE_HIGH ), + }, +}; +static int intel_soc_pmic_find_gpio_irq (struct device *dev) {struct gpio_desc *desc;@@ -85,6 +96,9 @@ static int intel_soc_pmic_i2c_probe(struct i2c_client *i2c,if (ret)dev_warn (dev,"Can't enable IRQ as wake source: %d\n" , ret); +/* Add lookup table binding for Panel Control to the GPIO Chip */ +gpiod_add_lookup_table (&panel_gpio_table); + ret =mfd_add_devices (dev,-1 , config->cell_dev, config->n_cell_devs,NULL ,0 ,regmap_irq_get_domain (pmic->irq_chip_data));@@ -104,6 +118,9 @@ static int intel_soc_pmic_i2c_remove(struct i2c_client *i2c)regmap_del_irq_chip (pmic->irq, pmic->irq_chip_data); +/* Remove lookup table for Panel Control from the GPIO Chip */ +gpiod_remove_lookup_table (&panel_gpio_table); +mfd_remove_devices (&i2c->dev);return 0 ;
Re: [PATCH 6/8] drivers/pwm: Add Crystalcove (CRC) PWM driver
In reply to Shobhit KumarQuoted 12 lines · Shobhit Kumar
drivers/pwm/Kconfig +6
-0+config PWM_CRC + bool "Intel Crystalcove (CRC) PWM support" + depends on X86 && INTEL_SOC_PMIC + help + Generic PWM framework driver for Crystalcove (CRC) PMIC based PWM + control.
drivers/pwm/Makefile
Quoted 2 lines
drivers/pwm/Makefile +1
-0+obj-$(CONFIG_PWM_CRC) += pwm-crc.o
PWM_CRC is a bool symbol. So pwm-crc.o can never be part of a module.
(If I'm wrong, and that object file can actually be part of a module, you can stop reading here.)
drivers/pwm/pwm-crc.c
Quoted 4 lines
drivers/pwm/pwm-crc.c new file +1
-0+#include <linux/module.h>
Perhaps this include is not needed.
drivers/pwm/pwm-crc.c line 113
Quoted 5 lines
drivers/pwm/pwm-crc.c new file +5
-0+static const struct pwm_ops crc_pwm_ops = { + .config = crc_pwm_config, + .enable = crc_pwm_enable, + .disable = crc_pwm_disable, + .owner =THIS_MODULE ,
For built-in only code THIS_MODULE is basically equivalent to NULL (see include/linux/export.h). So I guess this line can be dropped.
drivers/pwm/pwm-crc.c line 167
Quoted 11 lines
drivers/pwm/pwm-crc.c new file +10
-0+}; +static struct platform_driver crystalcove_pwm_driver = { + .probe = crystalcove_pwm_probe, + .remove = crystalcove_pwm_remove, + .driver = { + .name ="crystal_cove_pwm" , + }, +}; + +module_platform_driver (crystalcove_pwm_driver);
Speaking from memory: for built-in only code this is equivalent to calling
platform_driver_register(&crystalcove_pwm_driver);
from a wrapper, and marking that wrapper with device_initcall().
drivers/pwm/pwm-crc.c line 171
Quoted 3 lines
drivers/pwm/pwm-crc.c new file +3
-0+MODULE_AUTHOR ("Shobhit Kumar <[email protected]>" ); +MODULE_DESCRIPTION ("Intel Crystal Cove PWM Driver" ); +MODULE_LICENSE ("GPL v2" );
These macros will be effectively preprocessed away for built-in only code.
Paul Bolle
Re: [PATCH 8/8] drm/i915: Backlight control using CRC PMIC based PWM driver
In reply to Shobhit KumarTask id: 6290 -------------------------------------Summary-------------------------------------
Platform Delta drm-intel-nightly Series Applied
PNV 276/276 276/276 ILK 301/301 301/301 SNB 316/316 316/316 IVB 342/342 342/342 BYT 286/286 286/286 BDW 321/321 321/321
-------------------------------------Detailed-------------------------------------
Platform Test drm-intel-nightly Series Applied
Note: You need to pay more attention to line start with '*'
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 1/8 gpiolib: Add support for removing registered consumer lookup table
In reply to Shobhit KumarIn case we unload and load a driver module again that is registering a lookup table, without this it will result in multiple entries. Provide an option to remove the lookup table on driver unload
v2: Ccing maintainers
v3: Correct the subject line (Lee jones)
--- drivers/gpio/gpiolib.c | 13 +++++++++++++ include/linux/gpio/machine.h | 1 + 2 files changed, 14 insertions(+)
drivers/gpio/gpiolib.c +13 -0
@@ -1658,6 +1658,19 @@ void gpiod_add_lookup_table(struct gpiod_lookup_table *table)mutex_unlock (&gpio_lookup_lock); } +/** +* gpiod_remove_lookup_table() - unregister GPIO device consumers +* @table: table of consumers to unregister +*/ +void gpiod_remove_lookup_table (struct gpiod_lookup_table *table) +{ +mutex_lock (&gpio_lookup_lock); + +list_del (&table->list); + +mutex_unlock (&gpio_lookup_lock); +} +static struct gpio_desc *of_find_gpio (struct device *dev,const char *con_id,unsigned int idx,enum gpio_lookup_flags *flags)
include/linux/gpio/machine.h +1 -0
@@ -57,5 +57,6 @@ struct gpiod_lookup_table { }void gpiod_add_lookup_table (struct gpiod_lookup_table *table); +void gpiod_remove_lookup_table (struct gpiod_lookup_table *table);#endif /* __LINUX_GPIO_MACHINE_H */
Signature · 6 lines
2.1.0 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 2/8 pwm: core: Add support to remove registered consumer lookup tables
In reply to Shobhit KumarIn case some drivers are unloading, they can remove lookup tables which they would have registered during their load time to avoid redundant entries if loaded again
v2: Ccing maintainers
v3: Correct the subject line (Lee jones)
--- drivers/pwm/core.c | 17 +++++++++++++++++ include/linux/pwm.h | 5 +++++ 2 files changed, 22 insertions(+)
drivers/pwm/core.c +17 -0
@@ -586,6 +586,23 @@ void pwm_add_table(struct pwm_lookup *table, size_t num) }/** +* pwm_remove_table() - un-register PWM device consumers +* @table: array of consumers to un-register +* @num: number of consumers in table +*/ +void pwm_remove_table (struct pwm_lookup *table,size_t num) +{ +mutex_lock (&pwm_lookup_lock); + +while (num--) { +list_del (&table->list); + table++; + } + +mutex_unlock (&pwm_lookup_lock); +} + +/** * pwm_get() - look up and request a PWM device * @dev: device for PWM consumer * @con_id: consumer name
include/linux/pwm.h +5 -0
@@ -290,10 +290,15 @@ struct pwm_lookup {#if IS_ENABLED (CONFIG_PWM )void pwm_add_table (struct pwm_lookup *table,size_t num); +void pwm_remove_table (struct pwm_lookup *table,size_t num);#else static inline void pwm_add_table (struct pwm_lookup *table,size_t num) { } + +static inline void pwm_remove_table (struct pwm_lookup *table,size_t num) +{ +}#endif #ifdef CONFIG_PWM_SYSFS
Signature · 6 lines
2.1.0 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 3/8 mfd: intel_soc_pmic_core: Add lookup table for Panel Control as GPIO signal
In reply to Shobhit KumarOn some Intel SoC platforms, the panel enable/disable signals are controlled by CRC PMIC. Add those control as a new GPIO in a lookup table for gpio-crystalcove chip during CRC driver load
v2: Make the lookup table static (Thierry)
Remove the lookup table during driver remove (Thierry)
v3: Correct the subject line (Lee jones)
--- drivers/mfd/intel_soc_pmic_core.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+)
drivers/mfd/intel_soc_pmic_core.c +17 -0
@@ -24,8 +24,19 @@#include <linux/acpi.h> #include <linux/regmap.h> #include <linux/mfd/intel_soc_pmic.h> +#include <linux/gpio/machine.h> #include "intel_soc_pmic_core.h" +/* Lookup table for the Panel Enable/Disable line as GPIO signals */ +static struct gpiod_lookup_table panel_gpio_table = { +/* Intel GFX is consumer */ + .dev_id ="0000:00:02.0" , + .table = { +/* Panel EN/DISABLE */ +GPIO_LOOKUP ("gpio_crystalcove" ,94 ,"panel" ,GPIO_ACTIVE_HIGH ), + }, +}; +static int intel_soc_pmic_find_gpio_irq (struct device *dev) {struct gpio_desc *desc;
@@ -85,6 +96,9 @@ static int intel_soc_pmic_i2c_probe(struct i2c_client *i2c,if (ret)dev_warn (dev,"Can't enable IRQ as wake source: %d\n" , ret); +/* Add lookup table binding for Panel Control to the GPIO Chip */ +gpiod_add_lookup_table (&panel_gpio_table); + ret =mfd_add_devices (dev,-1 , config->cell_dev, config->n_cell_devs,NULL ,0 ,regmap_irq_get_domain (pmic->irq_chip_data));
@@ -104,6 +118,9 @@ static int intel_soc_pmic_i2c_remove(struct i2c_client *i2c)regmap_del_irq_chip (pmic->irq, pmic->irq_chip_data); +/* Remove lookup table for Panel Control from the GPIO Chip */ +gpiod_remove_lookup_table (&panel_gpio_table); +mfd_remove_devices (&i2c->dev);return 0 ;
Signature · 1 line
2.1.0
PATCH 4/8 mfd: intel_soc_pmic_crc: Add PWM cell device for Crystalcove PMIC
In reply to Shobhit KumarNeeded for PWM control suuported by the PMIC
v2: Correct the subject line (Lee jones)
--- drivers/mfd/intel_soc_pmic_crc.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/mfd/intel_soc_pmic_crc.c +3 -0
@@ -109,6 +109,9 @@ static struct mfd_cell crystal_cove_dev[] = { { .name = "crystal_cove_pmic", }, + { + .name = "crystal_cove_pwm", + }, }; static const struct regmap_config crystal_cove_regmap_config = {
Signature · 1 line
2.1.0
PATCH 5/8 mfd: intel_soc_pmic_core: ADD PWM lookup table for CRC PMIC based PWM
In reply to Shobhit KumarOn some BYT PLatform the PWM is controlled using CRC PMIC. Add a lookup entry for the same to be used by the consumer (Intel GFX)
v2: Remove the lookup table on driver unload (Thierry)
v3: Correct the subject line (Lee jones)
--- drivers/mfd/intel_soc_pmic_core.c | 12 ++++++++++++ 1 file changed, 12 insertions(+)
drivers/mfd/intel_soc_pmic_core.c +12 -0
@@ -25,6 +25,7 @@#include <linux/regmap.h> #include <linux/mfd/intel_soc_pmic.h> #include <linux/gpio/machine.h> +#include <linux/pwm.h> #include "intel_soc_pmic_core.h" /* Lookup table for the Panel Enable/Disable line as GPIO signals */
@@ -37,6 +38,11 @@ static struct gpiod_lookup_table panel_gpio_table = { }, }; +/* PWM consumed by the Intel GFX */ +static struct pwm_lookup crc_pwm_lookup[] = { +PWM_LOOKUP ("crystal_cove_pwm" ,0 ,"0000:00:02.0" ,"pwm_backlight" ,0 ,PWM_POLARITY_NORMAL ), +}; +static int intel_soc_pmic_find_gpio_irq (struct device *dev) {struct gpio_desc *desc;
@@ -99,6 +105,9 @@ static int intel_soc_pmic_i2c_probe(struct i2c_client *i2c,/* Add lookup table binding for Panel Control to the GPIO Chip */ gpiod_add_lookup_table (&panel_gpio_table); +/* Add lookup table for crc-pwm */ +pwm_add_table (crc_pwm_lookup,ARRAY_SIZE (crc_pwm_lookup)); + ret =mfd_add_devices (dev,-1 , config->cell_dev, config->n_cell_devs,NULL ,0 ,regmap_irq_get_domain (pmic->irq_chip_data));
@@ -121,6 +130,9 @@ static int intel_soc_pmic_i2c_remove(struct i2c_client *i2c)/* Remove lookup table for Panel Control from the GPIO Chip */ gpiod_remove_lookup_table (&panel_gpio_table); +/* remove crc-pwm lookup table */ +pwm_remove_table (crc_pwm_lookup,ARRAY_SIZE (crc_pwm_lookup)); +mfd_remove_devices (&i2c->dev);return 0 ;
Signature · 6 lines
2.1.0 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 6/8 pwm: crc: Add Crystalcove (CRC) PWM driver
In reply to Shobhit KumarThe Crystalcove PMIC controls PWM signals and this driver exports that capability as a PWM chip driver. This is platform device implementtaion of the drivers/mfd cell device for CRC PMIC
v2: Use the existing config callback with duty_ns and period_ns(Thierry)
v3: Correct the subject line (Lee jones)
--- drivers/pwm/Kconfig | 7 +++ drivers/pwm/Makefile | 1 + drivers/pwm/pwm-crc.c | 171 ++++++++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 179 insertions(+) create mode 100644 drivers/pwm/pwm-crc.c
drivers/pwm/Kconfig +7 -0
@@ -183,6 +183,13 @@ config PWM_LPC32XX To compile this driver as a module, choose M here: the module will be called pwm-lpc32xx. +config PWM_CRC + bool "Intel Crystalcove (CRC) PWM support" + depends on X86 && INTEL_SOC_PMIC + help + Generic PWM framework driver for Crystalcove (CRC) PMIC based PWM + control. + config PWM_LPSS tristate "Intel LPSS PWM support" depends on X86
drivers/pwm/Makefile +1 -0
@@ -35,3 +35,4 @@ obj-$(CONFIG_PWM_TIPWMSS) += pwm-tipwmss.o obj-$(CONFIG_PWM_TWL) += pwm-twl.o obj-$(CONFIG_PWM_TWL_LED) += pwm-twl-led.o obj-$(CONFIG_PWM_VT8500) += pwm-vt8500.o +obj-$(CONFIG_PWM_CRC) += pwm-crc.o
drivers/pwm/pwm-crc.c new file +171 -0
171 lines not on this page · raw message
Signature · 6 lines
2.1.0 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH 5/8] drivers/mfd: ADD PWM lookup table for CRC PMIC based PWM
In reply to Lee JonesQuoted 16 lines · Lee Jones
Quoted 5 lines · Shobhit Kumar
On some BYT PLatform the PWM is controlled using CRC PMIC. Add a lookup entry for the same to be used by the consumer (Intel GFX)
v2: Remove the lookup table on driver unload (Thierry)
Quoted 8 lines
CC Samuel Ortiz <[email protected]>Cc Linus Walleij <[email protected]>Cc Alexandre Courbot <[email protected]>Cc Thierry Reding <[email protected]>Signed-off-by Shobhit Kumar <[email protected]>--- drivers/mfd/intel_soc_pmic_core.c | 12 ++++++++++++ 1 file changed, 12 insertions(+)
Quoted 1 line
How do you expect this set to be managed?
There are some dependencies on the look up table remove functionality in earlier patches, so I think 3/8 can go in only after 1/8. Similarly 5/8 can go only after 2/8. Rest all can be independent.
Regards
Shobhit
Quoted 48 lines
Acked-by Lee Jones <[email protected]>Quoted 44 lines
drivers/mfd/intel_soc_pmic_core.c +12
-0@@ -25,6 +25,7 @@#include <linux/regmap.h> #include <linux/mfd/intel_soc_pmic.h> #include <linux/gpio/machine.h> +#include <linux/pwm.h> #include "intel_soc_pmic_core.h" /* Lookup table for the Panel Enable/Disable line as GPIO signals */ @@ -37,6 +38,11 @@ static struct gpiod_lookup_table panel_gpio_table = { }, }; +/* PWM consumed by the Intel GFX */ +static struct pwm_lookup crc_pwm_lookup[] = { +PWM_LOOKUP ("crystal_cove_pwm" ,0 ,"0000:00:02.0" ,"pwm_backlight" ,0 ,PWM_POLARITY_NORMAL ), +}; +static int intel_soc_pmic_find_gpio_irq (struct device *dev) {struct gpio_desc *desc;@@ -99,6 +105,9 @@ static int intel_soc_pmic_i2c_probe(struct i2c_client *i2c,/* Add lookup table binding for Panel Control to the GPIO Chip */ gpiod_add_lookup_table (&panel_gpio_table); +/* Add lookup table for crc-pwm */ +pwm_add_table (crc_pwm_lookup,ARRAY_SIZE (crc_pwm_lookup)); + ret =mfd_add_devices (dev,-1 , config->cell_dev, config->n_cell_devs,NULL ,0 ,regmap_irq_get_domain (pmic->irq_chip_data));@@ -121,6 +130,9 @@ static int intel_soc_pmic_i2c_remove(struct i2c_client *i2c)/* Remove lookup table for Panel Control from the GPIO Chip */ gpiod_remove_lookup_table (&panel_gpio_table); +/* remove crc-pwm lookup table */ +pwm_remove_table (crc_pwm_lookup,ARRAY_SIZE (crc_pwm_lookup)); +mfd_remove_devices (&i2c->dev);return 0 ;
Re: [PATCH 5/8] drivers/mfd: ADD PWM lookup table for CRC PMIC based PWM
Quoted 17 lines · Shobhit Kumar
Quoted 16 lines · Lee Jones
Quoted 13 lines · Shobhit Kumar
On some BYT PLatform the PWM is controlled using CRC PMIC. Add a lookup entry for the same to be used by the consumer (Intel GFX)
v2: Remove the lookup table on driver unload (Thierry)
CC Samuel Ortiz <[email protected]>Cc Linus Walleij <[email protected]>Cc Alexandre Courbot <[email protected]>Cc Thierry Reding <[email protected]>Signed-off-by Shobhit Kumar <[email protected]>--- drivers/mfd/intel_soc_pmic_core.c | 12 ++++++++++++ 1 file changed, 12 insertions(+)
Quoted 5 lines
Quoted 1 line
How do you expect this set to be managed?
There are some dependencies on the look up table remove functionality in earlier patches, so I think 3/8 can go in only after 1/8. Similarly 5/8 can go only after 2/8. Rest all can be independent.
Taking patches 'in order' is tough to coordinate and takes a very long time. The best thing to do is have all of the patches taken in via a single tree at the same time.
Quoted 47 lines
Quoted 47 lines
Acked-by Lee Jones <[email protected]>Quoted 44 lines
drivers/mfd/intel_soc_pmic_core.c +12
-0@@ -25,6 +25,7 @@#include <linux/regmap.h> #include <linux/mfd/intel_soc_pmic.h> #include <linux/gpio/machine.h> +#include <linux/pwm.h> #include "intel_soc_pmic_core.h" /* Lookup table for the Panel Enable/Disable line as GPIO signals */ @@ -37,6 +38,11 @@ static struct gpiod_lookup_table panel_gpio_table = { }, }; +/* PWM consumed by the Intel GFX */ +static struct pwm_lookup crc_pwm_lookup[] = { +PWM_LOOKUP ("crystal_cove_pwm" ,0 ,"0000:00:02.0" ,"pwm_backlight" ,0 ,PWM_POLARITY_NORMAL ), +}; +static int intel_soc_pmic_find_gpio_irq (struct device *dev) {struct gpio_desc *desc;@@ -99,6 +105,9 @@ static int intel_soc_pmic_i2c_probe(struct i2c_client *i2c,/* Add lookup table binding for Panel Control to the GPIO Chip */ gpiod_add_lookup_table (&panel_gpio_table); +/* Add lookup table for crc-pwm */ +pwm_add_table (crc_pwm_lookup,ARRAY_SIZE (crc_pwm_lookup)); + ret =mfd_add_devices (dev,-1 , config->cell_dev, config->n_cell_devs,NULL ,0 ,regmap_irq_get_domain (pmic->irq_chip_data));@@ -121,6 +130,9 @@ static int intel_soc_pmic_i2c_remove(struct i2c_client *i2c)/* Remove lookup table for Panel Control from the GPIO Chip */ gpiod_remove_lookup_table (&panel_gpio_table); +/* remove crc-pwm lookup table */ +pwm_remove_table (crc_pwm_lookup,ARRAY_SIZE (crc_pwm_lookup)); +mfd_remove_devices (&i2c->dev);return 0 ;
Signature · 8 lines
Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH 1/8] gpiolib: Add support for removing registered consumer lookup table
In reply to Shobhit KumarThis is not how we submit subsequent patch-sets.
Please submit them as a whole, seperately from the first submission and with versioning information i.e. [PATCH v2 X/Y] Stuff ...
Quoted 6 lines
In case we unload and load a driver module again that is registering a lookup table, without this it will result in multiple entries. Provide an option to remove the lookup table on driver unload
v2: Ccing maintainers
v3: Correct the subject line (Lee jones)
Change logs should go underneth the '---' and above the diffstat found below.
Quoted 46 lines
Cc Samuel Ortiz <[email protected]>Cc Linus Walleij <[email protected]>Cc Alexandre Courbot <[email protected]>Cc Thierry Reding <[email protected]>Reviewed-by Alexandre Courbot <[email protected]>Signed-off-by Shobhit Kumar <[email protected]>--- drivers/gpio/gpiolib.c | 13 +++++++++++++ include/linux/gpio/machine.h | 1 + 2 files changed, 14 insertions(+)drivers/gpio/gpiolib.c +13
-0@@ -1658,6 +1658,19 @@ void gpiod_add_lookup_table(struct gpiod_lookup_table *table)mutex_unlock (&gpio_lookup_lock); } +/** +* gpiod_remove_lookup_table() - unregister GPIO device consumers +* @table: table of consumers to unregister +*/ +void gpiod_remove_lookup_table (struct gpiod_lookup_table *table) +{ +mutex_lock (&gpio_lookup_lock); + +list_del (&table->list); + +mutex_unlock (&gpio_lookup_lock); +} +static struct gpio_desc *of_find_gpio (struct device *dev,const char *con_id,unsigned int idx,enum gpio_lookup_flags *flags)include/linux/gpio/machine.h +1
-0@@ -57,5 +57,6 @@ struct gpiod_lookup_table { }void gpiod_add_lookup_table (struct gpiod_lookup_table *table); +void gpiod_remove_lookup_table (struct gpiod_lookup_table *table);#endif /* __LINUX_GPIO_MACHINE_H */
Signature · 8 lines
Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 1/8] gpiolib: Add support for removing registered consumer lookup table
Quoted 1 line · Lee Jones
This is not how we submit subsequent patch-sets.
It is unfortunately how we handle patches on dri-devel&intel-gfx to be able to cope with massive mail load. If everyone who submits to intel-gfx would always resend the entire series for minor updates of som patches we'd completely drown in the resulting flood.
Quoted 7 lines
Please submit them as a whole, seperately from the first submission and with versioning information i.e. [PATCH v2 X/Y] Stuff ...
Quoted 4 lines
In case we unload and load a driver module again that is registering a lookup table, without this it will result in multiple entries. Provide an option to remove the lookup table on driver unload
Quoted 5 lines
Quoted 2 lines
v2: Ccing maintainers
v3: Correct the subject line (Lee jones)Change logs should go underneth the '---' and above the diffstat found below.
Again just style differences between subsystems, I generally want to have those above the ---.
-Daniel
Quoted 57 lines
Quoted 47 lines
Cc Samuel Ortiz <[email protected]>Cc Linus Walleij <[email protected]>Cc Alexandre Courbot <[email protected]>Cc Thierry Reding <[email protected]>Reviewed-by Alexandre Courbot <[email protected]>Signed-off-by Shobhit Kumar <[email protected]>--- drivers/gpio/gpiolib.c | 13 +++++++++++++ include/linux/gpio/machine.h | 1 + 2 files changed, 14 insertions(+)drivers/gpio/gpiolib.c +13
-0@@ -1658,6 +1658,19 @@ void gpiod_add_lookup_table(struct gpiod_lookup_table *table)mutex_unlock (&gpio_lookup_lock); } +/** +* gpiod_remove_lookup_table() - unregister GPIO device consumers +* @table: table of consumers to unregister +*/ +void gpiod_remove_lookup_table (struct gpiod_lookup_table *table) +{ +mutex_lock (&gpio_lookup_lock); + +list_del (&table->list); + +mutex_unlock (&gpio_lookup_lock); +} +static struct gpio_desc *of_find_gpio (struct device *dev,const char *con_id,unsigned int idx,enum gpio_lookup_flags *flags)include/linux/gpio/machine.h +1
-0@@ -57,5 +57,6 @@ struct gpiod_lookup_table { }void gpiod_add_lookup_table (struct gpiod_lookup_table *table); +void gpiod_remove_lookup_table (struct gpiod_lookup_table *table);#endif /* __LINUX_GPIO_MACHINE_H */ Signature · 8 lines
Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH 6/8] pwm: crc: Add Crystalcove (CRC) PWM driver
In reply to Shobhit KumarQuoted 6 lines · Shobhit Kumar
The Crystalcove PMIC controls PWM signals and this driver exports that capability as a PWM chip driver. This is platform device implementtaion of the
drivers/mfdcell device for CRC PMICv2: Use the existing config callback with
duty_nsandperiod_ns(Thierry)
Quoted 7 lines
v3: Correct the subject line (Lee jones)
CC Samuel Ortiz <[email protected]>Cc Linus Walleij <[email protected]>Cc Alexandre Courbot <[email protected]>Cc Thierry Reding <[email protected]>Signed-off-by Shobhit Kumar <[email protected]>
The same comments can be made as for v2, see
http://lkml.kernel.org/r/1430428322.2187.24.camel@x220 . Maybe you didn't receive that message.
It could also be that you think my comments were invalid, or too vague, or whatever. Please say so, because then I don't have to bother you again when you send out v4.
Thanks,
Paul Bolle
_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH 6/8] pwm: crc: Add Crystalcove (CRC) PWM driver
In reply to Shobhit KumarQuoted 1 line · Shobhit Kumar
The Crystalcove PMIC controls PWM signals and this driver exports that
You say signal_s_ here, but you only expose a single PWM device. Does the PMIC really control more than one? If it isn't, this should probably
become: "controls a PWM output and this driver...".
Quoted 1 line
capability as a PWM chip driver. This is platform device implementtaion
"implementation"
Quoted 1 line
of the
drivers/mfdcell device for CRC PMIC
Sentences should end with a full stop.
Quoted 5 lines
drivers/pwm/Kconfig +0
-0
drivers/pwm/Kconfig config PWM_LPC32XX · line 192
Quoted 10 lines
drivers/pwm/Kconfig +7
-0@@ -183,6 +183,13 @@ config PWM_LPC32XX To compile this driver as a module, choose M here: the module will be called pwm-lpc32xx. +config PWM_CRC + bool "Intel Crystalcove (CRC) PWM support" + depends on X86 && INTEL_SOC_PMIC + help + Generic PWM framework driver for Crystalcove (CRC) PMIC based PWM + control. +
This is badly sorted. Please keep the list sorted alphabetically.
drivers/pwm/Makefile obj-$(CONFIG_PWM_TIPWMSS) += pwm-tipwmss.o · line 38
Quoted 12 lines
drivers/pwm/Kconfig +0
-0config PWM_LPSS tristate "Intel LPSS PWM support" depends on X86drivers/pwm/Makefile +1
-0@@ -35,3 +35,4 @@ obj-$(CONFIG_PWM_TIPWMSS) += pwm-tipwmss.o obj-$(CONFIG_PWM_TWL) += pwm-twl.o obj-$(CONFIG_PWM_TWL_LED) += pwm-twl-led.o obj-$(CONFIG_PWM_VT8500) += pwm-vt8500.o +obj-$(CONFIG_PWM_CRC) += pwm-crc.o
This too.
drivers/pwm/pwm-crc.c line 2
Quoted 8 lines
drivers/pwm/pwm-crc.c new file +2
-0@@ -0,0 +1,171 @@ +/* +* pwm-crc.c - Intel Crystal Cove PWM Driver
I think you can safely remove this line. You already know what file it is when you open it in your editor, and the description is in the MODULE_DESCRIPTION string already.
Quoted 13 lines
drivers/pwm/pwm-crc.c new file +13
-0+* +* Copyright (C) 2015 Intel Corporation. All rights reserved. +* +* This program is free software; you can redistribute it and/or +* modify it under the terms of the GNU General Public License version +* 2 as published by the Free Software Foundation. +* +* This program is distributed in the hope that it will be useful, +* but WITHOUT ANY WARRANTY; without even the implied warranty of +* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +* GNU General Public License for more details. +* +* Author: Shobhit Kumar <[email protected]>
drivers/pwm/pwm-crc.c line 25
Quoted 10 lines
drivers/pwm/pwm-crc.c new file +10
-0+*/ + +#include <linux/module.h> +#include <linux/platform_device.h> +#include <linux/regmap.h> +#include <linux/mfd/intel_soc_pmic.h> +#include <linux/pwm.h> + +#define PWM0_CLK_DIV 0x4B +#define PWM_OUTPUT_ENABLE (1<<7)
Should have spaces around <<.
drivers/pwm/pwm-crc.c line 35
Quoted 10 lines
drivers/pwm/pwm-crc.c new file +10
-0+#define PWM_DIV_CLK_0 0x00/* DIVIDECLK = BASECLK */ +#define PWM_DIV_CLK_100 0x63/* DIVIDECLK = BASECLK/100 */ +#define PWM_DIV_CLK_128 0x7F/* DIVIDECLK = BASECLK/128 */ + +#define PWM0_DUTY_CYCLE 0x4E +#define BACKLIGHT_EN 0x51 + +#define PWM_MAX_LEVEL 0xFF + +#define PWM_BASE_CLK 6000/* 6 MHz */
This number is actually 6 KHz. I think it'd be better if you stuck with one unit here. Or perhaps there's some other reason why you can't use 6000000 here instead?
drivers/pwm/pwm-crc.c line 45
Quoted 10 lines
drivers/pwm/pwm-crc.c new file +10
-0+#define PWM_MAX_PERIOD_NS 21333/* 46.875KHz */ + +/** +* struct crystalcove_pwm - Crystal Cove PWM controller +* @chip: the abstract pwm_chip structure. +* @regmap: the regmap from the parent device. +*/ +struct crystalcove_pwm { +struct pwm_chip chip; +struct platform_device *pdev;
I think I had at some point requested that you get rid of this and use the chip.dev member instead. There's no kerneldoc for it and it isn't (well, almost, see below) used anywhere else, so perhaps you forgot to remove it here?
Quoted 16 lines
drivers/pwm/pwm-crc.c new file +16
-0+struct regmap *regmap; +}; + +static inline struct crystalcove_pwm *to_crc_pwm (struct pwm_chip *pc) +{ + return container_of(pc, struct crystalcove_pwm, chip); +} + +static int crc_pwm_enable (struct pwm_chip *c,struct pwm_device *pwm) +{ +struct crystalcove_pwm *crc_pwm =to_crc_pwm (c); + +regmap_write (crc_pwm->regmap,BACKLIGHT_EN ,1 ); + +return 0 ; +}
drivers/pwm/pwm-crc.c line 71
Quoted 10 lines
drivers/pwm/pwm-crc.c new file +10
-0+ +static void crc_pwm_disable (struct pwm_chip *c,struct pwm_device *pwm) +{ +struct crystalcove_pwm *crc_pwm =to_crc_pwm (c); + +regmap_write (crc_pwm->regmap,BACKLIGHT_EN ,0 ); +} + +static int crc_pwm_config (struct pwm_chip *c,struct pwm_device *pwm, +int duty_ns,int period_ns)
Please align arguments on subsequent lines with the first argument of the first line.
drivers/pwm/pwm-crc.c line 74
Quoted 3 lines
drivers/pwm/pwm-crc.c new file +3
-0+{ +struct crystalcove_pwm *crc_pwm =to_crc_pwm (c); +struct device *dev = &crc_pwm->pdev->dev;
Did you test reconfiguring the PWM? I don't see crc_pwm->pdev getting initialized anywhere, so this should crash trying to dereference a NULL pointer.
Of course if you get rid of the pdev field as I suggested you can simply get the struct device * from c->dev.
drivers/pwm/pwm-crc.c line 79
Quoted 5 lines
drivers/pwm/pwm-crc.c new file +5
-0+int level, percent; + +if (period_ns >PWM_MAX_PERIOD_NS ) { +dev_err (dev,"un-supported period_ns\n" ); +return -1 ;
You should return -EINVAL here. Besides being a literal and therefore a bad idea, -1 == -EPERM and doesn't match the error condition.
drivers/pwm/pwm-crc.c line 87
Quoted 8 lines
drivers/pwm/pwm-crc.c new file +8
-0+ } + +if (pwm->period != period_ns) { +int clk_div; + +/* changing the clk divisor, need to disable fisrt */ +crc_pwm_disable (c, pwm); + clk_div =PWM_BASE_CLK * period_ns /1000000 ;
Similar to the above, this is confusing because you're mixing up different scales here. period_ns is in nanoseconds, so it'd be natural to divide by 1000000000 (though you should really be using NSEC_PER_SEC instead). If you counterweight that by expressing PWM_BASE_CLK in Hz (6000000) you get much nicer symmetry and make the code a lot easier to understand.
drivers/pwm/pwm-crc.c line 99
Quoted 12 lines
drivers/pwm/pwm-crc.c new file +12
-0+ +regmap_write (crc_pwm->regmap,PWM0_CLK_DIV , + clk_div |PWM_OUTPUT_ENABLE ); + +/* enable back */ +crc_pwm_enable (c, pwm); + } + +if (duty_ns > period_ns) { +dev_err (dev,"duty cycle cannot be greater than cycle period\n" ); +return -1 ; + }
The PWM core already performs this check, so you'll never get here in case this condition is true.
drivers/pwm/pwm-crc.c line 103
Quoted 4 lines
drivers/pwm/pwm-crc.c new file +4
-0+ +/* change the pwm duty cycle */ + percent = duty_ns *100 / period_ns; + level = percent *PWM_MAX_LEVEL /100 ;
Why do you need to apply the rule of three twice here? Doesn't
level = duty_ns * PWM_MAX_LEVEL / period_ns;
give you what you want?
Quoted 26 lines
drivers/pwm/pwm-crc.c new file +26
-0+regmap_write (crc_pwm->regmap,PWM0_DUTY_CYCLE , level); + +return 0 ; +} + +static const struct pwm_ops crc_pwm_ops = { + .config = crc_pwm_config, + .enable = crc_pwm_enable, + .disable = crc_pwm_disable, + .owner =THIS_MODULE , +}; + +static int crystalcove_pwm_probe (struct platform_device *pdev) +{ +struct crystalcove_pwm *pwm; +int retval; +struct device *dev = pdev->dev.parent; +struct intel_soc_pmic *pmic =dev_get_drvdata (dev); + + pwm =devm_kzalloc (&pdev->dev,sizeof (*pwm),GFP_KERNEL ); +if (!pwm) +return -ENOMEM ; + + pwm->chip.dev = &pdev->dev; + pwm->chip.ops = &crc_pwm_ops; + pwm->chip.base =-1 ;
drivers/pwm/pwm-crc.c line 139
Quoted 10 lines
drivers/pwm/pwm-crc.c new file +10
-0+ pwm->chip.npwm =1 ; + +/* get the PMIC regmap */ + pwm->regmap = pmic->regmap; + + retval =pwmchip_add (&pwm->chip); +if (retval <0 ) +return retval; + +dev_dbg (&pdev->dev,"crc-pwm probe successful\n" );
Do you really want this? The driver core will complain in any of the above failures, so what use is there to be chatty when probing succeeds?
drivers/pwm/pwm-crc.c line 163
Quoted 5 lines
drivers/pwm/pwm-crc.c new file +5
-0+static struct platform_driver crystalcove_pwm_driver = { + .probe = crystalcove_pwm_probe, + .remove = crystalcove_pwm_remove, + .driver = { + .name ="crystal_cove_pwm" ,
I'd prefer this to be "crystal-cove-pwm" for consistency with other drivers, but since the MFD part already uses underscores in names it'd introduce an inconsistency there. So I'm fine with this one as-is.
Thierry
Thierry Reding
AppliedRe: [PATCH 2/8] pwm: core: Add support to remove registered consumer lookup tables
In reply to Shobhit KumarQuoted 12 lines · Shobhit Kumar
In case some drivers are unloading, they can remove lookup tables which they would have registered during their load time to avoid redundant entries if loaded again
v2: Ccing maintainers
v3: Correct the subject line (Lee jones)CC Samuel Ortiz <[email protected]>Cc Linus Walleij <[email protected]>Cc Alexandre Courbot <[email protected]>Cc Thierry Reding <[email protected]>Signed-off-by Shobhit Kumar <[email protected]>
Quoted 4 lines
--- drivers/pwm/core.c | 17 +++++++++++++++++ include/linux/pwm.h | 5 +++++ 2 files changed, 22 insertions(+)
Applied, thanks.
Thierry
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH 7/8] drm/i915: Use the CRC gpio for panel enable/disable
In reply to Shobhit KumarQuoted 100 lines · Shobhit Kumar
The CRC (Crystal Cove) PMIC, controls the panel enable and disable signals for BYT for dsi panels. This is indicated in the VBT fields. Use that to initialize and use GPIO based control for these signals.
v2: Use the newer gpiod interface(Alexandre)
v3: Remove the redundant checks and unused code (Ville)CC Samuel Ortiz <[email protected]>Cc Linus Walleij <[email protected]>Cc Alexandre Courbot <[email protected]>Cc Thierry Reding <[email protected]>Signed-off-by Shobhit Kumar <[email protected]>--- drivers/gpu/drm/i915/intel_dsi.c | 32 ++++++++++++++++++++++++++++++-- drivers/gpu/drm/i915/intel_dsi.h | 6 ++++++ 2 files changed, 36 insertions(+), 2 deletions(-)drivers/gpu/drm/i915/intel_dsi.c +30
-2@@ -31,6 +31,7 @@#include <drm/drm_panel.h> #include <drm/drm_mipi_dsi.h> #include <linux/slab.h> +#include <linux/gpio/consumer.h> #include "i915_drv.h" #include "intel_drv.h" #include "intel_dsi.h" @@ -415,6 +416,12 @@ static void intel_dsi_pre_enable(struct intel_encoder *encoder)DRM_DEBUG_KMS ("\n" ); +/* Panel Enable over CRC PMIC */ +if (intel_dsi->gpio_panel) +gpiod_set_value_cansleep (intel_dsi->gpio_panel,1 ); + +msleep (intel_dsi->panel_on_delay); +/* Disable DPOunit clock gating, can stall pipe * and we need DPLL REFA always enabled */ tmp =I915_READ (DPLL (pipe));@@ -432,8 +439,6 @@ static void intel_dsi_pre_enable(struct intel_encoder *encoder)/* put device in ready state */ intel_dsi_device_ready (encoder); -msleep (intel_dsi->panel_on_delay); -drm_panel_prepare (intel_dsi->panel);for_each_dsi_port (port, intel_dsi->ports)@@ -576,6 +581,10 @@ static void intel_dsi_post_disable(struct intel_encoder *encoder)msleep (intel_dsi->panel_off_delay);msleep (intel_dsi->panel_pwr_cycle_delay); + +/* Panel Disable over CRC PMIC */ +if (intel_dsi->gpio_panel) +gpiod_set_value_cansleep (intel_dsi->gpio_panel,0 ); } static bool intel_dsi_get_hw_state(struct intel_encoder *encoder,@@ -955,6 +964,11 @@ static void intel_dsi_encoder_destroy(struct drm_encoder *encoder)/* XXX: Logically this call belongs in the panel driver. */ drm_panel_remove (intel_dsi->panel); } + +/* dispose of the gpios */ +if (intel_dsi->gpio_panel) +gpiod_put (intel_dsi->gpio_panel); +intel_encoder_destroy (encoder); }@@ -1071,6 +1085,20 @@ void intel_dsi_init(struct drm_device *dev) goto err; } +/* +* In case of BYT with CRC PMIC, we need to use GPIO for +* Panel control. +*/ +if (dev_priv->vbt.dsi.config->pwm_blc ==PPS_BLC_PMIC ) { + intel_dsi->gpio_panel = +gpiod_get (dev->dev,"panel" ,GPIOD_OUT_HIGH ); + +if (IS_ERR (intel_dsi->gpio_panel)) { +DRM_ERROR ("Failed to own gpio for panel control\n" ); + intel_dsi->gpio_panel =NULL ; + } + } + intel_encoder->type =INTEL_OUTPUT_DSI ; intel_encoder->cloneable =0 ; drm_connector_init(dev, connector, &intel_dsi_connector_funcs,drivers/gpu/drm/i915/intel_dsi.h +0
-0
drivers/gpu/drm/i915/intel_dsi.h line 33
Quoted 5 lines
drivers/gpu/drm/i915/intel_dsi.h +2
-0@@ -29,6 +29,9 @@#include <drm/drm_mipi_dsi.h> #include "intel_drv.h" +#define PPS_BLC_PMIC 0 +#define PPS_BLC_SOC 1
Since these values are defined in the VBT, perhaps these should be in intel_bios.h. Up to you, I'm fine either way.
Quoted 17 lines
drivers/gpu/drm/i915/intel_dsi.h +4
-0+/* Dual Link support */ #define DSI_DUAL_LINK_NONE 0#define DSI_DUAL_LINK_FRONT_BACK 1@@ -42,6 +45,9 @@ struct intel_dsi {struct drm_panel *panel;struct intel_dsi_host *dsi_hosts[I915_MAX_PORTS ]; +/* GPIO Desc for CRC based Panel control */ +struct gpio_desc *gpio_panel; +struct intel_connector *attached_connector;/* bit mask of ports being driven */ Signature · 1 line
2.1.0
Signature · 1 line
Jani Nikula, Intel Open Source Technology Center
Re: [PATCH 8/8] drm/i915: Backlight control using CRC PMIC based PWM driver
In reply to Shobhit KumarQuoted 21 lines · Shobhit Kumar
Use the CRC PWM device in
intel_panel.cand add new MIPI backlight specififc callbacksv2: Modify to use
pwm_configcallbackCC Samuel Ortiz <[email protected]>Cc Linus Walleij <[email protected]>Cc Alexandre Courbot <[email protected]>Cc Thierry Reding <[email protected]>Signed-off-by Shobhit Kumar <[email protected]>--- drivers/gpu/drm/i915/intel_drv.h | 5 +++ drivers/gpu/drm/i915/intel_dsi.c | 6 +++ drivers/gpu/drm/i915/intel_panel.c | 92 +++++++++++++++++++++++++++++++++++--- 3 files changed, 98 insertions(+), 5 deletions(-)drivers/gpu/drm/i915/intel_drv.h +0
-0
drivers/gpu/drm/i915/intel_drv.h struct intel_panel { · line 190
Quoted 9 lines
drivers/gpu/drm/i915/intel_drv.h +5
-0@@ -182,7 +182,12 @@ struct intel_panel {bool enabled;bool combination_mode;/* gen 2/4 only */ bool active_low_pwm; + +/* PWM chip */ +struct pwm_device *pwm; +struct backlight_device *device; +
Superfluous whitespace.
Quoted 52 lines
drivers/gpu/drm/i915/intel_drv.h +0
-0} backlight;void (*backlight_power)(struct intel_connector *,bool enable);drivers/gpu/drm/i915/intel_dsi.c +6
-0@@ -402,6 +402,8 @@ static void intel_dsi_enable(struct intel_encoder *encoder)intel_dsi_port_enable (encoder); } + +intel_panel_enable_backlight (intel_dsi->attached_connector); }static void intel_dsi_pre_enable (struct intel_encoder *encoder)@@ -466,6 +468,8 @@ static void intel_dsi_pre_disable(struct intel_encoder *encoder)DRM_DEBUG_KMS ("\n" ); +intel_panel_disable_backlight (intel_dsi->attached_connector); +if (is_vid_mode (intel_dsi)) {/* Send Shutdown command to the panel in LP mode */ for_each_dsi_port (port, intel_dsi->ports)@@ -1132,6 +1136,8 @@ void intel_dsi_init(struct drm_device *dev) }intel_panel_init (&intel_connector->panel, fixed_mode,NULL ); +intel_panel_setup_backlight (connector, + (intel_encoder->crtc_mask = (1 <<PIPE_A )) ?PIPE_A :PIPE_B );return ;drivers/gpu/drm/i915/intel_panel.c +4
-0@@ -32,8 +32,12 @@#include <linux/kernel.h> #include <linux/moduleparam.h> +#include <linux/pwm.h> #include "intel_drv.h" +#define CRC_PMIC_PWM_PERIOD_NS 21333 +#define CRC_PMIC_PWM_STEPS 255 +void intel_fixed_panel_mode (const struct drm_display_mode *fixed_mode,struct drm_display_mode *adjusted_mode)
drivers/gpu/drm/i915/intel_panel.c static u32 vlv_get_backlight(struct intel_connector *connector) · line 543
Quoted 4 lines
drivers/gpu/drm/i915/intel_panel.c +1
-0@@ -536,6 +540,15 @@ static u32 vlv_get_backlight(struct intel_connector *connector)return _vlv_get_backlight (dev, pipe); } +static u32 vlv_get_mipi_backlight (struct intel_connector *connector)
I'd rather call this either pmic_get_backlight or even pwm_get_backlight because there's nothing really vlv specific about the functions themselves. Same for all of them.
drivers/gpu/drm/i915/intel_panel.c static u32 vlv_get_backlight(struct intel_connector *connector) · line 549
Quoted 6 lines
drivers/gpu/drm/i915/intel_panel.c +6
-0+{ +struct intel_panel *panel = &connector->panel; +int duty_ns; + + duty_ns =pwm_get_duty_cycle (panel->backlight.pwm); +return DIV_ROUND_UP (duty_ns *100 ,CRC_PMIC_PWM_PERIOD_NS );
Basically we have all the code in place to do the scaling from hw to user. See the note in intel_backlight_device_register. We shouldn't need to add additional scaling all around.
However this can be a future cleanup IMO.
Quoted 39 lines
drivers/gpu/drm/i915/intel_panel.c +20
-0+} +static u32 intel_panel_get_backlight (struct intel_connector *connector) {struct drm_device *dev = connector->base.dev;@@ -616,6 +629,14 @@ static void vlv_set_backlight(struct intel_connector *connector, u32 level)I915_WRITE (VLV_BLC_PWM_CTL (pipe), tmp | level); } +static void vlv_set_mipi_backlight (struct intel_connector *connector,u32 level) +{ +struct intel_panel *panel = &connector->panel; +int duty_ns =DIV_ROUND_UP (level *CRC_PMIC_PWM_PERIOD_NS ,100 ); + +pwm_config (panel->backlight.pwm, duty_ns,CRC_PMIC_PWM_PERIOD_NS ); +} +static void intel_panel_actually_set_backlight (struct intel_connector *connector,u32 level) {@@ -741,6 +762,16 @@ static void vlv_disable_backlight(struct intel_connector *connector)I915_WRITE (VLV_BLC_PWM_CTL2 (pipe), tmp & ~BLM_PWM_ENABLE ); } +static void vlv_disable_mipi_backlight (struct intel_connector *connector) +{ +struct intel_panel *panel = &connector->panel; + +/* Disable the backlight */ +pwm_config (panel->backlight.pwm,0 ,CRC_PMIC_PWM_PERIOD_NS ); +usleep_range (2000 ,3000 ); +pwm_disable (panel->backlight.pwm); +} +void intel_panel_disable_backlight (struct intel_connector *connector) {struct drm_device *dev = connector->base.dev;@@ -947,6 +978,16 @@ static void vlv_enable_backlight(struct intel_connector *connector)I915_WRITE (VLV_BLC_PWM_CTL2 (pipe), ctl2 |BLM_PWM_ENABLE );
drivers/gpu/drm/i915/intel_panel.c static void vlv_enable_backlight(struct intel_connector *connector) · line 988
Quoted 10 lines
drivers/gpu/drm/i915/intel_panel.c +8
-0} +static void vlv_enable_mipi_backlight (struct intel_connector *connector) +{ +struct intel_panel *panel = &connector->panel; +int duty_ns =DIV_ROUND_UP ( + panel->backlight.level *CRC_PMIC_PWM_PERIOD_NS ,100 ); + +pwm_enable (panel->backlight.pwm); +pwm_config (panel->backlight.pwm, duty_ns,CRC_PMIC_PWM_PERIOD_NS );
All other enable functions call
intel_panel_actually_set_backlight(connector, panel->backlight.level);
to do this. It'll give you logging too.
Quoted 9 lines
drivers/gpu/drm/i915/intel_panel.c +2
-0+} +void intel_panel_enable_backlight (struct intel_connector *connector) {struct drm_device *dev = connector->base.dev;@@ -1299,6 +1340,34 @@ static int vlv_setup_backlight(struct intel_connector *connector, enum pipe pipereturn 0 ; }
drivers/gpu/drm/i915/intel_panel.c static int vlv_setup_backlight(struct intel_connector *connector, enum pipe pipe · line 1352
Quoted 10 lines
drivers/gpu/drm/i915/intel_panel.c +10
-0+static int vlv_setup_mipi_backlight (struct intel_connector *connector,enum pipe pipe) +{ +struct drm_device *dev = connector->base.dev; +struct intel_panel *panel = &connector->panel; + +/* Get the PWM chip for backlight control */ + panel->backlight.pwm =pwm_get (dev->dev,"pwm_backlight" ); +if (IS_ERR (panel->backlight.pwm)) { +DRM_ERROR ("Faild to own the pwm chip\n" ); + panel->backlight.pwm =NULL ;
I think you want to return -ENODEV here. And then you can drop the "else" below and make that a normal if.
drivers/gpu/drm/i915/intel_panel.c static int vlv_setup_backlight(struct intel_connector *connector, enum pipe pipe · line 1358
Quoted 6 lines
drivers/gpu/drm/i915/intel_panel.c +6
-0+ }else if (pwm_config (panel->backlight.pwm,CRC_PMIC_PWM_PERIOD_NS , +CRC_PMIC_PWM_PERIOD_NS ) <0 ) { +DRM_ERROR ("Failed to configure the pwm chip\n" ); +pwm_put (panel->backlight.pwm); + panel->backlight.pwm =NULL ; +return -1 ;
Save whatever pwm_config returns and return that instead of -1.
drivers/gpu/drm/i915/intel_panel.c static int vlv_setup_backlight(struct intel_connector *connector, enum pipe pipe · line 1366
Quoted 8 lines
drivers/gpu/drm/i915/intel_panel.c +8
-0+ } + + panel->backlight.min =0 ;/* 0% */ + panel->backlight.max =100 ;/* 100% */ + panel->backlight.level =DIV_ROUND_UP ( +pwm_get_duty_cycle (panel->backlight.pwm) *100 , +CRC_PMIC_PWM_PERIOD_NS ); + panel->backlight.enabled = panel->backlight.level ? true : false;
panel->backlight.level != 0
Quoted 33 lines
drivers/gpu/drm/i915/intel_panel.c +17
-5+ +return 0 ; +} +int intel_panel_setup_backlight (struct drm_connector *connector,enum pipe pipe) {struct drm_device *dev = connector->dev;@@ -1363,11 +1432,19 @@ void intel_panel_init_backlight_funcs(struct drm_device *dev) dev_priv->display.set_backlight = pch_set_backlight; dev_priv->display.get_backlight = pch_get_backlight; }else if (IS_VALLEYVIEW (dev)) { - dev_priv->display.setup_backlight = vlv_setup_backlight; - dev_priv->display.enable_backlight = vlv_enable_backlight; - dev_priv->display.disable_backlight = vlv_disable_backlight; - dev_priv->display.set_backlight = vlv_set_backlight; - dev_priv->display.get_backlight = vlv_get_backlight; +if (dev_priv->vbt.has_mipi) { + dev_priv->display.setup_backlight = vlv_setup_mipi_backlight; + dev_priv->display.enable_backlight = vlv_enable_mipi_backlight; + dev_priv->display.disable_backlight = vlv_disable_mipi_backlight; + dev_priv->display.set_backlight = vlv_set_mipi_backlight; + dev_priv->display.get_backlight = vlv_get_mipi_backlight; + }else { + dev_priv->display.setup_backlight = vlv_setup_backlight; + dev_priv->display.enable_backlight = vlv_enable_backlight; + dev_priv->display.disable_backlight = vlv_disable_backlight; + dev_priv->display.set_backlight = vlv_set_backlight; + dev_priv->display.get_backlight = vlv_get_backlight; + } }else if (IS_GEN4 (dev)) { dev_priv->display.setup_backlight = i965_setup_backlight; dev_priv->display.enable_backlight = i965_enable_backlight;
drivers/gpu/drm/i915/intel_panel.c void intel_panel_fini(struct intel_panel *panel) · line 1488
Quoted 8 lines
drivers/gpu/drm/i915/intel_panel.c +5
-0@@ -1404,6 +1481,11 @@ void intel_panel_fini(struct intel_panel *panel)if (panel->downclock_mode)drm_mode_destroy (intel_connector->base.dev, panel->downclock_mode); + +/* dispose of the pwm */ +if (panel->backlight.pwm) +pwm_put (panel->backlight.pwm); +
The cleanup should be in intel_panel_destroy_backlight to match where .pwm is initialized.
BR,
Jani.
Quoted 6 lines
drivers/gpu/drm/i915/intel_panel.c +0
-0}void intel_backlight_register (struct drm_device *dev)Signature · 1 line
2.1.0
Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 7/8] drm/i915: Use the CRC gpio for panel enable/disable
In reply to Jani NikulaQuoted 104 lines · Jani Nikula
Quoted 103 lines · Shobhit Kumar
The CRC (Crystal Cove) PMIC, controls the panel enable and disable signals for BYT for dsi panels. This is indicated in the VBT fields. Use that to initialize and use GPIO based control for these signals.
v2: Use the newer gpiod interface(Alexandre)
v3: Remove the redundant checks and unused code (Ville)CC Samuel Ortiz <[email protected]>Cc Linus Walleij <[email protected]>Cc Alexandre Courbot <[email protected]>Cc Thierry Reding <[email protected]>Signed-off-by Shobhit Kumar <[email protected]>--- drivers/gpu/drm/i915/intel_dsi.c | 32 ++++++++++++++++++++++++++++++-- drivers/gpu/drm/i915/intel_dsi.h | 6 ++++++ 2 files changed, 36 insertions(+), 2 deletions(-)drivers/gpu/drm/i915/intel_dsi.c +30
-2@@ -31,6 +31,7 @@#include <drm/drm_panel.h> #include <drm/drm_mipi_dsi.h> #include <linux/slab.h> +#include <linux/gpio/consumer.h> #include "i915_drv.h" #include "intel_drv.h" #include "intel_dsi.h" @@ -415,6 +416,12 @@ static void intel_dsi_pre_enable(struct intel_encoder *encoder)DRM_DEBUG_KMS ("\n" ); +/* Panel Enable over CRC PMIC */ +if (intel_dsi->gpio_panel) +gpiod_set_value_cansleep (intel_dsi->gpio_panel,1 ); + +msleep (intel_dsi->panel_on_delay); +/* Disable DPOunit clock gating, can stall pipe * and we need DPLL REFA always enabled */ tmp =I915_READ (DPLL (pipe));@@ -432,8 +439,6 @@ static void intel_dsi_pre_enable(struct intel_encoder *encoder)/* put device in ready state */ intel_dsi_device_ready (encoder); -msleep (intel_dsi->panel_on_delay); -drm_panel_prepare (intel_dsi->panel);for_each_dsi_port (port, intel_dsi->ports)@@ -576,6 +581,10 @@ static void intel_dsi_post_disable(struct intel_encoder *encoder)msleep (intel_dsi->panel_off_delay);msleep (intel_dsi->panel_pwr_cycle_delay); + +/* Panel Disable over CRC PMIC */ +if (intel_dsi->gpio_panel) +gpiod_set_value_cansleep (intel_dsi->gpio_panel,0 ); } static bool intel_dsi_get_hw_state(struct intel_encoder *encoder,@@ -955,6 +964,11 @@ static void intel_dsi_encoder_destroy(struct drm_encoder *encoder)/* XXX: Logically this call belongs in the panel driver. */ drm_panel_remove (intel_dsi->panel); } + +/* dispose of the gpios */ +if (intel_dsi->gpio_panel) +gpiod_put (intel_dsi->gpio_panel); +intel_encoder_destroy (encoder); }@@ -1071,6 +1085,20 @@ void intel_dsi_init(struct drm_device *dev) goto err; } +/* +* In case of BYT with CRC PMIC, we need to use GPIO for +* Panel control. +*/ +if (dev_priv->vbt.dsi.config->pwm_blc ==PPS_BLC_PMIC ) { + intel_dsi->gpio_panel = +gpiod_get (dev->dev,"panel" ,GPIOD_OUT_HIGH ); + +if (IS_ERR (intel_dsi->gpio_panel)) { +DRM_ERROR ("Failed to own gpio for panel control\n" ); + intel_dsi->gpio_panel =NULL ; + } + } + intel_encoder->type =INTEL_OUTPUT_DSI ; intel_encoder->cloneable =0 ; drm_connector_init(dev, connector, &intel_dsi_connector_funcs,drivers/gpu/drm/i915/intel_dsi.h +0
-0@@ -29,6 +29,9 @@#include <drm/drm_mipi_dsi.h> #include "intel_drv.h"
Quoted 7 lines
drivers/gpu/drm/i915/intel_dsi.h line 33
Quoted 2 lines
drivers/gpu/drm/i915/intel_dsi.h +2
-0+#define PPS_BLC_PMIC 0 +#define PPS_BLC_SOC 1Since these values are defined in the VBT, perhaps these should be in
intel_bios.h. Up to you, I'm fine either way.Reviewed-by Jani Nikula <[email protected]>
Yeah if they're vbt it's better to keep all that together. Maybe we'll eventually get a bright future where vbt documentation is solid, and then it's good to have it all in one place.
-Daniel
Quoted 26 lines
Quoted 19 lines
drivers/gpu/drm/i915/intel_dsi.h +4
-0+/* Dual Link support */ #define DSI_DUAL_LINK_NONE 0#define DSI_DUAL_LINK_FRONT_BACK 1@@ -42,6 +45,9 @@ struct intel_dsi {struct drm_panel *panel;struct intel_dsi_host *dsi_hosts[I915_MAX_PORTS ]; +/* GPIO Desc for CRC based Panel control */ +struct gpio_desc *gpio_panel; +struct intel_connector *attached_connector;/* bit mask of ports being driven */ Signature · 1 line
2.1.0Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH 1/8] drivers/gpio/gpiolib: Add support for removing registered consumer lookup table
In reply to Shobhit KumarQuoted 4 lines · Shobhit Kumar
In case we unload and load a driver module again that is registering a lookup table, without this it will result in multiple entries. Provide an option to remove the lookup table on driver unload
Quoted 8 lines
v2: Ccing maintainers
Cc Samuel Ortiz <[email protected]>Cc Linus Walleij <[email protected]>Cc Alexandre Courbot <[email protected]>Cc Thierry Reding <[email protected]>Reviewed-by Alexandre Courbot <[email protected]>Signed-off-by Shobhit Kumar <[email protected]>
Since it is core support I'd prefer to merge this into the GPIO git tree. Is it OK or do you need to merge it through some other means?
Yours,
Linus Walleij
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH 3/8] drivers/mfd: Add lookup table for Panel Control as GPIO signal
In reply to Shobhit KumarQuoted 4 lines · Shobhit Kumar
On some Intel SoC platforms, the panel enable/disable signals are controlled by CRC PMIC. Add those control as a new GPIO in a lookup table for gpio-crystalcove chip during CRC driver load
Quoted 8 lines
v2: Make the lookup table static (Thierry)
Remove the lookup table during driver remove (Thierry)CC Samuel Ortiz <[email protected]>Cc Linus Walleij <[email protected]>Cc Alexandre Courbot <[email protected]>Cc Thierry Reding <[email protected]>Signed-off-by Shobhit Kumar <[email protected]>
Yours,
Linus Walleij
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 1/8] drivers/gpio/gpiolib: Add support for removing registered consumer lookup table
In reply to Linus WalleijQuoted 8 lines · Linus Walleij
Quoted 6 lines · Shobhit Kumar
In case we unload and load a driver module again that is registering a lookup table, without this it will result in multiple entries. Provide an option to remove the lookup table on driver unload
v2: Ccing maintainers
Quoted 8 lines
Quoted 6 lines
Cc Samuel Ortiz <[email protected]>Cc Linus Walleij <[email protected]>Cc Alexandre Courbot <[email protected]>Cc Thierry Reding <[email protected]>Reviewed-by Alexandre Courbot <[email protected]>Signed-off-by Shobhit Kumar <[email protected]>Reviewed-by Linus Walleij <[email protected]>
I think the gpio/pwm and mfd parts would all need to go in through the same tree. i915 parts are decoupled. I guess I could do a branch with just those patches, tag it and then send a pull request to all 3 subsystems once it's reviewed. Would that be ok?
-Daniel
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 6/8] pwm: crc: Add Crystalcove (CRC) PWM driver
In reply to Paul BolleQuoted 15 lines · Paul Bolle
Quoted 6 lines · Shobhit Kumar
The Crystalcove PMIC controls PWM signals and this driver exports that capability as a PWM chip driver. This is platform device implementtaion of the
drivers/mfdcell device for CRC PMICv2: Use the existing config callback with
duty_nsandperiod_ns(Thierry)Quoted 7 lines
v3: Correct the subject line (Lee jones)
CC Samuel Ortiz <[email protected]>Cc Linus Walleij <[email protected]>Cc Alexandre Courbot <[email protected]>Cc Thierry Reding <[email protected]>Signed-off-by Shobhit Kumar <[email protected]>
Quoted 8 lines
The same comments can be made as for v2, see
http://lkml.kernel.org/r/1430428322.2187.24.camel@x220 . Maybe you didn't receive that message.It could also be that you think my comments were invalid, or too vague, or whatever. Please say so, because then I don't have to bother you again when you send out v4.
Not at all, I just missed your comments and realise my mistake later after sending next update. Somehow the mailing list filters that I have setup are not working correctly. I will look into your comments.
Regards
Shobhit
Re: [Intel-gfx] [PATCH 6/8] pwm: crc: Add Crystalcove (CRC) PWM driver
In reply to Thierry RedingQuoted 6 lines · Thierry Reding
Quoted 1 line · Shobhit Kumar
The Crystalcove PMIC controls PWM signals and this driver exports that
You say
signal_s_here, but you only expose a single PWM device. Does the PMIC really control more than one? If it isn't, this should probably
become: "controls a PWM output and this driver...".
Actually it does support 3 of them but on the platform only one is being used and I exported only that as of now. Probably I should expand a little in the commit message indicating this. will re-post after fixing based on your other comments.
Regards
Shobhit
Quoted 263 lines
Quoted 2 lines
capability as a PWM chip driver. This is platform device implementtaion
"implementation"
Quoted 1 line
of the
drivers/mfdcell device for CRC PMICSentences should end with a full stop.
Quoted 5 lines
drivers/pwm/Kconfig +0
-0drivers/pwm/Kconfig config PWM_LPC32XX · line 192
Quoted 10 lines
drivers/pwm/Kconfig +7
-0@@ -183,6 +183,13 @@ config PWM_LPC32XX To compile this driver as a module, choose M here: the module will be called pwm-lpc32xx. +config PWM_CRC + bool "Intel Crystalcove (CRC) PWM support" + depends on X86 && INTEL_SOC_PMIC + help + Generic PWM framework driver for Crystalcove (CRC) PMIC based PWM + control. +This is badly sorted. Please keep the list sorted alphabetically.
drivers/pwm/Makefile obj-$(CONFIG_PWM_TIPWMSS) += pwm-tipwmss.o · line 38
Quoted 12 lines
drivers/pwm/Kconfig +0
-0config PWM_LPSS tristate "Intel LPSS PWM support" depends on X86drivers/pwm/Makefile +1
-0@@ -35,3 +35,4 @@ obj-$(CONFIG_PWM_TIPWMSS) += pwm-tipwmss.o obj-$(CONFIG_PWM_TWL) += pwm-twl.o obj-$(CONFIG_PWM_TWL_LED) += pwm-twl-led.o obj-$(CONFIG_PWM_VT8500) += pwm-vt8500.o +obj-$(CONFIG_PWM_CRC) += pwm-crc.oThis too.
drivers/pwm/pwm-crc.c line 2
Quoted 8 lines
drivers/pwm/pwm-crc.c new file +2
-0@@ -0,0 +1,171 @@ +/* +* pwm-crc.c - Intel Crystal Cove PWM Driver I think you can safely remove this line. You already know what file it is when you open it in your editor, and the description is in the
MODULE_DESCRIPTIONstring already.Quoted 13 lines
drivers/pwm/pwm-crc.c new file +13
-0+* +* Copyright (C) 2015 Intel Corporation. All rights reserved. +* +* This program is free software; you can redistribute it and/or +* modify it under the terms of the GNU General Public License version +* 2 as published by the Free Software Foundation. +* +* This program is distributed in the hope that it will be useful, +* but WITHOUT ANY WARRANTY; without even the implied warranty of +* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +* GNU General Public License for more details. +* +* Author: Shobhit Kumar <[email protected]> drivers/pwm/pwm-crc.c line 25
Quoted 10 lines
drivers/pwm/pwm-crc.c new file +10
-0+*/ + +#include <linux/module.h> +#include <linux/platform_device.h> +#include <linux/regmap.h> +#include <linux/mfd/intel_soc_pmic.h> +#include <linux/pwm.h> + +#define PWM0_CLK_DIV 0x4B +#define PWM_OUTPUT_ENABLE (1<<7)Should have spaces around <<.
drivers/pwm/pwm-crc.c line 35
Quoted 10 lines
drivers/pwm/pwm-crc.c new file +10
-0+#define PWM_DIV_CLK_0 0x00/* DIVIDECLK = BASECLK */ +#define PWM_DIV_CLK_100 0x63/* DIVIDECLK = BASECLK/100 */ +#define PWM_DIV_CLK_128 0x7F/* DIVIDECLK = BASECLK/128 */ + +#define PWM0_DUTY_CYCLE 0x4E +#define BACKLIGHT_EN 0x51 + +#define PWM_MAX_LEVEL 0xFF + +#define PWM_BASE_CLK 6000/* 6 MHz */ This number is actually 6 KHz. I think it'd be better if you stuck with one unit here. Or perhaps there's some other reason why you can't use 6000000 here instead?
drivers/pwm/pwm-crc.c line 45
Quoted 10 lines
drivers/pwm/pwm-crc.c new file +10
-0+#define PWM_MAX_PERIOD_NS 21333/* 46.875KHz */ + +/** +* struct crystalcove_pwm - Crystal Cove PWM controller +* @chip: the abstract pwm_chip structure. +* @regmap: the regmap from the parent device. +*/ +struct crystalcove_pwm { +struct pwm_chip chip; +struct platform_device *pdev;I think I had at some point requested that you get rid of this and use the chip.dev member instead. There's no kerneldoc for it and it isn't (well, almost, see below) used anywhere else, so perhaps you forgot to remove it here?
Quoted 16 lines
drivers/pwm/pwm-crc.c new file +16
-0+struct regmap *regmap; +}; + +static inline struct crystalcove_pwm *to_crc_pwm (struct pwm_chip *pc) +{ + return container_of(pc, struct crystalcove_pwm, chip); +} + +static int crc_pwm_enable (struct pwm_chip *c,struct pwm_device *pwm) +{ +struct crystalcove_pwm *crc_pwm =to_crc_pwm (c); + +regmap_write (crc_pwm->regmap,BACKLIGHT_EN ,1 ); + +return 0 ; +}drivers/pwm/pwm-crc.c line 71
Quoted 10 lines
drivers/pwm/pwm-crc.c new file +10
-0+ +static void crc_pwm_disable (struct pwm_chip *c,struct pwm_device *pwm) +{ +struct crystalcove_pwm *crc_pwm =to_crc_pwm (c); + +regmap_write (crc_pwm->regmap,BACKLIGHT_EN ,0 ); +} + +static int crc_pwm_config (struct pwm_chip *c,struct pwm_device *pwm, +int duty_ns,int period_ns)Please align arguments on subsequent lines with the first argument of the first line.
drivers/pwm/pwm-crc.c line 74
Quoted 3 lines
drivers/pwm/pwm-crc.c new file +3
-0+{ +struct crystalcove_pwm *crc_pwm =to_crc_pwm (c); +struct device *dev = &crc_pwm->pdev->dev;Did you test reconfiguring the PWM? I don't see
crc_pwm->pdevgetting initialized anywhere, so this should crash trying to dereference a NULL pointer.Of course if you get rid of the pdev field as I suggested you can simply get the struct device * from
c->dev.drivers/pwm/pwm-crc.c line 79
Quoted 5 lines
drivers/pwm/pwm-crc.c new file +5
-0+int level, percent; + +if (period_ns >PWM_MAX_PERIOD_NS ) { +dev_err (dev,"un-supported period_ns\n" ); +return -1 ;You should return
-EINVALhere. Besides being a literal and therefore a bad idea, -1 ==-EPERMand doesn't match the error condition.drivers/pwm/pwm-crc.c line 87
Quoted 8 lines
drivers/pwm/pwm-crc.c new file +8
-0+ } + +if (pwm->period != period_ns) { +int clk_div; + +/* changing the clk divisor, need to disable fisrt */ +crc_pwm_disable (c, pwm); + clk_div =PWM_BASE_CLK * period_ns /1000000 ;Similar to the above, this is confusing because you're mixing up different scales here.
period_nsis in nanoseconds, so it'd be natural to divide by 1000000000 (though you should really be usingNSEC_PER_SECinstead). If you counterweight that by expressingPWM_BASE_CLKin Hz (6000000) you get much nicer symmetry and make the code a lot easier to understand.drivers/pwm/pwm-crc.c line 99
Quoted 12 lines
drivers/pwm/pwm-crc.c new file +12
-0+ +regmap_write (crc_pwm->regmap,PWM0_CLK_DIV , + clk_div |PWM_OUTPUT_ENABLE ); + +/* enable back */ +crc_pwm_enable (c, pwm); + } + +if (duty_ns > period_ns) { +dev_err (dev,"duty cycle cannot be greater than cycle period\n" ); +return -1 ; + }The PWM core already performs this check, so you'll never get here in case this condition is true.
drivers/pwm/pwm-crc.c line 103
Quoted 4 lines
drivers/pwm/pwm-crc.c new file +4
-0+ +/* change the pwm duty cycle */ + percent = duty_ns *100 / period_ns; + level = percent *PWM_MAX_LEVEL /100 ;Why do you need to apply the rule of three twice here? Doesn't
level = duty_ns * PWM_MAX_LEVEL / period_ns;give you what you want?
Quoted 26 lines
drivers/pwm/pwm-crc.c new file +26
-0+regmap_write (crc_pwm->regmap,PWM0_DUTY_CYCLE , level); + +return 0 ; +} + +static const struct pwm_ops crc_pwm_ops = { + .config = crc_pwm_config, + .enable = crc_pwm_enable, + .disable = crc_pwm_disable, + .owner =THIS_MODULE , +}; + +static int crystalcove_pwm_probe (struct platform_device *pdev) +{ +struct crystalcove_pwm *pwm; +int retval; +struct device *dev = pdev->dev.parent; +struct intel_soc_pmic *pmic =dev_get_drvdata (dev); + + pwm =devm_kzalloc (&pdev->dev,sizeof (*pwm),GFP_KERNEL ); +if (!pwm) +return -ENOMEM ; + + pwm->chip.dev = &pdev->dev; + pwm->chip.ops = &crc_pwm_ops; + pwm->chip.base =-1 ;drivers/pwm/pwm-crc.c line 139
Quoted 10 lines
drivers/pwm/pwm-crc.c new file +10
-0+ pwm->chip.npwm =1 ; + +/* get the PMIC regmap */ + pwm->regmap = pmic->regmap; + + retval =pwmchip_add (&pwm->chip); +if (retval <0 ) +return retval; + +dev_dbg (&pdev->dev,"crc-pwm probe successful\n" );Do you really want this? The driver core will complain in any of the above failures, so what use is there to be chatty when probing succeeds?
drivers/pwm/pwm-crc.c line 163
Quoted 5 lines
drivers/pwm/pwm-crc.c new file +5
-0+static struct platform_driver crystalcove_pwm_driver = { + .probe = crystalcove_pwm_probe, + .remove = crystalcove_pwm_remove, + .driver = { + .name ="crystal_cove_pwm" ,I'd prefer this to be "crystal-cove-pwm" for consistency with other drivers, but since the MFD part already uses underscores in names it'd introduce an inconsistency there. So I'm fine with this one as-is.
Thierry
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 1/8] gpiolib: Add support for removing registered consumer lookup table
In reply to Daniel VetterQuoted 7 lines · Daniel Vetter
Quoted 1 line · Lee Jones
This is not how we submit subsequent patch-sets.
It is unfortunately how we handle patches on dri-devel&intel-gfx to be able to cope with massive mail load. If everyone who submits to intel-gfx would always resend the entire series for minor updates of som patches we'd completely drown in the resulting flood.
For one or two simple fix-ups in the set perhaps, but when submitting the entire set it needs to be threaded as a separate block, rather than seeing current and superseded patches inter-woven. This submission is already a rat's nest and I'm struggling to see which patches are which. I'm really not looking forward to v3 and v4! Attaching one version to another is a good way to keep control if you really are over-whelmed. For your use-case I would expect to see the following, which is achieved using --in-reply-to:
[PATCH 0/2] Here is what I did...
[PATCH 1/2] Clean up and tests
[PATCH 2/2] Implementation
[PATCH v2 0/3] Here is a reroll
[PATCH v2 1/3] Clean up
[PATCH v2 2/3] New tests
[PATCH v2 3/3] Implementation
The version numbers also need to be present and aren't in this re-submission.
Quoted 7 lines
Quoted 7 lines
Please submit them as a whole, seperately from the first submission and with versioning information i.e. [PATCH v2 X/Y] Stuff ...
Quoted 4 lines
In case we unload and load a driver module again that is registering a lookup table, without this it will result in multiple entries. Provide an option to remove the lookup table on driver unload
Quoted 8 lines
Quoted 5 lines
Quoted 2 lines
v2: Ccing maintainers
v3: Correct the subject line (Lee jones)Change logs should go underneth the '---' and above the diffstat found below.
Again just style differences between subsystems, I generally want to have those above the ---.
For all commits? Then I'm guessing your Git history is all but unreadable. In the kernel, unless the changelog holds valuable historic information which influance key design decisions, we put the patch changelog *below* the '---'.
Please read Documentation/SubmittingPatches:
"14) The canonical patch format
[...]
The "---" marker line serves the essential purpose of marking for patch handling tools where the changelog message ends.
[...]
Other comments relevant only to the moment or the maintainer, not suitable for the permanent changelog, should also go here. A good example of such comments might be *"patch changelogs"* which describe what has changed between the v1 and v2 version of the patch."
Quoted 48 lines
Quoted 47 lines
Quoted 46 lines
Cc Samuel Ortiz <[email protected]>Cc Linus Walleij <[email protected]>Cc Alexandre Courbot <[email protected]>Cc Thierry Reding <[email protected]>Reviewed-by Alexandre Courbot <[email protected]>Signed-off-by Shobhit Kumar <[email protected]>--- drivers/gpio/gpiolib.c | 13 +++++++++++++ include/linux/gpio/machine.h | 1 + 2 files changed, 14 insertions(+)drivers/gpio/gpiolib.c +13
-0@@ -1658,6 +1658,19 @@ void gpiod_add_lookup_table(struct gpiod_lookup_table *table)mutex_unlock (&gpio_lookup_lock); } +/** +* gpiod_remove_lookup_table() - unregister GPIO device consumers +* @table: table of consumers to unregister +*/ +void gpiod_remove_lookup_table (struct gpiod_lookup_table *table) +{ +mutex_lock (&gpio_lookup_lock); + +list_del (&table->list); + +mutex_unlock (&gpio_lookup_lock); +} +static struct gpio_desc *of_find_gpio (struct device *dev,const char *con_id,unsigned int idx,enum gpio_lookup_flags *flags)include/linux/gpio/machine.h +1
-0@@ -57,5 +57,6 @@ struct gpiod_lookup_table { }void gpiod_add_lookup_table (struct gpiod_lookup_table *table); +void gpiod_remove_lookup_table (struct gpiod_lookup_table *table);#endif /* __LINUX_GPIO_MACHINE_H */
Signature · 8 lines
Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 1/8] drivers/gpio/gpiolib: Add support for removing registered consumer lookup table
In reply to Daniel VetterQuoted 16 lines · Daniel Vetter
Quoted 15 lines · Linus Walleij
Quoted 12 lines · Shobhit Kumar
In case we unload and load a driver module again that is registering a lookup table, without this it will result in multiple entries. Provide an option to remove the lookup table on driver unload
v2: Ccing maintainers
Cc Samuel Ortiz <[email protected]>Cc Linus Walleij <[email protected]>Cc Alexandre Courbot <[email protected]>Cc Thierry Reding <[email protected]>Reviewed-by Alexandre Courbot <[email protected]>Signed-off-by Shobhit Kumar <[email protected]>
Quoted 6 lines
Quoted 1 line
Reviewed-by Linus Walleij <[email protected]>I think the gpio/pwm and mfd parts would all need to go in through the same tree. i915 parts are decoupled. I guess I could do a branch with just those patches, tag it and then send a pull request to all 3 subsystems once it's reviewed. Would that be ok?
That's an immutable branch I guess, and yeah I think it's OK. I usually only pull these in if/when there are conflicts in -next.
Yours,
Linus Walleij
_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH 3/8] mfd: intel_soc_pmic_core: Add lookup table for Panel Control as GPIO signal
In reply to Shobhit KumarQuoted 7 lines · Shobhit Kumar
On some Intel SoC platforms, the panel enable/disable signals are controlled by CRC PMIC. Add those control as a new GPIO in a lookup table for gpio-crystalcove chip during CRC driver load
v2: Make the lookup table static (Thierry)
Remove the lookup table during driver remove (Thierry)
Quoted 8 lines
v3: Correct the subject line (Lee jones)
CC Samuel Ortiz <[email protected]>Cc Linus Walleij <[email protected]>Cc Alexandre Courbot <[email protected]>Cc Thierry Reding <[email protected]>Acked-by Lee Jones <[email protected]>Signed-off-by Shobhit Kumar <[email protected]>
Yours,
Linus Walleij
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH 7/8] drm/i915: Use the CRC gpio for panel enable/disable
In reply to Shobhit KumarQuoted 4 lines · Shobhit Kumar
The CRC (Crystal Cove) PMIC, controls the panel enable and disable signals for BYT for dsi panels. This is indicated in the VBT fields. Use that to initialize and use GPIO based control for these signals.
Quoted 8 lines
v2: Use the newer gpiod interface(Alexandre)
v3: Remove the redundant checks and unused code (Ville)CC Samuel Ortiz <[email protected]>Cc Linus Walleij <[email protected]>Cc Alexandre Courbot <[email protected]>Cc Thierry Reding <[email protected]>Signed-off-by Shobhit Kumar <[email protected]>
Yours,
Linus Walleij
Re: [Intel-gfx] [PATCH 6/8] pwm: crc: Add Crystalcove (CRC) PWM driver
In reply to Shobhit KumarQuoted 4 lines · Shobhit Kumar
Quoted 3 lines · Thierry Reding
Quoted 1 line · Shobhit Kumar
The Crystalcove PMIC controls PWM signals and this driver exports that
Quoted 8 lines
Quoted 3 lines
You say
signal_s_here, but you only expose a single PWM device. Does the PMIC really control more than one? If it isn't, this should probably
become: "controls a PWM output and this driver...".Actually it does support 3 of them but on the platform only one is being used and I exported only that as of now. Probably I should expand a little in the commit message indicating this. will re-post after fixing based on your other comments.
Updates pending due to personal leave. Can be expected next week.
Regards
Shobhit
Quoted 267 lines
Regards
ShobhitQuoted 263 lines
Quoted 2 lines
capability as a PWM chip driver. This is platform device implementtaion
"implementation"
Quoted 1 line
of the
drivers/mfdcell device for CRC PMICSentences should end with a full stop.
Quoted 5 lines
drivers/pwm/Kconfig +0
-0drivers/pwm/Kconfig config PWM_LPC32XX · line 192
Quoted 10 lines
drivers/pwm/Kconfig +7
-0@@ -183,6 +183,13 @@ config PWM_LPC32XX To compile this driver as a module, choose M here: the module will be called pwm-lpc32xx. +config PWM_CRC + bool "Intel Crystalcove (CRC) PWM support" + depends on X86 && INTEL_SOC_PMIC + help + Generic PWM framework driver for Crystalcove (CRC) PMIC based PWM + control. +This is badly sorted. Please keep the list sorted alphabetically.
drivers/pwm/Makefile obj-$(CONFIG_PWM_TIPWMSS) += pwm-tipwmss.o · line 38
Quoted 12 lines
drivers/pwm/Kconfig +0
-0config PWM_LPSS tristate "Intel LPSS PWM support" depends on X86drivers/pwm/Makefile +1
-0@@ -35,3 +35,4 @@ obj-$(CONFIG_PWM_TIPWMSS) += pwm-tipwmss.o obj-$(CONFIG_PWM_TWL) += pwm-twl.o obj-$(CONFIG_PWM_TWL_LED) += pwm-twl-led.o obj-$(CONFIG_PWM_VT8500) += pwm-vt8500.o +obj-$(CONFIG_PWM_CRC) += pwm-crc.oThis too.
drivers/pwm/pwm-crc.c line 2
Quoted 8 lines
drivers/pwm/pwm-crc.c new file +2
-0@@ -0,0 +1,171 @@ +/* +* pwm-crc.c - Intel Crystal Cove PWM Driver I think you can safely remove this line. You already know what file it is when you open it in your editor, and the description is in the
MODULE_DESCRIPTIONstring already.Quoted 13 lines
drivers/pwm/pwm-crc.c new file +13
-0+* +* Copyright (C) 2015 Intel Corporation. All rights reserved. +* +* This program is free software; you can redistribute it and/or +* modify it under the terms of the GNU General Public License version +* 2 as published by the Free Software Foundation. +* +* This program is distributed in the hope that it will be useful, +* but WITHOUT ANY WARRANTY; without even the implied warranty of +* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +* GNU General Public License for more details. +* +* Author: Shobhit Kumar <[email protected]> drivers/pwm/pwm-crc.c line 25
Quoted 10 lines
drivers/pwm/pwm-crc.c new file +10
-0+*/ + +#include <linux/module.h> +#include <linux/platform_device.h> +#include <linux/regmap.h> +#include <linux/mfd/intel_soc_pmic.h> +#include <linux/pwm.h> + +#define PWM0_CLK_DIV 0x4B +#define PWM_OUTPUT_ENABLE (1<<7)Should have spaces around <<.
drivers/pwm/pwm-crc.c line 35
Quoted 10 lines
drivers/pwm/pwm-crc.c new file +10
-0+#define PWM_DIV_CLK_0 0x00/* DIVIDECLK = BASECLK */ +#define PWM_DIV_CLK_100 0x63/* DIVIDECLK = BASECLK/100 */ +#define PWM_DIV_CLK_128 0x7F/* DIVIDECLK = BASECLK/128 */ + +#define PWM0_DUTY_CYCLE 0x4E +#define BACKLIGHT_EN 0x51 + +#define PWM_MAX_LEVEL 0xFF + +#define PWM_BASE_CLK 6000/* 6 MHz */ This number is actually 6 KHz. I think it'd be better if you stuck with one unit here. Or perhaps there's some other reason why you can't use 6000000 here instead?
drivers/pwm/pwm-crc.c line 45
Quoted 10 lines
drivers/pwm/pwm-crc.c new file +10
-0+#define PWM_MAX_PERIOD_NS 21333/* 46.875KHz */ + +/** +* struct crystalcove_pwm - Crystal Cove PWM controller +* @chip: the abstract pwm_chip structure. +* @regmap: the regmap from the parent device. +*/ +struct crystalcove_pwm { +struct pwm_chip chip; +struct platform_device *pdev;I think I had at some point requested that you get rid of this and use the chip.dev member instead. There's no kerneldoc for it and it isn't (well, almost, see below) used anywhere else, so perhaps you forgot to remove it here?
Quoted 16 lines
drivers/pwm/pwm-crc.c new file +16
-0+struct regmap *regmap; +}; + +static inline struct crystalcove_pwm *to_crc_pwm (struct pwm_chip *pc) +{ + return container_of(pc, struct crystalcove_pwm, chip); +} + +static int crc_pwm_enable (struct pwm_chip *c,struct pwm_device *pwm) +{ +struct crystalcove_pwm *crc_pwm =to_crc_pwm (c); + +regmap_write (crc_pwm->regmap,BACKLIGHT_EN ,1 ); + +return 0 ; +}drivers/pwm/pwm-crc.c line 71
Quoted 10 lines
drivers/pwm/pwm-crc.c new file +10
-0+ +static void crc_pwm_disable (struct pwm_chip *c,struct pwm_device *pwm) +{ +struct crystalcove_pwm *crc_pwm =to_crc_pwm (c); + +regmap_write (crc_pwm->regmap,BACKLIGHT_EN ,0 ); +} + +static int crc_pwm_config (struct pwm_chip *c,struct pwm_device *pwm, +int duty_ns,int period_ns)Please align arguments on subsequent lines with the first argument of the first line.
drivers/pwm/pwm-crc.c line 74
Quoted 3 lines
drivers/pwm/pwm-crc.c new file +3
-0+{ +struct crystalcove_pwm *crc_pwm =to_crc_pwm (c); +struct device *dev = &crc_pwm->pdev->dev;Did you test reconfiguring the PWM? I don't see
crc_pwm->pdevgetting initialized anywhere, so this should crash trying to dereference a NULL pointer.Of course if you get rid of the pdev field as I suggested you can simply get the struct device * from
c->dev.drivers/pwm/pwm-crc.c line 79
Quoted 5 lines
drivers/pwm/pwm-crc.c new file +5
-0+int level, percent; + +if (period_ns >PWM_MAX_PERIOD_NS ) { +dev_err (dev,"un-supported period_ns\n" ); +return -1 ;You should return
-EINVALhere. Besides being a literal and therefore a bad idea, -1 ==-EPERMand doesn't match the error condition.drivers/pwm/pwm-crc.c line 87
Quoted 8 lines
drivers/pwm/pwm-crc.c new file +8
-0+ } + +if (pwm->period != period_ns) { +int clk_div; + +/* changing the clk divisor, need to disable fisrt */ +crc_pwm_disable (c, pwm); + clk_div =PWM_BASE_CLK * period_ns /1000000 ;Similar to the above, this is confusing because you're mixing up different scales here.
period_nsis in nanoseconds, so it'd be natural to divide by 1000000000 (though you should really be usingNSEC_PER_SECinstead). If you counterweight that by expressingPWM_BASE_CLKin Hz (6000000) you get much nicer symmetry and make the code a lot easier to understand.drivers/pwm/pwm-crc.c line 99
Quoted 12 lines
drivers/pwm/pwm-crc.c new file +12
-0+ +regmap_write (crc_pwm->regmap,PWM0_CLK_DIV , + clk_div |PWM_OUTPUT_ENABLE ); + +/* enable back */ +crc_pwm_enable (c, pwm); + } + +if (duty_ns > period_ns) { +dev_err (dev,"duty cycle cannot be greater than cycle period\n" ); +return -1 ; + }The PWM core already performs this check, so you'll never get here in case this condition is true.
drivers/pwm/pwm-crc.c line 103
Quoted 4 lines
drivers/pwm/pwm-crc.c new file +4
-0+ +/* change the pwm duty cycle */ + percent = duty_ns *100 / period_ns; + level = percent *PWM_MAX_LEVEL /100 ;Why do you need to apply the rule of three twice here? Doesn't
level = duty_ns * PWM_MAX_LEVEL / period_ns;give you what you want?
Quoted 26 lines
drivers/pwm/pwm-crc.c new file +26
-0+regmap_write (crc_pwm->regmap,PWM0_DUTY_CYCLE , level); + +return 0 ; +} + +static const struct pwm_ops crc_pwm_ops = { + .config = crc_pwm_config, + .enable = crc_pwm_enable, + .disable = crc_pwm_disable, + .owner =THIS_MODULE , +}; + +static int crystalcove_pwm_probe (struct platform_device *pdev) +{ +struct crystalcove_pwm *pwm; +int retval; +struct device *dev = pdev->dev.parent; +struct intel_soc_pmic *pmic =dev_get_drvdata (dev); + + pwm =devm_kzalloc (&pdev->dev,sizeof (*pwm),GFP_KERNEL ); +if (!pwm) +return -ENOMEM ; + + pwm->chip.dev = &pdev->dev; + pwm->chip.ops = &crc_pwm_ops; + pwm->chip.base =-1 ;drivers/pwm/pwm-crc.c line 139
Quoted 10 lines
drivers/pwm/pwm-crc.c new file +10
-0+ pwm->chip.npwm =1 ; + +/* get the PMIC regmap */ + pwm->regmap = pmic->regmap; + + retval =pwmchip_add (&pwm->chip); +if (retval <0 ) +return retval; + +dev_dbg (&pdev->dev,"crc-pwm probe successful\n" );Do you really want this? The driver core will complain in any of the above failures, so what use is there to be chatty when probing succeeds?
drivers/pwm/pwm-crc.c line 163
Quoted 5 lines
drivers/pwm/pwm-crc.c new file +5
-0+static struct platform_driver crystalcove_pwm_driver = { + .probe = crystalcove_pwm_probe, + .remove = crystalcove_pwm_remove, + .driver = { + .name ="crystal_cove_pwm" ,I'd prefer this to be "crystal-cove-pwm" for consistency with other drivers, but since the MFD part already uses underscores in names it'd introduce an inconsistency there. So I'm fine with this one as-is.
Thierry
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 6/8] pwm: crc: Add Crystalcove (CRC) PWM driver
Quoted 9 lines · Shobhit Kumar
Quoted 8 lines · Shobhit Kumar
Quoted 6 lines · Thierry Reding
Quoted 1 line · Shobhit Kumar
The Crystalcove PMIC controls PWM signals and this driver exports that
You say
signal_s_here, but you only expose a single PWM device. Does the PMIC really control more than one? If it isn't, this should probably
become: "controls a PWM output and this driver...".
Quoted 6 lines
Quoted 4 lines
Actually it does support 3 of them but on the platform only one is being used and I exported only that as of now. Probably I should expand a little in the commit message indicating this. will re-post after fixing based on your other comments.
Updates pending due to personal leave. Can be expected next week.
Folks, really sorry, been busy with lot of unexpected and unavoidable stuff. Working on getting the patches right. Expect them this week.
Quoted 263 lines
Quoted 263 lines
Quoted 263 lines
Quoted 2 lines
capability as a PWM chip driver. This is platform device implementtaion
"implementation"
Quoted 1 line
of the
drivers/mfdcell device for CRC PMICSentences should end with a full stop.
Quoted 5 lines
drivers/pwm/Kconfig +0
-0drivers/pwm/Kconfig config PWM_LPC32XX · line 192
Quoted 10 lines
drivers/pwm/Kconfig +7
-0@@ -183,6 +183,13 @@ config PWM_LPC32XX To compile this driver as a module, choose M here: the module will be called pwm-lpc32xx. +config PWM_CRC + bool "Intel Crystalcove (CRC) PWM support" + depends on X86 && INTEL_SOC_PMIC + help + Generic PWM framework driver for Crystalcove (CRC) PMIC based PWM + control. +This is badly sorted. Please keep the list sorted alphabetically.
drivers/pwm/Makefile obj-$(CONFIG_PWM_TIPWMSS) += pwm-tipwmss.o · line 38
Quoted 12 lines
drivers/pwm/Kconfig +0
-0config PWM_LPSS tristate "Intel LPSS PWM support" depends on X86drivers/pwm/Makefile +1
-0@@ -35,3 +35,4 @@ obj-$(CONFIG_PWM_TIPWMSS) += pwm-tipwmss.o obj-$(CONFIG_PWM_TWL) += pwm-twl.o obj-$(CONFIG_PWM_TWL_LED) += pwm-twl-led.o obj-$(CONFIG_PWM_VT8500) += pwm-vt8500.o +obj-$(CONFIG_PWM_CRC) += pwm-crc.oThis too.
drivers/pwm/pwm-crc.c line 2
Quoted 8 lines
drivers/pwm/pwm-crc.c new file +2
-0@@ -0,0 +1,171 @@ +/* +* pwm-crc.c - Intel Crystal Cove PWM Driver I think you can safely remove this line. You already know what file it is when you open it in your editor, and the description is in the
MODULE_DESCRIPTIONstring already.Quoted 13 lines
drivers/pwm/pwm-crc.c new file +13
-0+* +* Copyright (C) 2015 Intel Corporation. All rights reserved. +* +* This program is free software; you can redistribute it and/or +* modify it under the terms of the GNU General Public License version +* 2 as published by the Free Software Foundation. +* +* This program is distributed in the hope that it will be useful, +* but WITHOUT ANY WARRANTY; without even the implied warranty of +* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +* GNU General Public License for more details. +* +* Author: Shobhit Kumar <[email protected]> drivers/pwm/pwm-crc.c line 25
Quoted 10 lines
drivers/pwm/pwm-crc.c new file +10
-0+*/ + +#include <linux/module.h> +#include <linux/platform_device.h> +#include <linux/regmap.h> +#include <linux/mfd/intel_soc_pmic.h> +#include <linux/pwm.h> + +#define PWM0_CLK_DIV 0x4B +#define PWM_OUTPUT_ENABLE (1<<7)Should have spaces around <<.
drivers/pwm/pwm-crc.c line 35
Quoted 10 lines
drivers/pwm/pwm-crc.c new file +10
-0+#define PWM_DIV_CLK_0 0x00/* DIVIDECLK = BASECLK */ +#define PWM_DIV_CLK_100 0x63/* DIVIDECLK = BASECLK/100 */ +#define PWM_DIV_CLK_128 0x7F/* DIVIDECLK = BASECLK/128 */ + +#define PWM0_DUTY_CYCLE 0x4E +#define BACKLIGHT_EN 0x51 + +#define PWM_MAX_LEVEL 0xFF + +#define PWM_BASE_CLK 6000/* 6 MHz */ This number is actually 6 KHz. I think it'd be better if you stuck with one unit here. Or perhaps there's some other reason why you can't use 6000000 here instead?
drivers/pwm/pwm-crc.c line 45
Quoted 10 lines
drivers/pwm/pwm-crc.c new file +10
-0+#define PWM_MAX_PERIOD_NS 21333/* 46.875KHz */ + +/** +* struct crystalcove_pwm - Crystal Cove PWM controller +* @chip: the abstract pwm_chip structure. +* @regmap: the regmap from the parent device. +*/ +struct crystalcove_pwm { +struct pwm_chip chip; +struct platform_device *pdev;I think I had at some point requested that you get rid of this and use the chip.dev member instead. There's no kerneldoc for it and it isn't (well, almost, see below) used anywhere else, so perhaps you forgot to remove it here?
Quoted 16 lines
drivers/pwm/pwm-crc.c new file +16
-0+struct regmap *regmap; +}; + +static inline struct crystalcove_pwm *to_crc_pwm (struct pwm_chip *pc) +{ + return container_of(pc, struct crystalcove_pwm, chip); +} + +static int crc_pwm_enable (struct pwm_chip *c,struct pwm_device *pwm) +{ +struct crystalcove_pwm *crc_pwm =to_crc_pwm (c); + +regmap_write (crc_pwm->regmap,BACKLIGHT_EN ,1 ); + +return 0 ; +}drivers/pwm/pwm-crc.c line 71
Quoted 10 lines
drivers/pwm/pwm-crc.c new file +10
-0+ +static void crc_pwm_disable (struct pwm_chip *c,struct pwm_device *pwm) +{ +struct crystalcove_pwm *crc_pwm =to_crc_pwm (c); + +regmap_write (crc_pwm->regmap,BACKLIGHT_EN ,0 ); +} + +static int crc_pwm_config (struct pwm_chip *c,struct pwm_device *pwm, +int duty_ns,int period_ns)Please align arguments on subsequent lines with the first argument of the first line.
drivers/pwm/pwm-crc.c line 74
Quoted 3 lines
drivers/pwm/pwm-crc.c new file +3
-0+{ +struct crystalcove_pwm *crc_pwm =to_crc_pwm (c); +struct device *dev = &crc_pwm->pdev->dev;Did you test reconfiguring the PWM? I don't see
crc_pwm->pdevgetting initialized anywhere, so this should crash trying to dereference a NULL pointer.Of course if you get rid of the pdev field as I suggested you can simply get the struct device * from
c->dev.drivers/pwm/pwm-crc.c line 79
Quoted 5 lines
drivers/pwm/pwm-crc.c new file +5
-0+int level, percent; + +if (period_ns >PWM_MAX_PERIOD_NS ) { +dev_err (dev,"un-supported period_ns\n" ); +return -1 ;You should return
-EINVALhere. Besides being a literal and therefore a bad idea, -1 ==-EPERMand doesn't match the error condition.drivers/pwm/pwm-crc.c line 87
Quoted 8 lines
drivers/pwm/pwm-crc.c new file +8
-0+ } + +if (pwm->period != period_ns) { +int clk_div; + +/* changing the clk divisor, need to disable fisrt */ +crc_pwm_disable (c, pwm); + clk_div =PWM_BASE_CLK * period_ns /1000000 ;Similar to the above, this is confusing because you're mixing up different scales here.
period_nsis in nanoseconds, so it'd be natural to divide by 1000000000 (though you should really be usingNSEC_PER_SECinstead). If you counterweight that by expressingPWM_BASE_CLKin Hz (6000000) you get much nicer symmetry and make the code a lot easier to understand.drivers/pwm/pwm-crc.c line 99
Quoted 12 lines
drivers/pwm/pwm-crc.c new file +12
-0+ +regmap_write (crc_pwm->regmap,PWM0_CLK_DIV , + clk_div |PWM_OUTPUT_ENABLE ); + +/* enable back */ +crc_pwm_enable (c, pwm); + } + +if (duty_ns > period_ns) { +dev_err (dev,"duty cycle cannot be greater than cycle period\n" ); +return -1 ; + }The PWM core already performs this check, so you'll never get here in case this condition is true.
drivers/pwm/pwm-crc.c line 103
Quoted 4 lines
drivers/pwm/pwm-crc.c new file +4
-0+ +/* change the pwm duty cycle */ + percent = duty_ns *100 / period_ns; + level = percent *PWM_MAX_LEVEL /100 ;Why do you need to apply the rule of three twice here? Doesn't
level = duty_ns * PWM_MAX_LEVEL / period_ns;give you what you want?
Quoted 26 lines
drivers/pwm/pwm-crc.c new file +26
-0+regmap_write (crc_pwm->regmap,PWM0_DUTY_CYCLE , level); + +return 0 ; +} + +static const struct pwm_ops crc_pwm_ops = { + .config = crc_pwm_config, + .enable = crc_pwm_enable, + .disable = crc_pwm_disable, + .owner =THIS_MODULE , +}; + +static int crystalcove_pwm_probe (struct platform_device *pdev) +{ +struct crystalcove_pwm *pwm; +int retval; +struct device *dev = pdev->dev.parent; +struct intel_soc_pmic *pmic =dev_get_drvdata (dev); + + pwm =devm_kzalloc (&pdev->dev,sizeof (*pwm),GFP_KERNEL ); +if (!pwm) +return -ENOMEM ; + + pwm->chip.dev = &pdev->dev; + pwm->chip.ops = &crc_pwm_ops; + pwm->chip.base =-1 ;drivers/pwm/pwm-crc.c line 139
Quoted 10 lines
drivers/pwm/pwm-crc.c new file +10
-0+ pwm->chip.npwm =1 ; + +/* get the PMIC regmap */ + pwm->regmap = pmic->regmap; + + retval =pwmchip_add (&pwm->chip); +if (retval <0 ) +return retval; + +dev_dbg (&pdev->dev,"crc-pwm probe successful\n" );Do you really want this? The driver core will complain in any of the above failures, so what use is there to be chatty when probing succeeds?
drivers/pwm/pwm-crc.c line 163
Quoted 5 lines
drivers/pwm/pwm-crc.c new file +5
-0+static struct platform_driver crystalcove_pwm_driver = { + .probe = crystalcove_pwm_probe, + .remove = crystalcove_pwm_remove, + .driver = { + .name ="crystal_cove_pwm" ,I'd prefer this to be "crystal-cove-pwm" for consistency with other drivers, but since the MFD part already uses underscores in names it'd introduce an inconsistency there. So I'm fine with this one as-is.
Thierry
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 6/8] drivers/pwm: Add Crystalcove (CRC) PWM driver
In reply to Paul BolleQuoted 11 lines · Paul Bolle
Quoted 9 lines · Shobhit Kumar
drivers/pwm/Kconfig +6
-0+config PWM_CRC + bool "Intel Crystalcove (CRC) PWM support" + depends on X86 && INTEL_SOC_PMIC + help + Generic PWM framework driver for Crystalcove (CRC) PMIC based PWM + control.
Quoted 6 lines
drivers/pwm/Makefile
Quoted 4 lines
drivers/pwm/Makefile +1
-0+obj-$(CONFIG_PWM_CRC) += pwm-crc.o
PWM_CRCis a bool symbol. So pwm-crc.o can never be part of a module.
I actually started this as a module but later decided to make it as bool because INTEL_SOC_PMIC on which this depends is itself a bool as well. Still it is good to keep the module based initialization. Firstly because it causes no harm and even though some of the macros are pre-processed out, gives info about the driver. Secondly there were discussion on why INTEL_SOC_PMIC is bool (note this driver also has module based initialization even when bool). I am guessing because of some tricky module load order dependencies. If ever that becomes a module, this can mostly be unchanged to be loaded as a module.
Regards
Shobhit
Quoted 52 lines
(If I'm wrong, and that object file can actually be part of a module, you can stop reading here.)
drivers/pwm/pwm-crc.c
Quoted 4 lines
drivers/pwm/pwm-crc.c new file +1
-0+#include <linux/module.h> Perhaps this include is not needed.
drivers/pwm/pwm-crc.c line 113
Quoted 5 lines
drivers/pwm/pwm-crc.c new file +5
-0+static const struct pwm_ops crc_pwm_ops = { + .config = crc_pwm_config, + .enable = crc_pwm_enable, + .disable = crc_pwm_disable, + .owner =THIS_MODULE ,For built-in only code
THIS_MODULEis basically equivalent to NULL (seeinclude/linux/export.h). So I guess this line can be dropped.drivers/pwm/pwm-crc.c line 167
Quoted 11 lines
drivers/pwm/pwm-crc.c new file +10
-0+}; +static struct platform_driver crystalcove_pwm_driver = { + .probe = crystalcove_pwm_probe, + .remove = crystalcove_pwm_remove, + .driver = { + .name ="crystal_cove_pwm" , + }, +}; + +module_platform_driver (crystalcove_pwm_driver);Speaking from memory: for built-in only code this is equivalent to calling
platform_driver_register(&crystalcove_pwm_driver);from a wrapper, and marking that wrapper with
device_initcall().drivers/pwm/pwm-crc.c line 171
Quoted 3 lines
drivers/pwm/pwm-crc.c new file +3
-0+MODULE_AUTHOR ("Shobhit Kumar <[email protected]>" ); +MODULE_DESCRIPTION ("Intel Crystal Cove PWM Driver" ); +MODULE_LICENSE ("GPL v2" );These macros will be effectively preprocessed away for built-in only code.
Paul Bolle
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 6/8] drivers/pwm: Add Crystalcove (CRC) PWM driver
Hi Shobhit,
Quoted 15 lines · Shobhit Kumar
Quoted 14 lines · Paul Bolle
Quoted 12 lines · Shobhit Kumar
drivers/pwm/Kconfig +6
-0+config PWM_CRC + bool "Intel Crystalcove (CRC) PWM support" + depends on X86 && INTEL_SOC_PMIC + help + Generic PWM framework driver for Crystalcove (CRC) PMIC based PWM + control.drivers/pwm/Makefile +0
-0
Quoted 7 lines
Quoted 3 lines
Quoted 1 line
+obj-$(CONFIG_PWM_CRC) += pwm-crc.o
PWM_CRCis a bool symbol. So pwm-crc.o can never be part of a module.I actually started this as a module but later decided to make it as bool because
INTEL_SOC_PMICon which this depends is itself a bool as well.
As does GPIO_CRYSTAL_COVE and that's a tristate. So?
Quoted 2 lines
Still it is good to keep the module based initialization. Firstly because it causes no harm
If I got a dime for every time people used an argument like that I ... I could treat myself to an ice cream. A really big ice cream. Hmm, that doesn't sound too impressive. But still, "causes no harm" is below the bar for kernel code. Kernel code needs to add value.
Quoted 2 lines
and even though some of the macros
are pre-processed out, gives info about the driver.
None of which can't be gotten elsewhere (ie, the commit message, or the file these macro reside in).
Quoted 3 lines
Secondly there
were discussion on whyINTEL_SOC_PMICis bool (note this driver also has module based initialization even when bool).
Yes, there's copy and paste going on even in kernel development.
Quoted 3 lines
I am guessing because
of some tricky module load order dependencies. If ever that becomes a module, this can mostly be unchanged to be loaded as a module.
You put in a macro, or any other bit of code, when it's needed, not beforehand, "just in case". That's silly.
Thanks,
Paul Bolle
Re: [Intel-gfx] [PATCH 6/8] drivers/pwm: Add Crystalcove (CRC) PWM driver
Hi Paul,
Quoted 36 lines · Paul Bolle
Hi Shobhit,
Quoted 15 lines · Shobhit Kumar
Quoted 14 lines · Paul Bolle
Quoted 12 lines · Shobhit Kumar
drivers/pwm/Kconfig +6
-0+config PWM_CRC + bool "Intel Crystalcove (CRC) PWM support" + depends on X86 && INTEL_SOC_PMIC + help + Generic PWM framework driver for Crystalcove (CRC) PMIC based PWM + control.drivers/pwm/Makefile +0
-0Quoted 7 lines
Quoted 3 lines
Quoted 1 line
+obj-$(CONFIG_PWM_CRC) += pwm-crc.o
PWM_CRCis a bool symbol. So pwm-crc.o can never be part of a module.I actually started this as a module but later decided to make it as bool because
INTEL_SOC_PMICon which this depends is itself a bool as well.As does
GPIO_CRYSTAL_COVEand that's a tristate. So?Quoted 2 lines
Still it is good to keep the module based initialization. Firstly because it causes no harm
If I got a dime for every time people used an argument like that I ... I could treat myself to an ice cream. A really big ice cream. Hmm, that doesn't sound too impressive. But still, "causes no harm" is below the bar for kernel code. Kernel code needs to add value.
Quoted 6 lines
Quoted 2 lines
and even though some of the macros
are pre-processed out, gives info about the driver.None of which can't be gotten elsewhere (ie, the commit message, or the file these macro reside in).
Causes no harm comment had to be read together with more info about the driver. It causes no harm while providing more info. And as you only said those macros are pre-processed out to really the defaults for built-in drivers. So what is the exact big problem with this ? I can anyway shove out these macros to end the discussion.
BTW whether you buy the argument or not, please do treat yourself with ice cream for being able to make such a comment.
Quoted 6 lines
Quoted 3 lines
Secondly there
were discussion on whyINTEL_SOC_PMICis bool (note this driver also has module based initialization even when bool).Yes, there's copy and paste going on even in kernel development.
There are other examples in the kernel. I just gave the one which is related as well.
Regards
Shobhit
Quoted 4 lines
Quoted 3 lines
I am guessing because
of some tricky module load order dependencies. If ever that becomes a module, this can mostly be unchanged to be loaded as a module.
Quoted 8 lines
You put in a macro, or any other bit of code, when it's needed, not beforehand, "just in case". That's silly.
Thanks,
Paul Bolle
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 6/8] drivers/pwm: Add Crystalcove (CRC) PWM driver
[Added Paul Gortmaker.]
Hi Shobhit,
Quoted 1 line · Shobhit Kumar
So what is the exact big problem with this ?
The main problem I have is that it's hard to read a submitter's mind. And, I think, in cases like this we need to know if the submitter just made some silly mistake or that the mismatch (between Kconfig type and code) was intentional. So each time such a mismatch is spotted the submitter ought to be asked about it.
(I'd guess that one or two new drivers are submitted _each_ day. And these mismatches are quite common. I'd say I receive answers like:
- "Oops, yes bool should have been tristate"; or
- "Oops, forgot to clean up after noticing tristate didn't work"; or
- "I just copy-and-pasted a similar driver, the module stuff isn't actually needed"
at least once a week. Not sure, I don't keep track of this stuff.)
Furthermore, it appears that Paul Gortmaker is on a mission to, badly summarized, untangle the module and init code. See for instance
https://lkml.org/lkml/2015/5/28/809 and
https://lkml.org/lkml/2015/5/31/205 .
Now, I don't know whether (other) Paul is bothered by these MODULE_* macros. But Paul did submit a series that adds builtin_platform_driver(), see https://lkml.org/lkml/2015/5/10/131 . That new macro ensures built-in only code doesn't have to use module_platform_driver(), which your patch also uses. So perhaps Paul can explain some of the non-obvious issues caused by built-in only code using module specific constructs.
Quoted 1 line
I can anyway shove out these macros to end the discussion.
I'd rather convince you than annoy you into doing as I suggested.
Quoted 2 lines
BTW whether you buy the argument or not, please do treat yourself with ice cream for being able to make such a comment.
Will do.
Thanks,
Paul Bolle
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
Re: [Intel-gfx] [PATCH 6/8] drivers/pwm: Add Crystalcove (CRC) PWM driver
Quoted 21 lines · [Re: [Intel-gfx] [PATCH 6/8] drivers/pwm: Add Crystalcove (CRC) PWM driver] On…
[Added Paul Gortmaker.]
Hi Shobhit,
Quoted 1 line · Shobhit Kumar
So what is the exact big problem with this ?
The main problem I have is that it's hard to read a submitter's mind. And, I think, in cases like this we need to know if the submitter just made some silly mistake or that the mismatch (between
Kconfigtype and code) was intentional. So each time such a mismatch is spotted the submitter ought to be asked about it.(I'd guess that one or two new drivers are submitted _each_ day. And these mismatches are quite common. I'd say I receive answers like:
- "Oops, yes bool should have been tristate"; or
- "Oops, forgot to clean up after noticing tristate didn't work"; or
- "I just copy-and-pasted a similar driver, the module stuff isn't actually needed"
at least once a week. Not sure, I don't keep track of this stuff.)
Quoted 7 lines
Furthermore, it appears that Paul Gortmaker is on a mission to, badly summarized, untangle the module and init code. See for instance
https://lkml.org/lkml/2015/5/28/809 and
https://lkml.org/lkml/2015/5/31/205 .Now, I don't know whether (other) Paul is bothered by these MODULE_* macros. But Paul did submit a series that adds
Yes, I agree that it would be nice to not see these mismatches, regardless of whether we can get away with it or not.
Quoted 5 lines
builtin_platform_driver(), see https://lkml.org/lkml/2015/5/10/131 . That new macro ensures built-in only code doesn't have to usemodule_platform_driver(), which your patch also uses. So perhaps Paul can explain some of the non-obvious issues caused by built-in only code using module specific constructs.
In https://lkml.org/lkml/2015/5/10/125 I'd written:
There are several downsides to this:
1) The code can appear modular to a reader of the code, and they won't know if the code really is modular without checking the Makefile and Kconfig to see if compilation is governed by a bool or tristate.
2) Coders of drivers may be tempted to code up an __exit function that is never used, just in order to satisfy the required three args of the modular registration function.
3) Non-modular code ends up including the <module.h> which increases CPP overhead that they don't need.
4) It hinders us from performing better separation of the module init code and the generic init code.
The nature of linux means that thousands of developers are reading the code every day -- so I think that there is a genuine value in having the code convey a clear message on how it was designed to be used. Only using module related headers/macros for genuinely modular code helps us (albeit in a small way) towards achieving that.
Looking at this thread, I see that one of the reasons given for this code's ambiguous module vs. built-in identity was the observation of a similar identity crisis of the related INTEL_SOC_PMIC code. Does that not back up the point above about the value in having the code speak for itself? So IMHO we probably should clarify the PMIC code vs. adding another example that looks just like it.
Paul.
--
Quoted 8 lines
Quoted 2 lines
I can anyway shove out these macros to end the discussion.
I'd rather convince you than annoy you into doing as I suggested.
Quoted 2 lines
BTW whether you buy the argument or not, please do treat yourself with ice cream for being able to make such a comment.
Quoted 7 lines
Will do.
Thanks,
Paul Bolle
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
Re: [Intel-gfx] [PATCH 6/8] drivers/pwm: Add Crystalcove (CRC) PWM driver
Quoted 42 lines · Paul Gortmaker
Quoted 21 lines · [Re: [Intel-gfx] [PATCH 6/8] drivers/pwm: Add Crystalcove (CRC) PWM driver] On…
[Added Paul Gortmaker.]
Hi Shobhit,
Quoted 1 line · Shobhit Kumar
So what is the exact big problem with this ?
The main problem I have is that it's hard to read a submitter's mind. And, I think, in cases like this we need to know if the submitter just made some silly mistake or that the mismatch (between
Kconfigtype and code) was intentional. So each time such a mismatch is spotted the submitter ought to be asked about it.(I'd guess that one or two new drivers are submitted _each_ day. And these mismatches are quite common. I'd say I receive answers like:
- "Oops, yes bool should have been tristate"; or
- "Oops, forgot to clean up after noticing tristate didn't work"; or
- "I just copy-and-pasted a similar driver, the module stuff isn't actually needed"
at least once a week. Not sure, I don't keep track of this stuff.)Quoted 7 lines
Furthermore, it appears that Paul Gortmaker is on a mission to, badly summarized, untangle the module and init code. See for instance
https://lkml.org/lkml/2015/5/28/809 and
https://lkml.org/lkml/2015/5/31/205 .Now, I don't know whether (other) Paul is bothered by these MODULE_* macros. But Paul did submit a series that adds
Yes, I agree that it would be nice to not see these mismatches, regardless of whether we can get away with it or not.
Quoted 5 lines
builtin_platform_driver(), see https://lkml.org/lkml/2015/5/10/131 . That new macro ensures built-in only code doesn't have to usemodule_platform_driver(), which your patch also uses. So perhaps Paul can explain some of the non-obvious issues caused by built-in only code using module specific constructs.In https://lkml.org/lkml/2015/5/10/125 I'd written:
Quoted 13 lines
There are several downsides to this:
1) The code can appear modular to a reader of the code, and they won't know if the code really is modular without checking theMakefileandKconfigto see if compilation is governed by a bool or tristate.
2) Coders of drivers may be tempted to code up an__exitfunction that is never used, just in order to satisfy the required three args of the modular registration function.
3) Non-modular code ends up including the <module.h> which increases CPP overhead that they don't need.
4) It hinders us from performing better separation of the module init code and the generic init code.
Okay. Get the idea and the need in terms of clear separation. Its just that there are quite a few built-in drivers using module initialization that I assumed its okay.
Quoted 6 lines
The nature of linux means that thousands of developers are reading the code every day -- so I think that there is a genuine value in having the code convey a clear message on how it was designed to be used. Only using module related headers/macros for genuinely modular code helps us (albeit in a small way) towards achieving that.
Quoted 7 lines
Looking at this thread, I see that one of the reasons given for this code's ambiguous module vs. built-in identity was the observation of a similar identity crisis of the related
INTEL_SOC_PMICcode. Does that not back up the point above about the value in having the code speak for itself? So IMHO we probably should clarify the PMIC code vs. adding another example that looks just like it.
Okay agree. I think there are quite of them lurking in the sources which would need correction. For this PWM driver I will take care as suggested.
Regards
Shobhit
Quoted 18 lines
Paul.
--Quoted 15 lines
Quoted 2 lines
I can anyway shove out these macros to end the discussion.
I'd rather convince you than annoy you into doing as I suggested.
Quoted 2 lines
BTW whether you buy the argument or not, please do treat yourself with ice cream for being able to make such a comment.
Will do.
Thanks,
Paul Bolle
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx