Skip to contentSkip to conversation

gpio/xilinx: Use correct address when setting initial values.

PATCH Superseded Raphaël Teysseyre 2 participants 2 messages Jun 23, 2015

Subsystems (3)
GPIO Arm/Zynq architecture Xilinx GPIO driver

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Raphaël Teysseyre

author
#0 lore raw

PATCH 1/1 gpio/xilinx: Use correct address when setting initial values.

Quoted 1 line

From 670209328307a198b80723a917957269a815fc32 Mon Sep 17 00:00:00 2001

From: =?UTF-8?q?Rapha=C3=ABl=20Teysseyre?= <[email protected]>
Date: Tue, 23 Jun 2015 14:49:31 +0200
Subject: [PATCH] gpio/xilinx: Use correct address when setting initial values.
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by Rapha?l Teysseyre <[email protected]>
---
 drivers/gpio/gpio-xilinx.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/gpio/gpio-xilinx.c +2 -2
index 61243d1..e544b7a 100644
@@ -220,9 +220,9 @@ static void xgpio_save_regs(struct of_mm_gpio_chip *mm_gc)
 	if (!chip->gpio_width[1])
 		return;
 
-	xgpio_writereg(mm_gc->regs + XGPIO_DATA_OFFSET + XGPIO_TRI_OFFSET,
+	xgpio_writereg(mm_gc->regs + XGPIO_DATA_OFFSET + XGPIO_CHANNEL_OFFSET,
 		       chip->gpio_state[1]);
-	xgpio_writereg(mm_gc->regs + XGPIO_TRI_OFFSET + XGPIO_TRI_OFFSET,
+	xgpio_writereg(mm_gc->regs + XGPIO_TRI_OFFSET + XGPIO_CHANNEL_OFFSET,
 		       chip->gpio_dir[1]);
 }
Signature · 1 line
1.7.1
#1 lore raw
Quoted 7 lines · Rapha?l Teysseyre

From 670209328307a198b80723a917957269a815fc32 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Teysseyre?= <[email protected]>
Date: Tue, 23 Jun 2015 14:49:31 +0200
Subject: [PATCH] gpio/xilinx: Use correct address when setting initial values.
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Mmm this looks like you copy/pasted the output of git format-patch into your email client. Use git send-email instead, or avoid the mail headers if you wish to use another client.

Quoted 2 lines
Signed-off-by Rapha?l Teysseyre <[email protected]>

A commit message beyond the subject would be appreciated. What did you fix exactly? What was incorrect?

Quoted 25 lines
---
 drivers/gpio/gpio-xilinx.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/gpio/gpio-xilinx.c +2 -3
index 61243d1..e544b7a 100644
@@ -220,9 +220,9 @@ static void xgpio_save_regs(struct of_mm_gpio_chip *mm_gc)
        if (!chip->gpio_width[1])
                return;
 
-       xgpio_writereg(mm_gc->regs + XGPIO_DATA_OFFSET + XGPIO_TRI_OFFSET,
+       xgpio_writereg(mm_gc->regs + XGPIO_DATA_OFFSET + XGPIO_CHANNEL_OFFSET,
                       chip->gpio_state[1]);
-       xgpio_writereg(mm_gc->regs + XGPIO_TRI_OFFSET + XGPIO_TRI_OFFSET,
+       xgpio_writereg(mm_gc->regs + XGPIO_TRI_OFFSET + XGPIO_CHANNEL_OFFSET,
                       chip->gpio_dir[1]);
 }
 
--

1.7.1