Skip to contentSkip to conversation

ovl: add O_LARGEFILE flag when copyup files

PATCH RESEND New [email protected] 1 participant 1 message Sep 11, 2015 Overlay filesystem

lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/1 ovl: add O_LARGEFILE flag when copyup files

From: George Wang <[email protected]>

now ovl only use O_RDONLY for lower and O_WRONLY for upper file. But if the file size larger than MAX_NON_LFS(1UL << 31 -1), will suffer -EOVERFLOW. We should add O_LARGEFILE flag to make it work. Following script can reproduct it:

# cd $(mktemp -d)
# mkdir lower upper work root
# truncate -s 3G lower/sparse
# mount -t overlay -o workdir=work,upperdir=upper,lowerdir=lower overlay
work
# truncate -s 0 work/sparse
truncate: cannot open ‘work/sparse’ for writing: Value too large for
defined data type
---
 fs/overlayfs/copy_up.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
fs/overlayfs/copy_up.c +2 -2
index 84d693d..e8ed965 100644
@@ -81,11 +81,11 @@ static int ovl_copy_up_data(struct path *old, struct path *new, loff_t len)
 	if (len == 0)
 		return 0;
 
-	old_file = ovl_path_open(old, O_RDONLY);
+	old_file = ovl_path_open(old, O_RDONLY | O_LARGEFILE);
 	if (IS_ERR(old_file))
 		return PTR_ERR(old_file);
 
-	new_file = ovl_path_open(new, O_WRONLY);
+	new_file = ovl_path_open(new, O_WRONLY | O_LARGEFILE);
 	if (IS_ERR(new_file)) {
 		error = PTR_ERR(new_file);
 		goto out_fput;
Signature · 1 line
1.8.3.1