Skip to contentSkip to conversation

Staging: rtl8712: Use ether_addr_equal() over memcmp()

PATCH Superseded Punit Vara 2 participants 3 messages Oct 12, 2015 – Oct 13, 2015 Staging

lore
Share & tools
lore

Punit Vara

author
#0 lore raw

PATCH v2 2/4 Staging: rtl8712: Use ether_addr_equal() over memcmp()

This patch is to the rtl871x_ioctl_linux.c file that fixes up following warning reported by checkpatch.pl :

-Prefer ether_addr_equal() or ether_addr_equal_unaligned() over memcmp()

bssid and pnetwork->network.MacAddress both are 6 byte array which aligned with u16

Signed-off-by Punit Vara <[email protected]>
---
 drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8712/rtl871x_ioctl_linux.c +1 -1
index 143be0f..b19556a 100644
@@ -2008,7 +2008,7 @@ static int r871x_get_ap_info(struct net_device *dev,
 			return -EINVAL;
 		}
 		netdev_info(dev, "r8712u: BSSID:%pM\n", bssid);
-		if (!memcmp(bssid, pnetwork->network.MacAddress, ETH_ALEN)) {
+		if (ether_addr_equal(bssid, pnetwork->network.MacAddress)) {
 			/* BSSID match, then check if supporting wpa/wpa2 */
 			pbuf = r8712_get_wpa_ie(&pnetwork->network.IEs[12],
 			       &wpa_ielen, pnetwork->network.IELength-12);
Signature · 1 line
2.5.3
author
#1 lore raw
Quoted 27 lines · Punit Vara

This patch is to the rtl871x_ioctl_linux.c file that fixes up following warning reported by checkpatch.pl :

-Prefer ether_addr_equal() or ether_addr_equal_unaligned() over memcmp()

bssid and pnetwork->network.MacAddress both are 6 byte array which aligned with u16

Signed-off-by Punit Vara <[email protected]>
---
 drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8712/rtl871x_ioctl_linux.c +1 -2
index 143be0f..b19556a 100644
@@ -2008,7 +2008,7 @@ static int r871x_get_ap_info(struct net_device *dev,
                        return -EINVAL;
                }
                netdev_info(dev, "r8712u: BSSID:%pM\n", bssid);
-               if (!memcmp(bssid, pnetwork->network.MacAddress, ETH_ALEN)) {
+               if (ether_addr_equal(bssid, pnetwork->network.MacAddress)) {
                        /* BSSID match, then check if supporting wpa/wpa2 */
                        pbuf = r8712_get_wpa_ie(&pnetwork->network.IEs[12],
                               &wpa_ielen, pnetwork->network.IELength-12);
--
Quoted 2 lines

2.5.3

I have updated the patch as per feedback from various developers. As I am sending second time subject should be patch v2 right ?

maintainer
#2 lore raw
Quoted 25 lines · punit vara
Quoted 24 lines · Punit Vara

This patch is to the rtl871x_ioctl_linux.c file that fixes up following warning reported by checkpatch.pl :

-Prefer ether_addr_equal() or ether_addr_equal_unaligned() over memcmp()

bssid and pnetwork->network.MacAddress both are 6 byte array which aligned with u16

Signed-off-by Punit Vara <[email protected]>
---
 drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8712/rtl871x_ioctl_linux.c +1 -1
index 143be0f..b19556a 100644
@@ -2008,7 +2008,7 @@ static int r871x_get_ap_info(struct net_device *dev,
                        return -EINVAL;
                }
                netdev_info(dev, "r8712u: BSSID:%pM\n", bssid);
-               if (!memcmp(bssid, pnetwork->network.MacAddress, ETH_ALEN)) {
+               if (ether_addr_equal(bssid, pnetwork->network.MacAddress)) {
                        /* BSSID match, then check if supporting wpa/wpa2 */
Quoted 8 lines
Quoted 5 lines
drivers/staging/rtl8712/rtl871x_ioctl_linux.c +0 -1
                        pbuf = r8712_get_wpa_ie(&pnetwork->network.IEs[12],
                               &wpa_ielen, pnetwork->network.IELength-12);
--

2.5.3

I have updated the patch as per feedback from various developers. As I am sending second time subject should be patch v2 right ?

Please resend the whole series please.