Skip to contentSkip to conversation

ALSA: compress: Add SND_AUDIOCODEC_BESPOKE

RFC PATCH Superseded Charles Keepax 5 participants 9 messages Oct 20, 2015 – Nov 5, 2015

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

RFC PATCH 1/1 ALSA: compress: Add SND_AUDIOCODEC_BESPOKE

When working with the compressed framework occasionally vendors will use esoteric internal audio formats. For such formats it doesn't really make sense to add an new define to the kernel as their use is not sufficiently general.

This patch adds a new define SND_AUDIOCODEC_BESPOKE that vendors can use in such situations.

---
 include/uapi/sound/compress_params.h |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
include/uapi/sound/compress_params.h +2 -1
index d9bd9ca..e284380 100644
@@ -73,7 +73,8 @@
 #define SND_AUDIOCODEC_IEC61937              ((__u32) 0x0000000B)
 #define SND_AUDIOCODEC_G723_1                ((__u32) 0x0000000C)
 #define SND_AUDIOCODEC_G729                  ((__u32) 0x0000000D)
-#define SND_AUDIOCODEC_MAX                   SND_AUDIOCODEC_G729
+#define SND_AUDIOCODEC_BESPOKE               ((__u32) 0x0000000E)
+#define SND_AUDIOCODEC_MAX                   SND_AUDIOCODEC_BESPOKE
 
 /*
  * Profile and modes are listed with bit masks. This allows for a
Signature · 1 line
1.7.2.5
#1 lore raw
Quoted 18 lines · Charles Keepax

When working with the compressed framework occasionally vendors will use esoteric internal audio formats. For such formats it doesn't really make sense to add an new define to the kernel as their use is not sufficiently general.

This patch adds a new define SND_AUDIOCODEC_BESPOKE that vendors can use in such situations.

---
  include/uapi/sound/compress_params.h |    3 ++-
  1 files changed, 2 insertions(+), 1 deletions(-)
include/uapi/sound/compress_params.h +0 -0
index d9bd9ca..e284380 100644

include/uapi/sound/compress_params.h line 76

Quoted 5 lines
include/uapi/sound/compress_params.h +1 -1
@@ -73,7 +73,8 @@
  #define SND_AUDIOCODEC_IEC61937              ((__u32) 0x0000000B)
  #define SND_AUDIOCODEC_G723_1                ((__u32) 0x0000000C)
  #define SND_AUDIOCODEC_G729                  ((__u32) 0x0000000D)
-#define SND_AUDIOCODEC_MAX                   SND_AUDIOCODEC_G729
+#define SND_AUDIOCODEC_BESPOKE               ((__u32) 0x0000000E)

No real objections from me, this is better than overloading PCM for this purpose...
Since this is clearly an escape mechanism for a non-standard codec, maybe we should use an ID that's not in sequence, eg 0x00001000.
If you need to set parameters maybe we should also change the definition of snd_enc_generic so that the reserved fields can be used for custom parameters, or document that their use is permitted for this sort of ID.

Quoted 5 lines
include/uapi/sound/compress_params.h +1 -0
+#define SND_AUDIOCODEC_MAX                   SND_AUDIOCODEC_BESPOKE
 
  /*
   * Profile and modes are listed with bit masks. This allows for a
#2 lore raw
Quoted 2 lines · Pierre-Louis Bossart

Since this is clearly an escape mechanism for a non-standard codec, maybe we should use an ID that's not in sequence, eg 0x00001000.

0xDEADBEEF. Also the bikeshed should be purple :)

Quoted 3 lines

If you need to set parameters maybe we should also change the definition of snd_enc_generic so that the reserved fields can be used for custom parameters, or document that their use is permitted for this sort of ID.

It does mean the core can't grab them but quite what the core is supposed to usefully do for something like this is unclear to me so...

#3 lore raw

Re: [RFC PATCH] ALSA: compress: Add SND_AUDIOCODEC_BESPOKE'

Quoted 8 lines · Mark Brown
Quoted 3 lines · Pierre-Louis Bossart

If you need to set parameters maybe we should also change the definition of snd_enc_generic so that the reserved fields can be used for custom parameters, or document that their use is permitted for this sort of ID.

It does mean the core can't grab them but quite what the core is supposed to usefully do for something like this is unclear to me so...

Well in case of compressed formats, core doesn't do anything, we just act as a transport and shove down data and information.

I do like Pierre's idea of giving some meaning to formats and use some reserved fields, but somehow I can't think of a clean solution for this!

Signature · 1 line
~Vinod
#4 lore raw

Re: [RFC PATCH] ALSA: compress: Add SND_AUDIOCODEC_BESPOKE'

Quoted 7 lines · Vinod Koul
Quoted 6 lines · Mark Brown
Quoted 3 lines · Pierre-Louis Bossart

If you need to set parameters maybe we should also change the definition of snd_enc_generic so that the reserved fields can be used for custom parameters, or document that their use is permitted for this sort of ID.

Quoted 8 lines
Quoted 2 lines

It does mean the core can't grab them but quite what the core is supposed to usefully do for something like this is unclear to me so...

Well in case of compressed formats, core doesn't do anything, we just act as a transport and shove down data and information.

I do like Pierre's idea of giving some meaning to formats and use some reserved fields, but somehow I can't think of a clean solution for this!

Personally, I feel a bit like doing nothing at the moment might be the best solution. If BESPOKE is for icky stuff that won't be generic trying to pull out generic fields to go in snd_enc_generic seems like a challenging exercise, and we can look submissions that use it and keep an eye out for anything that might be generic enough to go in there, rather than adding a bunch of stuff that ends up never getting used.

Thanks,
Charles

#5 lore raw

Re: [RFC PATCH] ALSA: compress: Add SND_AUDIOCODEC_BESPOKE'

Quoted 17 lines · Charles Keepax
Quoted 7 lines · Vinod Koul
Quoted 6 lines · Mark Brown
Quoted 3 lines · Pierre-Louis Bossart

If you need to set parameters maybe we should also change the definition of snd_enc_generic so that the reserved fields can be used for custom parameters, or document that their use is permitted for this sort of ID.

Quoted 8 lines
Quoted 2 lines

It does mean the core can't grab them but quite what the core is supposed to usefully do for something like this is unclear to me so...

Well in case of compressed formats, core doesn't do anything, we just act as a transport and shove down data and information.

I do like Pierre's idea of giving some meaning to formats and use some reserved fields, but somehow I can't think of a clean solution for this!

Quoted 7 lines

Personally, I feel a bit like doing nothing at the moment might be the best solution. If BESPOKE is for icky stuff that won't be generic trying to pull out generic fields to go in snd_enc_generic seems like a challenging exercise, and we can look submissions that use it and keep an eye out for anything that might be generic enough to go in there, rather than adding a bunch of stuff that ends up never getting used.

I was only suggesting to redefine these fields from 'reserved' to 'use for whatever parameters are needed for this BESPOKE codec type'. I wasn't trying to come-up with generic fields or predict future usages of non-standard codecs, that would be a waste of time indeed.

#6 lore raw

Re: [RFC PATCH] ALSA: compress: Add SND_AUDIOCODEC_BESPOKE'

In reply to Charles Keepax
Quoted 17 lines · Charles Keepax
Quoted 7 lines · Vinod Koul
Quoted 6 lines · Mark Brown
Quoted 3 lines · Pierre-Louis Bossart

If you need to set parameters maybe we should also change the definition of snd_enc_generic so that the reserved fields can be used for custom parameters, or document that their use is permitted for this sort of ID.

Quoted 8 lines
Quoted 2 lines

It does mean the core can't grab them but quite what the core is supposed to usefully do for something like this is unclear to me so...

Well in case of compressed formats, core doesn't do anything, we just act as a transport and shove down data and information.

I do like Pierre's idea of giving some meaning to formats and use some reserved fields, but somehow I can't think of a clean solution for this!

Quoted 7 lines

Personally, I feel a bit like doing nothing at the moment might be the best solution. If BESPOKE is for icky stuff that won't be generic trying to pull out generic fields to go in snd_enc_generic seems like a challenging exercise, and we can look submissions that use it and keep an eye out for anything that might be generic enough to go in there, rather than adding a bunch of stuff that ends up never getting used.

So what is the conclusion here..? Are we all okay with this approach?

Signature · 1 line
~Vinod
#7 lore raw

Re: [RFC PATCH] ALSA: compress: Add SND_AUDIOCODEC_BESPOKE'

Quoted 26 lines · Vinod Koul
Quoted 17 lines · Charles Keepax
Quoted 7 lines · Vinod Koul
Quoted 6 lines · Mark Brown
Quoted 3 lines · Pierre-Louis Bossart

If you need to set parameters maybe we should also change the definition of snd_enc_generic so that the reserved fields can be used for custom parameters, or document that their use is permitted for this sort of ID.

Quoted 8 lines
Quoted 2 lines

It does mean the core can't grab them but quite what the core is supposed to usefully do for something like this is unclear to me so...

Well in case of compressed formats, core doesn't do anything, we just act as a transport and shove down data and information.

I do like Pierre's idea of giving some meaning to formats and use some reserved fields, but somehow I can't think of a clean solution for this!

Quoted 7 lines

Personally, I feel a bit like doing nothing at the moment might be the best solution. If BESPOKE is for icky stuff that won't be generic trying to pull out generic fields to go in snd_enc_generic seems like a challenging exercise, and we can look submissions that use it and keep an eye out for anything that might be generic enough to go in there, rather than adding a bunch of stuff that ends up never getting used.

Quoted 1 line

So what is the conclusion here..? Are we all okay with this approach?

I was planning to send out a v2 shortly, just adding a comment by the reserved fields in snd_enc_generic to say its ok to use them if using BESPOKE and see where that gets us.

Thanks,
Charles

#8 lore raw
In reply to Mark Brown
Quoted 7 lines · Mark Brown
Quoted 2 lines · Pierre-Louis Bossart

Since this is clearly an escape mechanism for a non-standard codec, maybe we should use an ID that's not in sequence, eg 0x00001000.

0xDEADBEEF. Also the bikeshed should be purple :)

Oh, let's make it more brilliant like gold over shocking pink :)

Usually the number like 0x1000 makes sense only when the lower bits are used for relevant purpose, e.g. as a sub-type definition for BESPOKE. So, type_is_bespoke() won't be "type == 0x1000" but "type & 0x1000".

Takashi