Skip to contentSkip to conversation

vhost-user: ignore qemu-only features

PATCH New Michael S. Tsirkin 1 participant 1 message Nov 18, 2015

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 vhost-user: ignore qemu-only features

Some feratures (such as ctrl vq) are supported
by qemu without need to communicate with the
backend.

Drop them from the feature mask so we set them
unconditionally.

---

Changes since v1:
re-add VIRTIO_NET_F_GUEST_ANNOUNCE, add a comment explaining why it's needed.

 hw/net/vhost_net.c | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)
hw/net/vhost_net.c +1 -7
index 14337a4..318c3e6 100644
@@ -77,14 +77,8 @@ static const int user_feature_bits[] = {
     VIRTIO_NET_F_HOST_ECN,
     VIRTIO_NET_F_HOST_UFO,
     VIRTIO_NET_F_MRG_RXBUF,
-    VIRTIO_NET_F_STATUS,
-    VIRTIO_NET_F_CTRL_VQ,
-    VIRTIO_NET_F_CTRL_RX,
-    VIRTIO_NET_F_CTRL_VLAN,
-    VIRTIO_NET_F_CTRL_RX_EXTRA,
-    VIRTIO_NET_F_CTRL_MAC_ADDR,
-    VIRTIO_NET_F_CTRL_GUEST_OFFLOADS,
 
+    /* This bit implies RARP isn't sent by QEMU out of band */
     VIRTIO_NET_F_GUEST_ANNOUNCE,
 
     VIRTIO_NET_F_MQ,
Signature · 1 line
MST