vhost-user: ignore qemu-only features
PATCH 1/1 vhost-user: ignore qemu-only features
Some feratures (such as ctrl vq) are supported
by qemu without need to communicate with the
backend.
Drop them from the feature mask so we set them
unconditionally.
Reported-by Victor Kaplansky <[email protected]>
Signed-off-by Michael S. Tsirkin <[email protected]>
--- hw/net/vhost_net.c | 9 --------- 1 file changed, 9 deletions(-)
hw/net/vhost_net.c +0 -9
@@ -77,15 +77,6 @@ static const int user_feature_bits[] = {VIRTIO_NET_F_HOST_ECN ,VIRTIO_NET_F_HOST_UFO ,VIRTIO_NET_F_MRG_RXBUF , -VIRTIO_NET_F_STATUS , -VIRTIO_NET_F_CTRL_VQ , -VIRTIO_NET_F_CTRL_RX , -VIRTIO_NET_F_CTRL_VLAN , -VIRTIO_NET_F_CTRL_RX_EXTRA , -VIRTIO_NET_F_CTRL_MAC_ADDR , -VIRTIO_NET_F_CTRL_GUEST_OFFLOADS , - -VIRTIO_NET_F_GUEST_ANNOUNCE , VIRTIO_NET_F_MQ,
Signature · 1 line
MST
Quoted 23 lines · Michael S. Tsirkin
Some feratures (such as ctrl vq) are supported
by qemu without need to communicate with the
backend.Drop them from the feature mask so we set them
unconditionally.Reported-by Victor Kaplansky <[email protected]>Signed-off-by Michael S. Tsirkin <[email protected]>--- hw/net/vhost_net.c | 9 --------- 1 file changed, 9 deletions(-)hw/net/vhost_net.c +0
-2@@ -77,15 +77,6 @@ static const int user_feature_bits[] = {VIRTIO_NET_F_HOST_ECN ,VIRTIO_NET_F_HOST_UFO , VIRTIO_NET_F_MRG_RXBUF, -VIRTIO_NET_F_STATUS , - VIRTIO_NET_F_CTRL_VQ,
hw/net/vhost_net.c static const int user_feature_bits[] = { · line 82
Quoted 10 lines
hw/net/vhost_net.c +0
-7-VIRTIO_NET_F_CTRL_RX , -VIRTIO_NET_F_CTRL_VLAN , -VIRTIO_NET_F_CTRL_RX_EXTRA , -VIRTIO_NET_F_CTRL_MAC_ADDR , -VIRTIO_NET_F_CTRL_GUEST_OFFLOADS , - -VIRTIO_NET_F_GUEST_ANNOUNCE , VIRTIO_NET_F_MQ,
Acked-by Jason Wang <[email protected]>
Quoted 33 lines · Jason Wang
Quoted 31 lines · Michael S. Tsirkin
Some feratures (such as ctrl vq) are supported
by qemu without need to communicate with the
backend.Drop them from the feature mask so we set them
unconditionally.Reported-by Victor Kaplansky <[email protected]>Signed-off-by Michael S. Tsirkin <[email protected]>--- hw/net/vhost_net.c | 9 --------- 1 file changed, 9 deletions(-)hw/net/vhost_net.c +0
-9@@ -77,15 +77,6 @@ static const int user_feature_bits[] = {VIRTIO_NET_F_HOST_ECN ,VIRTIO_NET_F_HOST_UFO , VIRTIO_NET_F_MRG_RXBUF, -VIRTIO_NET_F_STATUS , -VIRTIO_NET_F_CTRL_VQ , -VIRTIO_NET_F_CTRL_RX , -VIRTIO_NET_F_CTRL_VLAN , -VIRTIO_NET_F_CTRL_RX_EXTRA , -VIRTIO_NET_F_CTRL_MAC_ADDR , -VIRTIO_NET_F_CTRL_GUEST_OFFLOADS , - - VIRTIO_NET_F_GUEST_ANNOUNCE,
Quoted 3 lines
hw/net/vhost_net.c static const int user_feature_bits[] = { · line 82
Quoted 2 lines
hw/net/vhost_net.c +0
-0VIRTIO_NET_F_MQ,Acked-by Jason Wang <[email protected]>
How about VIRTIO_NET_F_GUEST_* ?