Skip to contentSkip to conversation

vhost-user: ignore qemu-only features

PATCH Superseded Michael S. Tsirkin 2 participants 3 messages Nov 17, 2015 – Nov 18, 2015

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 vhost-user: ignore qemu-only features

Some feratures (such as ctrl vq) are supported
by qemu without need to communicate with the
backend.

Drop them from the feature mask so we set them
unconditionally.

---
 hw/net/vhost_net.c | 9 ---------
 1 file changed, 9 deletions(-)
hw/net/vhost_net.c +0 -9
index 14337a4..8c9b52d 100644
@@ -77,15 +77,6 @@ static const int user_feature_bits[] = {
     VIRTIO_NET_F_HOST_ECN,
     VIRTIO_NET_F_HOST_UFO,
     VIRTIO_NET_F_MRG_RXBUF,
-    VIRTIO_NET_F_STATUS,
-    VIRTIO_NET_F_CTRL_VQ,
-    VIRTIO_NET_F_CTRL_RX,
-    VIRTIO_NET_F_CTRL_VLAN,
-    VIRTIO_NET_F_CTRL_RX_EXTRA,
-    VIRTIO_NET_F_CTRL_MAC_ADDR,
-    VIRTIO_NET_F_CTRL_GUEST_OFFLOADS,
-
-    VIRTIO_NET_F_GUEST_ANNOUNCE,
 
     VIRTIO_NET_F_MQ,
 
Signature · 1 line
MST
Acked-by on v1 1/1
#1 lore raw
Quoted 23 lines · Michael S. Tsirkin

Some feratures (such as ctrl vq) are supported
by qemu without need to communicate with the
backend.

Drop them from the feature mask so we set them
unconditionally.

---
 hw/net/vhost_net.c | 9 ---------
 1 file changed, 9 deletions(-)
hw/net/vhost_net.c +0 -2
index 14337a4..8c9b52d 100644
@@ -77,15 +77,6 @@ static const int user_feature_bits[] = {
     VIRTIO_NET_F_HOST_ECN,
     VIRTIO_NET_F_HOST_UFO,
     VIRTIO_NET_F_MRG_RXBUF,
-    VIRTIO_NET_F_STATUS,
-    VIRTIO_NET_F_CTRL_VQ,

hw/net/vhost_net.c static const int user_feature_bits[] = { · line 82

Quoted 10 lines
hw/net/vhost_net.c +0 -7
-    VIRTIO_NET_F_CTRL_RX,
-    VIRTIO_NET_F_CTRL_VLAN,
-    VIRTIO_NET_F_CTRL_RX_EXTRA,
-    VIRTIO_NET_F_CTRL_MAC_ADDR,
-    VIRTIO_NET_F_CTRL_GUEST_OFFLOADS,
-
-    VIRTIO_NET_F_GUEST_ANNOUNCE,
 
     VIRTIO_NET_F_MQ,
 
#2 lore raw
Quoted 33 lines · Jason Wang
Quoted 31 lines · Michael S. Tsirkin

Some feratures (such as ctrl vq) are supported
by qemu without need to communicate with the
backend.

Drop them from the feature mask so we set them
unconditionally.

---
 hw/net/vhost_net.c | 9 ---------
 1 file changed, 9 deletions(-)
hw/net/vhost_net.c +0 -9
index 14337a4..8c9b52d 100644
@@ -77,15 +77,6 @@ static const int user_feature_bits[] = {
     VIRTIO_NET_F_HOST_ECN,
     VIRTIO_NET_F_HOST_UFO,
     VIRTIO_NET_F_MRG_RXBUF,
-    VIRTIO_NET_F_STATUS,
-    VIRTIO_NET_F_CTRL_VQ,
-    VIRTIO_NET_F_CTRL_RX,
-    VIRTIO_NET_F_CTRL_VLAN,
-    VIRTIO_NET_F_CTRL_RX_EXTRA,
-    VIRTIO_NET_F_CTRL_MAC_ADDR,
-    VIRTIO_NET_F_CTRL_GUEST_OFFLOADS,
-
-    VIRTIO_NET_F_GUEST_ANNOUNCE,
 
Quoted 3 lines

hw/net/vhost_net.c static const int user_feature_bits[] = { · line 82

Quoted 2 lines
hw/net/vhost_net.c +0 -0
     VIRTIO_NET_F_MQ,
 

How about VIRTIO_NET_F_GUEST_* ?