Skip to contentSkip to conversation

conf: topology: Add the conf for SKL-rt286

PATCH Superseded Vinod Koul 3 participants 11 messages Apr 5, 2016 – Apr 6, 2016

v2 of 4 Superseded Latest is v4 →

lore
Share & tools
lore

Vinod Koul

author
#0 lore raw

v2 cover conf: topology: Add the conf for SKL-rt286

From: Shreyas NC <[email protected]>

The SKL RT286 I2S topology conf is provided here. The first patch adds that along with binary data for modules.

The Second patch provides source of those binayy blobs and allows them to be recompiled.

Shreyas NC (2):
conf: topology: Add Skylake i2s conf
conf: topology: Generate Private data binary blobs

 configure.ac                                       |    1 +
 src/conf/topology/Makefile.am                      |    2 +-
 src/conf/topology/sklrt286/Makefile.am             |    4 +
 src/conf/topology/sklrt286/codec0_in-cpr-1.bin     |  Bin 0 -> 4268 bytes
 src/conf/topology/sklrt286/codec0_in-mi.bin        |  Bin 0 -> 4268 bytes
 src/conf/topology/sklrt286/codec0_out-cpr-4.bin    |  Bin 0 -> 4268 bytes
 src/conf/topology/sklrt286/codec0_out-mo.bin       |  Bin 0 -> 4268 bytes
 src/conf/topology/sklrt286/codec1_out-cpr-5.bin    |  Bin 0 -> 4268 bytes
 src/conf/topology/sklrt286/codec1_out-mo.bin       |  Bin 0 -> 4268 bytes
 src/conf/topology/sklrt286/data/Makefile.am        |    4 +
 src/conf/topology/sklrt286/data/README             |    2 +
 src/conf/topology/sklrt286/data/compile_local      |   16 +
 src/conf/topology/sklrt286/data/configure.ac       |   30 +
 src/conf/topology/sklrt286/data/pvt.c              | 1815 ++++++++++++++++++++
 src/conf/topology/sklrt286/data/pvt_data.c         |   90 +
 src/conf/topology/sklrt286/data/pvt_data_local.h   |  115 ++
 .../topology/sklrt286/dmic01_hifi_in-cpr-3.bin     |  Bin 0 -> 4268 bytes
 src/conf/topology/sklrt286/dmic01_hifi_in-mi.bin   |  Bin 0 -> 4268 bytes
 src/conf/topology/sklrt286/hdmi1_pt_out-cpr-7.bin  |  Bin 0 -> 4268 bytes
 src/conf/topology/sklrt286/hdmi1_pt_out-cpr-8.bin  |  Bin 0 -> 4268 bytes
 src/conf/topology/sklrt286/hdmi2_pt_out-cpr-10.bin |  Bin 0 -> 4268 bytes
 src/conf/topology/sklrt286/hdmi2_pt_out-cpr-9.bin  |  Bin 0 -> 4268 bytes
 src/conf/topology/sklrt286/hdmi3_pt_out-cpr-11.bin |  Bin 0 -> 4268 bytes
 src/conf/topology/sklrt286/hdmi3_pt_out-cpr-12.bin |  Bin 0 -> 4268 bytes
 src/conf/topology/sklrt286/media0_in-cpr-0.bin     |  Bin 0 -> 4268 bytes
 src/conf/topology/sklrt286/media0_in-mi.bin        |  Bin 0 -> 4268 bytes
 src/conf/topology/sklrt286/media0_out-cpr-6.bin    |  Bin 0 -> 4268 bytes
 src/conf/topology/sklrt286/media0_out-mo.bin       |  Bin 0 -> 4268 bytes
 src/conf/topology/sklrt286/skl_i2s.conf            |  342 ++++
 29 files changed, 2420 insertions(+), 1 deletion(-)
 create mode 100644 src/conf/topology/sklrt286/Makefile.am
 create mode 100644 src/conf/topology/sklrt286/codec0_in-cpr-1.bin
 create mode 100644 src/conf/topology/sklrt286/codec0_in-mi.bin
 create mode 100644 src/conf/topology/sklrt286/codec0_out-cpr-4.bin
 create mode 100644 src/conf/topology/sklrt286/codec0_out-mo.bin
 create mode 100644 src/conf/topology/sklrt286/codec1_out-cpr-5.bin
 create mode 100644 src/conf/topology/sklrt286/codec1_out-mo.bin
 create mode 100644 src/conf/topology/sklrt286/data/Makefile.am
 create mode 100644 src/conf/topology/sklrt286/data/README
 create mode 100755 src/conf/topology/sklrt286/data/compile_local
 create mode 100644 src/conf/topology/sklrt286/data/configure.ac
 create mode 100644 src/conf/topology/sklrt286/data/pvt.c
 create mode 100644 src/conf/topology/sklrt286/data/pvt_data.c
 create mode 100644 src/conf/topology/sklrt286/data/pvt_data_local.h
 create mode 100644 src/conf/topology/sklrt286/dmic01_hifi_in-cpr-3.bin
 create mode 100644 src/conf/topology/sklrt286/dmic01_hifi_in-mi.bin
 create mode 100644 src/conf/topology/sklrt286/hdmi1_pt_out-cpr-7.bin
 create mode 100644 src/conf/topology/sklrt286/hdmi1_pt_out-cpr-8.bin
 create mode 100644 src/conf/topology/sklrt286/hdmi2_pt_out-cpr-10.bin
 create mode 100644 src/conf/topology/sklrt286/hdmi2_pt_out-cpr-9.bin
 create mode 100644 src/conf/topology/sklrt286/hdmi3_pt_out-cpr-11.bin
 create mode 100644 src/conf/topology/sklrt286/hdmi3_pt_out-cpr-12.bin
 create mode 100644 src/conf/topology/sklrt286/media0_in-cpr-0.bin
 create mode 100644 src/conf/topology/sklrt286/media0_in-mi.bin
 create mode 100644 src/conf/topology/sklrt286/media0_out-cpr-6.bin
 create mode 100644 src/conf/topology/sklrt286/media0_out-mo.bin
 create mode 100644 src/conf/topology/sklrt286/skl_i2s.conf
Signature · 1 line
2.4.11
author
#1 lore raw

PATCH v2 2/2 conf: topology: Generate Private data binary blobs

From: Shreyas NC <[email protected]>

The DSP modules need private data and that is provided as binary blob. These blobs are compiled from C structures which specify module configuration.

---
 src/conf/topology/sklrt286/data/Makefile.am      |    4 +
 src/conf/topology/sklrt286/data/README           |    2 +
 src/conf/topology/sklrt286/data/compile_local    |   16 +
 src/conf/topology/sklrt286/data/configure.ac     |   30 +
 src/conf/topology/sklrt286/data/pvt.c            | 1815 ++++++++++++++++++++++
 src/conf/topology/sklrt286/data/pvt_data.c       |   90 ++
 src/conf/topology/sklrt286/data/pvt_data_local.h |  115 ++
 7 files changed, 2072 insertions(+)
 create mode 100644 src/conf/topology/sklrt286/data/Makefile.am
 create mode 100644 src/conf/topology/sklrt286/data/README
 create mode 100755 src/conf/topology/sklrt286/data/compile_local
 create mode 100644 src/conf/topology/sklrt286/data/configure.ac
 create mode 100644 src/conf/topology/sklrt286/data/pvt.c
 create mode 100644 src/conf/topology/sklrt286/data/pvt_data.c
 create mode 100644 src/conf/topology/sklrt286/data/pvt_data_local.h
src/conf/topology/sklrt286/data/Makefile.am new file +4 -0
new file mode 100644
index 000000000000..9898b9808055
@@ -0,0 +1,4 @@
+bin_PROGRAMS = pvt_data
+pvt_data_SOURCES = pvt_data.c
+AM_CPPFLAGS = \
+         -Wall -I../../../../../include
src/conf/topology/sklrt286/data/README new file +2 -0
new file mode 100644
index 000000000000..7d1261069dae
@@ -0,0 +1,2 @@
+To compile the src file, run ./compile_local and then ./pvt_data to execute the binary.
+The private data blobs will be generated in the sklrt286 folder.
src/conf/topology/sklrt286/data/compile_local new file +16 -0
new file mode 100755
index 000000000000..4b935f8b760d
@@ -0,0 +1,16 @@
+#Helper script to compile
+touch ltconfig NEWS README AUTHORS ChangeLog
+libtoolize --force --copy --automake
+aclocal $ACLOCAL_FLAGS
+autoheader
+automake --foreign --copy --add-missing
+touch depcomp		# seems to be missing for old automake
+autoconf
+export CFLAGS='-O2 -Wall -W -pipe -g'
+echo "CFLAGS=$CFLAGS"
+echo "./configure $args"
+./configure $args || exit 1
+unset CFLAGS
+if [ -z "$GITCOMPILE_NO_MAKE" ]; then
+  make
+fi
src/conf/topology/sklrt286/data/configure.ac new file +30 -0
new file mode 100644
index 000000000000..72c9021edeaf
@@ -0,0 +1,30 @@
+#                                               -*- Autoconf -*-
+# Process this file with autoconf to produce a configure script.
+
+AC_PREREQ([2.69])
+AC_INIT(pvt_data, [VERSION], [BUG-REPORT-ADDRESS])
+AM_INIT_AUTOMAKE(pvt_data, 2.6)
+AC_CONFIG_SRCDIR([pvt_data.c])
+AC_CONFIG_HEADERS([])
+
+# Checks for programs.
+AC_PROG_CC
+
+# Checks for libraries.
+
+# Checks for header files.
+AC_CHECK_HEADERS([limits.h stdint.h])
+
+# Checks for typedefs, structures, and compiler characteristics.
+AC_TYPE_INT16_T
+AC_TYPE_INT32_T
+AC_TYPE_INT8_T
+AC_TYPE_UINT16_T
+AC_TYPE_UINT32_T
+AC_TYPE_UINT8_T
+
+# Checks for library functions.
+AC_CHECK_FUNCS([memset strchr])
+AC_CONFIG_FILES([Makefile])
+
+AC_OUTPUT
src/conf/topology/sklrt286/data/pvt.c new file +1815 -0

1,815 lines not on this page · raw message

src/conf/topology/sklrt286/data/pvt_data.c new file +90 -0

90 lines not on this page · raw message

src/conf/topology/sklrt286/data/pvt_data_local.h new file +115 -0

115 lines not on this page · raw message

Signature · 1 line
2.4.11
#2 lore raw

Re: [PATCH v2 2/2] conf: topology: Generate Private data binary blobs

Quoted 32 lines · Vinod Koul

From: Shreyas NC <[email protected]>

The DSP modules need private data and that is provided as binary blob. These blobs are compiled from C structures which specify module configuration.

---
 src/conf/topology/sklrt286/data/Makefile.am      |    4 +
 src/conf/topology/sklrt286/data/README           |    2 +
 src/conf/topology/sklrt286/data/compile_local    |   16 +
 src/conf/topology/sklrt286/data/configure.ac     |   30 +
 src/conf/topology/sklrt286/data/pvt.c            | 1815 ++++++++++++++++++++++
 src/conf/topology/sklrt286/data/pvt_data.c       |   90 ++
 src/conf/topology/sklrt286/data/pvt_data_local.h |  115 ++
 7 files changed, 2072 insertions(+)
 create mode 100644 src/conf/topology/sklrt286/data/Makefile.am
 create mode 100644 src/conf/topology/sklrt286/data/README
 create mode 100755 src/conf/topology/sklrt286/data/compile_local
 create mode 100644 src/conf/topology/sklrt286/data/configure.ac
 create mode 100644 src/conf/topology/sklrt286/data/pvt.c
 create mode 100644 src/conf/topology/sklrt286/data/pvt_data.c
 create mode 100644 src/conf/topology/sklrt286/data/pvt_data_local.h
src/conf/topology/sklrt286/data/Makefile.am new file +0 -0
new file mode 100644
index 000000000000..9898b9808055

src/conf/topology/sklrt286/data/Makefile.am line 4

Quoted 4 lines
src/conf/topology/sklrt286/data/Makefile.am new file +4 -0
@@ -0,0 +1,4 @@
+bin_PROGRAMS = pvt_data
+pvt_data_SOURCES = pvt_data.c
+AM_CPPFLAGS = \
+         -Wall -I../../../../../include

What is this path?

Quoted 56 lines
src/conf/topology/sklrt286/data/README new file +2 -0
new file mode 100644
index 000000000000..7d1261069dae
@@ -0,0 +1,2 @@
+To compile the src file, run ./compile_local and then ./pvt_data to execute the binary.
+The private data blobs will be generated in the sklrt286 folder.
src/conf/topology/sklrt286/data/compile_local new file +16 -0
new file mode 100755
index 000000000000..4b935f8b760d
@@ -0,0 +1,16 @@
+#Helper script to compile
+touch ltconfig NEWS README AUTHORS ChangeLog
+libtoolize --force --copy --automake
+aclocal $ACLOCAL_FLAGS
+autoheader
+automake --foreign --copy --add-missing
+touch depcomp		# seems to be missing for old automake
+autoconf
+export CFLAGS='-O2 -Wall -W -pipe -g'
+echo "CFLAGS=$CFLAGS"
+echo "./configure $args"
+./configure $args || exit 1
+unset CFLAGS
+if [ -z "$GITCOMPILE_NO_MAKE" ]; then
+  make
+fi
src/conf/topology/sklrt286/data/configure.ac new file +20 -0
new file mode 100644
index 000000000000..72c9021edeaf
@@ -0,0 +1,30 @@
+#                                               -*- Autoconf -*-
+# Process this file with autoconf to produce a configure script.
+
+AC_PREREQ([2.69])
+AC_INIT(pvt_data, [VERSION], [BUG-REPORT-ADDRESS])
+AM_INIT_AUTOMAKE(pvt_data, 2.6)
+AC_CONFIG_SRCDIR([pvt_data.c])
+AC_CONFIG_HEADERS([])
+
+# Checks for programs.
+AC_PROG_CC
+
+# Checks for libraries.
+
+# Checks for header files.
+AC_CHECK_HEADERS([limits.h stdint.h])
+
+# Checks for typedefs, structures, and compiler characteristics.
+AC_TYPE_INT16_T
+AC_TYPE_INT32_T

src/conf/topology/sklrt286/data/configure.ac line 30

Quoted 10 lines
src/conf/topology/sklrt286/data/configure.ac new file +10 -0
+AC_TYPE_INT8_T
+AC_TYPE_UINT16_T
+AC_TYPE_UINT32_T
+AC_TYPE_UINT8_T
+
+# Checks for library functions.
+AC_CHECK_FUNCS([memset strchr])
+AC_CONFIG_FILES([Makefile])
+
+AC_OUTPUT

There is no special dependency here, so we can just add src/conf/toplogty/*/data/Makefile.am in the toplevel configure.ac?

thanks,

Takashi

#3 lore raw

Re: [PATCH v2 2/2] conf: topology: Generate Private data binary blobs

Quoted 110 lines · Takashi Iwai
Quoted 35 lines · Vinod Koul

From: Shreyas NC <[email protected]>

The DSP modules need private data and that is provided as binary blob. These blobs are compiled from C structures which specify module
configuration.

---
 src/conf/topology/sklrt286/data/Makefile.am      |    4 +
 src/conf/topology/sklrt286/data/README           |    2 +
 src/conf/topology/sklrt286/data/compile_local    |   16 +
 src/conf/topology/sklrt286/data/configure.ac     |   30 +
 src/conf/topology/sklrt286/data/pvt.c            | 1815
++++++++++++++++++++++
 src/conf/topology/sklrt286/data/pvt_data.c       |   90 ++
 src/conf/topology/sklrt286/data/pvt_data_local.h |  115 ++
 7 files changed, 2072 insertions(+)
 create mode 100644 src/conf/topology/sklrt286/data/Makefile.am
 create mode 100644 src/conf/topology/sklrt286/data/README
 create mode 100755 src/conf/topology/sklrt286/data/compile_local
 create mode 100644 src/conf/topology/sklrt286/data/configure.ac
 create mode 100644 src/conf/topology/sklrt286/data/pvt.c
 create mode 100644 src/conf/topology/sklrt286/data/pvt_data.c
 create mode 100644 src/conf/topology/sklrt286/data/pvt_data_local.h
src/conf/topology/sklrt286/data/Makefile.am new file +0 -0
new file mode 100644
index 000000000000..9898b9808055

src/conf/topology/sklrt286/data/Makefile.am line 4

Quoted 4 lines
src/conf/topology/sklrt286/data/Makefile.am new file +4 -0
@@ -0,0 +1,4 @@
+bin_PROGRAMS = pvt_data
+pvt_data_SOURCES = pvt_data.c
+AM_CPPFLAGS = \
+         -Wall -I../../../../../include

What is this path?

Quoted 65 lines
src/conf/topology/sklrt286/data/README new file +1 -0
new file mode 100644
index 000000000000..7d1261069dae
@@ -0,0 +1,2 @@
+To compile the src file, run ./compile_local and then ./pvt_data to

execute the binary.

src/conf/topology/sklrt286/data/README new file +1 -0
+The private data blobs will be generated in the sklrt286 folder.
src/conf/topology/sklrt286/data/compile_local new file +16 -0
new file mode 100755
index 000000000000..4b935f8b760d
@@ -0,0 +1,16 @@
+#Helper script to compile
+touch ltconfig NEWS README AUTHORS ChangeLog
+libtoolize --force --copy --automake
+aclocal $ACLOCAL_FLAGS
+autoheader
+automake --foreign --copy --add-missing
+touch depcomp		# seems to be missing for old automake
+autoconf
+export CFLAGS='-O2 -Wall -W -pipe -g'
+echo "CFLAGS=$CFLAGS"
+echo "./configure $args"
+./configure $args || exit 1
+unset CFLAGS
+if [ -z "$GITCOMPILE_NO_MAKE" ]; then
+  make
+fi
src/conf/topology/sklrt286/data/configure.ac new file +25 -0
new file mode 100644
index 000000000000..72c9021edeaf
@@ -0,0 +1,30 @@
+#                                               -*- Autoconf -*-
+# Process this file with autoconf to produce a configure script.
+
+AC_PREREQ([2.69])
+AC_INIT(pvt_data, [VERSION], [BUG-REPORT-ADDRESS])
+AM_INIT_AUTOMAKE(pvt_data, 2.6)
+AC_CONFIG_SRCDIR([pvt_data.c])
+AC_CONFIG_HEADERS([])
+
+# Checks for programs.
+AC_PROG_CC
+
+# Checks for libraries.
+
+# Checks for header files.
+AC_CHECK_HEADERS([limits.h stdint.h])
+
+# Checks for typedefs, structures, and compiler characteristics.
+AC_TYPE_INT16_T
+AC_TYPE_INT32_T
+AC_TYPE_INT8_T
+AC_TYPE_UINT16_T
+AC_TYPE_UINT32_T
+AC_TYPE_UINT8_T
+
Quoted 8 lines

src/conf/topology/sklrt286/data/configure.ac line 30

Quoted 5 lines
src/conf/topology/sklrt286/data/configure.ac new file +5 -0
+# Checks for library functions.
+AC_CHECK_FUNCS([memset strchr])
+AC_CONFIG_FILES([Makefile])
+
+AC_OUTPUT

There is no special dependency here, so we can just add src/conf/toplogty/*/data/Makefile.am in the toplevel configure.ac?

Yes that seems better. Also please note if we do that alsa-lib can compile the data before it compiles skl topology so we can get rid of bnary blobs whcih are prebuilt and get them generated on alsa-lib compile.

This will solve above header patch and will use std path in lib

Is that okay with you?

Signature · 1 line
~Vinod
#4 lore raw

Re: [PATCH v2 2/2] conf: topology: Generate Private data binary blobs

Quoted 121 lines · Vinod
Quoted 110 lines · Takashi Iwai
Quoted 35 lines · Vinod Koul

From: Shreyas NC <[email protected]>

The DSP modules need private data and that is provided as binary blob. These blobs are compiled from C structures which specify module
configuration.

---
 src/conf/topology/sklrt286/data/Makefile.am      |    4 +
 src/conf/topology/sklrt286/data/README           |    2 +
 src/conf/topology/sklrt286/data/compile_local    |   16 +
 src/conf/topology/sklrt286/data/configure.ac     |   30 +
 src/conf/topology/sklrt286/data/pvt.c            | 1815
++++++++++++++++++++++
 src/conf/topology/sklrt286/data/pvt_data.c       |   90 ++
 src/conf/topology/sklrt286/data/pvt_data_local.h |  115 ++
 7 files changed, 2072 insertions(+)
 create mode 100644 src/conf/topology/sklrt286/data/Makefile.am
 create mode 100644 src/conf/topology/sklrt286/data/README
 create mode 100755 src/conf/topology/sklrt286/data/compile_local
 create mode 100644 src/conf/topology/sklrt286/data/configure.ac
 create mode 100644 src/conf/topology/sklrt286/data/pvt.c
 create mode 100644 src/conf/topology/sklrt286/data/pvt_data.c
 create mode 100644 src/conf/topology/sklrt286/data/pvt_data_local.h
src/conf/topology/sklrt286/data/Makefile.am new file +0 -0
new file mode 100644
index 000000000000..9898b9808055

src/conf/topology/sklrt286/data/Makefile.am line 4

Quoted 4 lines
src/conf/topology/sklrt286/data/Makefile.am new file +4 -0
@@ -0,0 +1,4 @@
+bin_PROGRAMS = pvt_data
+pvt_data_SOURCES = pvt_data.c
+AM_CPPFLAGS = \
+         -Wall -I../../../../../include

What is this path?

Quoted 65 lines
src/conf/topology/sklrt286/data/README new file +1 -0
new file mode 100644
index 000000000000..7d1261069dae
@@ -0,0 +1,2 @@
+To compile the src file, run ./compile_local and then ./pvt_data to

execute the binary.

src/conf/topology/sklrt286/data/README new file +1 -0
+The private data blobs will be generated in the sklrt286 folder.
src/conf/topology/sklrt286/data/compile_local new file +16 -0
new file mode 100755
index 000000000000..4b935f8b760d
@@ -0,0 +1,16 @@
+#Helper script to compile
+touch ltconfig NEWS README AUTHORS ChangeLog
+libtoolize --force --copy --automake
+aclocal $ACLOCAL_FLAGS
+autoheader
+automake --foreign --copy --add-missing
+touch depcomp		# seems to be missing for old automake
+autoconf
+export CFLAGS='-O2 -Wall -W -pipe -g'
+echo "CFLAGS=$CFLAGS"
+echo "./configure $args"
+./configure $args || exit 1
+unset CFLAGS
+if [ -z "$GITCOMPILE_NO_MAKE" ]; then
+  make
+fi
src/conf/topology/sklrt286/data/configure.ac new file +25 -0
new file mode 100644
index 000000000000..72c9021edeaf
@@ -0,0 +1,30 @@
+#                                               -*- Autoconf -*-
+# Process this file with autoconf to produce a configure script.
+
+AC_PREREQ([2.69])
+AC_INIT(pvt_data, [VERSION], [BUG-REPORT-ADDRESS])
+AM_INIT_AUTOMAKE(pvt_data, 2.6)
+AC_CONFIG_SRCDIR([pvt_data.c])
+AC_CONFIG_HEADERS([])
+
+# Checks for programs.
+AC_PROG_CC
+
+# Checks for libraries.
+
+# Checks for header files.
+AC_CHECK_HEADERS([limits.h stdint.h])
+
+# Checks for typedefs, structures, and compiler characteristics.
+AC_TYPE_INT16_T
+AC_TYPE_INT32_T
+AC_TYPE_INT8_T
+AC_TYPE_UINT16_T
+AC_TYPE_UINT32_T
+AC_TYPE_UINT8_T
+
Quoted 8 lines

src/conf/topology/sklrt286/data/configure.ac line 30

Quoted 5 lines
src/conf/topology/sklrt286/data/configure.ac new file +5 -0
+# Checks for library functions.
+AC_CHECK_FUNCS([memset strchr])
+AC_CONFIG_FILES([Makefile])
+
+AC_OUTPUT

There is no special dependency here, so we can just add src/conf/toplogty/*/data/Makefile.am in the toplevel configure.ac?

Quoted 4 lines

Yes that seems better. Also please note if we do that alsa-lib can compile the data before it compiles skl topology so we can get rid of bnary blobs whcih are prebuilt and get them generated on alsa-lib compile.

Yeah, that's nicer, too.

Quoted 3 lines

This will solve above header patch and will use std path in lib

Is that okay with you?

Sure.

thanks,

Takashi

#5 lore raw

Re: [PATCH v2 2/2] conf: topology: Generate Private data binary blobs

Quoted 10 lines · Takashi Iwai
Quoted 8 lines

There is no special dependency here, so we can just add

Quoted 1 line

src/conf/toplogty/*/data/Makefile.am in the toplevel configure.ac?

Yes that seems better. Also please note if we do that alsa-lib can compile the data before it compiles skl topology so we can get rid of
bnary blobs whcih are prebuilt and get them generated on alsa-lib compile.

Yeah, that's nicer, too.

One thing though we need to run the binary to generate blobs, am thinking of hooking that up with install step.

Quoted 11 lines
Quoted 4 lines

This will solve above header patch and will use std path in lib

Is that okay with you?

Sure.

thanks,

Takashi

Signature · 1 line
~Vinod
#6 lore raw

Re: [PATCH v2 2/2] conf: topology: Generate Private data binary blobs

Quoted 11 lines · Vinod
Quoted 9 lines · Takashi Iwai
Quoted 8 lines

There is no special dependency here, so we can just add

Quoted 1 line

src/conf/toplogty/*/data/Makefile.am in the toplevel configure.ac?

Yes that seems better. Also please note if we do that alsa-lib can compile the data before it compiles skl topology so we can get rid of
bnary blobs whcih are prebuilt and get them generated on alsa-lib compile.

Quoted 4 lines
Quoted 1 line

Yeah, that's nicer, too.

One thing though we need to run the binary to generate blobs, am thinking of hooking that up with install step.

Compiling something at installation is wrong in general.

Takashi

#7 lore raw

Re: [PATCH v2 2/2] conf: topology: Generate Private data binary blobs

Quoted 17 lines · Takashi Iwai
Quoted 15 lines · Vinod
Quoted 13 lines · Takashi Iwai
Quoted 12 lines

There is no special dependency here, so we can just add

Quoted 2 lines

src/conf/toplogty/*/data/Makefile.am in the toplevel configure.ac?

Yes that seems better. Also please note if we do that alsa-lib can
compile the data before it compiles skl topology so we can get rid
of
bnary blobs whcih are prebuilt and get them generated on alsa -lib
compile.

Quoted 6 lines
Quoted 4 lines
Quoted 1 line

Yeah, that's nicer, too.

One thing though we need to run the binary to generate blobs, am thinking of hooking that up with install step.

Compiling something at installation is wrong in general.

Nope that's not what I meant.

We will compile the tool and create the binary at alsa-lib compile step.

Then we need to run that to generate the binary blobs and that can be done at install step

Signature · 1 line
~Vinod
#8 lore raw

Re: [PATCH v2 2/2] conf: topology: Generate Private data binary blobs

Quoted 24 lines · Vinod
Quoted 22 lines · Takashi Iwai
Quoted 19 lines · Vinod
Quoted 13 lines · Takashi Iwai
Quoted 4 lines

There is no special dependency here, so we can just add

Quoted 2 lines

src/conf/toplogty/*/data/Makefile.am in the toplevel configure.ac?

Quoted 8 lines

Yes that seems better. Also please note if we do that alsa-lib can
compile the data before it compiles skl topology so we can get rid
of
bnary blobs whcih are prebuilt and get them generated on alsa -lib
compile.

Quoted 1 line

Yeah, that's nicer, too.

One thing though we need to run the binary to generate blobs, am thinking of hooking that up with install step.

Quoted 8 lines
Quoted 1 line

Compiling something at installation is wrong in general.

Nope that's not what I meant.

We will compile the tool and create the binary at alsa-lib compile step.

Then we need to run that to generate the binary blobs and that can be done at install step

OK. But now I noticed another pitfall.
The topology firmware is endian-sensitive, and the code to generate is so, too. Thus it can't work for big-endian architectures.

One solution would be to bundle the firmware binary and provide the generator code as a supplement like the current version.

Another option would be to check the endianess in configure script and limit the intel topology f/w only for little endian via AM_CONDITIONAL().

Takashi

#9 lore raw

Re: [PATCH v2 2/2] conf: topology: Generate Private data binary blobs

Quoted 3 lines · Takashi Iwai

OK. But now I noticed another pitfall.
The topology firmware is endian-sensitive, and the code to generate is so, too. Thus it can't work for big-endian architectures.

The firmware side of this needs to be fixed at the ABI level I think, that's definitely an oversight - thanks for spotting it! We have platforms which can switch at boot time between big and little endian so an unfixed endinanness is not going to be usable there.

#10 lore raw

Re: [PATCH v2 2/2] conf: topology: Generate Private data binary blobs

Quoted 6 lines · Mark Brown
Quoted 4 lines · Takashi Iwai

OK. But now I noticed another pitfall.
The topology firmware is endian-sensitive, and the code to generate is
so, too. Thus it can't work for big-endian architectures.

This code is not intended to work on big-endian ones :). We will add __lexx notations on these.

Quoted 4 lines

The firmware side of this needs to be fixed at the ABI level I think, that's definitely an oversight - thanks for spotting it! We have platforms which can switch at boot time between big and little endian so an unfixed endinanness is not going to be usable there.

The topology ABI has been defined as little-endian. The driver needs to do conversion to machine type and use data from topology.

Signature · 1 line
~Vinod