Skip to contentSkip to conversation

FAILED: patch "[PATCH] drm/i915/bdw: Add missing delay during L3 SQC credit" failed to apply to 4.7-stable tree

PATCH [email protected] 1 participant 1 message Aug 18, 2016

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer
#0 lore raw

The patch below does not apply to the 4.7-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.

thanks,

greg k-h

------------------ original commit in Linus's tree ------------------

Quoted 1 line

From 48e5d68d28f00c0cadac5a830980ff3222781abb Mon Sep 17 00:00:00 2001

From: Imre Deak <[email protected]>
Date: Tue, 3 May 2016 15:54:19 +0300
Subject: [PATCH] drm/i915/bdw: Add missing delay during L3 SQC credit
programming
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

BSpec requires us to wait ~100 clocks before re-enabling clock gating, so make sure we do this.

drivers/gpu/drm/i915/intel_pm.c +6 -0
index 2422ac38ce5d..227cd2d395a9 100644
@@ -6738,6 +6738,12 @@ static void broadwell_init_clock_gating(struct drm_device *dev)
 	misccpctl = I915_READ(GEN7_MISCCPCTL);
 	I915_WRITE(GEN7_MISCCPCTL, misccpctl & ~GEN7_DOP_CLOCK_GATE_ENABLE);
 	I915_WRITE(GEN8_L3SQCREG1, BDW_WA_L3SQCREG1_DEFAULT);
+	/*
+	 * Wait at least 100 clocks before re-enabling clock gating. See
+	 * the definition of L3SQCREG1 in BSpec.
+	 */
+	POSTING_READ(GEN8_L3SQCREG1);
+	udelay(1);
 	I915_WRITE(GEN7_MISCCPCTL, misccpctl);
 
 	/*