Skip to contentSkip to conversation

Patch "pinctrl: baytrail: Add missing spinlock usage in byt_gpio_irq_handler" has been added to the 4.9-stable tree

PATCH [email protected] 1 participant 1 message Feb 4, 2017

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

pinctrl: baytrail: Add missing spinlock usage in byt_gpio_irq_handler

to the 4.9-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
pinctrl-baytrail-add-missing-spinlock-usage-in-byt_gpio_irq_handler.patch
and it can be found in the queue-4.9 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From cdca06e4e85974d8a3503ab15709dbbaf90d3dd1 Mon Sep 17 00:00:00 2001

From: Alexander Stein <[email protected]>
Date: Mon, 30 Jan 2017 12:35:28 +0100
Subject: pinctrl: baytrail: Add missing spinlock usage in byt_gpio_irq_handler

From: Alexander Stein <[email protected]>

commit cdca06e4e85974d8a3503ab15709dbbaf90d3dd1 upstream.

According to VLI64 Intel Atom E3800 Specification Update (#329901) concurrent read accesses may result in returning 0xffffffff and write accesses may be dropped silently.
To workaround all accesses must be protected by locks.

---
 drivers/pinctrl/intel/pinctrl-baytrail.c |    2 ++
 1 file changed, 2 insertions(+)
drivers/pinctrl/intel/pinctrl-baytrail.c +2 -0
@@ -1612,7 +1612,9 @@ static void byt_gpio_irq_handler(struct
 			continue;
 		}
 
+		raw_spin_lock(&vg->lock);
 		pending = readl(reg);
+		raw_spin_unlock(&vg->lock);
 		for_each_set_bit(pin, &pending, 32) {
 			virq = irq_find_mapping(vg->chip.irqdomain, base + pin);
 			generic_handle_irq(virq);

Patches currently in stable-queue which might be from [email protected] are

queue-4.9/pinctrl-baytrail-add-missing-spinlock-usage-in-byt_gpio_irq_handler.patch