usb: dwc2: Make sure we disconnect the gadget state
Subsystems (2)
PATCH 1/1 usb: dwc2: Make sure we disconnect the gadget state
I had seen some odd behavior with HiKey's usb-gadget interface that I finally seemed to have chased down. Basically every other time I pluged in the OTG port, the gadget interface would properly initialize. The other times, I'd get a big WARN_ON in dwc2_hsotg_init_fifo() about the fifo_map not being clear.
Ends up if we don't disconnect the gadget state, the fifo-map doesn't get cleared properly, which causes WARN_ON messages and also results in the device not properly being setup as a gadget every other time the OTG port is connected.
So this patch adds a call to dwc2_hsotg_disconnect() in the reset path so the state is properly cleared.
With it, the gadget interface initializes properly on every plug in.
--- drivers/usb/dwc2/hcd.c | 1 + 1 file changed, 1 insertion(+)
drivers/usb/dwc2/hcd.c +1 -0
@@ -3264,6 +3264,7 @@ static void dwc2_conn_id_status_change(struct work_struct *work)dwc2_core_init (hsotg, false);dwc2_enable_global_interrupts (hsotg);spin_lock_irqsave (&hsotg->lock, flags); +dwc2_hsotg_disconnect (hsotg);dwc2_hsotg_core_init_disconnected (hsotg, false);spin_unlock_irqrestore (&hsotg->lock, flags);dwc2_hsotg_core_connect (hsotg);
Signature · 1 line
2.7.4
Hello!
Quoted 3 lines · John Stultz
I had seen some odd behavior with HiKey's usb-gadget interface that I finally seemed to have chased down. Basically every other time I pluged in the OTG port, the gadget interface would
Plugged. Perhaps could be fixed while applying...
Quoted 14 lines
properly initialize. The other times, I'd get a big
WARN_ONindwc2_hsotg_init_fifo()about thefifo_mapnot being clear.Ends up if we don't disconnect the gadget state, the fifo-map doesn't get cleared properly, which causes
WARN_ONmessages and also results in the device not properly being setup as a gadget every other time the OTG port is connected.So this patch adds a call to
dwc2_hsotg_disconnect()in the reset path so the state is properly cleared.With it, the gadget interface initializes properly on every plug in.
Quoted 12 lines
Cc Wei Xu <[email protected]>Cc Guodong Xu <[email protected]>Cc Amit Pundir <[email protected]>Cc Rob Herring <[email protected]>Cc John Youn <[email protected]>Cc Douglas Anderson <[email protected]>Cc Chen Yu <[email protected]>Cc Felipe Balbi <[email protected]>Cc Greg Kroah-Hartman <[email protected]>Acked-by John Youn <[email protected]>Signed-off-by John Stultz <[email protected]>
[...]
MBR, Sergei