Skip to contentSkip to conversation

perf config: Check whether items are from system config in set_config()

PATCH Superseded Taeung Song 1 participant 1 message May 9, 2017 perf events

v3 of 5 Superseded Latest is v5 →

lore
Share & tools
lore
#0 lore raw

PATCH v3 6/7 perf config: Check whether items are from system config in set_config()

It is not being checked that items are from system config or not (i.e. a boolean variable item->from_system_config), when iterating over item list of each section in set_config(), instead only section->from_system_config is being checked multiple times, so fix it.

Cc Jiri Olsa <[email protected]>
Cc Namhyung Kim <[email protected]>
---
 tools/perf/builtin-config.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/builtin-config.c +1 -1
index f62cc2d..34ebe83 100644
@@ -56,7 +56,7 @@ static int set_config(struct perf_config_set *set, const char *file_name)
 		fprintf(fp, "[%s]\n", section->name);
 
 		perf_config_items__for_each_entry(&section->items, item) {
-			if (!use_system_config && section->from_system_config)
+			if (!use_system_config && item->from_system_config)
 				continue;
 			if (item->value)
 				fprintf(fp, "\t%s = %s\n",
Signature · 1 line
2.7.4