Skip to contentSkip to conversation

configure: Only build the s390-ccw bios if the compiler supports -march=z900

PATCH Superseded Thomas Huth 2 participants 3 messages Jan 14, 2019

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 configure: Only build the s390-ccw bios if the compiler supports -march=z900

We want to build our s390-ccw bios with -march=z900 so that it also works with the oldest s390x CPU that we support with TCG. However, Clang on s390x does not support -march=z900 anymore, so we can not use this compiler to build the s390-ccw bios. Thus add a proper test to the configure script to see whether the compiler is usable.

---
 configure | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
configure +4 -1
index 05b7e85..df34974 100755
@@ -5906,7 +5906,10 @@ if test "$cpu" = "ppc64" -a "$targetos" != "Darwin" ; then
 fi
 
 if test "$cpu" = "s390x" ; then
-  roms="$roms s390-ccw"
+  # Only build the s390-ccw bios if the compiler supports -march=z900
+  if "$cc" -dumpspecs 2>/dev/null | grep -q "march=z900"; then
+    roms="$roms s390-ccw"
+  fi
 fi
 
 # Probe for the need for relocating the user-only binary.
Signature · 1 line
1.8.3.1
#1 lore raw
Quoted 17 lines · Thomas Huth

We want to build our s390-ccw bios with -march=z900 so that it also works with the oldest s390x CPU that we support with TCG. However, Clang on s390x does not support -march=z900 anymore, so we can not use this compiler to build the s390-ccw bios. Thus add a proper test to the configure script to see whether the compiler is usable.

---
 configure | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
configure +0 -0
index 05b7e85..df34974 100755

configure if test "$cpu" = "ppc64" -a "$targetos" != "Darwin" ; then · line 5913

Quoted 9 lines
configure +4 -1
@@ -5906,7 +5906,10 @@ if test "$cpu" = "ppc64" -a "$targetos" != "Darwin" ; then
 fi
 
 if test "$cpu" = "s390x" ; then
-  roms="$roms s390-ccw"
+  # Only build the s390-ccw bios if the compiler supports -march=z900
+  if "$cc" -dumpspecs 2>/dev/null | grep -q "march=z900"; then
+    roms="$roms s390-ccw"
+  fi
 fi

clang doesn't support -dumpspecs at all, so you're implicitly saying "not clang" by doing the check this way... If you want to check "does the compiler supoprt -march=z900" why not do a test compile with that in the compile flags ?

write_c_skeleton
if compile_prog "-march=z900" ""; then

       roms="$roms s390-ccw"

fi

?

(untested)

thanks
-- PMM

#2 lore raw
Quoted 33 lines · Peter Maydell
Quoted 17 lines · Thomas Huth

We want to build our s390-ccw bios with -march=z900 so that it also works with the oldest s390x CPU that we support with TCG. However, Clang on s390x does not support -march=z900 anymore, so we can not use this compiler to build the s390-ccw bios. Thus add a proper test to the configure script to see whether the compiler is usable.

---
 configure | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
configure +0 -0
index 05b7e85..df34974 100755

configure if test "$cpu" = "ppc64" -a "$targetos" != "Darwin" ; then · line 5913

Quoted 9 lines
configure +4 -1
@@ -5906,7 +5906,10 @@ if test "$cpu" = "ppc64" -a "$targetos" != "Darwin" ; then
 fi
 
 if test "$cpu" = "s390x" ; then
-  roms="$roms s390-ccw"
+  # Only build the s390-ccw bios if the compiler supports -march=z900
+  if "$cc" -dumpspecs 2>/dev/null | grep -q "march=z900"; then
+    roms="$roms s390-ccw"
+  fi
 fi

clang doesn't support -dumpspecs at all, so you're implicitly saying "not clang" by doing the check this way... If you want to check "does the compiler supoprt -march=z900" why not do a test compile with that in the compile flags ?

Quoted 6 lines
   write_c_skeleton
   if compile_prog "-march=z900" ""; then
       roms="$roms s390-ccw"
   fi

?

Good idea, that seems to work fine, too. I'll send a v2...

Thanks,
Thomas