Skip to contentSkip to conversation

configure: Only build the s390-ccw bios if the compiler supports -march=z900

PATCH Applied Thomas Huth 3 participants 5 messages Jan 14, 2019 – Jan 15, 2019

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 configure: Only build the s390-ccw bios if the compiler supports -march=z900

We want to build our s390-ccw bios with -march=z900 so that it also works with the oldest s390x CPU that we support with TCG. However, Clang on s390x does not support -march=z900 anymore, so we can not use this compiler to build the s390-ccw bios. Thus add a proper test to the configure script to see whether the compiler is usable.

---
v2: Use compile_prog as suggested by Peter

 configure | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
configure +5 -1
index 05b7e85..2b9ba7d 100755
@@ -5905,8 +5905,12 @@ if test "$cpu" = "ppc64" -a "$targetos" != "Darwin" ; then
   roms="$roms spapr-rtas"
 fi
 
+# Only build s390-ccw bios if we're on s390x and the compiler has -march=z900
 if test "$cpu" = "s390x" ; then
-  roms="$roms s390-ccw"
+  write_c_skeleton
+  if compile_prog "-march=z900" ""; then
+    roms="$roms s390-ccw"
+  fi
 fi
 
 # Probe for the need for relocating the user-only binary.
Signature · 1 line
1.8.3.1
#1 lore raw
Quoted 6 lines · On Mon, 14 Jan 2019 13:52:26 +0100 Thomas Huth <[email protected]> wrote:

We want to build our s390-ccw bios with -march=z900 so that it also works with the oldest s390x CPU that we support with TCG. However, Clang on s390x does not support -march=z900 anymore, so we can not use this compiler to build the s390-ccw bios. Thus add a proper test to the configure script to see whether the compiler is usable.

Quoted 6 lines

---
v2: Use compile_prog as suggested by Peter

 configure | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

With this, the fpu/softfloat patch, and Marcel's rdma patches, I can compile with clang on my Fedora 29 s390x system. Yeah!

Should this patch go through the s390 tree, or take some other path?

#2 lore raw
Quoted 13 lines · Cornelia Huck
Quoted 10 lines · On Mon, 14 Jan 2019 13:52:26 +0100 Thomas Huth <[email protected]> wrote:

We want to build our s390-ccw bios with -march=z900 so that it also works with the oldest s390x CPU that we support with TCG. However, Clang on s390x does not support -march=z900 anymore, so we can not use this compiler to build the s390-ccw bios. Thus add a proper test to the configure script to see whether the compiler is usable.

---
v2: Use compile_prog as suggested by Peter

Quoted 7 lines
Quoted 2 lines
 configure | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

With this, the fpu/softfloat patch, and Marcel's rdma patches, I can compile with clang on my Fedora 29 s390x system. Yeah!

Should this patch go through the s390 tree, or take some other path?

There is no dedicated maintainer for the configure script, so please take it through the s390 tree.

Thanks,
Thomas

#3 lore raw
In reply to Thomas Huth
Quoted 6 lines · On Mon, 14 Jan 2019 13:52:26 +0100 Thomas Huth <[email protected]> wrote:

We want to build our s390-ccw bios with -march=z900 so that it also works with the oldest s390x CPU that we support with TCG. However, Clang on s390x does not support -march=z900 anymore, so we can not use this compiler to build the s390-ccw bios. Thus add a proper test to the configure script to see whether the compiler is usable.

Quoted 6 lines

---
v2: Use compile_prog as suggested by Peter

 configure | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

Thanks, applied.

Acked-by on v2 1/1
#4 lore raw
In reply to Thomas Huth
Quoted 7 lines · Thomas Huth

We want to build our s390-ccw bios with -march=z900 so that it also works with the oldest s390x CPU that we support with TCG. However, Clang on s390x does not support -march=z900 anymore, so we can not use this compiler to build the s390-ccw bios. Thus add a proper test to the configure script to see whether the compiler is usable.

Quoted 25 lines

---
v2: Use compile_prog as suggested by Peter

 configure | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
configure +5 -1
index 05b7e85..2b9ba7d 100755
@@ -5905,8 +5905,12 @@ if test "$cpu" = "ppc64" -a "$targetos" != "Darwin" ; then
   roms="$roms spapr-rtas"
 fi
 
+# Only build s390-ccw bios if we're on s390x and the compiler has -march=z900
 if test "$cpu" = "s390x" ; then
-  roms="$roms s390-ccw"
+  write_c_skeleton
+  if compile_prog "-march=z900" ""; then
+    roms="$roms s390-ccw"
+  fi
 fi
 
 # Probe for the need for relocating the user-only binary.