Skip to contentSkip to conversation

staging: frontier: fix memory leak in usb_alphatrack_probe()

PATCH New Daeseok Youn 1 participant 1 message Mar 7, 2014 Staging

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 staging: frontier: fix memory leak in usb_alphatrack_probe()

oldi_buffer and write_buffer need to free when usb_alphatrack_delete() is called.

---
v2: remove the unneeded comment.

 drivers/staging/frontier/alphatrack.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)
drivers/staging/frontier/alphatrack.c +3 -1
index edd5cef..e59ee51 100644
@@ -208,7 +208,9 @@ static void usb_alphatrack_delete(struct usb_alphatrack *dev)
 	kfree(dev->ring_buffer);
 	kfree(dev->interrupt_in_buffer);
 	kfree(dev->interrupt_out_buffer);
-	kfree(dev);		/* fixme oldi_buffer */
+	kfree(dev->oldi_buffer);
+	kfree(dev->write_buffer);
+	kfree(dev);
 }
 
 /** usb_alphatrack_interrupt_in_callback */
Signature · 1 line
1.7.4.4