staging: frontier: fix memory leak in usb_alphatrack_probe()
PATCH 1/1 staging: frontier: fix memory leak in usb_alphatrack_probe()
oldi_buffer and write_buffer need to free when usb_alphatrack_delete() is called.
--- drivers/staging/frontier/alphatrack.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
drivers/staging/frontier/alphatrack.c +2 -0
@@ -208,6 +208,8 @@ static void usb_alphatrack_delete(struct usb_alphatrack *dev)kfree (dev->ring_buffer);kfree (dev->interrupt_in_buffer);kfree (dev->interrupt_out_buffer); +kfree (dev->oldi_buffer); +kfree (dev->write_buffer);kfree (dev);/* fixme oldi_buffer */ }
Signature · 1 line
1.7.4.4
Quoted 14 lines · Daeseok Youn
oldi_bufferandwrite_bufferneed to free whenusb_alphatrack_delete()is called.Signed-off-by Daeseok Youn <[email protected]>--- drivers/staging/frontier/alphatrack.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)drivers/staging/frontier/alphatrack.c +0
-0
drivers/staging/frontier/alphatrack.c static void usb_alphatrack_delete(struct usb_alphatrack *dev) · line 213
Quoted 6 lines
drivers/staging/frontier/alphatrack.c +2
-0@@ -208,6 +208,8 @@ static void usb_alphatrack_delete(struct usb_alphatrack *dev)kfree (dev->ring_buffer);kfree (dev->interrupt_in_buffer);kfree (dev->interrupt_out_buffer); +kfree (dev->oldi_buffer); +kfree (dev->write_buffer);kfree (dev);/* fixme oldi_buffer */
^^^^^^^^^^^^^^^^^
Remove this comment now?
regards,
dan carpenter
OK. I will remove that comment and send again.
Thanks.
Daeseok Youn.
2014-03-07 17:14 GMT+09:00 Dan Carpenter <[email protected]>:
Quoted 27 lines · Daeseok Youn
Quoted 14 lines
oldi_bufferandwrite_bufferneed to free whenusb_alphatrack_delete()is called.Signed-off-by Daeseok Youn <[email protected]>--- drivers/staging/frontier/alphatrack.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)drivers/staging/frontier/alphatrack.c +0
-0drivers/staging/frontier/alphatrack.c static void usb_alphatrack_delete(struct usb_alphatrack *dev) · line 213
Quoted 6 lines
drivers/staging/frontier/alphatrack.c +2
-0@@ -208,6 +208,8 @@ static void usb_alphatrack_delete(struct usb_alphatrack *dev)kfree (dev->ring_buffer);kfree (dev->interrupt_in_buffer);kfree (dev->interrupt_out_buffer); +kfree (dev->oldi_buffer); +kfree (dev->write_buffer);kfree (dev);/* fixme oldi_buffer */ ^^^^^^^^^^^^^^^^^Remove this comment now?
regards,
dan carpenter