riscv: virt: Allow PCI address 0
PATCH 1/1 riscv: virt: Allow PCI address 0
When testing e1000 with the virt machine, e1000's I/O space cannot be accessed. Debugging shows that the I/O BAR (BAR1) is correctly written with address 0 plus I/O enable bit, but QEMU's "info pci" shows that:
Bus 0, device 1, function 0:
Ethernet controller: PCI device 8086:100e
...
BAR1: I/O at 0xffffffffffffffff [0x003e].
...
It turns out we should set pci_allow_0_address to true to allow 0 PCI address, otherwise pci_bar_address() treats such address as PCI_BAR_UNMAPPED.
---
hw/riscv/virt.c | 1 + 1 file changed, 1 insertion(+)
hw/riscv/virt.c +1 -0
@@ -603,6 +603,7 @@ static void riscv_virt_machine_class_init(ObjectClass *oc, void *data) mc->init = riscv_virt_board_init; mc->max_cpus =8 ; mc->default_cpu_type =VIRT_CPU ; + mc->pci_allow_0_address = true; }static const TypeInfo riscv_virt_machine_typeinfo = {
Signature · 1 line
2.7.4
Quoted 26 lines · On Fri, 22 Nov 2019 07:27:52 PST (-0800), [email protected] wrote:
When testing e1000 with the virt machine, e1000's I/O space cannot be accessed. Debugging shows that the I/O BAR (BAR1) is correctly written with address 0 plus I/O enable bit, but QEMU's "info pci" shows that:
Bus 0, device 1, function 0:
Ethernet controller: PCI device 8086:100e
...BAR1: I/O at 0xffffffffffffffff [0x003e]....
It turns out we should set
pci_allow_0_addressto true to allow 0 PCI address, otherwisepci_bar_address()treats such address asPCI_BAR_UNMAPPED.Signed-off-by Bin Meng <[email protected]>---
hw/riscv/virt.c | 1 + 1 file changed, 1 insertion(+)hw/riscv/virt.c +0
-0
hw/riscv/virt.c static void riscv_virt_machine_class_init(ObjectClass *oc, void *data) · line 609
Quoted 7 lines
hw/riscv/virt.c +1
-0@@ -603,6 +603,7 @@ static void riscv_virt_machine_class_init(ObjectClass *oc, void *data) mc->init = riscv_virt_board_init; mc->max_cpus =8 ; mc->default_cpu_type =VIRT_CPU ; + mc->pci_allow_0_address = true; }static const TypeInfo riscv_virt_machine_typeinfo = {
I've put this on for-next, as I don't think this is 4.2 material.
Thanks!
Hi Palmer,
Quoted 34 lines · Palmer Dabbelt
Quoted 32 lines · On Fri, 22 Nov 2019 07:27:52 PST (-0800), [email protected] wrote:
When testing e1000 with the virt machine, e1000's I/O space cannot be accessed. Debugging shows that the I/O BAR (BAR1) is correctly written with address 0 plus I/O enable bit, but QEMU's "info pci" shows that:
Bus 0, device 1, function 0:
Ethernet controller: PCI device 8086:100e
...BAR1: I/O at 0xffffffffffffffff [0x003e]....
It turns out we should set
pci_allow_0_addressto true to allow 0 PCI address, otherwisepci_bar_address()treats such address asPCI_BAR_UNMAPPED.Signed-off-by Bin Meng <[email protected]>---
hw/riscv/virt.c | 1 + 1 file changed, 1 insertion(+)hw/riscv/virt.c +1
-0@@ -603,6 +603,7 @@ static void riscv_virt_machine_class_init(ObjectClass *oc, void *data) mc->init = riscv_virt_board_init; mc->max_cpus =8 ; mc->default_cpu_type =VIRT_CPU ; + mc->pci_allow_0_address = true; }
Quoted 5 lines
hw/riscv/virt.c static void riscv_virt_machine_class_init(ObjectClass *oc, void *data) · line 609
Quoted 1 line
hw/riscv/virt.c +0
-0static const TypeInfo riscv_virt_machine_typeinfo = {Reviewed-by Palmer Dabbelt <[email protected]>I've put this on for-next, as I don't think this is 4.2 material.
Looks you missed picking up this one :(
Regards,
Bin
Quoted 37 lines · On Sun, 02 Feb 2020 07:41:25 PST (-0800), [email protected] wrote:
Hi Palmer,
Quoted 34 lines · Palmer Dabbelt
Quoted 32 lines · On Fri, 22 Nov 2019 07:27:52 PST (-0800), [email protected] wrote:
When testing e1000 with the virt machine, e1000's I/O space cannot be accessed. Debugging shows that the I/O BAR (BAR1) is correctly written with address 0 plus I/O enable bit, but QEMU's "info pci" shows that:
Bus 0, device 1, function 0:
Ethernet controller: PCI device 8086:100e
...BAR1: I/O at 0xffffffffffffffff [0x003e]....
It turns out we should set
pci_allow_0_addressto true to allow 0 PCI address, otherwisepci_bar_address()treats such address asPCI_BAR_UNMAPPED.Signed-off-by Bin Meng <[email protected]>---
hw/riscv/virt.c | 1 + 1 file changed, 1 insertion(+)hw/riscv/virt.c +1
-0@@ -603,6 +603,7 @@ static void riscv_virt_machine_class_init(ObjectClass *oc, void *data) mc->init = riscv_virt_board_init; mc->max_cpus =8 ; mc->default_cpu_type =VIRT_CPU ; + mc->pci_allow_0_address = true; }
Quoted 7 lines
Quoted 5 lines
hw/riscv/virt.c static void riscv_virt_machine_class_init(ObjectClass *oc, void *data) · line 609
Quoted 1 line
hw/riscv/virt.c +0
-0static const TypeInfo riscv_virt_machine_typeinfo = {Reviewed-by Palmer Dabbelt <[email protected]>I've put this on for-next, as I don't think this is 4.2 material.
Looks you missed picking up this one :(
Sorry about that, it's back on for-master.