Skip to contentSkip to conversation

ARM: dts: aspeed: Fix SCU IRQ controller node addresses

PATCH In review Eddie James 2 participants 5 messages Feb 10, 2020 – Feb 16, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

v2 cover ARM: dts: aspeed: Fix SCU IRQ controller node addresses

Warnings were introduced due to unit address on nodes that had no reg property. Add the reg properties for the nodes to fix the warnings.

Eddie James (2):
ARM: dts: aspeed: ast2500: Fix SCU IRQ controller node
ARM: dts: aspeed: ast2600: Fix SCU IRQ controller nodes

 arch/arm/boot/dts/aspeed-g5.dtsi | 1 +
 arch/arm/boot/dts/aspeed-g6.dtsi | 6 ++++--
 2 files changed, 5 insertions(+), 2 deletions(-)
Signature · 1 line
1.8.3.1
#1 lore raw

PATCH v2 1/2 ARM: dts: aspeed: ast2500: Fix SCU IRQ controller node

The node was defined with a unit address but had no reg property, resulting in a warning. Add a reg property for consistency to fix the warning.

---
 arch/arm/boot/dts/aspeed-g5.dtsi | 1 +
 1 file changed, 1 insertion(+)
arch/arm/boot/dts/aspeed-g5.dtsi +1 -0
index 569f9d7..9db7bde 100644
@@ -225,6 +225,7 @@
 				scu_ic: interrupt-controller at 18 {
 					#interrupt-cells = <1>;
 					compatible = "aspeed,ast2500-scu-ic";
+					reg = <0x18 0x4>;
 					interrupts = <21>;
 					interrupt-controller;
 				};
Signature · 1 line
1.8.3.1
Reviewed-by on v2 1/2
#2 lore raw

Re: [PATCH v2 1/2] ARM: dts: aspeed: ast2500: Fix SCU IRQ controller node

Quoted 5 lines · Eddie James

The node was defined with a unit address but had no reg property, resulting in a warning. Add a reg property for consistency to fix the warning.

Quoted 20 lines
---
 arch/arm/boot/dts/aspeed-g5.dtsi | 1 +
 1 file changed, 1 insertion(+)
arch/arm/boot/dts/aspeed-g5.dtsi +1 -0
index 569f9d7..9db7bde 100644
@@ -225,6 +225,7 @@
 				scu_ic: interrupt-controller at 18 {
 					#interrupt-cells = <1>;
 					compatible = "aspeed,ast2500-scu-ic";
+					reg = <0x18 0x4>;
 					interrupts = <21>;
 					interrupt-controller;
 				};
Signature · 1 line
1.8.3.1
#3 lore raw

PATCH v2 2/2 ARM: dts: aspeed: ast2600: Fix SCU IRQ controller nodes

In reply to Eddie James

The nodes were defined with a unit address but had no reg property, resulting in a warning. Add the reg properties for consistency to fix the warning.

---
 arch/arm/boot/dts/aspeed-g6.dtsi | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
arch/arm/boot/dts/aspeed-g6.dtsi +4 -2
index 82a3cd1..301fdb4 100644
@@ -269,16 +269,18 @@
 					reg = <0x180 0x40>;
 				};
 
-				scu_ic0: interrupt-controller at 0 {
+				scu_ic0: interrupt-controller at 560 {
 					#interrupt-cells = <1>;
 					compatible = "aspeed,ast2600-scu-ic0";
+					reg = <0x560 0x4>;
 					interrupts = <GIC_SPI 12 IRQ_TYPE_LEVEL_HIGH>;
 					interrupt-controller;
 				};
 
-				scu_ic1: interrupt-controller at 1 {
+				scu_ic1: interrupt-controller at 570 {
 					#interrupt-cells = <1>;
 					compatible = "aspeed,ast2600-scu-ic1";
+					reg = <0x570 0x4>;
 					interrupts = <GIC_SPI 41 IRQ_TYPE_LEVEL_HIGH>;
 					interrupt-controller;
 				};
Signature · 1 line
1.8.3.1
Reviewed-by on v2 2/2
#4 lore raw

Re: [PATCH v2 2/2] ARM: dts: aspeed: ast2600: Fix SCU IRQ controller nodes

Quoted 5 lines · Eddie James

The nodes were defined with a unit address but had no reg property, resulting in a warning. Add the reg properties for consistency to fix the warning.

Quoted 33 lines
---
 arch/arm/boot/dts/aspeed-g6.dtsi | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
arch/arm/boot/dts/aspeed-g6.dtsi +4 -2
index 82a3cd1..301fdb4 100644
@@ -269,16 +269,18 @@
 					reg = <0x180 0x40>;
 				};
 
-				scu_ic0: interrupt-controller at 0 {
+				scu_ic0: interrupt-controller at 560 {
 					#interrupt-cells = <1>;
 					compatible = "aspeed,ast2600-scu-ic0";
+					reg = <0x560 0x4>;
 					interrupts = <GIC_SPI 12 IRQ_TYPE_LEVEL_HIGH>;
 					interrupt-controller;
 				};
 
-				scu_ic1: interrupt-controller at 1 {
+				scu_ic1: interrupt-controller at 570 {
 					#interrupt-cells = <1>;
 					compatible = "aspeed,ast2600-scu-ic1";
+					reg = <0x570 0x4>;
 					interrupts = <GIC_SPI 41 IRQ_TYPE_LEVEL_HIGH>;
 					interrupt-controller;
 				};
Signature · 1 line
1.8.3.1