Skip to contentSkip to conversation

ARM: dts: aspeed: Fix SCU IRQ controller node addresses

PATCH Superseded Eddie James 2 participants 4 messages Feb 4, 2020 – Feb 10, 2020

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

cover ARM: dts: aspeed: Fix SCU IRQ controller node addresses

Warnings were introduced due to unit address on nodes that had no reg property. Drop the unit addresses from the nodes.

Eddie James (2):
ARM: dts: aspeed: ast2500: Fix SCU IRQ controller node address
ARM: dts: aspeed: ast2600: Fix SCU IRQ controller node addresses

 arch/arm/boot/dts/aspeed-g5.dtsi | 2 +-
 arch/arm/boot/dts/aspeed-g6.dtsi | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)
Signature · 1 line
2.24.0
#1 lore raw

PATCH 1/2 ARM: dts: aspeed: ast2500: Fix SCU IRQ controller node address

The node was defined with a unit address but had no reg property, resulting in a warning. The address is unecessary, so drop it.

---
 arch/arm/boot/dts/aspeed-g5.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/aspeed-g5.dtsi +1 -1
index 569f9d74c696..aeee18fc1e7e 100644
@@ -222,7 +222,7 @@ syscon: syscon at 1e6e2000 {
 				#clock-cells = <1>;
 				#reset-cells = <1>;
 
-				scu_ic: interrupt-controller at 18 {
+				scu_ic: interrupt-controller {
 					#interrupt-cells = <1>;
 					compatible = "aspeed,ast2500-scu-ic";
 					interrupts = <21>;
Signature · 1 line
2.24.0
maintainer
#2 lore raw

Re: [PATCH 1/2] ARM: dts: aspeed: ast2500: Fix SCU IRQ controller node address

Quoted 3 lines · Eddie James

The node was defined with a unit address but had no reg property, resulting in a warning. The address is unecessary, so drop it.

Please add a reg property instead of removing the unit address.

The hardware still lives at that address, even if your driver doesn't currently use that information.

Cheers,

Joel

Quoted 22 lines
---
 arch/arm/boot/dts/aspeed-g5.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/aspeed-g5.dtsi +1 -2
index 569f9d74c696..aeee18fc1e7e 100644
@@ -222,7 +222,7 @@ syscon: syscon at 1e6e2000 {
                                #clock-cells = <1>;
                                #reset-cells = <1>;
 
-                               scu_ic: interrupt-controller at 18 {
+                               scu_ic: interrupt-controller {
                                        #interrupt-cells = <1>;
                                        compatible = "aspeed,ast2500-scu-ic";
                                        interrupts = <21>;
--

2.24.0

#3 lore raw

PATCH 2/2 ARM: dts: aspeed: ast2600: Fix SCU IRQ controller node addresses

In reply to Eddie James

The nodes were defined with a unit address but had no reg property, resulting in a warning. The address is unecessary, so drop it.

---
 arch/arm/boot/dts/aspeed-g6.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/boot/dts/aspeed-g6.dtsi +2 -2
index 82a3cd10cc2b..6f6a2d0217dc 100644
@@ -269,14 +269,14 @@ smp-memram at 180 {
 					reg = <0x180 0x40>;
 				};
 
-				scu_ic0: interrupt-controller at 0 {
+				scu_ic0: interrupt-controller {
 					#interrupt-cells = <1>;
 					compatible = "aspeed,ast2600-scu-ic0";
 					interrupts = <GIC_SPI 12 IRQ_TYPE_LEVEL_HIGH>;
 					interrupt-controller;
 				};
 
-				scu_ic1: interrupt-controller at 1 {
+				scu_ic1: interrupt-controller {
 					#interrupt-cells = <1>;
 					compatible = "aspeed,ast2600-scu-ic1";
 					interrupts = <GIC_SPI 41 IRQ_TYPE_LEVEL_HIGH>;
Signature · 1 line
2.24.0