Skip to contentSkip to conversation

Expose recovery/coredump configuration from sysfs

PATCH Superseded Rishabh Bhatnagar 5 participants 18 messages Aug 27, 2020 – Oct 14, 2020 1 message not in the archive Remote processor (remoteproc)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#4 lore raw

PATCH v2 3/3 remoteproc: Add recovery configuration to sysfs

In reply to Rishabh Bhatnagar

Expose recovery configuration in sysfs under a feature flag. This is useful for systems where access to debugfs might be limited.

---
 Documentation/ABI/testing/sysfs-class-remoteproc | 20 ++++++++
 drivers/remoteproc/remoteproc_debugfs.c          |  6 ++-
 drivers/remoteproc/remoteproc_sysfs.c            | 58 ++++++++++++++++++++++++
 3 files changed, 82 insertions(+), 2 deletions(-)
Documentation/ABI/testing/sysfs-class-remoteproc +20 -0
index f6c44fa..7368b50 100644
@@ -82,3 +82,23 @@ Description:	Remote processor coredump configuration
 		all data is read by usersapce.
 
 		"disabled" means no dump will be collected.
+
+What:		/sys/class/remoteproc/.../recovery
+Date:		July 2020
+Contact:	Bjorn Andersson <[email protected]>, Ohad Ben-Cohen <[email protected]>
+Description:	Remote processor recovery mechanism
+
+		Reports the recovery mechanism of the remote processor,
+		which will be one of:
+
+		"enabled"
+		"disabled"
+
+		"enabled" means, the remote processor will be automatically
+		recovered whenever it crashes. Moreover, if the remote
+		processor crashes while recovery is disabled, it will
+		be automatically recovered too as soon as recovery is enabled.
+
+		"disabled" means, a remote processor will remain in a crashed
+		state if it crashes. This is useful for debugging purposes;
+		without it, debugging a crash is substantially harder.
drivers/remoteproc/remoteproc_debugfs.c +4 -2
index 48dfd0a..415a9ff 100644
@@ -174,6 +174,7 @@ static const struct file_operations rproc_name_ops = {
 	.llseek	= generic_file_llseek,
 };
 
+#if (!IS_ENABLED(CONFIG_RPROC_SYSFS_CONFIGURATION_SUPPORT))
 /* expose recovery flag via debugfs */
 static ssize_t rproc_recovery_read(struct file *filp, char __user *userbuf,
 				   size_t count, loff_t *ppos)
@@ -249,6 +250,7 @@ static const struct file_operations rproc_recovery_ops = {
 	.open = simple_open,
 	.llseek = generic_file_llseek,
 };
+#endif
 
 /* expose the crash trigger via debugfs */
 static ssize_t
@@ -419,8 +421,6 @@ void rproc_create_debug_dir(struct rproc *rproc)
 
 	debugfs_create_file("name", 0400, rproc->dbg_dir,
 			    rproc, &rproc_name_ops);
-	debugfs_create_file("recovery", 0600, rproc->dbg_dir,
-			    rproc, &rproc_recovery_ops);
 	debugfs_create_file("crash", 0200, rproc->dbg_dir,
 			    rproc, &rproc_crash_ops);
 	debugfs_create_file("resource_table", 0400, rproc->dbg_dir,
@@ -430,6 +430,8 @@ void rproc_create_debug_dir(struct rproc *rproc)
 #if (!IS_ENABLED(CONFIG_RPROC_SYSFS_CONFIGURATION_SUPPORT))
 	debugfs_create_file("coredump", 0600, rproc->dbg_dir,
 			    rproc, &rproc_coredump_fops);
+	debugfs_create_file("recovery", 0600, rproc->dbg_dir,
+			    rproc, &rproc_recovery_ops);
 #endif
 }
 
drivers/remoteproc/remoteproc_sysfs.c +58 -0

70 lines not on this page · raw message

Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
#1 lore raw

PATCH v2 1/3 remoteproc: Expose remoteproc configuration through sysfs

In reply to Rishabh Bhatnagar

Add a feature flag to expose some of the remoteproc configuration through sysfs. This feature is helpful in systems where debugfs is not available/mounted. Currently the recovery and coredump configuration is exposed through sysfs rather than debugfs when this feature is selected.

---
 drivers/remoteproc/Kconfig | 12 ++++++++++++
 1 file changed, 12 insertions(+)
drivers/remoteproc/Kconfig +12 -0
index c6659dfe..8aecf70 100644
@@ -275,6 +275,18 @@ config TI_K3_DSP_REMOTEPROC
 	  It's safe to say N here if you're not interested in utilizing
 	  the DSP slave processors.
 
+config RPROC_SYSFS_CONFIGURATION_SUPPORT
+	bool "Expose remoteproc configuration sysfs entries"
+	default n
+	help
+	  Say y here to expose recovery and coredump configuration sysfs
+	  entries. This will remove the corresponding entries from debugfs
+	  and expose it through sysfs. This is helpful in operating systems
+	  where debugfs is not available.
+
+	  It's safe to say N here if you are not interested in accessing
+	  recovery and coredump configuration through sysfs.
+
 endif # REMOTEPROC
 
 endmenu
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
#0 lore raw

v2 cover Expose recovery/coredump configuration from sysfs

From Android R onwards Google has restricted access to debugfs in user and user-debug builds. This restricts access to most of the features exposed through debugfs. This patch series adds a configurable option to move the recovery/coredump interfaces to sysfs. If the feature flag is selected it would move these interfaces to sysfs and remove the equivalent debugfs interface. 'Coredump' and 'Recovery' are critical interfaces that are required for remoteproc to work on Qualcomm Chipsets. Coredump configuration needs to be set to "inline" in debug/test build and "disabled" in production builds. Whereas recovery needs to be "disabled" for debugging purposes and "enabled" on production builds.

Changelog:

v1 -> v2:
- Correct the contact name in the sysfs documentation.
- Remove the redundant write documentation for coredump/recovery sysfs
- Add a feature flag to make this interface switch configurable.

Rishabh Bhatnagar (3):
remoteproc: Expose remoteproc configuration through sysfs
remoteproc: Add coredump configuration to sysfs
remoteproc: Add recovery configuration to sysfs

 Documentation/ABI/testing/sysfs-class-remoteproc |  44 ++++++++
 drivers/remoteproc/Kconfig                       |  12 +++
 drivers/remoteproc/remoteproc_debugfs.c          |  10 +-
 drivers/remoteproc/remoteproc_sysfs.c            | 126 +++++++++++++++++++++++
 4 files changed, 190 insertions(+), 2 deletions(-)
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
#2 lore raw

PATCH v2 2/3 remoteproc: Add coredump configuration to sysfs

Expose coredump configuration in sysfs under a feature flag. This is useful for systems where access to debugfs might be limited.

---
 Documentation/ABI/testing/sysfs-class-remoteproc | 24 +++++++++
 drivers/remoteproc/remoteproc_debugfs.c          |  4 ++
 drivers/remoteproc/remoteproc_sysfs.c            | 68 ++++++++++++++++++++++++
 3 files changed, 96 insertions(+)
Documentation/ABI/testing/sysfs-class-remoteproc +24 -0
index 36094fb..f6c44fa 100644
@@ -58,3 +58,27 @@ Description:	Remote processor name
 		Reports the name of the remote processor. This can be used by
 		userspace in exactly identifying a remote processor and ease
 		up the usage in modifying the 'firmware' or 'state' files.
+
+What:		/sys/class/remoteproc/.../coredump
+Date:		July 2020
+Contact:	Bjorn Andersson <[email protected]>, Ohad Ben-Cohen <[email protected]>
+Description:	Remote processor coredump configuration
+
+		Reports the coredump configuration of the remote processor,
+		which will be one of:
+
+		"default"
+		"inline"
+		"disabled"
+
+		"default" means when the remote processor's coredump is
+		collected it will be copied to a separate buffer and that
+		buffer is exposed to userspace.
+
+		"inline" means when the remote processor's coredump is
+		collected userspace will directly read from the remote
+		processor's device memory. Extra buffer will not be used to
+		copy the dump. Also recovery process will not proceed until
+		all data is read by usersapce.
+
+		"disabled" means no dump will be collected.
drivers/remoteproc/remoteproc_debugfs.c +4 -0
index 2e3b3e2..48dfd0a 100644
@@ -27,6 +27,7 @@
 /* remoteproc debugfs parent dir */
 static struct dentry *rproc_dbg;
 
+#if (!IS_ENABLED(CONFIG_RPROC_SYSFS_CONFIGURATION_SUPPORT))
 /*
  * A coredump-configuration-to-string lookup table, for exposing a
  * human readable configuration via debugfs. Always keep in sync with
@@ -114,6 +115,7 @@ static const struct file_operations rproc_coredump_fops = {
 	.open = simple_open,
 	.llseek = generic_file_llseek,
 };
+#endif
 
 /*
  * Some remote processors may support dumping trace logs into a shared
@@ -425,8 +427,10 @@ void rproc_create_debug_dir(struct rproc *rproc)
 			    rproc, &rproc_rsc_table_fops);
 	debugfs_create_file("carveout_memories", 0400, rproc->dbg_dir,
 			    rproc, &rproc_carveouts_fops);
+#if (!IS_ENABLED(CONFIG_RPROC_SYSFS_CONFIGURATION_SUPPORT))
 	debugfs_create_file("coredump", 0600, rproc->dbg_dir,
 			    rproc, &rproc_coredump_fops);
+#endif
 }
 
 void __init rproc_init_debugfs(void)
drivers/remoteproc/remoteproc_sysfs.c +68 -0

80 lines not on this page · raw message

Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
maintainer
#5 lore raw
In reply to Rishabh Bhatnagar

Hi Rishabh,

Quoted 6 lines · Rishabh Bhatnagar

From Android R onwards Google has restricted access to debugfs in user and user-debug builds. This restricts access to most of the features exposed through debugfs. This patch series adds a configurable option to move the recovery/coredump interfaces to sysfs. If the feature flag is selected it would move these interfaces to sysfs and remove the equivalent debugfs interface.

What I meant wast to move the coredump entry from debugfs to sysfs and from there make it available to user space using a kernel config. But thinking further on this it may be better to simply provide an API to set the coredump mode from the platform driver, the same way rproc_coredump_set_elf_info() works. That will prevent breaking a fair amount of user space code...

Let me know if that can work for you.

Thanks,
Mathieu

Quoted 28 lines

'Coredump' and 'Recovery' are critical
interfaces that are required for remoteproc to work on Qualcomm Chipsets. Coredump configuration needs to be set to "inline" in debug/test build and "disabled" in production builds. Whereas recovery needs to be "disabled" for debugging purposes and "enabled" on production builds.

Changelog:

v1 -> v2:
- Correct the contact name in the sysfs documentation.
- Remove the redundant write documentation for coredump/recovery sysfs
- Add a feature flag to make this interface switch configurable.

Rishabh Bhatnagar (3):
remoteproc: Expose remoteproc configuration through sysfs
remoteproc: Add coredump configuration to sysfs
remoteproc: Add recovery configuration to sysfs

 Documentation/ABI/testing/sysfs-class-remoteproc |  44 ++++++++
 drivers/remoteproc/Kconfig                       |  12 +++
 drivers/remoteproc/remoteproc_debugfs.c          |  10 +-
 drivers/remoteproc/remoteproc_sysfs.c            | 126 +++++++++++++++++++++++
 4 files changed, 190 insertions(+), 2 deletions(-)
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
#6 lore raw
Quoted 16 lines · Mathieu Poirier

Hi Rishabh,

Quoted 6 lines · Rishabh Bhatnagar

From Android R onwards Google has restricted access to debugfs in user and user-debug builds. This restricts access to most of the features exposed through debugfs. This patch series adds a configurable option to move the recovery/coredump interfaces to sysfs. If the feature flag is selected it would move these interfaces to sysfs and remove the equivalent debugfs interface.

What I meant wast to move the coredump entry from debugfs to sysfs and from there make it available to user space using a kernel config. But thinking further on this it may be better to simply provide an API to set the coredump mode from the platform driver, the same way rproc_coredump_set_elf_info() works. That will prevent breaking a fair amount of user space code...

Quoted 5 lines

Let me know if that can work for you.

Thanks,
Mathieu

Hi Mathieu,
That works for product configuration but that would still limit internal testing. Since there is also restriction on accessing debugfs through userspace code, automation won't be able to run recovery/coredump tests. Only other way for us would be to provide these sysfs entries through the platform drivers locally but that would create a lot of mess/redundancy.

Quoted 29 lines
Quoted 29 lines

'Coredump' and 'Recovery' are critical
interfaces that are required for remoteproc to work on Qualcomm Chipsets. Coredump configuration needs to be set to "inline" in debug/test build and "disabled" in production builds. Whereas recovery needs to be "disabled" for debugging purposes and "enabled" on production builds.

Changelog:

v1 -> v2:
- Correct the contact name in the sysfs documentation.
- Remove the redundant write documentation for coredump/recovery sysfs
- Add a feature flag to make this interface switch configurable.

Rishabh Bhatnagar (3):
remoteproc: Expose remoteproc configuration through sysfs
remoteproc: Add coredump configuration to sysfs
remoteproc: Add recovery configuration to sysfs

 Documentation/ABI/testing/sysfs-class-remoteproc |  44 ++++++++
 drivers/remoteproc/Kconfig                       |  12 +++
 drivers/remoteproc/remoteproc_debugfs.c          |  10 +-
 drivers/remoteproc/remoteproc_sysfs.c            | 126 
+++++++++++++++++++++++
 4 files changed, 190 insertions(+), 2 deletions(-)

--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project

maintainer
#7 lore raw
Quoted 23 lines · On Wed, Sep 02, 2020 at 04:14:19PM -0700, [email protected] wrote:
Quoted 22 lines · Mathieu Poirier

Hi Rishabh,

Quoted 6 lines · Rishabh Bhatnagar

From Android R onwards Google has restricted access to debugfs in user and user-debug builds. This restricts access to most of the features exposed through debugfs. This patch series adds a configurable option to move the recovery/coredump interfaces to sysfs. If the feature flag is selected it would move these interfaces to sysfs and remove the equivalent debugfs interface.

What I meant wast to move the coredump entry from debugfs to sysfs and from
there make it available to user space using a kernel config. But thinking
further on this it may be better to simply provide an API to set the coredump
mode from the platform driver, the same way rproc_coredump_set_elf_info() works.
That will prevent breaking a fair amount of user space code...

Let me know if that can work for you.

Quoted 7 lines
Quoted 3 lines

Thanks,
Mathieu

Hi Mathieu,
That works for product configuration but that would still limit internal testing. Since there is also restriction on accessing debugfs through userspace code, automation won't be able to run recovery/coredump tests.

Ok, please spinoff a new version that follows the guidelines above and we can restart the conversation from there.

Quoted 3 lines

Only other way for us would be to provide these sysfs entries through the platform drivers locally but that would create a lot of mess/redundancy.

Right, this is definitely not the right way to proceed.

Quoted 31 lines
Quoted 31 lines
Quoted 31 lines

'Coredump' and 'Recovery' are critical
interfaces that are required for remoteproc to work on Qualcomm Chipsets.
Coredump configuration needs to be set to "inline" in debug/test build and "disabled" in production builds. Whereas recovery needs to be "disabled" for debugging purposes and "enabled" on production builds.

Changelog:

v1 -> v2:
- Correct the contact name in the sysfs documentation.
- Remove the redundant write documentation for coredump/recovery sysfs
- Add a feature flag to make this interface switch configurable.

Rishabh Bhatnagar (3):
remoteproc: Expose remoteproc configuration through sysfs
remoteproc: Add coredump configuration to sysfs
remoteproc: Add recovery configuration to sysfs

 Documentation/ABI/testing/sysfs-class-remoteproc |  44 ++++++++
 drivers/remoteproc/Kconfig                       |  12 +++
 drivers/remoteproc/remoteproc_debugfs.c          |  10 +-
 drivers/remoteproc/remoteproc_sysfs.c            | 126
+++++++++++++++++++++++
 4 files changed, 190 insertions(+), 2 deletions(-)

--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

#8 lore raw
In reply to Mathieu Poirier
Quoted 10 lines · Mathieu Poirier

Hi Rishabh,

Quoted 6 lines · Rishabh Bhatnagar

From Android R onwards Google has restricted access to debugfs in user and user-debug builds. This restricts access to most of the features exposed through debugfs. This patch series adds a configurable option to move the recovery/coredump interfaces to sysfs. If the feature flag is selected it would move these interfaces to sysfs and remove the equivalent debugfs interface.

Quoted 2 lines

What I meant wast to move the coredump entry from debugfs to sysfs and from there make it available to user space using a kernel config.

Why would we not always make this available in sysfs?

Quoted 3 lines

But thinking further on this it may be better to simply provide an API to set the coredump mode from the platform driver, the same way rproc_coredump_set_elf_info() works.

Being able to invoke these from the platform drivers sounds like a new feature. What would trigger the platform drivers to call this? Or are you perhaps asking for the means of the drivers to be able to select the default mode?

Regarding the default mode, I think it would make sense to make the default "disabled", because this is the most sensible configuration in a "production" environment. And the sysfs means we have a convenient mechanism to configure it, even on production environments.

Quoted 2 lines

That will prevent breaking a fair amount of user space code...

We typically don't guarantee that the debugfs interfaces are stable and if I understand the beginning of you reply you still want to move it from debugfs to sysfs - which I presume would break such scripts in the first place?

I would prefer to see that we don't introduce config options for every little thing, unless there's good reason for it.

Regards,
Bjorn

Quoted 33 lines

Let me know if that can work for you.

Thanks,
Mathieu

Quoted 28 lines

'Coredump' and 'Recovery' are critical
interfaces that are required for remoteproc to work on Qualcomm Chipsets. Coredump configuration needs to be set to "inline" in debug/test build and "disabled" in production builds. Whereas recovery needs to be "disabled" for debugging purposes and "enabled" on production builds.

Changelog:

v1 -> v2:
- Correct the contact name in the sysfs documentation.
- Remove the redundant write documentation for coredump/recovery sysfs
- Add a feature flag to make this interface switch configurable.

Rishabh Bhatnagar (3):
remoteproc: Expose remoteproc configuration through sysfs
remoteproc: Add coredump configuration to sysfs
remoteproc: Add recovery configuration to sysfs

 Documentation/ABI/testing/sysfs-class-remoteproc |  44 ++++++++
 drivers/remoteproc/Kconfig                       |  12 +++
 drivers/remoteproc/remoteproc_debugfs.c          |  10 +-
 drivers/remoteproc/remoteproc_sysfs.c            | 126 +++++++++++++++++++++++
 4 files changed, 190 insertions(+), 2 deletions(-)
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
maintainer
#9 lore raw
Quoted 12 lines · Bjorn Andersson
Quoted 10 lines · Mathieu Poirier

Hi Rishabh,

Quoted 6 lines · Rishabh Bhatnagar

From Android R onwards Google has restricted access to debugfs in user and user-debug builds. This restricts access to most of the features exposed through debugfs. This patch series adds a configurable option to move the recovery/coredump interfaces to sysfs. If the feature flag is selected it would move these interfaces to sysfs and remove the equivalent debugfs interface.

Quoted 4 lines
Quoted 2 lines

What I meant wast to move the coredump entry from debugfs to sysfs and from there make it available to user space using a kernel config.

Why would we not always make this available in sysfs?

At this time the options are in debugfs and vendors can decide to make that available on products if they want to. The idea behind using a kernel configuration once moved to sysfs was to give the same kind of options.

Quoted 9 lines
Quoted 4 lines

But thinking further on this it may be better to simply provide an API to set the coredump mode from the platform driver, the same way rproc_coredump_set_elf_info() works.

Being able to invoke these from the platform drivers sounds like a new feature. What would trigger the platform drivers to call this? Or are you perhaps asking for the means of the drivers to be able to select the default mode?

My ultimate goal is to avoid needlessly stuffing things in sysfs. My hope in suggesting a new API was that platform drivers could recognise the kind of build/environment they operate in and setup the coredump mode accordingly. That would have allowed us to leave debugfs options alone.

Quoted 6 lines

Regarding the default mode, I think it would make sense to make the default "disabled", because this is the most sensible configuration in a "production" environment. And the sysfs means we have a convenient mechanism to configure it, even on production environments.

I am weary of changing something that hasn't been requested.

Quoted 7 lines
Quoted 2 lines

That will prevent breaking a fair amount of user space code...

We typically don't guarantee that the debugfs interfaces are stable and if I understand the beginning of you reply you still want to move it from debugfs to sysfs - which I presume would break such scripts in the first place?

Correct - I am sure that moving coredump and recovery options to sysfs will break user space scripts. Even if debugfs is not part of the ABI it would be nice to avoid disrupting people as much as possible.

Quoted 4 lines

I would prefer to see that we don't introduce config options for every little thing, unless there's good reason for it.

I totally agree. It is with great reluctance that I asked Rishab to proceed the way he did in V3. His usecase makes sense... On the flip side this is pushed down on the kernel community and I really like Christoph's position about fixing Android and leaving the kernel alone.

Quoted 37 lines

Regards,
Bjorn

Quoted 33 lines

Let me know if that can work for you.

Thanks,
Mathieu

Quoted 28 lines

'Coredump' and 'Recovery' are critical
interfaces that are required for remoteproc to work on Qualcomm Chipsets. Coredump configuration needs to be set to "inline" in debug/test build and "disabled" in production builds. Whereas recovery needs to be "disabled" for debugging purposes and "enabled" on production builds.

Changelog:

v1 -> v2:
- Correct the contact name in the sysfs documentation.
- Remove the redundant write documentation for coredump/recovery sysfs
- Add a feature flag to make this interface switch configurable.

Rishabh Bhatnagar (3):
remoteproc: Expose remoteproc configuration through sysfs
remoteproc: Add coredump configuration to sysfs
remoteproc: Add recovery configuration to sysfs

 Documentation/ABI/testing/sysfs-class-remoteproc |  44 ++++++++
 drivers/remoteproc/Kconfig                       |  12 +++
 drivers/remoteproc/remoteproc_debugfs.c          |  10 +-
 drivers/remoteproc/remoteproc_sysfs.c            | 126 +++++++++++++++++++++++
 4 files changed, 190 insertions(+), 2 deletions(-)
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
#10 lore raw
Quoted 60 lines · Mathieu Poirier
Quoted 12 lines · Bjorn Andersson
Quoted 10 lines · Mathieu Poirier

Hi Rishabh,

Quoted 6 lines · Rishabh Bhatnagar

From Android R onwards Google has restricted access to debugfs in user and user-debug builds. This restricts access to most of the features exposed through debugfs. This patch series adds a configurable option to move the recovery/coredump interfaces to sysfs. If the feature flag is selected it would move these interfaces to sysfs and remove the equivalent debugfs interface.

Quoted 4 lines
Quoted 2 lines

What I meant wast to move the coredump entry from debugfs to sysfs and from there make it available to user space using a kernel config.

Why would we not always make this available in sysfs?

At this time the options are in debugfs and vendors can decide to make that available on products if they want to. The idea behind using a kernel configuration once moved to sysfs was to give the same kind of options.

Quoted 9 lines
Quoted 4 lines

But thinking further on this it may be better to simply provide an API to set the coredump mode from the platform driver, the same way rproc_coredump_set_elf_info() works.

Being able to invoke these from the platform drivers sounds like a new feature. What would trigger the platform drivers to call this? Or are you perhaps asking for the means of the drivers to be able to select the default mode?

My ultimate goal is to avoid needlessly stuffing things in sysfs. My hope in suggesting a new API was that platform drivers could recognise the kind of build/environment they operate in and setup the coredump mode accordingly. That would have allowed us to leave debugfs options alone.

Quoted 6 lines

Regarding the default mode, I think it would make sense to make the default "disabled", because this is the most sensible configuration in a "production" environment. And the sysfs means we have a convenient mechanism to configure it, even on production environments.

I am weary of changing something that hasn't been requested.

Quoted 7 lines
Quoted 2 lines

That will prevent breaking a fair amount of user space code...

We typically don't guarantee that the debugfs interfaces are stable and if I understand the beginning of you reply you still want to move it from debugfs to sysfs - which I presume would break such scripts in the first place?

Correct - I am sure that moving coredump and recovery options to sysfs will break user space scripts. Even if debugfs is not part of the ABI it would be nice to avoid disrupting people as much as possible.

Quoted 2 lines
Quoted 8 lines
Quoted 2 lines

I would prefer to see that we don't introduce config options for every little thing, unless there's good reason for it.

I totally agree. It is with great reluctance that I asked Rishab to proceed the way he did in V3. His usecase makes sense... On the flip side this is pushed down on the kernel community and I really like Christoph's position about fixing Android and leaving the kernel alone.

Well, removing debugfs is conscious decision taken by android due to security concerns and there is not we can fix there.
Would it be a terrible idea to have recovery and coredump exposed from both sysfs and debugfs instead of choosing one and breaking userspace code?

Quoted 37 lines
Quoted 37 lines

Regards,
Bjorn

Quoted 33 lines

Let me know if that can work for you.

Thanks,
Mathieu

Quoted 28 lines

'Coredump' and 'Recovery' are critical
interfaces that are required for remoteproc to work on Qualcomm Chipsets. Coredump configuration needs to be set to "inline" in debug/test build and "disabled" in production builds. Whereas recovery needs to be "disabled" for debugging purposes and "enabled" on production builds.

Changelog:

v1 -> v2:
- Correct the contact name in the sysfs documentation.
- Remove the redundant write documentation for coredump/recovery sysfs
- Add a feature flag to make this interface switch configurable.

Rishabh Bhatnagar (3):
remoteproc: Expose remoteproc configuration through sysfs
remoteproc: Add coredump configuration to sysfs
remoteproc: Add recovery configuration to sysfs

 Documentation/ABI/testing/sysfs-class-remoteproc |  44 ++++++++
 drivers/remoteproc/Kconfig                       |  12 +++
 drivers/remoteproc/remoteproc_debugfs.c          |  10 +-
 drivers/remoteproc/remoteproc_sysfs.c            | 126 +++++++++++++++++++++++
 4 files changed, 190 insertions(+), 2 deletions(-)

--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project

#11 lore raw

+android kernel team

Quoted 110 lines · On 2020-09-09 10:27, [email protected] wrote:
Quoted 60 lines · Mathieu Poirier
Quoted 12 lines · Bjorn Andersson
Quoted 10 lines · Mathieu Poirier

Hi Rishabh,

Quoted 6 lines · Rishabh Bhatnagar

From Android R onwards Google has restricted access to debugfs in user and user-debug builds. This restricts access to most of the features exposed through debugfs. This patch series adds a configurable option to move the recovery/coredump interfaces to sysfs. If the feature flag is selected it would move these interfaces to sysfs and remove the equivalent debugfs interface.

Quoted 4 lines
Quoted 2 lines

What I meant wast to move the coredump entry from debugfs to sysfs and from there make it available to user space using a kernel config.

Why would we not always make this available in sysfs?

At this time the options are in debugfs and vendors can decide to make that available on products if they want to. The idea behind using a kernel configuration once moved to sysfs was to give the same kind of options.

Quoted 9 lines
Quoted 4 lines

But thinking further on this it may be better to simply provide an API to set the coredump mode from the platform driver, the same way rproc_coredump_set_elf_info() works.

Being able to invoke these from the platform drivers sounds like a new feature. What would trigger the platform drivers to call this? Or are you perhaps asking for the means of the drivers to be able to select the default mode?

My ultimate goal is to avoid needlessly stuffing things in sysfs. My hope in suggesting a new API was that platform drivers could recognise the kind of build/environment they operate in and setup the coredump mode accordingly. That would have allowed us to leave debugfs options alone.

Quoted 6 lines

Regarding the default mode, I think it would make sense to make the default "disabled", because this is the most sensible configuration in a "production" environment. And the sysfs means we have a convenient mechanism to configure it, even on production environments.

I am weary of changing something that hasn't been requested.

Quoted 7 lines
Quoted 2 lines

That will prevent breaking a fair amount of user space code...

We typically don't guarantee that the debugfs interfaces are stable and if I understand the beginning of you reply you still want to move it from debugfs to sysfs - which I presume would break such scripts in the first place?

Correct - I am sure that moving coredump and recovery options to sysfs will break user space scripts. Even if debugfs is not part of the ABI it would be nice to avoid disrupting people as much as possible.

Quoted 2 lines
Quoted 8 lines
Quoted 2 lines

I would prefer to see that we don't introduce config options for every little thing, unless there's good reason for it.

I totally agree. It is with great reluctance that I asked Rishab to proceed the way he did in V3. His usecase makes sense... On the flip side this is pushed down on the kernel community and I really like Christoph's position about fixing Android and leaving the kernel alone.

Well, removing debugfs is conscious decision taken by android due to security concerns and there is not we can fix there.
Would it be a terrible idea to have recovery and coredump exposed from both sysfs and debugfs instead of choosing one and breaking userspace code?

Quoted 37 lines
Quoted 37 lines

Regards,
Bjorn

Quoted 33 lines

Let me know if that can work for you.

Thanks,
Mathieu

Quoted 28 lines

'Coredump' and 'Recovery' are critical
interfaces that are required for remoteproc to work on Qualcomm Chipsets. Coredump configuration needs to be set to "inline" in debug/test build and "disabled" in production builds. Whereas recovery needs to be "disabled" for debugging purposes and "enabled" on production builds.

Changelog:

v1 -> v2:
- Correct the contact name in the sysfs documentation.
- Remove the redundant write documentation for coredump/recovery sysfs
- Add a feature flag to make this interface switch configurable.

Rishabh Bhatnagar (3):
remoteproc: Expose remoteproc configuration through sysfs
remoteproc: Add coredump configuration to sysfs
remoteproc: Add recovery configuration to sysfs

 Documentation/ABI/testing/sysfs-class-remoteproc |  44 ++++++++
 drivers/remoteproc/Kconfig                       |  12 +++
 drivers/remoteproc/remoteproc_debugfs.c          |  10 +-
 drivers/remoteproc/remoteproc_sysfs.c            | 126 +++++++++++++++++++++++
 4 files changed, 190 insertions(+), 2 deletions(-)

--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project

maintainer
#13 lore raw
In reply to a message not in the archive
Quoted 82 lines · On Wed, Sep 09, 2020 at 05:27:46PM +0000, [email protected] wrote:
Quoted 73 lines · Mathieu Poirier
Quoted 12 lines · Bjorn Andersson
Quoted 10 lines · Mathieu Poirier

Hi Rishabh,

Quoted 6 lines · Rishabh Bhatnagar

From Android R onwards Google has restricted access to debugfs in user and user-debug builds. This restricts access to most of the features exposed through debugfs. This patch series adds a configurable option to move the recovery/coredump interfaces to sysfs. If the feature flag is selected it would move these interfaces to sysfs and remove the equivalent debugfs interface.

Quoted 4 lines
Quoted 2 lines

What I meant wast to move the coredump entry from debugfs to sysfs and from there make it available to user space using a kernel config.

Why would we not always make this available in sysfs?

At this time the options are in debugfs and vendors can decide to make that
available on products if they want to. The idea behind using a kernel configuration once moved to sysfs was to give the same kind of options.

Quoted 10 lines
Quoted 4 lines

But thinking further on this it may be better to simply provide an API to set the coredump mode from the platform driver, the same way rproc_coredump_set_elf_info() works.

Being able to invoke these from the platform drivers sounds like a new feature. What would trigger the platform drivers to call this? Or are you perhaps asking for the means of the drivers to be able to select the
default mode?

My ultimate goal is to avoid needlessly stuffing things in sysfs. My hope in
suggesting a new API was that platform drivers could recognise the kind of
build/environment they operate in and setup the coredump mode accordingly. That
would have allowed us to leave debugfs options alone.

Quoted 7 lines

Regarding the default mode, I think it would make sense to make the default "disabled", because this is the most sensible configuration in a
"production" environment. And the sysfs means we have a convenient mechanism to configure it, even on production environments.

I am weary of changing something that hasn't been requested.

Quoted 9 lines
Quoted 2 lines

That will prevent breaking a fair amount of user space code...

We typically don't guarantee that the debugfs interfaces are stable and
if I understand the beginning of you reply you still want to move it from debugfs to sysfs - which I presume would break such scripts in the
first place?

Correct - I am sure that moving coredump and recovery options to sysfs will
break user space scripts. Even if debugfs is not part of the ABI it would be
nice to avoid disrupting people as much as possible.

Quoted 4 lines

I would prefer to see that we don't introduce config options for every little thing, unless there's good reason for it.

Quoted 8 lines

I totally agree. It is with great reluctance that I asked Rishab to proceed
the way he did in V3. His usecase makes sense... On the flip side this is
pushed down on the kernel community and I really like Christoph's position about
fixing Android and leaving the kernel alone.

Quoted 5 lines

Well, removing debugfs is conscious decision taken by android due to security
concerns and there is not we can fix there.
Would it be a terrible idea to have recovery and coredump exposed from both sysfs and debugfs instead of choosing one and breaking userspace code?

Yes, two interfaces to do the same thing is not acceptable.

That being said Arnaud Pouliquen had the excellent idea of using the newly added remoteproc character device.

Quoted 37 lines
Quoted 37 lines
Quoted 37 lines

Regards,
Bjorn

Quoted 33 lines

Let me know if that can work for you.

Thanks,
Mathieu

Quoted 28 lines

'Coredump' and 'Recovery' are critical
interfaces that are required for remoteproc to work on Qualcomm Chipsets. Coredump configuration needs to be set to "inline" in debug/test build and "disabled" in production builds. Whereas recovery needs to be "disabled" for debugging purposes and "enabled" on production builds.

Changelog:

v1 -> v2:
- Correct the contact name in the sysfs documentation.
- Remove the redundant write documentation for coredump/recovery sysfs
- Add a feature flag to make this interface switch configurable.

Rishabh Bhatnagar (3):
remoteproc: Expose remoteproc configuration through sysfs
remoteproc: Add coredump configuration to sysfs
remoteproc: Add recovery configuration to sysfs

 Documentation/ABI/testing/sysfs-class-remoteproc |  44 ++++++++
 drivers/remoteproc/Kconfig                       |  12 +++
 drivers/remoteproc/remoteproc_debugfs.c          |  10 +-
 drivers/remoteproc/remoteproc_sysfs.c            | 126 +++++++++++++++++++++++
 4 files changed, 190 insertions(+), 2 deletions(-)

--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project

#14 lore raw
In reply to Mathieu Poirier
Quoted 49 lines · Mathieu Poirier
Quoted 12 lines · Bjorn Andersson
Quoted 10 lines · Mathieu Poirier

Hi Rishabh,

Quoted 6 lines · Rishabh Bhatnagar

From Android R onwards Google has restricted access to debugfs in user and user-debug builds. This restricts access to most of the features exposed through debugfs. This patch series adds a configurable option to move the recovery/coredump interfaces to sysfs. If the feature flag is selected it would move these interfaces to sysfs and remove the equivalent debugfs interface.

Quoted 4 lines
Quoted 2 lines

What I meant wast to move the coredump entry from debugfs to sysfs and from there make it available to user space using a kernel config.

Why would we not always make this available in sysfs?

At this time the options are in debugfs and vendors can decide to make that available on products if they want to. The idea behind using a kernel configuration once moved to sysfs was to give the same kind of options.

Quoted 9 lines
Quoted 4 lines

But thinking further on this it may be better to simply provide an API to set the coredump mode from the platform driver, the same way rproc_coredump_set_elf_info() works.

Being able to invoke these from the platform drivers sounds like a new feature. What would trigger the platform drivers to call this? Or are you perhaps asking for the means of the drivers to be able to select the default mode?

My ultimate goal is to avoid needlessly stuffing things in sysfs. My hope in suggesting a new API was that platform drivers could recognise the kind of build/environment they operate in and setup the coredump mode accordingly. That would have allowed us to leave debugfs options alone.

Quoted 6 lines

Regarding the default mode, I think it would make sense to make the default "disabled", because this is the most sensible configuration in a "production" environment. And the sysfs means we have a convenient mechanism to configure it, even on production environments.

I am weary of changing something that hasn't been requested.

Quoted 3 lines
Quoted 2 lines

That will prevent breaking a fair amount of user space code...

Quoted 8 lines
Quoted 4 lines

We typically don't guarantee that the debugfs interfaces are stable and if I understand the beginning of you reply you still want to move it from debugfs to sysfs - which I presume would break such scripts in the first place?

Correct - I am sure that moving coredump and recovery options to sysfs will break user space scripts. Even if debugfs is not part of the ABI it would be nice to avoid disrupting people as much as possible.

Don't move the files, keep them in both places. Lots of systems restrict debugfs, so moving "stable" stuff like this into sysfs makes sense.

thanks,

greg k-h

#3 lore raw

Re: [PATCH v2 2/3] remoteproc: Add coredump configuration to sysfs

In reply to Rishabh Bhatnagar
Quoted 64 lines · Rishabh Bhatnagar

Expose coredump configuration in sysfs under a feature flag. This is useful for systems where access to debugfs might be limited.

---
 Documentation/ABI/testing/sysfs-class-remoteproc | 24 +++++++++
 drivers/remoteproc/remoteproc_debugfs.c          |  4 ++
 drivers/remoteproc/remoteproc_sysfs.c            | 68 ++++++++++++++++++++++++
 3 files changed, 96 insertions(+)
Documentation/ABI/testing/sysfs-class-remoteproc +24 -0
index 36094fb..f6c44fa 100644
@@ -58,3 +58,27 @@ Description:	Remote processor name
 		Reports the name of the remote processor. This can be used by
 		userspace in exactly identifying a remote processor and ease
 		up the usage in modifying the 'firmware' or 'state' files.
+
+What:		/sys/class/remoteproc/.../coredump
+Date:		July 2020
+Contact:	Bjorn Andersson <[email protected]>, Ohad Ben-Cohen <[email protected]>
+Description:	Remote processor coredump configuration
+
+		Reports the coredump configuration of the remote processor,
+		which will be one of:
+
+		"default"
+		"inline"
+		"disabled"
+
+		"default" means when the remote processor's coredump is
+		collected it will be copied to a separate buffer and that
+		buffer is exposed to userspace.
+
+		"inline" means when the remote processor's coredump is
+		collected userspace will directly read from the remote
+		processor's device memory. Extra buffer will not be used to
+		copy the dump. Also recovery process will not proceed until
+		all data is read by usersapce.
+
+		"disabled" means no dump will be collected.
drivers/remoteproc/remoteproc_debugfs.c +2 -0
index 2e3b3e2..48dfd0a 100644
@@ -27,6 +27,7 @@
 /* remoteproc debugfs parent dir */
 static struct dentry *rproc_dbg;
 
+#if (!IS_ENABLED(CONFIG_RPROC_SYSFS_CONFIGURATION_SUPPORT))
 /*
  * A coredump-configuration-to-string lookup table, for exposing a
  * human readable configuration via debugfs. Always keep in sync with
@@ -114,6 +115,7 @@ static const struct file_operations rproc_coredump_fops = {
 	.open = simple_open,
 	.llseek = generic_file_llseek,
 };
+#endif
 
 /*
  * Some remote processors may support dumping trace logs into a shared

drivers/remoteproc/remoteproc_debugfs.c void rproc_create_debug_dir(struct rproc *rproc) · line 433

Quoted 7 lines
drivers/remoteproc/remoteproc_debugfs.c +2 -0
@@ -425,8 +427,10 @@ void rproc_create_debug_dir(struct rproc *rproc)
 			    rproc, &rproc_rsc_table_fops);
 	debugfs_create_file("carveout_memories", 0400, rproc->dbg_dir,
 			    rproc, &rproc_carveouts_fops);
+#if (!IS_ENABLED(CONFIG_RPROC_SYSFS_CONFIGURATION_SUPPORT))
 	debugfs_create_file("coredump", 0600, rproc->dbg_dir,
 			    rproc, &rproc_coredump_fops);
+#endif

Why does sysfs support for this have anything to do if you have a debugfs file present or not? They should both work at the same time if needed, right?

Same for patch 3/3 in this series...

thanks,

greg k-h

#15 lore raw
In reply to Rishabh Bhatnagar

Hi Rishabh,

Quoted 10 lines · Rishabh Bhatnagar

From Android R onwards Google has restricted access to debugfs in user and user-debug builds. This restricts access to most of the features exposed through debugfs. This patch series adds a configurable option to move the recovery/coredump interfaces to sysfs. If the feature flag is selected it would move these interfaces to sysfs and remove the equivalent debugfs interface. 'Coredump' and 'Recovery' are critical interfaces that are required for remoteproc to work on Qualcomm Chipsets. Coredump configuration needs to be set to "inline" in debug/test build and "disabled" in production builds. Whereas recovery needs to be "disabled" for debugging purposes and "enabled" on production builds.

The remoteproc_cdev had been created to respond to some sysfs limitations. I wonder if this evolution should not also be implemented in the cdev. In this case an additional event could be addedd to inform the application that a crash occurred and that a core dump is available.

Of course it's only a suggestion... As it would be a redesign. I let Björn and Mathieu comment.

Regards,
Arnaud

Quoted 19 lines

Changelog:

v1 -> v2:
- Correct the contact name in the sysfs documentation.
- Remove the redundant write documentation for coredump/recovery sysfs
- Add a feature flag to make this interface switch configurable.

Rishabh Bhatnagar (3):
remoteproc: Expose remoteproc configuration through sysfs
remoteproc: Add coredump configuration to sysfs
remoteproc: Add recovery configuration to sysfs

 Documentation/ABI/testing/sysfs-class-remoteproc |  44 ++++++++
 drivers/remoteproc/Kconfig                       |  12 +++
 drivers/remoteproc/remoteproc_debugfs.c          |  10 +-
 drivers/remoteproc/remoteproc_sysfs.c            | 126 +++++++++++++++++++++++
 4 files changed, 190 insertions(+), 2 deletions(-)
#16 lore raw
Quoted 14 lines · Arnaud POULIQUEN

Hi Rishabh,

Quoted 10 lines · Rishabh Bhatnagar

From Android R onwards Google has restricted access to debugfs in user and user-debug builds. This restricts access to most of the features exposed through debugfs. This patch series adds a configurable option to move the recovery/coredump interfaces to sysfs. If the feature flag is selected it would move these interfaces to sysfs and remove the equivalent debugfs interface. 'Coredump' and 'Recovery' are critical interfaces that are required for remoteproc to work on Qualcomm Chipsets. Coredump configuration needs to be set to "inline" in debug/test build and "disabled" in production builds. Whereas recovery needs to be "disabled" for debugging purposes and "enabled" on production builds.

Quoted 1 line

The remoteproc_cdev had been created to respond to some sysfs limitations.

The limitation here is in debugfs not being available on all systems, sysfs is present and I really do like the idea of being able to change these things without having to compile a tool to invoke the ioctl...

Quoted 4 lines

I wonder if this evolution should not also be implemented in the cdev. In this case an additional event could be addedd to inform the application that a crash occurred and that a core dump is available.

Specifically for userspace to know when a coredump is present there's already uevents being sent when the devcoredump is ready. That said, having some means to getting notified about remoteproc state changes does sounds reasonable. If there is a use case we should discuss that.

Quoted 1 line

Of course it's only a suggestion... As it would be a redesign.

A very valid suggestion. I don't think it's a redesign, but more of an extension of what we have today.

Regards,
Bjorn

Quoted 24 lines

I let Björn and Mathieu comment.

Regards,
Arnaud

Quoted 19 lines

Changelog:

v1 -> v2:
- Correct the contact name in the sysfs documentation.
- Remove the redundant write documentation for coredump/recovery sysfs
- Add a feature flag to make this interface switch configurable.

Rishabh Bhatnagar (3):
remoteproc: Expose remoteproc configuration through sysfs
remoteproc: Add coredump configuration to sysfs
remoteproc: Add recovery configuration to sysfs

 Documentation/ABI/testing/sysfs-class-remoteproc |  44 ++++++++
 drivers/remoteproc/Kconfig                       |  12 +++
 drivers/remoteproc/remoteproc_debugfs.c          |  10 +-
 drivers/remoteproc/remoteproc_sysfs.c            | 126 +++++++++++++++++++++++
 4 files changed, 190 insertions(+), 2 deletions(-)
#17 lore raw

Hi Bjorn,

Quoted 16 lines · Bjorn Andersson
Quoted 14 lines · Arnaud POULIQUEN

Hi Rishabh,

Quoted 10 lines · Rishabh Bhatnagar

From Android R onwards Google has restricted access to debugfs in user and user-debug builds. This restricts access to most of the features exposed through debugfs. This patch series adds a configurable option to move the recovery/coredump interfaces to sysfs. If the feature flag is selected it would move these interfaces to sysfs and remove the equivalent debugfs interface. 'Coredump' and 'Recovery' are critical interfaces that are required for remoteproc to work on Qualcomm Chipsets. Coredump configuration needs to be set to "inline" in debug/test build and "disabled" in production builds. Whereas recovery needs to be "disabled" for debugging purposes and "enabled" on production builds.

Quoted 5 lines
Quoted 1 line

The remoteproc_cdev had been created to respond to some sysfs limitations.

The limitation here is in debugfs not being available on all systems, sysfs is present and I really do like the idea of being able to change these things without having to compile a tool to invoke the ioctl...

Right,

Quoted 10 lines
Quoted 5 lines

I wonder if this evolution should not also be implemented in the cdev. In this case an additional event could be addedd to inform the application that a crash occurred and that a core dump is available.

Specifically for userspace to know when a coredump is present there's already uevents being sent when the devcoredump is ready. That said, having some means to getting notified about remoteproc state changes does sounds reasonable. If there is a use case we should discuss that.

The main use case i have in mind is to inform the userspace that the remote processor has crashed. This would allow applications to perform specific action to avoid getting stuck and/or resetting it's environement befor restarting the remote processor and associated IPC.
If i well remember QCOM has this kind of mechanism for its modem but this is implemented in a platform driver.
We would be interested to have something more generic relying on the remoteproc framework.

Thanks,
Arnaud

Quoted 33 lines
Quoted 2 lines

Of course it's only a suggestion... As it would be a redesign.

A very valid suggestion. I don't think it's a redesign, but more of an extension of what we have today.

Regards,
Bjorn

Quoted 24 lines

I let Björn and Mathieu comment.

Regards,
Arnaud

Quoted 19 lines

Changelog:

v1 -> v2:
- Correct the contact name in the sysfs documentation.
- Remove the redundant write documentation for coredump/recovery sysfs
- Add a feature flag to make this interface switch configurable.

Rishabh Bhatnagar (3):
remoteproc: Expose remoteproc configuration through sysfs
remoteproc: Add coredump configuration to sysfs
remoteproc: Add recovery configuration to sysfs

 Documentation/ABI/testing/sysfs-class-remoteproc |  44 ++++++++
 drivers/remoteproc/Kconfig                       |  12 +++
 drivers/remoteproc/remoteproc_debugfs.c          |  10 +-
 drivers/remoteproc/remoteproc_sysfs.c            | 126 +++++++++++++++++++++++
 4 files changed, 190 insertions(+), 2 deletions(-)
#18 lore raw
Quoted 38 lines · Arnaud POULIQUEN

Hi Bjorn,

Quoted 16 lines · Bjorn Andersson
Quoted 14 lines · Arnaud POULIQUEN

Hi Rishabh,

Quoted 10 lines · Rishabh Bhatnagar

From Android R onwards Google has restricted access to debugfs in user and user-debug builds. This restricts access to most of the features exposed through debugfs. This patch series adds a configurable option to move the recovery/coredump interfaces to sysfs. If the feature flag is selected it would move these interfaces to sysfs and remove the equivalent debugfs interface. 'Coredump' and 'Recovery' are critical interfaces that are required for remoteproc to work on Qualcomm Chipsets. Coredump configuration needs to be set to "inline" in debug/test build and "disabled" in production builds. Whereas recovery needs to be "disabled" for debugging purposes and "enabled" on production builds.

Quoted 5 lines
Quoted 1 line

The remoteproc_cdev had been created to respond to some sysfs limitations.

The limitation here is in debugfs not being available on all systems, sysfs is present and I really do like the idea of being able to change these things without having to compile a tool to invoke the ioctl...

Right,

Quoted 10 lines
Quoted 5 lines

I wonder if this evolution should not also be implemented in the cdev. In this case an additional event could be addedd to inform the application that a crash occurred and that a core dump is available.

Specifically for userspace to know when a coredump is present there's already uevents being sent when the devcoredump is ready. That said, having some means to getting notified about remoteproc state changes does sounds reasonable. If there is a use case we should discuss that.

Quoted 9 lines

The main use case i have in mind is to inform the userspace that the remote processor has crashed. This would allow applications to perform specific action to avoid getting stuck and/or resetting it's environement befor restarting the remote processor and associated IPC.
If i well remember QCOM has this kind of mechanism for its modem but this is implemented in a platform driver.
We would be interested to have something more generic relying on the remoteproc framework.

I believe that there is such a notification mechanism implemented by Qualcomm downstream. Upstream we've so far relied on the fact that the interfaces exposed by the various rpmsg_devices would be torn down and re-registered as the remoteproc is restarted.

Same goes with the few cases where we use rpmsg_char, as the channels are going down the IO operations on the rpmsg endpoint fails to allow userspace to detect the shutdown part. Then as the new channels appears userspace will be notified about the newly available channels through the standard uevents.

Regards,
Bjorn

Quoted 36 lines

Thanks,
Arnaud

Quoted 33 lines
Quoted 2 lines

Of course it's only a suggestion... As it would be a redesign.

A very valid suggestion. I don't think it's a redesign, but more of an extension of what we have today.

Regards,
Bjorn

Quoted 24 lines

I let Björn and Mathieu comment.

Regards,
Arnaud

Quoted 19 lines

Changelog:

v1 -> v2:
- Correct the contact name in the sysfs documentation.
- Remove the redundant write documentation for coredump/recovery sysfs
- Add a feature flag to make this interface switch configurable.

Rishabh Bhatnagar (3):
remoteproc: Expose remoteproc configuration through sysfs
remoteproc: Add coredump configuration to sysfs
remoteproc: Add recovery configuration to sysfs

 Documentation/ABI/testing/sysfs-class-remoteproc |  44 ++++++++
 drivers/remoteproc/Kconfig                       |  12 +++
 drivers/remoteproc/remoteproc_debugfs.c          |  10 +-
 drivers/remoteproc/remoteproc_sysfs.c            | 126 +++++++++++++++++++++++
 4 files changed, 190 insertions(+), 2 deletions(-)