leds: mt6360: Add LED driver for MT6360
Subsystems (3)
v10 cover leds: mt6360: Add LED driver for MT6360
[PATCH v10 0/6] leds: mt6360: Add LED driver for MT6360
This patch series add MT6360 LED support contains driver and binding document
Gene Chen (6)
leds: flash: Add flash registration with undefined CONFIG_LEDS_CLASS_FLASH
leds: flash: Fix multicolor no-ops registration by return 0
dt-bindings: leds: Add LED_COLOR_ID_MOONLIGHT definitions
dt-bindings: leds: common: Increase LED_COLOR_ID_* maximum size
dt-bindings: leds: Add bindings for MT6360 LED
leds: mt6360: Add LED driver for MT6360
Documentation/devicetree/bindings/leds/common.yaml | 2 Documentation/devicetree/bindings/leds/leds-mt6360.yaml | 164 +++ drivers/leds/Kconfig | 13 drivers/leds/Makefile | 1 drivers/leds/leds-mt6360.c | 811 ++++++++++++++++ include/dt-bindings/leds/common.h | 1 include/linux/led-class-flash.h | 42 include/linux/led-class-multicolor.h | 42 8 files changed, 1039 insertions(+), 37 deletions(-)
changelogs between v1 & v2
- add led driver with mfd
changelogs between v2 & v3
- independent add led driver
- add dt-binding document
- refactor macros definition for easy to debug
- parse device tree by fwnode
- use devm*ext to register led class device
changelogs between v3 & v4
- fix binding document description
- use GENMASK and add unit postfix to definition
- isink register led class device
changelogs between v4 & v5
- change rgb isink to multicolor control
- add binding reference to mfd yaml
changelogs between v5 & v6
- Use DT to decide RGB LED is multicolor device or indicator device only
changelogs between v6 & v7
- Add binding multicolor device sample code
- Add flash ops mutex lock
- Remove V4L2 init with indicator device
changelogs between v7 & v8
- Add mutex for led fault get ops
- Fix flash and multicolor no-ops return 0
- Add LED_FUNCTION_MOONLIGHT
changelogs between v8 & v9
- reuse api in flash and multicolor header
changelogs between v9 & v10
- add comment for reuse registration functions in flash and multicolor
PATCH v10 1/6 leds: flash: Add flash registration with undefined CONFIG_LEDS_CLASS_FLASH
From: Gene Chen <[email protected]>
Add flash registration with undefined CONFIG_LEDS_CLASS_FLASH, and reuse same registration functions no matter flash class exist or not.
--- include/linux/led-class-flash.h | 42 ++++++++++++++++++++++++++++++++--------- 1 file changed, 33 insertions(+), 9 deletions(-)
include/linux/led-class-flash.h +33 -9
@@ -85,6 +85,7 @@ static inline struct led_classdev_flash *lcdev_to_flcdev( return container_of(lcdev, struct led_classdev_flash, led_cdev); } +#if IS_ENABLED (CONFIG_LEDS_CLASS_FLASH )/** * led_classdev_flash_register_ext - register a new object of LED class with * init data and with support for flash LEDs
@@ -98,12 +99,6 @@ int led_classdev_flash_register_ext(struct device *parent,struct led_classdev_flash *fled_cdev, struct led_init_data *init_data); -static inline int led_classdev_flash_register (struct device *parent, -struct led_classdev_flash *fled_cdev) -{ -return led_classdev_flash_register_ext (parent, fled_cdev,NULL ); -} -/** * led_classdev_flash_unregister - unregisters an object of led_classdev class * with support for flash LEDs
@@ -118,15 +113,44 @@ int devm_led_classdev_flash_register_ext(struct device *parent, struct led_init_data *init_data); +void devm_led_classdev_flash_unregister (struct device *parent, +struct led_classdev_flash *fled_cdev); + +#else + +static inline int led_classdev_flash_register_ext (struct device *parent, +struct led_classdev_flash *fled_cdev, +struct led_init_data *init_data) +{ +return 0 ; +} + +static inline void led_classdev_flash_unregister (struct led_classdev_flash *fled_cdev) {}; +static inline int devm_led_classdev_flash_register_ext (struct device *parent, +struct led_classdev_flash *fled_cdev, +struct led_init_data *init_data) +{ +return 0 ; +} + +static inline void devm_led_classdev_flash_unregister (struct device *parent, +struct led_classdev_flash *fled_cdev) +{}; + +#endif /* IS_ENABLED(CONFIG_LEDS_CLASS_FLASH) */ + +static inline int led_classdev_flash_register (struct device *parent, +struct led_classdev_flash *fled_cdev) +{ +return led_classdev_flash_register_ext (parent, fled_cdev,NULL ); +} +static inline int devm_led_classdev_flash_register (struct device *parent,struct led_classdev_flash *fled_cdev) {return devm_led_classdev_flash_register_ext (parent, fled_cdev,NULL ); } -void devm_led_classdev_flash_unregister (struct device *parent, -struct led_classdev_flash *fled_cdev); -/** * led_set_flash_strobe - setup flash strobe * @fled_cdev: the flash LED to set strobe on
Signature · 1 line
2.7.4
PATCH v10 2/6 leds: flash: Fix multicolor no-ops registration by return 0
In reply to Gene ChenFrom: Gene Chen <[email protected]>
Fix multicolor no-ops registration by return 0,
and reuse same registration functions no matter multicolor class exist or not.
--- include/linux/led-class-multicolor.h | 42 +++++++++++++----------------------- 1 file changed, 15 insertions(+), 27 deletions(-)
include/linux/led-class-multicolor.h +15 -27
@@ -44,12 +44,6 @@ int led_classdev_multicolor_register_ext(struct device *parent,struct led_classdev_mc *mcled_cdev, struct led_init_data *init_data); -static inline int led_classdev_multicolor_register (struct device *parent, -struct led_classdev_mc *mcled_cdev) -{ -return led_classdev_multicolor_register_ext (parent, mcled_cdev,NULL ); -} -/** * led_classdev_multicolor_unregister - unregisters an object of led_classdev * class with support for multicolor LEDs
@@ -68,13 +62,6 @@ int devm_led_classdev_multicolor_register_ext(struct device *parent,struct led_classdev_mc *mcled_cdev, struct led_init_data *init_data); -static inline int devm_led_classdev_multicolor_register (struct device *parent, -struct led_classdev_mc *mcled_cdev) -{ -return devm_led_classdev_multicolor_register_ext (parent, mcled_cdev, -NULL ); -} -void devm_led_classdev_multicolor_unregister (struct device *parent,struct led_classdev_mc *mcled_cdev);#else
@@ -83,27 +70,33 @@ static inline int led_classdev_multicolor_register_ext(struct device *parent, struct led_classdev_mc *mcled_cdev, struct led_init_data *init_data) { - return -EINVAL; -} - -static inline int led_classdev_multicolor_register (struct device *parent, -struct led_classdev_mc *mcled_cdev) -{ -return led_classdev_multicolor_register_ext (parent, mcled_cdev,NULL ); +return 0 ; }static inline void led_classdev_multicolor_unregister (struct led_classdev_mc *mcled_cdev) {};static inline int led_mc_calc_color_components (struct led_classdev_mc *mcled_cdev,enum led_brightness brightness) { -return -EINVAL ; +return 0 ; }static inline int devm_led_classdev_multicolor_register_ext (struct device *parent,struct led_classdev_mc *mcled_cdev,struct led_init_data *init_data) { -return -EINVAL ; +return 0 ; +} + +static inline void devm_led_classdev_multicolor_unregister (struct device *parent, +struct led_classdev_mc *mcled_cdev) +{}; + +#endif /* IS_ENABLED(CONFIG_LEDS_CLASS_MULTICOLOR) */ + +static inline int led_classdev_multicolor_register (struct device *parent, +struct led_classdev_mc *mcled_cdev) +{ +return led_classdev_multicolor_register_ext (parent, mcled_cdev,NULL ); } static inline int devm_led_classdev_multicolor_register(struct device *parent,
@@ -113,9 +106,4 @@ static inline int devm_led_classdev_multicolor_register(struct device *parent, NULL); } -static inline void devm_led_classdev_multicolor_unregister (struct device *parent, -struct led_classdev_mc *mcled_cdev) -{}; - -#endif /* IS_ENABLED(CONFIG_LEDS_CLASS_MULTICOLOR) */ #endif /* _LINUX_MULTICOLOR_LEDS_H_INCLUDED */
Signature · 1 line
2.7.4
PATCH v10 3/6 dt-bindings: leds: Add LED_FUNCTION_MOONLIGHT definitions
In reply to Gene ChenFrom: Gene Chen <[email protected]>
Add LED_FUNCTION_MOONLIGHT definitions
--- include/dt-bindings/leds/common.h | 1 + 1 file changed, 1 insertion(+)
include/dt-bindings/leds/common.h +1 -0
@@ -78,6 +78,7 @@#define LED_FUNCTION_INDICATOR "indicator"#define LED_FUNCTION_LAN "lan"#define LED_FUNCTION_MAIL "mail" +#define LED_FUNCTION_MOONLIGHT "moonlight"#define LED_FUNCTION_MTD "mtd"#define LED_FUNCTION_PANIC "panic"#define LED_FUNCTION_PROGRAMMING "programming"
Signature · 1 line
2.7.4
PATCH v10 4/6 dt-bindings: leds: common: Increase LED_COLOR_ID_* maximum size
In reply to Gene ChenFrom: Gene Chen <[email protected]>
Increase LED_COLOR_ID maximum size for LED_COLOR_ID_RGB
--- Documentation/devicetree/bindings/leds/common.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/devicetree/bindings/leds/common.yaml +1 -1
@@ -43,7 +43,7 @@ properties: LED_COLOR_ID available, add a new one. $ref: /schemas/types.yaml#definitions/uint32 minimum: 0 - maximum: 8 + maximum: 9 function-enumerator: description:
Signature · 1 line
2.7.4
PATCH v10 5/6 dt-bindings: leds: Add bindings for MT6360 LED
In reply to Gene ChenFrom: Gene Chen <[email protected]>
Add bindings document for LED support on MT6360 PMIC
--- .../devicetree/bindings/leds/leds-mt6360.yaml | 164 +++++++++++++++++++++ 1 file changed, 164 insertions(+) create mode 100644 Documentation/devicetree/bindings/leds/leds-mt6360.yaml
Documentation/devicetree/bindings/leds/leds-mt6360.yaml new file +164 -0
@@ -0,0 +1,164 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/leds/leds-mt6360.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: LED driver for MT6360 PMIC from MediaTek Integrated. + +maintainers: + - Gene Chen <[email protected]> + +description: | + This module is part of the MT6360 MFD device. + see Documentation/devicetree/bindings/mfd/mt6360.yaml + Add MT6360 LED driver include 2-channel Flash LED with torch/strobe mode, + and 4-channel RGB LED support Register/Flash/Breath Mode + +properties: + compatible: + const: mediatek,mt6360-led + + "#address-cells": + const: 1 + + "#size-cells": + const: 0 + +patternProperties: + "^led@[0-6]$": + type: object + $ref: common.yaml# + description: + Properties for a single LED. + + properties: + reg: + description: Index of the LED. + enum: + - 0 # LED output INDICATOR1_RED + - 1 # LED output INDICATOR1_GREEN + - 2 # LED output INDICATOR1_BLUE + - 3 # LED output INDICATOR2_ML + - 4 # LED output FLED1 + - 5 # LED output FLED2 + - 6 # LED output MULTICOLOR + +unevaluatedProperties: false + +required: + - compatible + - "#address-cells" + - "#size-cells" + +additionalProperties: false + +examples: + - | + #include <dt-bindings/leds/common.h> + led-controller { + compatible = "mediatek,mt6360-led"; + #address-cells = <1>; + #size-cells = <0>; + + led@3 { + reg = <3>; + function = LED_FUNCTION_MOONLIGHT; + color = <LED_COLOR_ID_WHITE>; + led-max-microamp = <150000>; + }; + led@4 { + reg = <4>; + function = LED_FUNCTION_FLASH; + color = <LED_COLOR_ID_WHITE>; + function-enumerator = <1>; + led-max-microamp = <200000>; + flash-max-microamp = <500000>; + flash-max-timeout-us = <1024000>; + }; + led@5 { + reg = <5>; + function = LED_FUNCTION_FLASH; + color = <LED_COLOR_ID_WHITE>; + function-enumerator = <2>; + led-max-microamp = <200000>; + flash-max-microamp = <500000>; + flash-max-timeout-us = <1024000>; + }; + led@6 { + reg = <6>; + function = LED_FUNCTION_INDICATOR; + color = <LED_COLOR_ID_RGB>; + led-max-microamp = <24000>; + #address-cells = <1>; + #size-cells = <0>; + + led@0 { + reg = <0>; + function = LED_FUNCTION_INDICATOR; + color = <LED_COLOR_ID_RED>; + }; + led@1 { + reg = <1>; + function = LED_FUNCTION_INDICATOR; + color = <LED_COLOR_ID_GREEN>; + }; + led@2 { + reg = <2>; + function = LED_FUNCTION_INDICATOR; + color = <LED_COLOR_ID_BLUE>; + }; + }; + }; + + - | + + led-controller { + compatible = "mediatek,mt6360-led"; + #address-cells = <1>; + #size-cells = <0>; + + led@0 { + reg = <0>; + function = LED_FUNCTION_INDICATOR; + color = <LED_COLOR_ID_RED>; + led-max-microamp = <24000>; + }; + led@1 { + reg = <1>; + function = LED_FUNCTION_INDICATOR; + color = <LED_COLOR_ID_GREEN>; + led-max-microamp = <24000>; + }; + led@2 { + reg = <2>; + function = LED_FUNCTION_INDICATOR; + color = <LED_COLOR_ID_BLUE>; + led-max-microamp = <24000>; + }; + led@3 { + reg = <3>; + function = LED_FUNCTION_MOONLIGHT; + color = <LED_COLOR_ID_WHITE>; + led-max-microamp = <150000>; + }; + led@4 { + reg = <4>; + function = LED_FUNCTION_FLASH; + color = <LED_COLOR_ID_WHITE>; + function-enumerator = <1>; + led-max-microamp = <200000>; + flash-max-microamp = <500000>; + flash-max-timeout-us = <1024000>; + }; + led@5 { + reg = <5>; + function = LED_FUNCTION_FLASH; + color = <LED_COLOR_ID_WHITE>; + function-enumerator = <2>; + led-max-microamp = <200000>; + flash-max-microamp = <500000>; + flash-max-timeout-us = <1024000>; + }; + }; +...
Signature · 1 line
2.7.4
PATCH v10 6/6 leds: mt6360: Add LED driver for MT6360
In reply to Gene ChenFrom: Gene Chen <[email protected]>
Add MT6360 LED driver include 2-channel Flash LED with torch/strobe mode, 3-channel RGB LED support Register/Flash/Breath Mode, and 1-channel for moonlight LED.
--- drivers/leds/Kconfig | 13 + drivers/leds/Makefile | 1 + drivers/leds/leds-mt6360.c | 811 +++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 825 insertions(+) create mode 100644 drivers/leds/leds-mt6360.c
drivers/leds/Kconfig +13 -0
@@ -271,6 +271,19 @@ config LEDS_MT6323 This option enables support for on-chip LED drivers found on Mediatek MT6323 PMIC. +config LEDS_MT6360 + tristate "LED Support for Mediatek MT6360 PMIC" + depends on LEDS_CLASS && OF + depends on LEDS_CLASS_FLASH || !LEDS_CLASS_FLASH + depends on LEDS_CLASS_MULTICOLOR || !LEDS_CLASS_MULTICOLOR + depends on V4L2_FLASH_LED_CLASS || !V4L2_FLASH_LED_CLASS + depends on MFD_MT6360 + help + This option enables support for dual Flash LED drivers found on + Mediatek MT6360 PMIC. + Independent current sources supply for each flash LED support torch + and strobe mode. + config LEDS_S3C24XX tristate "LED Support for Samsung S3C24XX GPIO LEDs" depends on LEDS_CLASS
drivers/leds/Makefile +1 -0
@@ -66,6 +66,7 @@ obj-$(CONFIG_LEDS_MIKROTIK_RB532) += leds-rb532.o obj-$(CONFIG_LEDS_MLXCPLD) += leds-mlxcpld.o obj-$(CONFIG_LEDS_MLXREG) += leds-mlxreg.o obj-$(CONFIG_LEDS_MT6323) += leds-mt6323.o +obj-$(CONFIG_LEDS_MT6360) += leds-mt6360.o obj-$(CONFIG_LEDS_NET48XX) += leds-net48xx.o obj-$(CONFIG_LEDS_NETXBIG) += leds-netxbig.o obj-$(CONFIG_LEDS_NIC78BX) += leds-nic78bx.o
drivers/leds/leds-mt6360.c new file +811 -0
811 lines not on this page · raw message
Signature · 1 line
2.7.4
Re: [PATCH v10 5/6] dt-bindings: leds: Add bindings for MT6360 LED
In reply to Gene ChenHi Gene,
Quoted 48 lines · Gene Chen
From: Gene Chen <[email protected]>
Add bindings document for LED support on MT6360 PMIC
Signed-off-by Gene Chen <[email protected]>--- .../devicetree/bindings/leds/leds-mt6360.yaml | 164 +++++++++++++++++++++ 1 file changed, 164 insertions(+)create mode 100644
Documentation/devicetree/bindings/leds/leds-mt6360.yamlDocumentation/devicetree/bindings/leds/leds-mt6360.yaml new file +32
-0@@ -0,0 +1,164 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/leds/leds-mt6360.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: LED driver for MT6360 PMIC from MediaTek Integrated. + +maintainers: + - Gene Chen <[email protected]> + +description: | + This module is part of the MT6360 MFD device. + see Documentation/devicetree/bindings/mfd/mt6360.yaml + Add MT6360 LED driver include 2-channel Flash LED with torch/strobe mode, + and 4-channel RGB LED support Register/Flash/Breath Mode + +properties: + compatible: + const: mediatek,mt6360-led + + "#address-cells": + const: 1 + + "#size-cells": + const: 0 + +patternProperties: + "^led@[0-6]$": + type: object + $ref: common.yaml# + description:
Documentation/devicetree/bindings/leds/leds-mt6360.yaml line 42
Quoted 10 lines
Documentation/devicetree/bindings/leds/leds-mt6360.yaml new file +10
-0+ Properties for a single LED. + + properties: + reg: + description: Index of the LED. + enum: + - 0 # LED output INDICATOR1_RED + - 1 # LED output INDICATOR1_GREEN + - 2 # LED output INDICATOR1_BLUE + - 3 # LED output INDICATOR2_
These LED output descriptions look odd.
In the driver you have:
enum {
MT6360_LED_ISNK1 = 0,
MT6360_LED_ISNK2,
MT6360_LED_ISNK3,
MT6360_LED_ISNKML
...I think the same names should be used for DT reg property documentation:
- 0 # LED output ISNK1
- 1 # LED output ISNK2
- 2 # LED output ISNK3
- 3 # LED output ISNKML
Here you're describing hardware, i.e. current sinks as they are defined in the device documentation, and not the functions you're assigning in DT to the connected LEDs.
Documentation/devicetree/bindings/leds/leds-mt6360.yaml line 45
Quoted 3 lines
Documentation/devicetree/bindings/leds/leds-mt6360.yaml new file +3
-0+ - 4 # LED output FLED1 + - 5 # LED output FLED2 + - 6 # LED output MULTICOLOR
This last enum is also disputable, since it is driver specific, and not hardware specific. Actually you should rather check LED color id and basing on that treat the LED as multicolor (for LED_COLOR_ID_RGB). See drivers/leds/leds-lp55xx-common.c for a reference.
Quoted 10 lines
Documentation/devicetree/bindings/leds/leds-mt6360.yaml new file +10
-0+unevaluatedProperties: false + +required: + - compatible + - "#address-cells" + - "#size-cells" + +additionalProperties: false + +examples:
Documentation/devicetree/bindings/leds/leds-mt6360.yaml
Quoted 10 lines
Documentation/devicetree/bindings/leds/leds-mt6360.yaml new file +10
-0+ - | + #include <dt-bindings/leds/common.h> + led-controller { + compatible = "mediatek,mt6360-led"; + #address-cells = <1>; + #size-cells = <0>; + + led@3 { + reg = <3>; + function
= LED_FUNCTION_MOONLIGHT;
Quoted 22 lines
Documentation/devicetree/bindings/leds/leds-mt6360.yaml new file +22
-0+ color = <LED_COLOR_ID_WHITE>; + led-max-microamp = <150000>; + }; + led@4 { + reg = <4>; + function = LED_FUNCTION_FLASH; + color = <LED_COLOR_ID_WHITE>; + function-enumerator = <1>; + led-max-microamp = <200000>; + flash-max-microamp = <500000>; + flash-max-timeout-us = <1024000>; + }; + led@5 { + reg = <5>; + function = LED_FUNCTION_FLASH; + color = <LED_COLOR_ID_WHITE>; + function-enumerator = <2>; + led-max-microamp = <200000>; + flash-max-microamp = <500000>; + flash-max-timeout-us = <1024000>; + }; + led@6 {
Documentation/devicetree/bindings/leds/leds-mt6360.yaml line 98
Quoted 10 lines
Documentation/devicetree/bindings/leds/leds-mt6360.yaml new file +10
-0+ reg = <6>; + function = LED_FUNCTION_INDICATOR; + color = <LED_COLOR_ID_RGB>; + led-max-microamp = <24000>; + #address-cells = <1>; + #size-cells = <0>; + + led@0 { + reg = <0>; + function = LED_FUNCTION_INDICATOR;
The function is unused in case of the multicolor subleds. Please drop it from here.
Documentation/devicetree/bindings/leds/leds-mt6360.yaml line 103
Quoted 5 lines
Documentation/devicetree/bindings/leds/leds-mt6360.yaml new file +5
-0+ color = <LED_COLOR_ID_RED>; + }; + led@1 { + reg = <1>; + function = LED_FUNCTION_INDICATOR;
Ditto.
Documentation/devicetree/bindings/leds/leds-mt6360.yaml line 108
Quoted 5 lines
Documentation/devicetree/bindings/leds/leds-mt6360.yaml new file +5
-0+ color = <LED_COLOR_ID_GREEN>; + }; + led@2 { + reg = <2>; + function = LED_FUNCTION_INDICATOR;
Ditto.
Quoted 57 lines
Documentation/devicetree/bindings/leds/leds-mt6360.yaml new file +56
-0+ color = <LED_COLOR_ID_BLUE>; + }; + }; + }; + + - | + + led-controller { + compatible = "mediatek,mt6360-led"; + #address-cells = <1>; + #size-cells = <0>; + + led@0 { + reg = <0>; + function = LED_FUNCTION_INDICATOR; + color = <LED_COLOR_ID_RED>; + led-max-microamp = <24000>; + }; + led@1 { + reg = <1>; + function = LED_FUNCTION_INDICATOR; + color = <LED_COLOR_ID_GREEN>; + led-max-microamp = <24000>; + }; + led@2 { + reg = <2>; + function = LED_FUNCTION_INDICATOR; + color = <LED_COLOR_ID_BLUE>; + led-max-microamp = <24000>; + }; + led@3 { + reg = <3>; + function = LED_FUNCTION_MOONLIGHT; + color = <LED_COLOR_ID_WHITE>; + led-max-microamp = <150000>; + }; + led@4 { + reg = <4>; + function = LED_FUNCTION_FLASH; + color = <LED_COLOR_ID_WHITE>; + function-enumerator = <1>; + led-max-microamp = <200000>; + flash-max-microamp = <500000>; + flash-max-timeout-us = <1024000>; + }; + led@5 { + reg = <5>; + function = LED_FUNCTION_FLASH; + color = <LED_COLOR_ID_WHITE>; + function-enumerator = <2>; + led-max-microamp = <200000>; + flash-max-microamp = <500000>; + flash-max-timeout-us = <1024000>; + }; + }; +...
Signature · 7 lines
Best regards, Jacek Anaszewski _______________________________________________ Linux-mediatek mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-mediatek
Rob Herring
maintainerRe: [PATCH v10 5/6] dt-bindings: leds: Add bindings for MT6360 LED
In reply to Gene ChenQuoted 10 lines · Gene Chen
From: Gene Chen <[email protected]>
Add bindings document for LED support on MT6360 PMIC
Signed-off-by Gene Chen <[email protected]>--- .../devicetree/bindings/leds/leds-mt6360.yaml | 164 +++++++++++++++++++++ 1 file changed, 164 insertions(+) create mode 100644 Documentation/devicetree/bindings/leds/leds-mt6360.yaml
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:./Documentation/devicetree/bindings/leds/leds-mt6360.yaml:57:2: [warning] wrong indentation: expected 2 but found 1 (indentation)
dtschema/dtc warnings/errors:
See https://patchwork.ozlabs.org/patch/1406971
The base for the patch is generally the last rc1. Any dependencies should be noted.
If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date:
pip3 install dtschema --upgrade
Please check and re-submit.
_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek
Re: [PATCH v10 3/6] dt-bindings: leds: Add LED_FUNCTION_MOONLIGHT definitions
In reply to Gene ChenQuoted 10 lines · Gene Chen
From: Gene Chen <[email protected]>
Add
LED_FUNCTION_MOONLIGHTdefinitionsSigned-off-by Gene Chen <[email protected]>Acked-by Jacek Anaszewski <[email protected]>--- include/dt-bindings/leds/common.h | 1 + 1 file changed, 1 insertion(+)
_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek
Rob Herring
maintainerRe: [PATCH v10 4/6] dt-bindings: leds: common: Increase LED_COLOR_ID_* maximum size
In reply to Gene ChenQuoted 14 lines · Gene Chen
From: Gene Chen <[email protected]>
Increase
LED_COLOR_IDmaximum size forLED_COLOR_ID_RGBSigned-off-by Gene Chen <[email protected]>--- Documentation/devicetree/bindings/leds/common.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)Documentation/devicetree/bindings/leds/common.yaml +0
-0
Documentation/devicetree/bindings/leds/common.yaml properties: · line 46
Quoted 5 lines
Documentation/devicetree/bindings/leds/common.yaml +1
-1@@ -43,7 +43,7 @@ properties: LED_COLOR_ID available, add a new one. $ref: /schemas/types.yaml#definitions/uint32 minimum: 0 - maximum: 8 + maximum: 9
Already in linux-next.
Quoted 6 lines
Documentation/devicetree/bindings/leds/common.yaml +0
-0function-enumerator: description:Signature · 1 line
2.7.4
_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek