drivers: qcom: rpmh-rsc: Do not read back the register write on trigger
Subsystems (2)
PATCH v2 1/1 drivers: qcom: rpmh-rsc: Do not read back the register write on trigger
From: Lina Iyer <[email protected]>
When triggering a TCS to send its contents, reading back the trigger value may return an incorrect value. That is because, writing the trigger may raise an interrupt which could be handled immediately and the trigger value could be reset in the interrupt handler.
A write_tcs_reg_sync() would read back the value that is written and try to match it to the value written to ensure that the value is written, but if that value is different, we may see false error for same.
---
Changes in v2:
- Add Fixes tag
- Add Reviewed-by tag
--- drivers/soc/qcom/rpmh-rsc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/soc/qcom/rpmh-rsc.c +1 -1
@@ -364,7 +364,7 @@ static void __tcs_set_trigger(struct rsc_drv *drv, int tcs_id, bool trigger) enable =TCS_AMC_MODE_ENABLE ;write_tcs_reg_sync (drv,RSC_DRV_CONTROL , tcs_id, enable); enable |=TCS_AMC_MODE_TRIGGER ; -write_tcs_reg_sync (drv,RSC_DRV_CONTROL , tcs_id, enable); +write_tcs_reg (drv,RSC_DRV_CONTROL , tcs_id, enable); } }
Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
This patch was applied to qcom/linux.git (refs/heads/for-next):
Hello:
This patch was applied to qcom/linux.git (refs/heads/for-next):
Quoted 8 lines · On Tue, 29 Dec 2020 14:03:21 +0530 you wrote:
From: Lina Iyer <[email protected]>
When triggering a TCS to send its contents, reading back the trigger value may return an incorrect value. That is because, writing the trigger may raise an interrupt which could be handled immediately and the trigger value could be reset in the interrupt handler.
[...]
Here is the summary with links:
- [v2] drivers: qcom: rpmh-rsc: Do not read back the register write on trigger
https://git.kernel.org/qcom/c/e1d8008179fe
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html