Introduce hba performance monitoring sysfs nodes
v2 cover Introduce hba performance monitoring sysfs nodes
Add a new sysfs group which has nodes to monitor data/request transfer performance. This sysfs group has nodes showing total sectors/requests transferred, total busy time spent and max/min/avg/sum latencies. This group can be enhanced later to show more UFS driver layer performance data during runtime.
It works like:/sys/bus/platform/drivers/ufshcd/*/monitor # echo 4096 > monitor_chunk_size /sys/bus/platform/drivers/ufshcd/*/monitor # echo 1 > monitor_enable /sys/bus/platform/drivers/ufshcd/*/monitor # grep ^ /dev/null * monitor_chunk_size:4096
monitor_enable:1
read_nr_requests:17
read_req_latency_avg:169
read_req_latency_max:594
read_req_latency_min:66
read_req_latency_sum:2887
read_total_busy:2639
read_total_sectors:136
write_nr_requests:116
write_req_latency_avg:440
write_req_latency_max:4921
write_req_latency_min:23
write_req_latency_sum:51052
write_total_busy:19584
write_total_sectors:928
Can Guo (2):
scsi: ufs: Introduce hba performance monitor sysfs nodes
scsi: ufs: Add support for hba performance monitor
Documentation/ABI/testing/sysfs-driver-ufs | 126 +++++++++++++++ drivers/scsi/ufs/ufs-sysfs.c | 237 +++++++++++++++++++++++++++++ drivers/scsi/ufs/ufshcd.c | 62 ++++++++ drivers/scsi/ufs/ufshcd.h | 21 +++ 4 files changed, 446 insertions(+)
Signature · 1 line
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.
PATCH v2 1/2 scsi: ufs: Introduce hba performance monitor sysfs nodes
Add a new sysfs group which has nodes to monitor data/request transfer performance. This sysfs group has nodes showing total sectors/requests transferred, total busy time spent and max/min/avg/sum latencies. This group can be enhanced later to show more UFS driver layer performance statistics data during runtime.
--- drivers/scsi/ufs/ufs-sysfs.c | 237 +++++++++++++++++++++++++++++++++++++++++++ drivers/scsi/ufs/ufshcd.c | 62 +++++++++++ drivers/scsi/ufs/ufshcd.h | 21 ++++ 3 files changed, 320 insertions(+)
drivers/scsi/ufs/ufs-sysfs.c +237 -0
@@ -278,6 +278,242 @@ static const struct attribute_group ufs_sysfs_default_group = { .attrs = ufs_sysfs_ufshcd_attrs, }; +static ssize_t monitor_enable_show (struct device *dev, +struct device_attribute *attr,char *buf) +{ +struct ufs_hba *hba =dev_get_drvdata (dev); + +return sysfs_emit (buf,"%d\n" , hba->monitor.enabled); +} + +static ssize_t monitor_enable_store (struct device *dev, +struct device_attribute *attr, +const char *buf,size_t count) +{ +struct ufs_hba *hba =dev_get_drvdata (dev); +unsigned long value, flags; + +if (kstrtoul (buf,0 , &value)) +return -EINVAL ; + + value = !!value; +spin_lock_irqsave (hba->host->host_lock, flags); +if (value == hba->monitor.enabled) + goto out_unlock; + +if (!value) { +memset (&hba->monitor,0 ,sizeof (hba->monitor)); + }else { + hba->monitor.enabled = true; + hba->monitor.enabled_ts =ktime_get (); + } + +out_unlock: +spin_unlock_irqrestore (hba->host->host_lock, flags); +return count; +} + +static ssize_t monitor_chunk_size_show (struct device *dev, +struct device_attribute *attr,char *buf) +{ +struct ufs_hba *hba =dev_get_drvdata (dev); + +return sysfs_emit (buf,"%lu\n" , hba->monitor.chunk_size); +} + +static ssize_t monitor_chunk_size_store (struct device *dev, +struct device_attribute *attr, +const char *buf,size_t count) +{ +struct ufs_hba *hba =dev_get_drvdata (dev); +unsigned long value, flags; + +if (kstrtoul (buf,0 , &value)) +return -EINVAL ; + +spin_lock_irqsave (hba->host->host_lock, flags); +/* Only allow chunk size change when monitor is disabled */ +if (!hba->monitor.enabled) + hba->monitor.chunk_size = value; +spin_unlock_irqrestore (hba->host->host_lock, flags); +return count; +} + +static ssize_t read_total_sectors_show (struct device *dev, +struct device_attribute *attr,char *buf) +{ +struct ufs_hba *hba =dev_get_drvdata (dev); + +return sysfs_emit (buf,"%lu\n" , hba->monitor.nr_sec_rw[READ ]); +} + +static ssize_t read_total_busy_show (struct device *dev, +struct device_attribute *attr,char *buf) +{ +struct ufs_hba *hba =dev_get_drvdata (dev); + +return sysfs_emit (buf,"%llu\n" , +ktime_to_us (hba->monitor.total_busy[READ ])); +} + +static ssize_t read_nr_requests_show (struct device *dev, +struct device_attribute *attr,char *buf) +{ +struct ufs_hba *hba =dev_get_drvdata (dev); + +return sysfs_emit (buf,"%lu\n" , hba->monitor.nr_req[READ ]); +} + +static ssize_t read_req_latency_avg_show (struct device *dev, +struct device_attribute *attr, +char *buf) +{ +struct ufs_hba *hba =dev_get_drvdata (dev); +struct ufs_hba_monitor *m = &hba->monitor; + +return sysfs_emit (buf,"%llu\n" , +ktime_to_us (m->lat_sum[READ ]) / m->nr_req[READ ]); +} + +static ssize_t read_req_latency_max_show (struct device *dev, +struct device_attribute *attr, +char *buf) +{ +struct ufs_hba *hba =dev_get_drvdata (dev); + +return sysfs_emit (buf,"%llu\n" , +ktime_to_us (hba->monitor.lat_max[READ ])); +} + +static ssize_t read_req_latency_min_show (struct device *dev, +struct device_attribute *attr, +char *buf) +{ +struct ufs_hba *hba =dev_get_drvdata (dev); + +return sysfs_emit (buf,"%llu\n" , +ktime_to_us (hba->monitor.lat_min[READ ])); +} + +static ssize_t read_req_latency_sum_show (struct device *dev, +struct device_attribute *attr, +char *buf) +{ +struct ufs_hba *hba =dev_get_drvdata (dev); + +return sysfs_emit (buf,"%llu\n" , +ktime_to_us (hba->monitor.lat_sum[READ ])); +} + +static ssize_t write_total_sectors_show (struct device *dev, +struct device_attribute *attr, +char *buf) +{ +struct ufs_hba *hba =dev_get_drvdata (dev); + +return sysfs_emit (buf,"%lu\n" , hba->monitor.nr_sec_rw[WRITE ]); +} + +static ssize_t write_total_busy_show (struct device *dev, +struct device_attribute *attr,char *buf) +{ +struct ufs_hba *hba =dev_get_drvdata (dev); + +return sysfs_emit (buf,"%llu\n" , +ktime_to_us (hba->monitor.total_busy[WRITE ])); +} + +static ssize_t write_nr_requests_show (struct device *dev, +struct device_attribute *attr,char *buf) +{ +struct ufs_hba *hba =dev_get_drvdata (dev); + +return sysfs_emit (buf,"%lu\n" , hba->monitor.nr_req[WRITE ]); +} + +static ssize_t write_req_latency_avg_show (struct device *dev, +struct device_attribute *attr, +char *buf) +{ +struct ufs_hba *hba =dev_get_drvdata (dev); +struct ufs_hba_monitor *m = &hba->monitor; + +return sysfs_emit (buf,"%llu\n" , +ktime_to_us (m->lat_sum[WRITE ]) / m->nr_req[WRITE ]); +} + +static ssize_t write_req_latency_max_show (struct device *dev, +struct device_attribute *attr, +char *buf) +{ +struct ufs_hba *hba =dev_get_drvdata (dev); + +return sysfs_emit (buf,"%llu\n" , +ktime_to_us (hba->monitor.lat_max[WRITE ])); +} + +static ssize_t write_req_latency_min_show (struct device *dev, +struct device_attribute *attr, +char *buf) +{ +struct ufs_hba *hba =dev_get_drvdata (dev); + +return sysfs_emit (buf,"%llu\n" , +ktime_to_us (hba->monitor.lat_min[WRITE ])); +} + +static ssize_t write_req_latency_sum_show (struct device *dev, +struct device_attribute *attr, +char *buf) +{ +struct ufs_hba *hba =dev_get_drvdata (dev); + +return sysfs_emit (buf,"%llu\n" , +ktime_to_us (hba->monitor.lat_sum[WRITE ])); +} + +static DEVICE_ATTR_RW (monitor_enable); +static DEVICE_ATTR_RW (monitor_chunk_size); +static DEVICE_ATTR_RO (read_total_sectors); +static DEVICE_ATTR_RO (read_total_busy); +static DEVICE_ATTR_RO (read_nr_requests); +static DEVICE_ATTR_RO (read_req_latency_avg); +static DEVICE_ATTR_RO (read_req_latency_max); +static DEVICE_ATTR_RO (read_req_latency_min); +static DEVICE_ATTR_RO (read_req_latency_sum); +static DEVICE_ATTR_RO (write_total_sectors); +static DEVICE_ATTR_RO (write_total_busy); +static DEVICE_ATTR_RO (write_nr_requests); +static DEVICE_ATTR_RO (write_req_latency_avg); +static DEVICE_ATTR_RO (write_req_latency_max); +static DEVICE_ATTR_RO (write_req_latency_min); +static DEVICE_ATTR_RO (write_req_latency_sum); + +static struct attribute *ufs_sysfs_monitor_attrs[] = { + &dev_attr_monitor_enable.attr, + &dev_attr_monitor_chunk_size.attr, + &dev_attr_read_total_sectors.attr, + &dev_attr_read_total_busy.attr, + &dev_attr_read_nr_requests.attr, + &dev_attr_read_req_latency_avg.attr, + &dev_attr_read_req_latency_max.attr, + &dev_attr_read_req_latency_min.attr, + &dev_attr_read_req_latency_sum.attr, + &dev_attr_write_total_sectors.attr, + &dev_attr_write_total_busy.attr, + &dev_attr_write_nr_requests.attr, + &dev_attr_write_req_latency_avg.attr, + &dev_attr_write_req_latency_max.attr, + &dev_attr_write_req_latency_min.attr, + &dev_attr_write_req_latency_sum.attr, +NULL +}; + +static const struct attribute_group ufs_sysfs_monitor_group = { + .name ="monitor" , + .attrs = ufs_sysfs_monitor_attrs, +}; + static ssize_t ufs_sysfs_read_desc_param(struct ufs_hba *hba, enum desc_idn desc_id, u8 desc_index,
@@ -881,6 +1117,7 @@ static const struct attribute_group ufs_sysfs_attributes_group = {static const struct attribute_group *ufs_sysfs_groups[] = { &ufs_sysfs_default_group, + &ufs_sysfs_monitor_group, &ufs_sysfs_device_descriptor_group, &ufs_sysfs_interconnect_descriptor_group, &ufs_sysfs_geometry_descriptor_group,
drivers/scsi/ufs/ufshcd.c +62 -0
80 lines not on this page · raw message
drivers/scsi/ufs/ufshcd.h +21 -0
@@ -645,6 +645,25 @@ struct ufs_hba_variant_params {u32 wb_flush_threshold; }; +struct ufs_hba_monitor { +unsigned long chunk_size; + +unsigned long nr_sec_rw[2 ]; +ktime_t total_busy[2 ]; + +unsigned long nr_req[2 ]; +/* latencies*/ +ktime_t lat_sum[2 ]; +ktime_t lat_max[2 ]; +ktime_t lat_min[2 ]; + +u32 nr_queued[2 ]; +ktime_t busy_start_ts[2 ]; + +ktime_t enabled_ts; +bool enabled; +}; +/** * struct ufs_hba - per adapter private structure * @mmio_base: UFSHCI base register address
@@ -832,6 +851,8 @@ struct ufs_hba {struct request_queue *bsg_queue;struct delayed_work rpm_dev_flush_recheck_work; +struct ufs_hba_monitor monitor; +#ifdef CONFIG_SCSI_UFS_CRYPTO union ufs_crypto_capabilities crypto_capabilities;union ufs_crypto_cap_entry *crypto_cap_array;
Signature · 1 line
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.
PATCH v2 2/2 scsi: ufs: Add support for hba performance monitor
In reply to Can GuoAdd a new sysfs group which has nodes to monitor data/request transfer performance. This sysfs group has nodes showing total sectors/requests transferred, total busy time spent and max/min/avg/sum latencies.
--- Documentation/ABI/testing/sysfs-driver-ufs | 126 +++++++++++++++++++++++++++++ 1 file changed, 126 insertions(+)
Documentation/ABI/testing/sysfs-driver-ufs +126 -0
@@ -995,6 +995,132 @@ Description: This entry shows the target state of an UFS UIC link The file is read only. +What: /sys/bus/platform/drivers/ufshcd/*/monitor/monitor_enable +Date: January 2021 +Contact: Can Guo <[email protected]> +Description: This file shows the status of performance monitor enablement + and it can be used to start/stop the monitor. When the monitor + is stopped, the performance data collected is also cleared. + +What: /sys/bus/platform/drivers/ufshcd/*/monitor/monitor_chunk_size +Date: January 2021 +Contact: Can Guo <[email protected]> +Description: This file tells the monitor to focus on requests transferring + data of specific chunk size (in Bytes). 0 means any chunk size. + It can only be changed when monitor is disabled. + +What: /sys/bus/platform/drivers/ufshcd/*/monitor/read_total_sectors +Date: January 2021 +Contact: Can Guo <[email protected]> +Description: This file shows how many sectors (in 512 Bytes) have been + sent from device to host after monitor gets started. + + The file is read only. + +What: /sys/bus/platform/drivers/ufshcd/*/monitor/read_total_busy +Date: January 2021 +Contact: Can Guo <[email protected]> +Description: This file shows how long (in micro seconds) has been spent + sending data from device to host after monitor gets started. + + The file is read only. + +What: /sys/bus/platform/drivers/ufshcd/*/monitor/read_nr_requests +Date: January 2021 +Contact: Can Guo <[email protected]> +Description: This file shows how many read requests have been sent after + monitor gets started. + + The file is read only. + +What: /sys/bus/platform/drivers/ufshcd/*/monitor/read_req_latency_max +Date: January 2021 +Contact: Can Guo <[email protected]> +Description: This file shows the maximum latency (in micro seconds) of + read requests after monitor gets started. + + The file is read only. + +What: /sys/bus/platform/drivers/ufshcd/*/monitor/read_req_latency_min +Date: January 2021 +Contact: Can Guo <[email protected]> +Description: This file shows the minimum latency (in micro seconds) of + read requests after monitor gets started. + + The file is read only. + +What: /sys/bus/platform/drivers/ufshcd/*/monitor/read_req_latency_avg +Date: January 2021 +Contact: Can Guo <[email protected]> +Description: This file shows the average latency (in micro seconds) of + read requests after monitor gets started. + + The file is read only. + +What: /sys/bus/platform/drivers/ufshcd/*/monitor/read_req_latency_sum +Date: January 2021 +Contact: Can Guo <[email protected]> +Description: This file shows the total latency (in micro seconds) of + read requests sent after monitor gets started. + + The file is read only. + +What: /sys/bus/platform/drivers/ufshcd/*/monitor/write_total_sectors +Date: January 2021 +Contact: Can Guo <[email protected]> +Description: This file shows how many sectors (in 512 Bytes) have been sent + from host to device after monitor gets started. + + The file is read only. + +What: /sys/bus/platform/drivers/ufshcd/*/monitor/write_total_busy +Date: January 2021 +Contact: Can Guo <[email protected]> +Description: This file shows how long (in micro seconds) has been spent + sending data from host to device after monitor gets started. + + The file is read only. + +What: /sys/bus/platform/drivers/ufshcd/*/monitor/write_nr_requests +Date: January 2021 +Contact: Can Guo <[email protected]> +Description: This file shows how many write requests have been sent after + monitor gets started. + + The file is read only. + +What: /sys/bus/platform/drivers/ufshcd/*/monitor/write_req_latency_max +Date: January 2021 +Contact: Can Guo <[email protected]> +Description: This file shows the maximum latency (in micro seconds) of write + requests after monitor gets started. + + The file is read only. + +What: /sys/bus/platform/drivers/ufshcd/*/monitor/write_req_latency_min +Date: January 2021 +Contact: Can Guo <[email protected]> +Description: This file shows the minimum latency (in micro seconds) of write + requests after monitor gets started. + + The file is read only. + +What: /sys/bus/platform/drivers/ufshcd/*/monitor/write_req_latency_avg +Date: January 2021 +Contact: Can Guo <[email protected]> +Description: This file shows the average latency (in micro seconds) of write + requests after monitor gets started. + + The file is read only. + +What: /sys/bus/platform/drivers/ufshcd/*/monitor/write_req_latency_sum +Date: January 2021 +Contact: Can Guo <[email protected]> +Description: This file shows the total latency (in micro seconds) of write + requests after monitor gets started. + + The file is read only. + What: /sys/bus/platform/drivers/ufshcd/*/device_descriptor/wb_presv_us_en Date: June 2020 Contact: Asutosh Das <[email protected]>
Signature · 1 line
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.
Quoted 12 lines · Can Guo
It works like:
/sys/bus/platform/drivers/ufshcd/*/monitor# echo 4096 >monitor_chunk_size/sys/bus/platform/drivers/ufshcd/*/monitor# echo 1 >monitor_enable/sys/bus/platform/drivers/ufshcd/*/monitor# grep ^/dev/null* monitor_chunk_size:4096
monitor_enable:1
read_nr_requests:17
read_req_latency_avg:169
read_req_latency_max:594
read_req_latency_min:66
read_req_latency_sum:2887
read_total_busy:2639
Quoted 8 lines
read_total_sectors:136
write_nr_requests:116
write_req_latency_avg:440
write_req_latency_max:4921
write_req_latency_min:23
write_req_latency_sum:51052
write_total_busy:19584
write_total_sectors:928
Are any of these attributes UFS-specific? If not, isn't this functionality that should be added to the block layer instead of to the UFS driver?
Thanks,
Bart.
Quoted 22 lines · Bart Van Assche
Quoted 12 lines · Can Guo
It works like:
/sys/bus/platform/drivers/ufshcd/*/monitor# echo 4096 >monitor_chunk_size/sys/bus/platform/drivers/ufshcd/*/monitor# echo 1 >monitor_enable/sys/bus/platform/drivers/ufshcd/*/monitor# grep ^/dev/null* monitor_chunk_size:4096
monitor_enable:1
read_nr_requests:17
read_req_latency_avg:169
read_req_latency_max:594
read_req_latency_min:66
read_req_latency_sum:2887
read_total_busy:2639Quoted 8 lines
read_total_sectors:136
write_nr_requests:116
write_req_latency_avg:440
write_req_latency_max:4921
write_req_latency_min:23
write_req_latency_sum:51052
write_total_busy:19584
write_total_sectors:928
Quoted 4 lines
Are any of these attributes UFS-specific? If not, isn't this functionality that should be added to the block layer instead of to the UFS driver?
Hi Bart,
I didn't think that before because we've already have the powerful "blktrace" tool to collect the overall statistics of each layer.
I add this because I find it really come handy when debug/analyze/profile UFS driver/HW performance. And there will be UFS-specific nodes to be added later to monitor statistics like UFS scaling, gating, doorbell, write booster, HPB and etc.
Thanks.
Can Guo.
Quoted 3 lines
Thanks,
Bart.
Quoted 35 lines · Bart Van Assche
Quoted 23 lines · Can Guo
Quoted 13 lines
It works like:
/sys/bus/platform/drivers/ufshcd/*/monitor# echo 4096 >monitor_chunk_size/sys/bus/platform/drivers/ufshcd/*/monitor# echo 1 >monitor_enable/sys/bus/platform/drivers/ufshcd/*/monitor# grep ^/dev/null* monitor_chunk_size:4096
monitor_enable:1
read_nr_requests:17
read_req_latency_avg:169
read_req_latency_max:594
read_req_latency_min:66
read_req_latency_sum:2887
read_total_busy:2639Quoted 8 lines
read_total_sectors:136
write_nr_requests:116
write_req_latency_avg:440
write_req_latency_max:4921
write_req_latency_min:23
write_req_latency_sum:51052
write_total_busy:19584
write_total_sectors:928Quoted 4 lines
Are any of these attributes UFS-specific? If not, isn't this functionality that should be added to the block layer instead of to the UFS driver?
Hi Bart,
I didn't think that before because we've already have the powerful "blktrace"
tool to collect the overall statistics of each layer.
Quoted 6 lines
I add this because I find it really come handy when debug/analyze/profile
UFS driver/HW performance. And there will be UFS-specific nodes to be added later to monitor statistics like UFS scaling, gating, doorbell, write
booster, HPB and etc.
We are using a designated analysis tool (web-based, a lot of fancy graphs etc.) that relies on ftrace - upiu tracer etc. Once the raw data is there - the options/insights are endless.
Thanks,
Avri
Quoted 8 lines
Thanks.
Can Guo.
Quoted 3 lines
Thanks,
Bart.
Quoted 41 lines · Avri Altman
Quoted 35 lines · Bart Van Assche
Quoted 23 lines · Can Guo
Quoted 13 lines
It works like:
/sys/bus/platform/drivers/ufshcd/*/monitor# echo 4096 >monitor_chunk_size/sys/bus/platform/drivers/ufshcd/*/monitor# echo 1 >monitor_enable/sys/bus/platform/drivers/ufshcd/*/monitor# grep ^/dev/null* monitor_chunk_size:4096
monitor_enable:1
read_nr_requests:17
read_req_latency_avg:169
read_req_latency_max:594
read_req_latency_min:66
read_req_latency_sum:2887
read_total_busy:2639Quoted 8 lines
read_total_sectors:136
write_nr_requests:116
write_req_latency_avg:440
write_req_latency_max:4921
write_req_latency_min:23
write_req_latency_sum:51052
write_total_busy:19584
write_total_sectors:928Quoted 4 lines
Are any of these attributes UFS-specific? If not, isn't this functionality that should be added to the block layer instead of to the UFS driver?
Hi Bart,
I didn't think that before because we've already have the powerful "blktrace"
tool to collect the overall statistics of each layer.Quoted 6 lines
I add this because I find it really come handy when debug/analyze/profile
UFS driver/HW performance. And there will be UFS-specific nodes to be added later to monitor statistics like UFS scaling, gating, doorbell, write
booster, HPB and etc.
Quoted 4 lines
We are using a designated analysis tool (web-based, a lot of fancy graphs etc.) that relies on ftrace - upiu tracer etc. Once the raw data is there - the options/insights are endless.
Hi Avri,
Yeah, one can dig out a lot of info from ftrace/systrace raw data. But, most important, ftrace/systrace has below disadvantages
[1] Enabling UFS/SCSI ftrace itself can impact UFS performance (a lot) as per our profiling
[2] One needs a parser tool (only if they have one) to get the wanted results
So we usually use ftrace to analyze some sequences, e.g., cmd-response, suspend-resume, gating and scaling, but not quite suitable for analyzing performance, see [1].
These nodes provide us a swift method to look into statistics during runtime [2].
Please let me know if you have any concerns w.r.t the change.
Thanks,
Can Guo.
Quoted 10 lines
Thanks,
AvriQuoted 8 lines
Thanks.
Can Guo.
Quoted 3 lines
Thanks,
Bart.
Quoted 58 lines · Avri Altman
Quoted 6 lines
Quoted 6 lines · Bart Van Assche
Quoted 5 lines · Can Guo
Quoted 4 lines
It works like:
/sys/bus/platform/drivers/ufshcd/*/monitor# echo 4096 >monitor_chunk_size/sys/bus/platform/drivers/ufshcd/*/monitor# echo 1 >
monitor_enableQuoted 35 lines
Quoted 29 lines
Quoted 18 lines
Quoted 9 lines
/sys/bus/platform/drivers/ufshcd/*/monitor# grep ^/dev/null* monitor_chunk_size:4096
monitor_enable:1
read_nr_requests:17
read_req_latency_avg:169
read_req_latency_max:594
read_req_latency_min:66
read_req_latency_sum:2887
read_total_busy:2639Quoted 8 lines
read_total_sectors:136
write_nr_requests:116
write_req_latency_avg:440
write_req_latency_max:4921
write_req_latency_min:23
write_req_latency_sum:51052
write_total_busy:19584
write_total_sectors:928Quoted 4 lines
Are any of these attributes UFS-specific? If not, isn't this functionality that should be added to the block layer instead of to the UFS driver?
Hi Bart,
I didn't think that before because we've already have the powerful "blktrace"
tool to collect the overall statistics of each layer.Quoted 6 lines
I add this because I find it really come handy when debug/analyze/profile
UFS driver/HW performance. And there will be UFS-specific nodes to be added later to monitor statistics like UFS scaling, gating, doorbell, write
booster, HPB and etc.Quoted 4 lines
We are using a designated analysis tool (web-based, a lot of fancy graphs etc.) that relies on ftrace - upiu tracer etc. Once the raw data is there - the options/insights are endless.
Hi Avri,
Yeah, one can dig out a lot of info from ftrace/systrace raw data. But, most important, ftrace/systrace has below disadvantages
[1] Enabling UFS/SCSI ftrace itself can impact UFS performance (a lot) as per our profiling
[2] One needs a parser tool (only if they have one) to get the wanted results
Quoted 8 lines
So we usually use ftrace to analyze some sequences, e.g., cmd-response, suspend-resume, gating and scaling, but not quite suitable for analyzing performance, see [1].
These nodes provide us a swift method to look into statistics during runtime [2].
Please let me know if you have any concerns w.r.t the change.
No - not really.
It's just this sort of things tend to grow...
Thanks,
Avri
Quoted 15 lines
Thanks,
Can Guo.
Quoted 10 lines
Thanks,
AvriQuoted 8 lines
Thanks.
Can Guo.
Quoted 3 lines
Thanks,
Bart.
kernel test robot
build botRe: [PATCH v2 1/2] scsi: ufs: Introduce hba performance monitor sysfs nodes
In reply to Can GuoThank you for the patch! Yet something to improve:
Hi Can,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on scsi/for-next]
[also build test ERROR on mkp-scsi/for-next linus/master v5.12-rc5 next-20210330] [cannot apply to target/for-next]
[If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Can-Guo/Introduce-hba-performance-monitoring-sysfs-nodes/20210331-111757 base: https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git for-next config: i386-randconfig-s002-20210330 (attached as .config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce: # apt-get install sparse # sparse version: v0.6.3-279-g6d5d9b42-dirty # https://github.com/0day-ci/linux/commit/b93786009e6f1d28ee1f01e6bc7e5093d20deed3 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Can-Guo/Introduce-hba-performance-monitoring-sysfs-nodes/20210331-111757 git checkout b93786009e6f1d28ee1f01e6bc7e5093d20deed3 # save the attached .config to linux build tree make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=i386
If you fix the issue, kindly add following tag as appropriate
All errors (new ones prefixed by >>):
ld: drivers/scsi/ufs/ufs-sysfs.o: in function `write_req_latency_avg_show':
>> drivers/scsi/ufs/ufs-sysfs.c:441: undefined reference to `__divdi3'
ld: drivers/scsi/ufs/ufs-sysfs.o: in function `read_req_latency_avg_show':
drivers/scsi/ufs/ufs-sysfs.c:374: undefined reference to `__divdi3'
vim +441 drivers/scsi/ufs/ufs-sysfs.c
433
434 static ssize_t write_req_latency_avg_show(struct device *dev,
435 struct device_attribute *attr,
436 char *buf)
437 {
438 struct ufs_hba *hba = dev_get_drvdata(dev);
439 struct ufs_hba_monitor *m = &hba->monitor;
440
> 441 return sysfs_emit(buf, "%llu\n",
442 ktime_to_us(m->lat_sum[WRITE]) / m->nr_req[WRITE]);
443 }
444
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
kernel test robot
build botRe: [PATCH v2 1/2] scsi: ufs: Introduce hba performance monitor sysfs nodes
In reply to Can GuoThank you for the patch! Yet something to improve:
Hi Can,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on scsi/for-next]
[also build test ERROR on mkp-scsi/for-next linus/master v5.12-rc5 next-20210331] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Can-Guo/Introduce-hba-performance-monitoring-sysfs-nodes/20210331-111757 base: https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git for-next config: parisc-randconfig-r024-20210330 (attached as .config) compiler: hppa-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/b93786009e6f1d28ee1f01e6bc7e5093d20deed3
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Can-Guo/Introduce-hba-performance-monitoring-sysfs-nodes/20210331-111757 git checkout b93786009e6f1d28ee1f01e6bc7e5093d20deed3
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=parisc
If you fix the issue, kindly add following tag as appropriate
All errors (new ones prefixed by >>, old ones prefixed by <<):
>> ERROR: modpost: "__divdi3" [drivers/scsi/ufs/ufshcd-core.ko] undefined!
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org