Skip to contentSkip to conversation

drm/msm/dp: signal audio plugged change at dp_pm_resume

PATCH In review Kuogee Hsieh 2 participants 3 messages Jul 23, 2021 – Jul 26, 2021

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 drm/msm/dp: signal audio plugged change at dp_pm_resume

There is a scenario that dp cable is unplugged from DUT during system suspended will cause audio option state does not match real connection state. Fix this problem by Signaling audio plugged change with realtime connection status at dp_pm_resume() so that audio option will be in correct state after system resumed.

Changes in V2:
-- correct Fixes tag commit id.

Fixes f591dbb5fb8c ("drm/msm/dp: power off DP phy at suspend")
---
 drivers/gpu/drm/msm/dp/dp_display.c | 4 ++++
 1 file changed, 4 insertions(+)
drivers/gpu/drm/msm/dp/dp_display.c +4 -0
index 78c5301..2b660e9 100644
@@ -1339,6 +1339,10 @@ static int dp_pm_resume(struct device *dev)
 	else
 		dp->dp_display.is_connected = false;
 
+	dp_display_handle_plugged_change(g_dp_display,
+				dp->dp_display.is_connected);
+
+
 	mutex_unlock(&dp->event_mutex);
 
 	return 0;
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
#1 lore raw

Quoting Kuogee Hsieh (2021-07-23 09:55:39)

Quoted 21 lines

There is a scenario that dp cable is unplugged from DUT during system suspended will cause audio option state does not match real connection state. Fix this problem by Signaling audio plugged change with realtime connection status at dp_pm_resume() so that audio option will be in correct state after system resumed.

Changes in V2:
-- correct Fixes tag commit id.

Fixes f591dbb5fb8c ("drm/msm/dp: power off DP phy at suspend")
---
 drivers/gpu/drm/msm/dp/dp_display.c | 4 ++++
 1 file changed, 4 insertions(+)
drivers/gpu/drm/msm/dp/dp_display.c +0 -0
index 78c5301..2b660e9 100644

drivers/gpu/drm/msm/dp/dp_display.c static int dp_pm_resume(struct device *dev) · line 1342

Quoted 4 lines
drivers/gpu/drm/msm/dp/dp_display.c +1 -0
@@ -1339,6 +1339,10 @@ static int dp_pm_resume(struct device *dev)
        else
                dp->dp_display.is_connected = false;
 
+       dp_display_handle_plugged_change(g_dp_display,

Can this be dp_display instead of g_dp_display?

Quoted 6 lines
drivers/gpu/drm/msm/dp/dp_display.c +3 -0
+                               dp->dp_display.is_connected);
+
+
        mutex_unlock(&dp->event_mutex);
 
        return 0;
#2 lore raw
In reply to Kuogee Hsieh

Quoting Kuogee Hsieh (2021-07-23 09:55:39)

Quoted 9 lines

There is a scenario that dp cable is unplugged from DUT during system suspended will cause audio option state does not match real connection state. Fix this problem by Signaling audio plugged change with realtime connection status at dp_pm_resume() so that audio option will be in correct state after system resumed.

Changes in V2:
-- correct Fixes tag commit id.

Quoted 6 lines
Fixes f591dbb5fb8c ("drm/msm/dp: power off DP phy at suspend")
---
 drivers/gpu/drm/msm/dp/dp_display.c | 4 ++++
 1 file changed, 4 insertions(+)

I noticed that with or without this patch I still have a problem with an apple dongle where if I leave the dongle connected but unplug the HDMI cable during suspend the audio device is still there when I resume. The display looks to be connected in that case too, according to modetest. I don't know if you want to roll that into this patch or make another follow-up patch to fix it, but it seems like the sink count isn't updated on resume? Did commit f591dbb5fb8c break a bunch of logic in here because now the link is powered down properly and so sink_count isn't updated properly?

drivers/gpu/drm/msm/dp/dp_display.c static int dp_pm_resume(struct device *dev) · line 1345

Quoted 13 lines
drivers/gpu/drm/msm/dp/dp_display.c +4 -0
index 78c5301..2b660e9 100644
@@ -1339,6 +1339,10 @@ static int dp_pm_resume(struct device *dev)
        else
                dp->dp_display.is_connected = false;
 
+       dp_display_handle_plugged_change(g_dp_display,
+                               dp->dp_display.is_connected);
+
+

There's also a double newline here that we should probably remove.

Quoted 3 lines
drivers/gpu/drm/msm/dp/dp_display.c +0 -0
        mutex_unlock(&dp->event_mutex);
 
        return 0;