Skip to contentSkip to conversation

arm64: dts: qcom: sc7280: fix display port phy reg property

PATCH In review Kuogee Hsieh 2 participants 2 messages Sep 9, 2021

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 arm64: dts: qcom: sc7280: fix display port phy reg property

Existing display port phy reg property is derived from usb phy which map display port phy pcs to wrong address which cause aux init with wrong address and prevent both dpcd read and write from working. Fix this problem by assigning correct pcs address to display port phy reg property.

Changes in V2:
-- rewording the commit text

Fixes 9886e8fd8438 ("arm64: dts: qcom: sc7280: Add USB related nodes")
---
 arch/arm64/boot/dts/qcom/sc7280.dtsi | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)
arch/arm64/boot/dts/qcom/sc7280.dtsi +2 -6
index fa1353f..cdaff5f 100644
@@ -2881,15 +2881,11 @@
 			dp_phy: dp-phy@88ea200 {
 				reg = <0 0x088ea200 0 0x200>,
 				      <0 0x088ea400 0 0x200>,
-				      <0 0x088eac00 0 0x400>,
+				      <0 0x088eaa00 0 0x200>,
 				      <0 0x088ea600 0 0x200>,
-				      <0 0x088ea800 0 0x200>,
-				      <0 0x088eaa00 0 0x100>;
+				      <0 0x088ea800 0 0x200>;
 				#phy-cells = <0>;
 				#clock-cells = <1>;
-				clocks = <&gcc GCC_USB3_PRIM_PHY_PIPE_CLK>;
-				clock-names = "pipe0";
-				clock-output-names = "usb3_phy_pipe_clk_src";
 			};
 		};
 
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
Reviewed-by on v2 1/1
#1 lore raw

Quoting Kuogee Hsieh (2021-09-09 12:49:58)

Quoted 8 lines

Existing display port phy reg property is derived from usb phy which map display port phy pcs to wrong address which cause aux init with wrong address and prevent both dpcd read and write from working. Fix this problem by assigning correct pcs address to display port phy reg property.

Changes in V2:
-- rewording the commit text

This Changes part can be put under the triple dash. This isn't drm tree material.

Quoted 4 lines
Fixes 9886e8fd8438 ("arm64: dts: qcom: sc7280: Add USB related nodes")

---