Skip to contentSkip to conversation

README.skeleton: add readme to meta-skeleton layer

PATCH Scott Weaver 2 participants 3 messages Jun 22, 2021 – Jun 24, 2021 1 message not in the archive

lore
Share & tools
lore
#1 lore raw
In reply to a message not in the archive

I didn't see that this patch was picked up (but maybe I'm looking in the wrong place) and I received the email from Stephen that the issue should be moved to 3.4 M2.
Did I send this to the wrong mailing list or is it not the solution you're looking for?

I elaborated in bugzilla on why I think just adding the readme file to close this issue is enough but you may not have seen that comment or agree. :)
https://bugzilla.yoctoproject.org/show_bug.cgi?id=13612

Scott

Quoted 32 lines · Scott Weaver via lists.openembedded.org

Added to satisfy the yocto-check-layer tool readme file test.

[YOCTO #13612]

---
 meta-skeleton/README.skeleton | 7 +++++++
 1 file changed, 7 insertions(+)
 create mode 100644 meta-skeleton/README.skeleton
meta-skeleton/README.skeleton new file +6 -0
new file mode 100644
index 0000000000..25468dc87a
@@ -0,0 +1,7 @@
+meta-skeleton
+=============
+
+The meta-skeleton layer contains example recipes and configuration files.
+
+This layer is not intended to demonstrate a Yocto Project Compatible

software layer.
+Disable the signature check when testing this layer using the yocto-check-layer tool.
--
2.25.1

#2 lore raw
Quoted 22 lines · Scott Weaver

I didn't see that this patch was picked up (but maybe I'm looking in the wrong place) and I received the email from Stephen that the issue should be moved to 3.4 M2.
Did I send this to the wrong mailing list or is it not the solution you're looking for?

I elaborated in bugzilla on why I think just adding the readme file to close this issue is enough but you may not have seen that comment or agree. :)
https://bugzilla.yoctoproject.org/show_bug.cgi?id=13612

Scott

Quoted 10 lines · Scott Weaver via lists.openembedded.org

Added to satisfy the yocto-check-layer tool readme file test.

[YOCTO #13612]

---
 meta-skeleton/README.skeleton | 7 +++++++

 1 file changed, 7 insertions(+)

 create mode 100644 meta-skeleton/README.skeleton

Quoted 13 lines

meta-skeleton/README.skeleton line 7

Quoted 13 lines
meta-skeleton/README.skeleton new file +7 -0
new file mode 100644
index 0000000000..25468dc87a
@@ -0,0 +1,7 @@
+meta-skeleton
+=============
+
+The meta-skeleton layer contains example recipes and configuration files.
+
+This layer is not intended to demonstrate a Yocto Project Compatible software layer.
+Disable the signature check when testing this layer using the yocto-check-layer tool.

Sorry, it takes time to page in the context for this.

I think we should fix meta-skeleton to work with yocto-check-layer. I think this may be relatively simple, we can change the busybox bbappend that is causing the signature failure to be 'distro' specific, e.g. something like:

-SRC_URI += " \
+SRC_URI_append_mydistro = " \

and then an example is still there but it doesn't break the checks (and isn't enabled by default). We could add a comment about it being enabled by a custom distro called 'mydistro'.

That change, along with your README addition should allow the layer tests to pass.

Cheers,

Richard

#3 lore raw

Thanks, Richard.
The issue noted that the distro specific update wasn't working but it's because they tried SRC_URI_append_poky (which correctly failed) so I didn't even think to try anything else.
My mistake. I'll make the changes you suggested.

Thanks again for your time!
Scott

Quoted 70 lines · Richard Purdie
Quoted 1 line · Scott Weaver

I didn't see that this patch was picked up (but maybe I'm looking in the

wrong place) and I received the email

Quoted 2 lines

from Stephen that the issue should be moved to 3.4 M2. Did I send this to the wrong mailing list or is it not the solution

you're looking for?

Quoted 2 lines

I elaborated in bugzilla on why I think just adding the readme file to

close this issue is enough but you may

Quoted 11 lines

not have seen that comment or agree. :)
https://bugzilla.yoctoproject.org/show_bug.cgi?id=13612

Scott

Quoted 4 lines · Scott Weaver via lists.openembedded.org

Added to satisfy the yocto-check-layer tool readme file test.

[YOCTO #13612]

Quoted 7 lines

Review

Quoted 7 lines
---
 meta-skeleton/README.skeleton | 7 +++++++
 1 file changed, 7 insertions(+)
 create mode 100644 meta-skeleton/README.skeleton
(quoted diff) +0 -0

b/meta-skeleton/README.skeleton

Quoted 9 lines

meta-skeleton/README.skeleton line 4

Quoted 9 lines

new file mode 100644
index 0000000000..25468dc87a

meta-skeleton/README.skeleton new file +4 -0
@@ -0,0 +1,7 @@
+meta-skeleton
+=============
+
+The meta-skeleton layer contains example recipes and configuration

files.

Quoted 2 lines

meta-skeleton/README.skeleton line 6

Quoted 2 lines
meta-skeleton/README.skeleton new file +2 -0
+
+This layer is not intended to demonstrate a Yocto Project Compatible

software layer.

Quoted 1 line

meta-skeleton/README.skeleton line 7

Quoted 1 line
meta-skeleton/README.skeleton new file +1 -0
+Disable the signature check when testing this layer using the

yocto-check-layer tool.

Sorry, it takes time to page in the context for this.

I think we should fix meta-skeleton to work with yocto-check-layer. I think this
may be relatively simple, we can change the busybox bbappend that is causing the
signature failure to be 'distro' specific, e.g. something like:

(quoted diff) +1 -1
-SRC_URI += " \
+SRC_URI_append_mydistro = " \

and then an example is still there but it doesn't break the checks (and isn't
enabled by default). We could add a comment about it being enabled by a custom
distro called 'mydistro'.

That change, along with your README addition should allow the layer tests to pass.

Cheers,

Richard