Skip to contentSkip to conversation

cifs_setattr() retval fix

PATCH In review [email protected] 1 participant 1 message Jun 26, 2004 VFS

lore
Share & tools
lore
#0 lore raw

PATCH 4/6 cifs_setattr() retval fix

CIFS is failing to propagate the inode_setattr() return value.

---

 25-akpm/fs/cifs/inode.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletion(-)
fs/cifs/inode.c renamed from fs/cifs/inode.c~cifs_setattr-retval-fix +2 -1
diff -puN fs/cifs/inode.c~cifs_setattr-retval-fix fs/cifs/inode.c
@@ -954,7 +954,8 @@ cifs_setattr(struct dentry *direntry, st
 	}
 
 	/* do not  need local check to inode_check_ok since the server does that */
-	inode_setattr(direntry->d_inode, attrs);
+	if (!rc)
+		rc = inode_setattr(direntry->d_inode, attrs);
 	if (full_path)
 		kfree(full_path);
 	FreeXid(xid);

_