Skip to contentSkip to conversation

SCSI: shift device_reprobe() warning explosion

PATCH New Jeff Garzik 1 participant 1 message Sep 28, 2006 SCSI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 SCSI: shift device_reprobe() warning explosion

SCSI warns about device_reprobe() for _every file_, even though there is only a single caller in the entirety of SCSI.

The need to check return code is valid, so we update the warning area to shift the burden to the [only] caller, mptsas.

include/scsi/scsi_device.h +2 -2
index 895d212..b401c82 100644
@@ -298,9 +298,9 @@ extern int scsi_execute_async(struct scs
 			      void (*done)(void *, char *, int, int),
 			      gfp_t gfp);
 
-static inline void scsi_device_reprobe(struct scsi_device *sdev)
+static inline int __must_check scsi_device_reprobe(struct scsi_device *sdev)
 {
-	device_reprobe(&sdev->sdev_gendev);
+	return device_reprobe(&sdev->sdev_gendev);
 }
 
 static inline unsigned int sdev_channel(struct scsi_device *sdev)