Skip to contentSkip to conversation

Dynamic kernel command-line - sh

PATCH Paul Mundt 2 participants 2 messages Oct 12, 2006 2 messages not in the archive

lore
Share & tools
lore

Paul Mundt

author Acked-by Acked-by
#2 lore raw
In reply to a message not in the archive
Quoted 6 lines · Alon Bar-Lev

1. Rename saved_command_line into boot_command_line.
2. Set command_line as __initdata.

The sh bits look fine, though I'm fairly impartial to this change. It doesn't seem like this is going to be needed in very many places..

In the future, you may also wish to CC linux-arch if you want the attention of architecture maintainers.

Quoted 6 lines · Alon Bar-Lev

1. Rename saved_command_line into boot_command_line.
2. Set command_line as __initdata.

Likewise for sh64.

#3 lore raw
Quoted 2 lines · Paul Mundt

The sh bits look fine, though I'm fairly impartial to this change. It doesn't seem like this is going to be needed in very many places..

Thank you for your quick response!
But I failed to push i386 command-line size to more than 256 bytes... You are right, it is required only for memory extreme devices...

Options:
1. Add COMMAND_LINE_SIZE to kernel config - was rejected because kernel has already too much parameters, this was the initial patch more than a year ago.
2. Just increase COMMAND_LINE_SIZE of i386, x86_64 - was rejected because of it affecting low memory devices.
3. Convert the command-line into dynamically allocated buffers - this try.

Quoted 2 lines

In the future, you may also wish to CC linux-arch if you want the attention of architecture maintainers.

Thank you, I was not aware of this.
I hope there will be no take 3 :)

Best Regards,
Alon Bar-Lev.