Skip to contentSkip to conversation

xm-test: don't export RD_PATH into TENV

PATCH Applied Ryan Harper 2 participants 2 messages Nov 1, 2006 – Nov 2, 2006

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xm-test: don't export RD_PATH into TENV

xm-test currently exports the RD_PATH value into the environment which prevents one from providing the value when running a test. Without this patch, one has to re-run ./autogen && ./configure with RD_PATH defined to change the RD_PATH value that is used.

Additionally, the current getRdPath() implementation already uses the the value that was being exported. In short, exporting the value is not needed unless one wants to override the default value.

With the patch, the following now works:

% cp xm-test/ramdisk/initrd.img /boot
% cd xm-test/tests/create
% RD_PATH=/boot TEST_VERBOSE=1 make TESTS=01_create_basic_pos.test check

Signature · 33 lines
Ryan Harper
Software Engineer; Linux Technology Center
IBM Corp., Austin, Tx
(512) 838-9253   T/L: 678-9253
[email protected]


diffstat output:
 configure.ac |    7 +++----
 1 files changed, 3 insertions(+), 4 deletions(-)

Signed-off-by: Ryan Harper <[email protected]>
---
fix xm-test configure.ac to not define RD_PATH which prevented env override

diff -r 2db4388fecb9 tools/xm-test/configure.ac
--- a/tools/xm-test/configure.ac	Tue Oct 31 16:42:46 2006 +0000
+++ b/tools/xm-test/configure.ac	Tue Oct 31 15:43:13 2006 -0600
@@ -11,11 +11,10 @@ AC_PROG_CC
 #AC_PROG_INSTALL
 AC_CHECK_PROG([LILO],	lilo,	lilo,	"no",	[$PATH])
 
-# Right now, we can assume that the lib/ and ramdisk/ directories
-# are two levels above the tests
+# Right now, we can assume that the lib/ directory
+# is two levels above the tests
 TESTLIB=../../lib
-RD_PATH=../../ramdisk
-TENV="PYTHONPATH=$PYTHONPATH:$TESTLIB RD_PATH=$RD_PATH"
+TENV="PYTHONPATH=$PYTHONPATH:$TESTLIB"
 
 AC_ARG_ENABLE(hvm-support,
 	[[  --enable-hvm-support           enable hardware virtual machine assist]],
Applied
#1 lore raw
Quoted 9 lines · Ryan Harper

xm-test currently exports the RD_PATH value into the environment which prevents one from providing the value when running a test. Without this patch, one has to re-run ./autogen && ./configure with RD_PATH defined to change the RD_PATH value that is used.

Additionally, the current getRdPath() implementation already uses the the value that was being exported. In short, exporting the value is not needed unless one wants to override the default value.

Quoted 5 lines

With the patch, the following now works:

% cp xm-test/ramdisk/initrd.img /boot
% cd xm-test/tests/create
% RD_PATH=/boot TEST_VERBOSE=1 make TESTS=01_create_basic_pos.test check

Applied, thanks Ryan.

Ewan.