: Resolve small FIXME
PATCH 3/10 : Resolve small FIXME
[CCID 3]: Resolve small FIXME
This considers the case - ACK received while no packet has been sent so far. Resolved by printing a (rate-limited) warning message.
Further removes an unnecessary BUG_ON in ccid3_hc_tx_packet_recv, received feedback on a terminating connection is simply ignored.
Signed-off-by Gerrit Renker <[email protected]>
--- net/dccp/ccids/ccid3.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-)
net/dccp/ccids/ccid3.c +4 -5
@@ -437,9 +437,6 @@ static void ccid3_hc_tx_packet_recv(stru pinv = opt_recv->ccid3or_loss_event_rate;switch (hctx->ccid3hctx_state) { -case TFRC_SSTATE_NO_SENT : -/* FIXME: what to do here? */ -return ;case TFRC_SSTATE_NO_FBACK :case TFRC_SSTATE_FBACK :/* Calculate new round trip sample by
@@ -545,8 +542,10 @@ static void ccid3_hc_tx_packet_recv(stru/* set idle flag */ hctx->ccid3hctx_idle =1 ;break ; -case TFRC_SSTATE_TERM : -DCCP_BUG ("Illegal %s state TERM, sk=%p" ,dccp_role (sk), sk); +case TFRC_SSTATE_NO_SENT : +DCCP_WARN ("Illegal ACK received - no packet has been sent\n" ); +/* fall through */ +case TFRC_SSTATE_TERM :/* ignore feedback when closing */ break ; } }
Arnaldo Carvalho de Melo
AppliedQuoted 9 lines · Gerrit Renker
[CCID 3]: Resolve small FIXME
This considers the case - ACK received while no packet has been sent so far. Resolved by printing a (rate-limited) warning message.
Further removes an unnecessary
BUG_ONinccid3_hc_tx_packet_recv, received feedback on a terminating connection is simply ignored.Signed-off-by Gerrit Renker <[email protected]>
Thanks, applied.
- Arnaldo
Quoted 2 lines · Gerrit Renker
[CCID 3]: Resolve small FIXME
Signed-off-by Ian McDonald <[email protected]>
Signature · 7 lines
Ian McDonald Web: http://wand.net.nz/~iam4 Blog: http://imcdnzl.blogspot.com WAND Network Research Group Department of Computer Science University of Waikato New Zealand