Skip to contentSkip to conversation

cmipci patch

PATCH Felix Hammer 2 participants 2 messages Jan 19, 2007

lore
Share & tools
lore
#0 lore raw

hi

according to this bug -->
https://bugtrack.alsa-project.org/alsa-bug/view.php?id=2491
i attached the diff for commit.

regards
felix
_______________________________________
http://www.lehrsaiten.de
http://sourceforge.net/projects/pokerth

cmipci.c renamed from alsa-kernel/pci/cmipci.c +7 -0
@@ -2779,6 +2779,13 @@
 	struct snd_opl3 *opl3;
 	int err;
 
+ 
+ 	if ( fm_port == 0 ) {
+ 		snd_cmipci_clear_bit(cm, CM_REG_MISC_CTRL, CM_FM_EN);
+ 		return 0;
+ 	}
+ 
+
 	/* first try FM regs in PCI port range */
 	iosynth = cm->iobase + CM_REG_FM_PCI;
 	err = snd_opl3_create(cm->card, iosynth, iosynth + 2,

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV

_______________________________________________
Alsa-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/alsa-devel

#1 lore raw

At Fri, 19 Jan 2007 11:22:05 +0100,

Quoted 6 lines · Felix Hammer

hi

according to this bug -->
https://bugtrack.alsa-project.org/alsa-bug/view.php?id=2491
i attached the diff for commit.

The patch looks OK, but please follow the standard coding style of the linux kernel, namely, remove spaces around parentheses. Also, give a proper changelog and a sign-off to merge.
(See the main page of ALSA BTS.)

thanks,

Takashi

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV