Skip to contentSkip to conversation

misc. cleanups

PATCH In review Shawn O. Pearce 1 participant 1 message Jun 15, 2016

lore
Share & tools
lore
#0 lore raw

cover misc. cleanups

This is a series of various cleanups that I have pending at the front of my pack v4 topic. The earlier ones are annoying nits, the later ones fix compiler errors caused by compiling with:

--snip--
CFLAGS += -Wall -ansi -pedantic -std=c99

ifdef strict

          CFLAGS += -Werror
          CFLAGS += -Wfour-char-constants
          CFLAGS += -fnon-lvalue-assign
          CFLAGS += -Wdeclaration-after-statement
          CFLAGS += -Wpointer-arith
          CFLAGS += -Wbad-function-cast
          CFLAGS += -Wcast-align
          CFLAGS += -Wwrite-strings
          CFLAGS += -Wshorten-64-to-32
  
          # No, currently a huge set.
          #CFLAGS += -Wsign-compare
  
          # No, only in diffcore-rename and that's ok.
          #CFLAGS += -Wfloat-equal
  
          # No, unused parameters, -Wsign-compare, missing initializers.
          # CFLAGS += -Wextra
  
          # No, memcmp trips on signed/unsigned conversion.
          # CFLAGS += -Wconversion

endif
--snap--

Signature · 1 line
Shawn.