scsi_data_buffer structure (in preparation for bidi)
cover scsi_data_buffer structure (in preparation for bidi)
This patchset, which I submitted before, adds a new data structure, scsi_data_buffer, including everything for data transfer:
struct scsi_data_buffer {
unsigned length;
int resid;
short sg_count;
short __sg_count;
struct scatterlist *sglist;
};One scsi_data_buffer structure is embedded in struct scsi_cmnd for uni-directional transfer. All the members are just moved from scsi_cmnd structure to scsi_data_buffer structure. So nothing is added to scsi_cmnd structure.
After applying this patchset, llds must use the scsi data accessors. This patchset includes some conversation patches (most of them are patches that Boaz submitted before), however there is still some code that is needed to be converted.
Boaz, if you still have other conversation patches, please submit them.
I suspect that nobody cares about some of unconverted llds, which will be not compilable after this patchset. I'll fix ldds that people complain about.
It's difficult to test this patchset in -mm via scsi-misc. Jens, please send this to -mm via the block tree.
Quoted 2 lines · On Fri, 7 Sep 2007 06:50:08 +0900 FUJITA Tomonori <[email protected]> wrote:
This patchset, which I submitted before, adds a new data structure,
scsi_data_buffer, including everything for data transfer:
This patch is against Jens' sglist branch with the following patches:
Quoted 19 lines · FUJITA Tomonori
This patchset, which I submitted before, adds a new data structure,
scsi_data_buffer, including everything for data transfer:struct
scsi_data_buffer{ unsigned length; int resid; shortsg_count;
short__sg_count; struct scatterlist *sglist; };One
scsi_data_bufferstructure is embedded in structscsi_cmndfor uni-directional transfer. All the members are just moved fromscsi_cmndstructure toscsi_data_bufferstructure. So nothing is added toscsi_cmndstructure.After applying this patchset, llds must use the scsi data accessors. This patchset includes some conversation patches (most of them are patches that Boaz submitted before), however there is still some code that is needed to be converted.
Boaz, if you still have other conversation patches, please submit them.
Quoted 6 lines
I suspect that nobody cares about some of unconverted llds, which will be not compilable after this patchset. I'll fix ldds that people
complain about.It's difficult to test this patchset in -mm via scsi-misc. Jens, please send this to -mm via the block tree.
Sorry for the late response. Just am back from vacation.
Tomo please hold with these patches a bit longer the Tree is not ready for it.
Mainly you will totally break USB storage mid-layer. There is one converted USB driver - microtek.c - that is currently broken. This is because usb mid-layer still issues a synchronous REQUEST_SENSE with use_sg == 0.
(And still bangs all over scsi_cmnd members) I have a complete and somewhat tested solution for the USB stack and all the drivers. as well as lots of other drivers (see list below). I will submit them group by group during this week and next week. The reason I did not release them yet is because I did not want to do this before the vacation and not be available for debugging.
Some of the files I have patches for are:
git-diff --stat
drivers/fc4/fc.c | 40 ++--- drivers/scsi/NCR5380.c | 39 ++-- drivers/scsi/NCR5380.h | 7 + drivers/scsi/NCR53C9x.c | 40 ++--- drivers/scsi/NCR53C9x.h | 2 - drivers/scsi/a2091.c | 36 +--- drivers/scsi/a3000.c | 15 +-- drivers/scsi/aha1542.c | 54 ++---- drivers/scsi/arm/acornscsi.c | 14 +- drivers/scsi/arm/fas216.c | 5 +- drivers/scsi/arm/fas216.h | 3 + drivers/scsi/arm/scsi.h | 34 +--- drivers/scsi/atari_NCR5380.c | 47 ++--- drivers/scsi/atp870u.c | 102 ++--------- drivers/scsi/dec_esp.c | 17 -- drivers/scsi/eata_pio.c | 12 +- drivers/scsi/fd_mcs.c | 36 +--- drivers/scsi/gdth.c | 2 +- drivers/scsi/imm.c | 13 +- drivers/scsi/in2000.c | 10 +- drivers/scsi/oktagon_esp.c | 14 -- drivers/scsi/pluto.c | 2 +- drivers/scsi/ppa.c | 12 +- drivers/scsi/qla1280.c | 348 +++++++++++++++-------------------- drivers/scsi/qlogicpti.c | 54 +----- drivers/scsi/scsi_error.c | 114 ++++++++---- drivers/scsi/seagate.c | 17 +- drivers/scsi/sun3_NCR5380.c | 42 ++--- drivers/scsi/sun3x_esp.c | 21 +-- drivers/scsi/wd33c93.c | 10 +- drivers/usb/storage/freecom.c | 14 +- drivers/usb/storage/isd200.c | 6 +- drivers/usb/storage/protocol.c | 120 +++++------- drivers/usb/storage/sddr09.c | 9 +- drivers/usb/storage/shuttle_usbat.c | 54 +++--- drivers/usb/storage/transport.c | 95 ++++------ drivers/usb/storage/transport.h | 2 + include/scsi/scsi_eh.h | 17 ++- 38 files changed, 574 insertions(+), 905 deletions(-)
If any of these are obsolete and should be removed please say so. Save me the work to submit them.
Thanks
Boaz
Quoted 24 lines · On Sun, 09 Sep 2007 11:25:57 +0300 Boaz Harrosh <[email protected]> wrote:
Quoted 23 lines · FUJITA Tomonori
This patchset, which I submitted before, adds a new data structure,
scsi_data_buffer, including everything for data transfer:struct
scsi_data_buffer{ unsigned length; int resid; shortsg_count;
short__sg_count; struct scatterlist *sglist; };One
scsi_data_bufferstructure is embedded in structscsi_cmndfor uni-directional transfer. All the members are just moved fromscsi_cmndstructure toscsi_data_bufferstructure. So nothing is added toscsi_cmndstructure.After applying this patchset, llds must use the scsi data accessors. This patchset includes some conversation patches (most of them are patches that Boaz submitted before), however there is still some code that is needed to be converted.
Boaz, if you still have other conversation patches, please submit them.
I suspect that nobody cares about some of unconverted llds, which will be not compilable after this patchset. I'll fix ldds that people
complain about.
Quoted 7 lines
Quoted 2 lines
It's difficult to test this patchset in -mm via scsi-misc. Jens, please send this to -mm via the block tree.
Sorry for the late response. Just am back from vacation.
Tomo please hold with these patches a bit longer the Tree is not ready for it.
Then we have no chance to merge scsi_data_buffer into 2.6.24.
Quoted 12 lines
Mainly you will totally break USB storage mid-layer. There is one converted USB driver -
microtek.c- that is currently broken. This is because usb mid-layer still issues a synchronousREQUEST_SENSEwithuse_sg== 0.
(And still bangs all overscsi_cmndmembers) I have a complete and somewhat tested solution for the USB stack and all the drivers. as well as lots of other drivers (see list below). I will submit them group by group during this week and next week. The reason I did not release them yet is because I did not want to do this before the vacation and not be available for debugging.
Quoted 4 lines
Some of the files I have patches for are:
git-diff --stat
drivers/fc4/fc.c | 40 ++---
I think that I fixed fc4 (the patch is in scsi-misc).
Quoted 15 lines
drivers/scsi/NCR5380.c | 39 ++-- drivers/scsi/NCR5380.h | 7 + drivers/scsi/NCR53C9x.c | 40 ++--- drivers/scsi/NCR53C9x.h | 2 - drivers/scsi/a2091.c | 36 +--- drivers/scsi/a3000.c | 15 +-- drivers/scsi/aha1542.c | 54 ++---- drivers/scsi/arm/acornscsi.c | 14 +- drivers/scsi/arm/fas216.c | 5 +- drivers/scsi/arm/fas216.h | 3 + drivers/scsi/arm/scsi.h | 34 +--- drivers/scsi/atari_NCR5380.c | 47 ++--- drivers/scsi/atp870u.c | 102 ++--------- drivers/scsi/dec_esp.c | 17 -- drivers/scsi/eata_pio.c | 12 +-
Quoted 8 lines
drivers/scsi/fd_mcs.c | 36 +--- drivers/scsi/gdth.c | 2 +- drivers/scsi/imm.c | 13 +- drivers/scsi/in2000.c | 10 +- drivers/scsi/oktagon_esp.c | 14 -- drivers/scsi/pluto.c | 2 +- drivers/scsi/ppa.c | 12 +- drivers/scsi/qla1280.c | 348 +++++++++++++++--------------------
The patchset includes qla1280 conversion.
Quoted 2 lines
drivers/scsi/qlogicpti.c | 54 +----- drivers/scsi/scsi_error.c | 114 ++++++++----
The patchset includes your patch to convert scsi_error.c. What else do you want to change?
Quoted 15 lines
drivers/scsi/seagate.c | 17 +- drivers/scsi/sun3_NCR5380.c | 42 ++--- drivers/scsi/sun3x_esp.c | 21 +-- drivers/scsi/wd33c93.c | 10 +- drivers/usb/storage/freecom.c | 14 +- drivers/usb/storage/isd200.c | 6 +- drivers/usb/storage/protocol.c | 120 +++++------- drivers/usb/storage/sddr09.c | 9 +- drivers/usb/storage/shuttle_usbat.c | 54 +++--- drivers/usb/storage/transport.c | 95 ++++------ drivers/usb/storage/transport.h | 2 + include/scsi/scsi_eh.h | 17 ++- 38 files changed, 574 insertions(+), 905 deletions(-)
Quoted 2 lines
If any of these are obsolete and should be removed please say so. Save me the work to submit them.
I think that nobody cares about some of these drivers and they might be even broken. We need to merge the patchset to -mm and then we can see what drivers people still care about. And if necessary, we can blindly just convert drivers.
Quoted 27 lines · FUJITA Tomonori
Quoted 24 lines · On Sun, 09 Sep 2007 11:25:57 +0300 Boaz Harrosh <[email protected]> wrote:
Quoted 23 lines · FUJITA Tomonori
This patchset, which I submitted before, adds a new data structure,
scsi_data_buffer, including everything for data transfer:struct
scsi_data_buffer{ unsigned length; int resid; shortsg_count;
short__sg_count; struct scatterlist *sglist; };One
scsi_data_bufferstructure is embedded in structscsi_cmndfor uni-directional transfer. All the members are just moved fromscsi_cmndstructure toscsi_data_bufferstructure. So nothing is added toscsi_cmndstructure.After applying this patchset, llds must use the scsi data accessors. This patchset includes some conversation patches (most of them are patches that Boaz submitted before), however there is still some code that is needed to be converted.
Boaz, if you still have other conversation patches, please submit them.
I suspect that nobody cares about some of unconverted llds, which will be not compilable after this patchset. I'll fix ldds that people
complain about.
Quoted 9 lines
Quoted 6 lines
Quoted 2 lines
It's difficult to test this patchset in -mm via scsi-misc. Jens, please send this to -mm via the block tree.
Sorry for the late response. Just am back from vacation.
Tomo please hold with these patches a bit longer the Tree is not ready for it.
Then we have no chance to merge
scsi_data_bufferinto 2.6.24.
I hope to submit all/most of the work this week. If we miss the window for 2.6.24 than I'm very sorry for that. But I don't think we are aloud to break USB storage subsystem.
Quoted 13 lines
Quoted 13 lines
Mainly you will totally break USB storage mid-layer. There is one converted USB driver -
microtek.c- that is currently broken. This is because usb mid-layer still issues a synchronousREQUEST_SENSEwithuse_sg== 0.
(And still bangs all overscsi_cmndmembers) I have a complete and somewhat tested solution for the USB stack and all the drivers. as well as lots of other drivers (see list below). I will submit them group by group during this week and next week. The reason I did not release them yet is because I did not want to do this before the vacation and not be available for debugging.
Quoted 7 lines
Quoted 4 lines
Some of the files I have patches for are:
git-diff --stat
drivers/fc4/fc.c | 40 ++---I think that I fixed fc4 (the patch is in scsi-misc).
Sorry I did not see that one I'll drop it
Quoted 25 lines
Quoted 16 lines
drivers/scsi/NCR5380.c | 39 ++-- drivers/scsi/NCR5380.h | 7 + drivers/scsi/NCR53C9x.c | 40 ++--- drivers/scsi/NCR53C9x.h | 2 - drivers/scsi/a2091.c | 36 +--- drivers/scsi/a3000.c | 15 +-- drivers/scsi/aha1542.c | 54 ++---- drivers/scsi/arm/acornscsi.c | 14 +- drivers/scsi/arm/fas216.c | 5 +- drivers/scsi/arm/fas216.h | 3 + drivers/scsi/arm/scsi.h | 34 +--- drivers/scsi/atari_NCR5380.c | 47 ++--- drivers/scsi/atp870u.c | 102 ++--------- drivers/scsi/dec_esp.c | 17 -- drivers/scsi/eata_pio.c | 12 +-Quoted 8 lines
drivers/scsi/fd_mcs.c | 36 +--- drivers/scsi/gdth.c | 2 +- drivers/scsi/imm.c | 13 +- drivers/scsi/in2000.c | 10 +- drivers/scsi/oktagon_esp.c | 14 -- drivers/scsi/pluto.c | 2 +- drivers/scsi/ppa.c | 12 +- drivers/scsi/qla1280.c | 348 +++++++++++++++--------------------
Quoted 1 line
The patchset includes qla1280 conversion.
Yes I saw it I'll drop qla1280.
Quoted 8 lines
Quoted 4 lines
drivers/scsi/qlogicpti.c | 54 +----- drivers/scsi/scsi_error.c | 114 ++++++++----The patchset includes your patch to convert
scsi_error.c. What else do you want to change?
scsi_error.c is to do with the USB changes I'll be sending very soon. It's currently in testing.
Quoted 16 lines
Quoted 16 lines
drivers/scsi/seagate.c | 17 +- drivers/scsi/sun3_NCR5380.c | 42 ++--- drivers/scsi/sun3x_esp.c | 21 +-- drivers/scsi/wd33c93.c | 10 +- drivers/usb/storage/freecom.c | 14 +- drivers/usb/storage/isd200.c | 6 +- drivers/usb/storage/protocol.c | 120 +++++------- drivers/usb/storage/sddr09.c | 9 +- drivers/usb/storage/shuttle_usbat.c | 54 +++--- drivers/usb/storage/transport.c | 95 ++++------ drivers/usb/storage/transport.h | 2 + include/scsi/scsi_eh.h | 17 ++- 38 files changed, 574 insertions(+), 905 deletions(-)
Quoted 7 lines
Quoted 2 lines
If any of these are obsolete and should be removed please say so. Save me the work to submit them.
I think that nobody cares about some of these drivers and they might be even broken. We need to merge the patchset to -mm and then we can see what drivers people still care about. And if necessary, we can blindly just convert drivers.
If you know of any, specifically than lets send patches to remove them. No point in leaving them not compilable. Other wise My conversions are not "blindly" and I think are pretty safe. I hope.
Boaz
Quoted 32 lines · On Sun, 09 Sep 2007 17:09:15 +0300 Boaz Harrosh <[email protected]> wrote:
Quoted 31 lines · FUJITA Tomonori
Quoted 28 lines · On Sun, 09 Sep 2007 11:25:57 +0300 Boaz Harrosh <[email protected]> wrote:
Quoted 19 lines · FUJITA Tomonori
This patchset, which I submitted before, adds a new data structure,
scsi_data_buffer, including everything for data transfer:struct
scsi_data_buffer{ unsigned length; int resid; shortsg_count;
short__sg_count; struct scatterlist *sglist; };One
scsi_data_bufferstructure is embedded in structscsi_cmndfor uni-directional transfer. All the members are just moved fromscsi_cmndstructure toscsi_data_bufferstructure. So nothing is added toscsi_cmndstructure.After applying this patchset, llds must use the scsi data accessors. This patchset includes some conversation patches (most of them are patches that Boaz submitted before), however there is still some code that is needed to be converted.
Boaz, if you still have other conversation patches, please submit them.
Quoted 6 lines
I suspect that nobody cares about some of unconverted llds, which will be not compilable after this patchset. I'll fix ldds that people
complain about.It's difficult to test this patchset in -mm via scsi-misc. Jens, please send this to -mm via the block tree.
Sorry for the late response. Just am back from vacation.
Quoted 8 lines
Quoted 5 lines
Quoted 2 lines
Tomo please hold with these patches a bit longer the Tree is not ready for it.
Then we have no chance to merge
scsi_data_bufferinto 2.6.24.I hope to submit all/most of the work this week. If we miss the window for 2.6.24 than I'm very sorry for that. But I don't think we are aloud to break USB storage subsystem.
I'll send patches for USB (in a 'search and replace' way) if you don't soon. Except for USB, I suspect that nobody cares about most of the unconverted drivers.