Re: [kvm-ppc-devel]
Quoted 15 lines · On Wednesday 02 April 2008 12:09:40 Jerone Young wrote:
Quoted 13 lines · Jimi Xenidis
Review
Quoted 7 lines · Jerone Young
(quoted diff) +7
-0+void ppc4xx_idle(void) +{ + unsigned long msr_save; + + /* set wait state MSR */ + msr_save = mfmsr(); + mtmsr(msr_save|MSR_WE|MSR_EE|MSR_CE);1) I think you also want
MSR_DEhere, no?
2) Just to be safe, I'd also append anisync();
3) In caseMSR_WEdoes nothing, or continues from here I'd append "mstmsr(msr_save);isync();" as well
Quoted 2 lines
Looks like using
local_irq_enable()just might have been a better idea after all.
Doesn't look that way to me.
Quoted 3 lines
So the
MSR_DEis yet another case that could go here. If it was on coming into power_save...I'm assuming it would get disabled bylocal_irq_disable().
This is not the case. Please look it up if you have any question.
Signature · 12 lines
Hollis Blanchard IBM Linux Technology Center ------------------------------------------------------------------------- Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace _______________________________________________ kvm-ppc-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/kvm-ppc-devel