Skip to contentSkip to conversation

xfs_unmountfs should return void

PATCH In review Christoph Hellwig 1 participant 1 message Jul 26, 2008 XFS filesystem

lore
Share & tools
lore
#0 lore raw

PATCH 3/6 xfs_unmountfs should return void

xfs_unmounts can't and shouldn't return errors so declare it as returning void.

fs/xfs/xfs_mount.c +5 -7
Index: linux-2.6-xfs/fs/xfs/xfs_mount.c
===================================================================
@@ -1229,16 +1229,15 @@ xfs_mountfs(
 }
 
 /*
- * xfs_unmountfs
- *
  * This flushes out the inodes,dquots and the superblock, unmounts the
  * log and makes sure that incore structures are freed.
  */
-int
-xfs_unmountfs(xfs_mount_t *mp)
+void
+xfs_unmountfs(
+	struct xfs_mount	*mp)
 {
-	__uint64_t	resblks;
-	int		error = 0;
+	__uint64_t		resblks;
+	int			error;
 
 	IRELE(mp->m_rootip);
 
@@ -1311,7 +1310,6 @@ xfs_unmountfs(xfs_mount_t *mp)
 	xfs_errortag_clearall(mp, 0);
 #endif
 	xfs_mount_free(mp);
-	return 0;
 }
 
 STATIC void
fs/xfs/xfs_mount.h +1 -1
Index: linux-2.6-xfs/fs/xfs/xfs_mount.h
===================================================================
@@ -511,7 +511,7 @@ extern int	xfs_log_sbcount(xfs_mount_t *
 extern int	xfs_mountfs(xfs_mount_t *mp);
 extern void	xfs_mountfs_check_barriers(xfs_mount_t *mp);
 
-extern int	xfs_unmountfs(xfs_mount_t *);
+extern void	xfs_unmountfs(xfs_mount_t *);
 extern int	xfs_unmountfs_writesb(xfs_mount_t *);
 extern int	xfs_unmount_flush(xfs_mount_t *, int);
 extern int	xfs_mod_incore_sb(xfs_mount_t *, xfs_sb_field_t, int64_t, int);