Skip to contentSkip to conversation

use KM_MAYFAIL in xfs_mountfs

PATCH In review Christoph Hellwig 1 participant 1 message Jul 26, 2008 XFS filesystem

lore
Share & tools
lore
#0 lore raw

PATCH 6/6 use KM_MAYFAIL in xfs_mountfs

Use KM_MAYFAIL for the m_perag allocation, we can deal with the error easily and blocking forever during mount is not a good idea either.

fs/xfs/xfs_mount.c +4 -2
Index: linux-2.6-xfs/fs/xfs/xfs_mount.c
===================================================================
@@ -1052,8 +1052,10 @@ xfs_mountfs(
 	 * Allocate and initialize the per-ag data.
 	 */
 	init_rwsem(&mp->m_peraglock);
-	mp->m_perag =
-		kmem_zalloc(sbp->sb_agcount * sizeof(xfs_perag_t), KM_SLEEP);
+	mp->m_perag = kmem_zalloc(sbp->sb_agcount * sizeof(xfs_perag_t),
+				  KM_MAYFAIL);
+	if (!mp->m_perag)
+		goto error1;
 
 	mp->m_maxagi = xfs_initialize_perag(mp, sbp->sb_agcount);