Skip to contentSkip to conversation

x86: UV runtime bios calls

PATCH In review Russ Anderson 2 participants 4 messages Sep 22, 2008 – Sep 24, 2008

lore
Share & tools
lore
#0 lore raw

cover x86: UV runtime bios calls

[PATCH 0/4] x86: UV runtime bios calls

Purpose:
Create an interface to allow calls into bios to return platform specific information. The interface uses EFI SAL table entry. EFI provides a mechanism for defining function pointers to firmware routines. This patchset builds on the EFI mechanism to provide access to those firmware routines.

Patches:
uv_efi_bios: Look for SAL entry in EFI tables.

uv_bios_common: Add the EFI callback function using the EFI table
entry. Create associated wrapper code. Initialize SAL system table entry info at boot time.

uv_bios_call_partition: Add call to get partitioning related info.

uv_sysfs: Create sysfs entrys in /sys/firmware/sgi_uv/ for
partitioning related information.

Implementation comments:

This patch uses sal_systab. sal_systab is used on ia64, but was not used on x86. An alternative would be to create a new EFI entry type (uv_systab), though that would require adding to struct efi.

The location in sysfs (/sys/firmware/sgi_uv/) is based on community feedback.

If EFI is not configured (CONFIG_EFI), the calls will return -ENOSYS. If run on a system with a bios that does not supportes EFI SAL, the calls will return -ENOSYS.

Paul Jackson assisted in the development of this code.

Signature · 2 lines
Russ Anderson, OS RAS/Partitioning Project Lead  
SGI - Silicon Graphics Inc          [email protected]
#1 lore raw

Hi, Russ,

This seems to include a extension to EFI runtime services. Why not also discuss that on UEFI forum? You can get some information about UEFI forum from http://www.uefi.org/.

Best Regards,
Huang Ying

Quoted 37 lines · Russ Anderson

[PATCH 0/4] x86: UV runtime bios calls

Purpose:
Create an interface to allow calls into bios to return platform specific information. The interface uses EFI SAL table entry. EFI provides a mechanism for defining function pointers to firmware routines. This patchset builds on the EFI mechanism to provide access to those firmware routines.

Patches:
uv_efi_bios: Look for SAL entry in EFI tables.

uv_bios_common: Add the EFI callback function using the EFI table
entry. Create associated wrapper code. Initialize SAL system table entry info at boot time.

uv_bios_call_partition: Add call to get partitioning related info.

uv_sysfs: Create sysfs entrys in /sys/firmware/sgi_uv/ for
partitioning related information.

Implementation comments:

This patch uses sal_systab. sal_systab is used on ia64, but was not used on x86. An alternative would be to create a new EFI entry type (uv_systab), though that would require adding to struct efi.

The location in sysfs (/sys/firmware/sgi_uv/) is based on community feedback.

If EFI is not configured (CONFIG_EFI), the calls will return -ENOSYS. If run on a system with a bios that does not supportes EFI SAL, the calls will return -ENOSYS.

Paul Jackson assisted in the development of this code.

#2 lore raw
In reply to Russ Anderson

Hi, Russ,

Quoted 4 lines · Russ Anderson

This patch uses sal_systab. sal_systab is used on ia64, but was not used on x86. An alternative would be to create a new EFI entry type (uv_systab), though that would require adding to struct efi.

I don't think it is a good idea to use sal_systab, if it is not a real sal_systab. It's better to add new field such as uv_systab to struct efi, which is not defined by UEFI standard, so can be changed.

Best Regards,
Huang Ying

#3 lore raw
Quoted 11 lines · Huang Ying

Hi, Russ,

Quoted 4 lines · Russ Anderson

This patch uses sal_systab. sal_systab is used on ia64, but was not used on x86. An alternative would be to create a new EFI entry type (uv_systab), though that would require adding to struct efi.

I don't think it is a good idea to use sal_systab, if it is not a real sal_systab. It's better to add new field such as uv_systab to struct efi, which is not defined by UEFI standard, so can be changed.

OK. My first development version took that approach, so it I just have to put that code back in.

Thanks,

Signature · 2 lines
Russ Anderson, OS RAS/Partitioning Project Lead  
SGI - Silicon Graphics Inc          [email protected]