Skip to contentSkip to conversation

e1000e: workaround hw errata

PATCH Applied Jeff Kirsher 2 participants 2 messages Jan 24, 2009 – Jan 26, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 e1000e: workaround hw errata

From: Jesse Brandeburg <[email protected]>

There is a hardware errata in some revisions of the 82574 that needs to be worked around in the driver by setting a register bit at init.

If this bit is not set A0 versions of the 82574 can generate tx hangs.

---

 drivers/net/e1000e/82571.c |    6 +++++-
 drivers/net/e1000e/hw.h    |    1 +
 2 files changed, 6 insertions(+), 1 deletions(-)
drivers/net/e1000e/82571.c +5 -1
index cf43ee7..0890162 100644
@@ -981,11 +981,15 @@ static void e1000_initialize_hw_bits_82571(struct e1000_hw *hw)
 		ew32(PBA_ECC, reg);
 	}
 
-	/* PCI-Ex Control Register */
+	/* PCI-Ex Control Registers */
 	if (hw->mac.type == e1000_82574) {
 		reg = er32(GCR);
 		reg |= (1 << 22);
 		ew32(GCR, reg);
+
+		reg = er32(GCR2);
+		reg |= 1;
+		ew32(GCR2, reg);
 	}
 
 	return;
drivers/net/e1000e/hw.h +1 -0
index f25e961..2d4ce04 100644
@@ -206,6 +206,7 @@ enum e1e_registers {
 	E1000_MANC2H    = 0x05860, /* Management Control To Host - RW */
 	E1000_SW_FW_SYNC = 0x05B5C, /* Software-Firmware Synchronization - RW */
 	E1000_GCR	= 0x05B00, /* PCI-Ex Control */
+	E1000_GCR2      = 0x05B64, /* PCI-Ex Control #2 */
 	E1000_FACTPS    = 0x05B30, /* Function Active and Power State to MNG */
 	E1000_SWSM      = 0x05B50, /* SW Semaphore */
 	E1000_FWSM      = 0x05B54, /* FW Semaphore */
maintainer Applied
#1 lore raw

From: Jeff Kirsher <[email protected]>
Date: Fri, 23 Jan 2009 17:35:31 -0800

Quoted 9 lines

There is a hardware errata in some revisions of the 82574 that needs to be worked around in the driver by setting a register bit at init.

If this bit is not set A0 versions of the 82574 can generate tx hangs.

Applied, thanks Jeff.