acpi: check _PSS invalidation when BIOS report _PSS with 0x80000000
PATCH 2/8 acpi: check _PSS invalidation when BIOS report _PSS with 0x80000000
From: Youquan, Song <[email protected]>
When cpu frequencey scaling is disabled, some BIOSes report _PSS with all 0x80000000. If the kernel treats this case as valid, the kernel will boot crash when load cpufreq govenors.
So in order to cover more buggy BIOSs, the patch just check _PSS core frequency invalidation.
---
drivers/acpi/processor_perflib.c | 9 +++++++++ 1 file changed, 9 insertions(+)
drivers/acpi/processor_perflib.c renamed from drivers/acpi/processor_perflib.c~acpi-check-_pss-invalidation-when-bios-report-_pss-with-all-0x80000000 +9 -0
@@ -42,6 +42,7 @@#define ACPI_PROCESSOR_CLASS "processor"#define ACPI_PROCESSOR_FILE_PERFORMANCE "performance"#define _COMPONENT ACPI_PROCESSOR_COMPONENT +#define ACPI_PROCESSOR_PSS_INVALID 0x80000000ACPI_MODULE_NAME ("processor_perflib" );static DEFINE_MUTEX (performance_mutex);
@@ -316,6 +317,14 @@ static int acpi_processor_get_performanckfree (pr->performance->states); goto end; } + +if (px->core_frequency ==ACPI_PROCESSOR_PSS_INVALID ) { + printk(KERN_ERR PREFIX + "P-states disabled in the BIOS\n"); + result = -EFAULT ; +kfree (pr->performance->states); + goto end; + } } end:
_
NAK -- per previous discussion on the list.
This patch is not the right way to address this issue, which is reported here, BTW:
https://bugzilla.redhat.com/show_bug.cgi?id=467941
--
Len Brown, Intel Open Source Technology Center
Quoted 46 lines · On Wed, 4 Mar 2009, [email protected] wrote:
From: Youquan, Song <[email protected]>
When cpu frequencey scaling is disabled, some BIOSes report
_PSSwith all0x80000000. If the kernel treats this case as valid, the kernel will boot crash when load cpufreq govenors.So in order to cover more buggy BIOSs, the patch just check
_PSScore frequency invalidation.Signed-off-by Youquan, Song <[email protected]>Signed-off-by Pallipadi, Venkatesh <[email protected]>Cc Len Brown <[email protected]>Signed-off-by Andrew Morton <[email protected]>---
drivers/acpi/processor_perflib.c | 9 +++++++++ 1 file changed, 9 insertions(+)diff -puN
drivers/acpi/processor_perflib.c~acpi-check-_pss-invalidation-when-bios-report-_pss-with-all-0x80000000drivers/acpi/processor_perflib.cdrivers/acpi/processor_perflib.c renamed from drivers/acpi/processor_perflib.c~acpi-check-_pss-invalidation-when-bios-report-_pss-with-all-0x80000000 +9
-0@@ -42,6 +42,7 @@#define ACPI_PROCESSOR_CLASS "processor"#define ACPI_PROCESSOR_FILE_PERFORMANCE "performance"#define _COMPONENT ACPI_PROCESSOR_COMPONENT +#define ACPI_PROCESSOR_PSS_INVALID 0x80000000ACPI_MODULE_NAME ("processor_perflib" );static DEFINE_MUTEX (performance_mutex);@@ -316,6 +317,14 @@ static int acpi_processor_get_performanckfree (pr->performance->states); goto end; } + +if (px->core_frequency ==ACPI_PROCESSOR_PSS_INVALID ) { + printk(KERN_ERR PREFIX + "P-states disabled in the BIOS\n"); + result = -EFAULT ; +kfree (pr->performance->states); + goto end; + } } end:_