Skip to contentSkip to conversation

ath9k: reset after PCI FATAL/PERR interrupts

PATCH New Steven Luo 2 participants 2 messages Apr 12, 2009 – Apr 13, 2009 Networking drivers (wireless)

lore
Share & tools
lore

Steven Luo

author
#0 lore raw

PATCH 1/1 ath9k: reset after PCI FATAL/PERR interrupts

From: Steven Luo <[email protected]>

ath9k_hw_getisr() doesn't appear to set anything in the status mask for PCI FATAL or PERR interrupts (AR_INTR_SYNC_HOST1_FATAL/PERR), which the open-source HAL seems to do. This means that the card isn't reset after these interrupts.

This patch seems to fix a problem where the wireless drops out with an "ath9k: received PCI FATAL interrupt" in dmesg after some time; the hardware is an AR5416 in an ASUS WL-500W running 2.6.28.7 (OpenWRT) and compat-wireless 2009-03-31.

---

drivers/net/wireless/ath9k/hw.c +1 -0
@@ -3007,6 +3007,7 @@ bool ath9k_hw_getisr(struct ath_hw *ah, 
 				DPRINTF(ah->ah_sc, ATH_DBG_ANY,
 					"received PCI PERR interrupt\n");
 			}
+			*masked |= ATH9K_INT_FATAL;
 		}
 		if (sync_cause & AR_INTR_SYNC_RADM_CPL_TIMEOUT) {
 			DPRINTF(ah->ah_sc, ATH_DBG_INTERRUPT,
#1 lore raw

PATCH 1/1 ath9k: reset after PCI FATAL/PERR interrupts

Quoted 17 lines · Steven Luo

ath9k_hw_getisr() doesn't appear to set anything in the status mask for PCI FATAL or PERR interrupts (AR_INTR_SYNC_HOST1_FATAL/PERR), which the open-source HAL seems to do. This means that the card isn't reset after these interrupts.

This patch seems to fix a problem where the wireless drops out with an "ath9k: received PCI FATAL interrupt" in dmesg after some time; the hardware is an AR5416 in an ASUS WL-500W running 2.6.28.7 (OpenWRT) and compat-wireless 2009-03-31.

---

drivers/net/wireless/ath9k/hw.c bool ath9k_hw_getisr(struct ath_hw *ah, · line 3013

Quoted 7 lines
drivers/net/wireless/ath9k/hw.c +1 -0
@@ -3007,6 +3007,7 @@ bool ath9k_hw_getisr(struct ath_hw *ah, 
 				DPRINTF(ah->ah_sc, ATH_DBG_ANY,
 					"received PCI PERR interrupt\n");
 			}
+			*masked |= ATH9K_INT_FATAL;
 		}
 		if (sync_cause & AR_INTR_SYNC_RADM_CPL_TIMEOUT) {
 			DPRINTF(ah->ah_sc, ATH_DBG_INTERRUPT,

Thanks for the patch. The actual cause of the FATAL interrupt still remains unclear, though. We'll work on this issue.

Sujith