mmc_spi: don't use EINVAL for possible transmission errors
Subsystems (2)
PATCH 1/1 mmc_spi: don't use EINVAL for possible transmission errors
From: Wolfgang Muees <[email protected]>
o This patch changes the reported error code for the responses to a command from EINVAL to EFAULT/ENOSYS, as EINVAL is reserved for non-recoverable host errors, and the responses from the SD/MMC card may be because of recoverable transmission errors in the command or in the response. Response codes in SPI mode are NOT protected by a checksum, so don't trust them.
This is a revised, minimal-invasive patch version. As Pierre Ossman pointed out, EINVAL should only be used for non-recoverable errors (and is used so in the whole rest of the mmc framework).
I have checked every instance of EINVAL in the mmc framework - no changes were needed here.
This patch is neccessary for doing a sensible retry managment in the mmmc block layer (patch will follow).
---
drivers/mmc/host/mmc_spi.c +6 -5
@@ -335,15 +335,16 @@ checkstatus:/* Status byte: the entire seven-bit R1 response. */ if (cmd->resp[0 ] !=0 ) { -if ((R1_SPI_PARAMETER |R1_SPI_ADDRESS - |R1_SPI_ILLEGAL_COMMAND ) +if ((R1_SPI_PARAMETER |R1_SPI_ADDRESS ) & cmd->resp[0 ]) - value = -EINVAL ; + value = -EFAULT ;/* Bad address */ +else if (R1_SPI_ILLEGAL_COMMAND & cmd->resp[0 ]) + value = -ENOSYS ;/* Function not implemented */ else if (R1_SPI_COM_CRC & cmd->resp[0 ]) - value = -EILSEQ ; + value = -EILSEQ ;/* Illegal byte sequence */ else if ((R1_SPI_ERASE_SEQ |R1_SPI_ERASE_RESET ) & cmd->resp[0 ]) - value = -EIO ; + value = -EIO ;/* I/O error */ /* else R1_SPI_IDLE, "it's resetting" */ }
---
regards
i. A. Wolfgang Mües
Signature · 13 lines
Auerswald GmbH & Co. KG Hardware Development Telefon: +49 (0)5306 9219 0 Telefax: +49 (0)5306 9219 94 E-Mail: [email protected] Web: http://www.auerswald.de -------------------------------------------------------------- Auerswald GmbH & Co. KG, Vor den Grashöfen 1, 38162 Cremlingen Registriert beim AG Braunschweig HRA 13289 p.h.G Auerswald Geschäftsführungsges. mbH Registriert beim AG Braunschweig HRB 7463 Geschäftsführer: Dipl-Ing. Gerhard Auerswald