Add inverted clock polarity support for Atmel LCD driver
Subsystems (3)
PATCH 1/1 Add inverted clock polarity support for Atmel LCD driver
This is my third try for Olimex SAM9-L9260/61 board support patches.
Here follows the first patch.
---
Boards utilizing the Atmel LCD driver can now specify that the LCD clock must be inverted by defining the macro CONFIG_LCD_INVERTED_CLOCK.
--- README | 5 +++++ drivers/video/atmel_lcdfb.c | 3 +++ 2 files changed, 8 insertions(+), 0 deletions(-)
README +5 -0
@@ -1063,6 +1063,11 @@ The following options need to be configured: Normally display is black on white background; define CONFIG_SYS_WHITE_ON_BLACK to get it inverted. + CONFIG_LCD_INVERTED_CLOCK + Define this if your LCD needs inverted clock polarity. Note + that this feature will work only if the selected LCD driver + and hardware controller support it. + - Splash Screen Support: CONFIG_SPLASH_SCREEN If this option is set, the environment is checked for
drivers/video/atmel_lcdfb.c +3 -0
@@ -112,6 +112,9 @@ void lcd_ctrl_init(void *lcdbase) value |= panel_info.vl_sync; value |= (panel_info.vl_bpix <<5 ); +#if defined(CONFIG_LCD_INVERTED_CLOCK ) + value |=ATMEL_LCDC_INVCLK_INVERTED ; +#endif lcdc_writel (panel_info.mmio,ATMEL_LCDC_LCDCON2 , value);/* Vertical timing */
Signature · 1 line
1.5.6.1
PATCH v3 2/3 Add support for Olimex SAM9-L9261 SBC
The SAM9-L9261 board support is based on code for AT91SAM9261EK. Networking is missing and will be added after the DM9000 support for AT91 boards is fixed to comply with U-Boot guide-lines.
--- MAINTAINERS | 3 + MAKEALL | 1 + Makefile | 17 +++ board/olimex/sam9_l9261/Makefile | 56 ++++++++ board/olimex/sam9_l9261/config.mk | 1 + board/olimex/sam9_l9261/led.c | 43 +++++++ board/olimex/sam9_l9261/partition.c | 40 ++++++ board/olimex/sam9_l9261/sam9_l9261.c | 214 +++++++++++++++++++++++++++++++ include/configs/sam9_l9261.h | 230 ++++++++++++++++++++++++++++++++++ tools/Makefile | 3 + tools/logos/olimex.bmp | Bin 0 -> 27510 bytes 11 files changed, 608 insertions(+), 0 deletions(-) create mode 100644 board/olimex/sam9_l9261/Makefile create mode 100644 board/olimex/sam9_l9261/config.mk create mode 100644 board/olimex/sam9_l9261/led.c create mode 100644 board/olimex/sam9_l9261/partition.c create mode 100644 board/olimex/sam9_l9261/sam9_l9261.c create mode 100644 include/configs/sam9_l9261.h create mode 100644 tools/logos/olimex.bmp
MAINTAINERS +3 -0
@@ -133,6 +133,9 @@ Jon Diekema <[email protected]> sbc8260 MPC8260 +Dimitar Dimitrov <[email protected]> + sam9_l9261 AT91SAM9261 + Dirk Eibach <[email protected]> gdppc440etx PPC440EP/GR
MAKEALL +1 -0
@@ -599,6 +599,7 @@ LIST_at91=" \ m501sk \ pm9261 \ pm9263 \ + sam9_l9261 \ " #########################################################################
Makefile +17 -0
@@ -2847,6 +2847,23 @@ at91sam9g45ekes_config : unconfig pm9263_config : unconfig @$(MKCONFIG) $(@:_config=) arm arm926ejs pm9263 ronetix at91 +sam9_l9261_nandflash_config \ +sam9_l9261_dataflash_cs0_config \ +sam9_l9261_dataflash_cs3_config \ +sam9_l9261_config : unconfig + @mkdir -p $(obj)include + @if [ "$(findstring _nandflash,$@)" ] ; then \ + echo "#define CONFIG_SYS_USE_NANDFLASH 1" >>$(obj)include/config.h ; \ + $(XECHO) "... with environment variable in NAND FLASH" ; \ + elif [ "$(findstring dataflash_cs3,$@)" ] ; then \ + echo "#define CONFIG_SYS_USE_DATAFLASH_CS3 1" >>$(obj)include/config.h ; \ + $(XECHO) "... with environment variable in SPI DATAFLASH CS3" ; \ + else \ + echo "#define CONFIG_SYS_USE_DATAFLASH_CS0 1" >>$(obj)include/config.h ; \ + $(XECHO) "... with environment variable in SPI DATAFLASH CS0" ; \ + fi; + @$(MKCONFIG) -a sam9_l9261 arm arm926ejs sam9_l9261 olimex at91 + ######################################################################## ## ARM Integrator boards - see doc/README-integrator for more info. integratorap_config \
board/olimex/sam9_l9261/Makefile new file +56 -0
56 lines not on this page · raw message
board/olimex/sam9_l9261/config.mk new file +1 -0
@@ -0,0 +1 @@ +TEXT_BASE = 0x23f00000
board/olimex/sam9_l9261/led.c new file +43 -0
43 lines not on this page · raw message
board/olimex/sam9_l9261/partition.c new file +40 -0
@@ -0,0 +1,40 @@ +/* +* (C) Copyright 2008 +* Ulf Samuelsson <[email protected]> +* +* This program is free software; you can redistribute it and/or +* modify it under the terms of the GNU General Public License as +* published by the Free Software Foundation; either version 2 of +* the License, or (at your option) any later version. +* +* This program is distributed in the hope that it will be useful, +* but WITHOUT ANY WARRANTY; without even the implied warranty of +* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +* GNU General Public License for more details. +* +* You should have received a copy of the GNU General Public License +* along with this program; if not, write to the Free Software +* Foundation, Inc., 59 Temple Place, Suite 330, Boston, +* MA 02111-1307 USA +* +*/ +#include <common.h> +#include <config.h> +#include <asm/hardware.h> +#include <dataflash.h> + +AT91S_DATAFLASH_INFO dataflash_info[CONFIG_SYS_MAX_DATAFLASH_BANKS ]; + +struct dataflash_addr cs[CONFIG_SYS_MAX_DATAFLASH_BANKS ] = { + {CONFIG_SYS_DATAFLASH_LOGIC_ADDR_CS0 ,0 },/* Logical adress, CS */ + {CONFIG_SYS_DATAFLASH_LOGIC_ADDR_CS3 ,3 } +}; + +/*define the area offsets*/ +dataflash_protect_t area_list[NB_DATAFLASH_AREA ] = { + {0x00000000 ,0x000041FF ,FLAG_PROTECT_SET ,0 ,"Bootstrap" }, + {0x00004200 ,0x000083FF ,FLAG_PROTECT_CLEAR ,0 ,"Environment" }, + {0x00008400 ,0x00041FFF ,FLAG_PROTECT_SET ,0 ,"U-Boot" }, + {0x00042000 ,0x00251FFF ,FLAG_PROTECT_CLEAR ,0 ,"Kernel" }, + {0x00252000 ,0xFFFFFFFF ,FLAG_PROTECT_CLEAR ,0 ,"FS" }, +};
board/olimex/sam9_l9261/sam9_l9261.c new file +214 -0
214 lines not on this page · raw message
include/configs/sam9_l9261.h new file +230 -0
230 lines not on this page · raw message
tools/Makefile +3 -0
@@ -122,6 +122,9 @@ endif ifeq ($(VENDOR),atmel) LOGO_BMP= logos/atmel.bmp endif +ifeq ($(VENDOR),olimex) +LOGO_BMP= logos/olimex.bmp +endif ifeq ($(VENDOR),ronetix) LOGO_BMP= logos/ronetix.bmp endif
tools/logos/olimex.bmp new file binary +0 -0
zzcIJCZ{WUx`v&eCxNqRTf%^vT8 at O-a?KdF*T0)b=YX9-@<d-&{&Ua3Z9+=F((s?^8 zyY}at#?Hw%eMRNU$!Yv?jbN7BB7>Fg16;P9xx%B0%XxWu{9%Eov)&b%t90-CY&Uad z2NfTi_3?Ov%ZIzHIhvMbCA>0~AbTCFsp^rM>?=NXYn at UF$8Ud|d)BOr4Ggnc#H-mJ zW$hLQ at +m^-4Tcl#@!f#}YmH=j^1<Bq#qWbs?veRlwn%o<4d at Cnqgrf#THB%2pGav zPmoX*E52;oUTRsrOA at 1^!VqcD-AK57#+l?uvsqJ8=A@wY(-m~)z9IX{6SX+cIx-gx z+>K-hPdmAq^jd>jFofC-9-RY!5rNpePRiVvuSdBU_DqX)S*FltO&QN at Ru;!PK$s z6fq{hlmy{D?NDBYihOP)IPv6ptdlCoq!Ti=sG{$fg5Ja}X~MG#t?Uwld4IQ-j(sK# z3+O5#3rj24u7-bK$YhKvm7wdnIOiTMv*}qU<F37>PRPcWUT at h@=WK=Ttlv3JY2>d z(ndd<4DgGv9<T5nVN<#<ZDxrKW*HBW7D?cANoG;>o{dN7LAb2Wr}q}i(?5hPqO^U z4cXZJFtehmwS{GT8UVr#OTI{x>qf>El%EQ~RLh+fgjZ-#g-mj}%0$<@%*BklAA=bq zoYub><M@DMCXW<91S{HYD!~12^kWpPiQV6RZOdCMS_rJ+06=_4P+uT=p9ni)cg+| zpB(B=>3VL-xQk?&AY=)3_(bOrT>u&v at 5cRsEtf;{x;#7v at fAym%p<F61s|Od6$Toz zZv#^^3?OPqTbyYqd4q=dNY;eN8Oajr@QKbLx&Sm}-xj21oJd$MV<k9L4B0XWku#E2 zwStdMi256+rgo63l~z)YDk=fiO5u7dLgWp|N=G9{oOvTX5y-xc2Tdk+fg&)G;A%y+ z3L->~Lsr^CjyUsr3g7>DD9OgiVUSrx^&l--tf*BG+2M~`$T2kYS_-=>;5LF!JWNqD zv at 0rz6yV?~czaePA;OTAwvZ#vJbyJZf40ydKQ-4blF6pBc29|qo>Z$)Lgb8Or7h%$ zGtYf$8Uo(j8*Gd*Yy&8fh%IOg+bc9=Uf>B4hOB^h13BW%BXGswd5Y|7Mw8iFnBUc! zW6il*(eZ=I6--F7W!gdoapvg at HEibK#Th<qjM=Nzh!92{De6zA at 6lJee1amAA&Z9 zP3B&%iia at iP*JsF3Hb|Mn9VKHL91)e0uRL?j9lUbvJG9+Jz568^b0ulR8L_isn^i z#usH~7D859LXJ4|<VMnr!)y#nP@P*VR9>erw5wtULkl4*Eg?sodGa1<#$h%FC8*A= z6)LY&7&=rwgrP-{m3ELL&OCXKG~+NEgA!Ed)(Vx^DGVJdAHvWg$VxlN5oeyhh=jnK z60<$wlew2tv6Q&SPurstaFwCulf|TJ<Z98I!fOg>QzqdEf#G+HRq+TW9jH~56XrBe zj~k{PR1jxgPvN_($rHl2a%~(LoM^9RQxBNKJbn>mr5)smGjF6P0=hNOTNMwgIF7Vc zlW&NM1lOTWteC8%AmciP7#(;+oe0t~WcE22gKdqc3%7r<RD6n at VrUU$r5)smGjF6P z0=fp!WX@d>tzBVQg+pzWt%S||mijTEUOF8);>;WAiGWT9noR7%iclw+s`RM}Lu(LO z>1gDLGjF6P0=fp!WMUUmL<UJ%DNU)Mm{|x}X$d*v%p2*6fUW^Fnb-x2z(j&8m1z|e zGYcUrEg?soc_Td$&^3T26T7G)E|m(_f_fE1h#ZHkw1pgT=8d!r=&zn^j2s3TDGaR? z!G)w|LC^``<<DX|fqz>>I2$}qgK>YM_eyGUBhe?eB1DcuRx*>%ffyZlO~LNUM3liN z9;R0WP1%9e^i5uKfql{mLKcCL$oF16F!-kSW86hj6TPKoR at hXu((pEt6(h?dODOY1 z4m<Pc?IlLx)psMK^eHpd5FtVS6ly**#t;i2FRRciBSt6lkkZEiW>JAn3azD(Z6ZLb z9Id_z3oM&V1z8}6n|QE{(hgj;=-PV<UlmGAY0^XphrtAC4^uRx%_SvQEPhgq)3bS5 z>-5V_9AM1I#RnV5ARaVsH7eQrA>-&-HR(3QvKxXacEAJlb%}Z9L(}pcJMk3WvPB zj~~$1GP^yKbYoF*caDfnXEWJE)F+?ZBF-Tusyb2^DbM^h1?VEkhzr5KT|lE+ at g@} zp(&ek5y5ApF}wg>=M$_Fg0CdxQ1S2u=h-dLgV*^WU3Y+e)b$l7KpcIoERmI{<JNu z!1zOgQ3beCiViP4ccmD-6yFFs;ZnbbeVr==X$3EX9LRxFu5u1ct(e067#<E|I;) z&un26p^lR>!r8nOM4p^gTG;G4J0l^Pk<F_%$eTomcNHaNnKFY#A8kjBQrNFNew1f ze8*U*0&TX=OhjlAQ)U=B5$dqCeNI?gs;@ZBbZoFA4IRT_)Pl$7mJMOmkA8PtJ%<9; zTNOHeHgyi*#mAJ_+>b(FA0q)g+ngF+nn)`vm75Hba-H at eItebee*xs_S%cMLtZPt zfwud;VbFV4%^}}&BR8A(b<vlzq(gq_p|J0VZhLXFb;^sa8^3ShzJdD&?i;vo;Dc}A w)2B!K=P|#1 at ZMkgcI|4~#f<-b=|}zW^Q~*?AD#Ql-GKat8c&zqOTB@A01O0K1ONa4
literal 0
HcmV?d00001
Signature · 1 line
1.5.6.1
PATCH v3 3/3 Add support for Olimex SAM9-L9260 SBC
In reply to Dimitar DimitrovThe SAM9-L9260 board support is based on code for AT91SAM9260EK. Networking is missing and will be added after the MACB support for AT91 boards is fixed to comply with U-Boot guide-lines.
--- MAINTAINERS | 1 + MAKEALL | 1 + Makefile | 17 +++ board/olimex/sam9_l9260/Makefile | 56 +++++++++ board/olimex/sam9_l9260/config.mk | 1 + board/olimex/sam9_l9260/led.c | 41 +++++++ board/olimex/sam9_l9260/partition.c | 40 +++++++ board/olimex/sam9_l9260/sam9_l9260.c | 111 ++++++++++++++++++ include/configs/sam9_l9260.h | 214 ++++++++++++++++++++++++++++++++++ 9 files changed, 482 insertions(+), 0 deletions(-) create mode 100644 board/olimex/sam9_l9260/Makefile create mode 100644 board/olimex/sam9_l9260/config.mk create mode 100644 board/olimex/sam9_l9260/led.c create mode 100644 board/olimex/sam9_l9260/partition.c create mode 100644 board/olimex/sam9_l9260/sam9_l9260.c create mode 100644 include/configs/sam9_l9260.h
MAINTAINERS +1 -0
@@ -134,6 +134,7 @@ Jon Diekema <[email protected]> sbc8260 MPC8260 Dimitar Dimitrov <[email protected]> + sam9_l9260 AT91SAM9260 sam9_l9261 AT91SAM9261 Dirk Eibach <[email protected]>
MAKEALL +1 -0
@@ -599,6 +599,7 @@ LIST_at91=" \ m501sk \ pm9261 \ pm9263 \ + sam9_l9260 \ sam9_l9261 \ "
Makefile +17 -0
@@ -2847,6 +2847,23 @@ at91sam9g45ekes_config : unconfig pm9263_config : unconfig @$(MKCONFIG) $(@:_config=) arm arm926ejs pm9263 ronetix at91 +sam9_l9260_nandflash_config \ +sam9_l9260_dataflash_cs0_config \ +sam9_l9260_dataflash_cs1_config \ +sam9_l9260_config : unconfig + @mkdir -p $(obj)include + @if [ "$(findstring _nandflash,$@)" ] ; then \ + echo "#define CONFIG_SYS_USE_NANDFLASH 1" >>$(obj)include/config.h ; \ + $(XECHO) "... with environment variable in NAND FLASH" ; \ + elif [ "$(findstring dataflash_cs0,$@)" ] ; then \ + echo "#define CONFIG_SYS_USE_DATAFLASH_CS0 1" >>$(obj)include/config.h ; \ + $(XECHO) "... with environment variable in SPI DATAFLASH CS0" ; \ + else \ + echo "#define CONFIG_SYS_USE_DATAFLASH_CS1 1" >>$(obj)include/config.h ; \ + $(XECHO) "... with environment variable in SPI DATAFLASH CS1" ; \ + fi; + @$(MKCONFIG) -a sam9_l9260 arm arm926ejs sam9_l9260 olimex at91 + sam9_l9261_nandflash_config \ sam9_l9261_dataflash_cs0_config \ sam9_l9261_dataflash_cs3_config \
board/olimex/sam9_l9260/Makefile new file +56 -0
56 lines not on this page · raw message
board/olimex/sam9_l9260/config.mk new file +1 -0
@@ -0,0 +1 @@ +TEXT_BASE = 0x23f00000
board/olimex/sam9_l9260/led.c new file +41 -0
41 lines not on this page · raw message
board/olimex/sam9_l9260/partition.c new file +40 -0
@@ -0,0 +1,40 @@ +/* +* (C) Copyright 2008 +* Ulf Samuelsson <[email protected]> +* +* This program is free software; you can redistribute it and/or +* modify it under the terms of the GNU General Public License as +* published by the Free Software Foundation; either version 2 of +* the License, or (at your option) any later version. +* +* This program is distributed in the hope that it will be useful, +* but WITHOUT ANY WARRANTY; without even the implied warranty of +* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +* GNU General Public License for more details. +* +* You should have received a copy of the GNU General Public License +* along with this program; if not, write to the Free Software +* Foundation, Inc., 59 Temple Place, Suite 330, Boston, +* MA 02111-1307 USA +* +*/ +#include <common.h> +#include <config.h> +#include <asm/hardware.h> +#include <dataflash.h> + +AT91S_DATAFLASH_INFO dataflash_info[CONFIG_SYS_MAX_DATAFLASH_BANKS ]; + +struct dataflash_addr cs[CONFIG_SYS_MAX_DATAFLASH_BANKS ] = { + {CONFIG_SYS_DATAFLASH_LOGIC_ADDR_CS0 ,0 },/* Logical adress, CS */ + {CONFIG_SYS_DATAFLASH_LOGIC_ADDR_CS1 ,1 } +}; + +/*define the area offsets*/ +dataflash_protect_t area_list[NB_DATAFLASH_AREA ] = { + {0x00000000 ,0x000041FF ,FLAG_PROTECT_SET ,0 ,"Bootstrap" }, + {0x00004200 ,0x000083FF ,FLAG_PROTECT_CLEAR ,0 ,"Environment" }, + {0x00008400 ,0x00041FFF ,FLAG_PROTECT_SET ,0 ,"U-Boot" }, + {0x00042000 ,0x00251FFF ,FLAG_PROTECT_CLEAR ,0 ,"Kernel" }, + {0x00252000 ,0xFFFFFFFF ,FLAG_PROTECT_CLEAR ,0 ,"FS" }, +};
board/olimex/sam9_l9260/sam9_l9260.c new file +111 -0
111 lines not on this page · raw message
include/configs/sam9_l9260.h new file +214 -0
214 lines not on this page · raw message
Signature · 1 line
1.5.6.1
PATCH 1/1 Add inverted clock polarity support for Atmel LCD driver
In reply to Dimitar DimitrovQuoted 11 lines · Dimitar Dimitrov
This is my third try for Olimex SAM9-L9260/61 board support patches.
Here follows the first patch.
---Boards utilizing the Atmel LCD driver can now specify that the LCD clock must be inverted by defining the macro
CONFIG_LCD_INVERTED_CLOCK.--- README | 5 +++++ drivers/video/atmel_lcdfb.c | 3 +++ 2 files changed, 8 insertions(+), 0 deletions(-)
Applied to u-boot-video after fixing commit message and adding your Signed-off-by line. Also please check for trailing white spaces next time. Thanks!
Best regards,
Anatolij
PATCH 1/1 Add inverted clock polarity support for Atmel LCD driver
In reply to Dimitar DimitrovQuoted 33 lines · Dimitar Dimitrov
This is my third try for Olimex SAM9-L9260/61 board support patches.
Here follows the first patch.
---Boards utilizing the Atmel LCD driver can now specify that the LCD clock must be inverted by defining the macro
CONFIG_LCD_INVERTED_CLOCK.--- README | 5 +++++ drivers/video/atmel_lcdfb.c | 3 +++ 2 files changed, 8 insertions(+), 0 deletions(-)README +5
-0@@ -1063,6 +1063,11 @@ The following options need to be configured: Normally display is black on white background; define CONFIG_SYS_WHITE_ON_BLACK to get it inverted. + CONFIG_LCD_INVERTED_CLOCK + Define this if your LCD needs inverted clock polarity. Note + that this feature will work only if the selected LCD driver + and hardware controller support it. + - Splash Screen Support: CONFIG_SPLASH_SCREEN If this option is set, the environment is checked fordrivers/video/atmel_lcdfb.c +0
-0
drivers/video/atmel_lcdfb.c void lcd_ctrl_init(void *lcdbase) · line 117
Quoted 6 lines
drivers/video/atmel_lcdfb.c +3
-0@@ -112,6 +112,9 @@ void lcd_ctrl_init(void *lcdbase) value |= panel_info.vl_sync; value |= (panel_info.vl_bpix <<5 ); +#if defined(CONFIG_LCD_INVERTED_CLOCK ) + value |=ATMEL_LCDC_INVCLK_INVERTED ; +#endif
NACK
do this throught the struct via vl_sync as in linux
Best Regards,
J.
PATCH v3 2/3 Add support for Olimex SAM9-L9261 SBC
In reply to Dimitar DimitrovQuoted 4 lines · Dimitar Dimitrov
The SAM9-L9261 board support is based on code for AT91SAM9261EK. Networking is missing and will be added after the DM9000 support for AT91 boards is fixed to comply with U-Boot guide-lines.
---
this patch look at 80% similar as the at91sam9261ek
could you regenerate it with
git format-patch -M -B -C
Quoted 20 lines
MAINTAINERS | 3 + MAKEALL | 1 + Makefile | 17 +++ board/olimex/sam9_l9261/Makefile | 56 ++++++++ board/olimex/sam9_l9261/config.mk | 1 + board/olimex/sam9_l9261/led.c | 43 +++++++ board/olimex/sam9_l9261/partition.c | 40 ++++++ board/olimex/sam9_l9261/sam9_l9261.c | 214 +++++++++++++++++++++++++++++++ include/configs/sam9_l9261.h | 230 ++++++++++++++++++++++++++++++++++ tools/Makefile | 3 + tools/logos/olimex.bmp | Bin 0 -> 27510 bytes 11 files changed, 608 insertions(+), 0 deletions(-) create mode 100644 board/olimex/sam9_l9261/Makefile create mode 100644 board/olimex/sam9_l9261/config.mk create mode 100644 board/olimex/sam9_l9261/led.c create mode 100644 board/olimex/sam9_l9261/partition.c create mode 100644 board/olimex/sam9_l9261/sam9_l9261.c create mode 100644 include/configs/sam9_l9261.h create mode 100644 tools/logos/olimex.bmp
<snip>
board/olimex/sam9_l9261/sam9_l9261.c line 44
Quoted 6 lines
board/olimex/sam9_l9261/sam9_l9261.c new file +6
-0+ +/* ------------------------------------------------------------------------- */ +/* +* Miscelaneous platform dependent initialisations +*/ +
why don't you configure the dm9000 SMC?
<snip>
include/configs/sam9_l9261.h line 32
Quoted 3 lines
include/configs/sam9_l9261.h new file +3
-0+ +/* ARM asynchronous clock */ +#define AT91_CPU_NAME "AT91SAM9261"
no-need please remove
Quoted 33 lines
include/configs/sam9_l9261.h new file +33
-0+#define AT91_MAIN_CLOCK 18432000/* 18.432 MHz crystal */ +#define CONFIG_SYS_HZ 1000 + +#define CONFIG_ARM926EJS 1/* This is an ARM926EJS Core */ +#define CONFIG_AT91SAM9261 1/* It's an Atmel AT91SAM9261 SoC*/ +#define CONFIG_SAM9_L9261 1/* on an SAM9_L9261 Board */ +#define CONFIG_ARCH_CPU_INIT +#undef CONFIG_USE_IRQ/* we don't need IRQ/FIQ stuff */ + +#define CONFIG_CMDLINE_TAG 1/* enable passing of ATAGs */ +#define CONFIG_SETUP_MEMORY_TAGS 1 +#define CONFIG_INITRD_TAG 1 + +#define CONFIG_SKIP_LOWLEVEL_INIT +#define CONFIG_SKIP_RELOCATE_UBOOT + +/* +* Hardware drivers +*/ +#define CONFIG_ATMEL_USART 1 +#undef CONFIG_USART0 +#undef CONFIG_USART1 +#undef CONFIG_USART2 +#define CONFIG_USART3 1/* USART 3 is DBGU */ + +/* LCD */ +#define CONFIG_LCD 1 +#define LCD_BPP LCD_COLOR8 +#define CONFIG_LCD_LOGO 1 +#undef LCD_TEST_PATTERN +#define CONFIG_LCD_INFO 1 +#define CONFIG_LCD_INFO_BELOW_LOGO 1 +#define CONFIG_LCD_INVERTED_CLOCK 1
include/configs/sam9_l9261.h line 75
Quoted 10 lines
include/configs/sam9_l9261.h new file +10
-0+#define CONFIG_SYS_WHITE_ON_BLACK 1 +#define CONFIG_ATMEL_LCD 1 +#define CONFIG_ATMEL_LCD_BGR555 1 +#define CONFIG_SYS_CONSOLE_IS_IN_ENV 1 + +/* LED */ +#define CONFIG_AT91_LED +#define CONFIG_RED_LED AT91_PIN_PA23/* this is the power led */ +#define CONFIG_GREEN_LED AT91_PIN_PA13/* this is the user1 led */ +#define CONFIG_YELLOW_LED AT91_PIN_PA14/* this is the user2 led */
please fix the indent
Quoted 11 lines
include/configs/sam9_l9261.h new file +11
-0+ +#define CONFIG_BOOTDELAY 3 + +/* +* BOOTP options +*/ +#define CONFIG_BOOTP_BOOTFILESIZE 1 +#define CONFIG_BOOTP_BOOTPATH 1 +#define CONFIG_BOOTP_GATEWAY 1 +#define CONFIG_BOOTP_HOSTNAME 1 +
<snip>
include/configs/sam9_l9261.h line 217
Quoted 12 lines
include/configs/sam9_l9261.h new file +12
-0+ +#define CONFIG_BAUDRATE 115200 +#define CONFIG_SYS_BAUDRATE_TABLE {115200 , 19200, 38400, 57600, 9600 } + +#define CONFIG_SYS_PROMPT "U-Boot> " +#define CONFIG_SYS_CBSIZE 256 +#define CONFIG_SYS_MAXARGS 16 +#define CONFIG_SYS_PBSIZE (CONFIG_SYS_CBSIZE + sizeof(CONFIG_SYS_PROMPT) + 16) +#define CONFIG_SYS_LONGHELP 1 +#define CONFIG_CMDLINE_EDITING 1 + +#define ROUND (A ,B ) (((A) + (B)) & ~((B) - 1))
no-need please remove
Quoted 3 lines
+/*
+ * Size ofmalloc()pool
+ */
Best Regards,
J.
PATCH v3 3/3 Add support for Olimex SAM9-L9260 SBC
In reply to Dimitar DimitrovQuoted 6 lines · Dimitar Dimitrov
The SAM9-L9260 board support is based on code for AT91SAM9260EK. Networking is missing and will be added after the MACB support for AT91 boards is fixed to comply with U-Boot guide-lines.
Signed-off-by Dimitar Dimitrov <[email protected]>---
same as 9261
could you regenerate it with
git format-patch -M -B -C
Quoted 9 lines
MAINTAINERS | 1 + MAKEALL | 1 + Makefile | 17 +++ board/olimex/sam9_l9260/Makefile | 56 +++++++++ board/olimex/sam9_l9260/config.mk | 1 + board/olimex/sam9_l9260/led.c | 41 +++++++ board/olimex/sam9_l9260/partition.c | 40 +++++++ board/olimex/sam9_l9260/sam9_l9260.c | 111 ++++++++++++++++++ include/configs/sam9_l9260.h | 214 ++++++++++++++++++++++++++++++++++
<snip>
include/configs/sam9_l9260.h line 37
Quoted 4 lines
include/configs/sam9_l9260.h new file +4
-0+ +#define CONFIG_ARM926EJS 1/* This is an ARM926EJS Core */ + +#define AT91_CPU_NAME "AT91SAM9260"
no-need please remove
Quoted 16 lines
include/configs/sam9_l9260.h new file +16
-0+#define CONFIG_AT91SAM9260 1/* It's an Atmel AT91SAM9260 SoC*/ +#define CONFIG_SAM9_L9260 1/* on an SAM9_L9260 Board */ + +#define CONFIG_ARCH_CPU_INIT +#undef CONFIG_USE_IRQ/* we don't need IRQ/FIQ stuff */ + +#define CONFIG_CMDLINE_TAG 1/* enable passing of ATAGs */ +#define CONFIG_SETUP_MEMORY_TAGS 1 +#define CONFIG_INITRD_TAG 1 + +#define CONFIG_SKIP_LOWLEVEL_INIT +#define CONFIG_SKIP_RELOCATE_UBOOT + +/* +* Hardware drivers +*/
include/configs/sam9_l9260.h line 63
Quoted 10 lines
include/configs/sam9_l9260.h new file +10
-0+#define CONFIG_ATMEL_USART 1 +#undef CONFIG_USART0 +#undef CONFIG_USART1 +#undef CONFIG_USART2 +#define CONFIG_USART3 1/* USART 3 is DBGU */ + +/* LED */ +#define CONFIG_AT91_LED +#define CONFIG_RED_LED AT91_PIN_PA9/* this is the power led */ +#define CONFIG_GREEN_LED AT91_PIN_PA6/* this is the user led */
please fix the indent
Quoted 10 lines
include/configs/sam9_l9260.h new file +10
-0+ +#define CONFIG_BOOTDELAY 3 + +/* +* BOOTP options +*/ +#define CONFIG_BOOTP_BOOTFILESIZE 1 +#define CONFIG_BOOTP_BOOTPATH 1 +#define CONFIG_BOOTP_GATEWAY 1 +#define CONFIG_BOOTP_HOSTNAME 1
<snip>
include/configs/sam9_l9260.h line 201
Quoted 12 lines
include/configs/sam9_l9260.h new file +12
-0+ +#define CONFIG_BAUDRATE 115200 +#define CONFIG_SYS_BAUDRATE_TABLE {115200 , 19200, 38400, 57600, 9600 } + +#define CONFIG_SYS_PROMPT "U-Boot> " +#define CONFIG_SYS_CBSIZE 256 +#define CONFIG_SYS_MAXARGS 16 +#define CONFIG_SYS_PBSIZE (CONFIG_SYS_CBSIZE + sizeof(CONFIG_SYS_PROMPT) + 16) +#define CONFIG_SYS_LONGHELP 1 +#define CONFIG_CMDLINE_EDITING 1 + +#define ROUND (A ,B ) (((A) + (B)) & ~((B) - 1))
no-need please remove
Quoted 3 lines
+/*
+ * Size ofmalloc()pool
+ */
Best Regards,
J.
PATCH 1/1 Add inverted clock polarity support for Atmel LCD driver
In reply to Jean-Christophe PLAGNIOL-VILLARDQuoted 1 line · Jean-Christophe PLAGNIOL-VILLARD
On 18:56 Wed 15 Jul , Dimitar Dimitrov wrote:
...
Quoted 11 lines
drivers/video/atmel_lcdfb.c void lcd_ctrl_init(void *lcdbase) · line 117
Quoted 9 lines
drivers/video/atmel_lcdfb.c +3
-0@@ -112,6 +112,9 @@ void lcd_ctrl_init(void *lcdbase) value |= panel_info.vl_sync; value |= (panel_info.vl_bpix <<5 ); +#if defined(CONFIG_LCD_INVERTED_CLOCK ) + value |=ATMEL_LCDC_INVCLK_INVERTED ; +#endif NACK
do this throught the struct viavl_syncas in linux
actually the "vl_sync" is supposed to contain HSYNC and VSYNC polarity flags and not the dot clock polarity. The Linux driver in mainline uses var.sync for this purpose too, and doesn't set inverted dot clock polarity at all.
This definition in struct vidinfo for Atmel LCD
/* LCD configuration register */
u_long vl_sync; /* Horizontal / vertical sync */
u_long vl_bpix; /* Bits per pixel, 0 = 1, 1 = 2, 2 = 4, 3 = 8,
4 = 16 */
u_long vl_tft; /* 0 = passive, 1 = TFT */is confusing. If these fields are supposed to contain flags for LCD configuration register LCDCON2 then we should define only one "u_long lcdcon2" field containing all the flags/fields for sync polarity, bpp, clock polarity, scan mode, display type, interface width, LCDD, LCDDEN polarities, LCDDOTCLK mode and memory ordering format. We are wasting tree u_longs here and are not even able to use half of the possible settings for LCDCON2 register. I would rather fix the struct vidinfo for Atmel LCD so that people could set needed flags in the board code, e.g.:
vidinfo_t panel_info = {
...
lcdcon2: ATMEL_LCDC_INVLINE_INVERTED |
ATMEL_LCDC_INVFRAME_INVERTED |
ATMEL_LCDC_INVCLK_INVERTED;
...
}I don't have the Atmel hardware to test/fix this change however.
Best regards,
Anatolij
PATCH 1/1 Add inverted clock polarity support for Atmel LCD driver
Quoted 17 lines
This definition in struct vidinfo for Atmel LCD
/* LCD configuration register */ u_long vl_sync; /* Horizontal / vertical sync */ u_long vl_bpix; /* Bits per pixel, 0 = 1, 1 = 2, 2 = 4, 3 = 8, 4 = 16 */ u_long vl_tft; /* 0 = passive, 1 = TFT */is confusing. If these fields are supposed to contain flags for LCD configuration register LCDCON2 then we should define only one "
u_longlcdcon2" field containing all the flags/fields for sync polarity, bpp, clock polarity, scan mode, display type, interface width, LCDD, LCDDEN polarities, LCDDOTCLK mode and memory ordering format. We are wasting treeu_longshere and are not even able to use half of the possible settings for LCDCON2 register. I would rather fix the struct vidinfo for Atmel LCD so that people could set needed flags in the board code, e.g.:
Quoted 7 lines
vidinfo_t panel_info = {
...
lcdcon2: ATMEL_LCDC_INVLINE_INVERTED |
ATMEL_LCDC_INVFRAME_INVERTED |
ATMEL_LCDC_INVCLK_INVERTED;
...
}I disagree here we must not make the panel_info atmel specific that way we can add fields to pass atmel specific info which are pass via struct atmel_lcdfb_info in Linux
But we need to be sync with linux as possible to simplify port and bugfix.
btw on Linux you do not specify it directly you specific thisFB_SYNC_HOR_HIGH_ACT => ATMEL_LCDC_INVLINE_INVERTEDFB_SYNC_VERT_HIGH_ACT => ATMEL_LCDC_INVFRAME_INVERTED
Best Regards,
J.
PATCH 1/1 Add inverted clock polarity support for Atmel LCD driver
In reply to Anatolij GustschinQuoted 13 lines · Anatolij Gustschin
Quoted 11 lines · Dimitar Dimitrov
This is my third try for Olimex SAM9-L9260/61 board support patches.
Here follows the first patch.
---Boards utilizing the Atmel LCD driver can now specify that the LCD clock must be inverted by defining the macro
CONFIG_LCD_INVERTED_CLOCK.--- README | 5 +++++ drivers/video/atmel_lcdfb.c | 3 +++ 2 files changed, 8 insertions(+), 0 deletions(-)
Quoted 3 lines
Applied to u-boot-video after fixing commit message and adding your Signed-off-by line. Also please check for trailing white spaces next time. Thanks!
now i removed this patch from u-boot-video due to NACK from Jean-Christophe.
Best regards,
Anatolij
PATCH 1/1 Add inverted clock polarity support for Atmel LCD driver
In reply to Dimitar DimitrovDear Dimitar Dimitrov,
Quoted 11 lines · In message <[email protected]> you wrote:
This is my third try for Olimex SAM9-L9260/61 board support patches.
Here follows the first patch.
---Boards utilizing the Atmel LCD driver can now specify that the LCD clock must be inverted by defining the macro
CONFIG_LCD_INVERTED_CLOCK.--- README | 5 +++++ drivers/video/atmel_lcdfb.c | 3 +++ 2 files changed, 8 insertions(+), 0 deletions(-)
I think we are stillw aiting for a re-submit of this patch after cleaning up?
Best regards,
Wolfgang Denk
Signature · 7 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de There comes to all races an ultimate crisis which you have yet to face .... One day our minds became so powerful we dared think of ourselves as gods. -- Sargon, "Return to Tomorrow", stardate 4768.3
PATCH 1/1 Add inverted clock polarity support for Atmel LCD driver
Quoted 15 lines · Wolfgang Denk
Dear Dimitar Dimitrov,
Quoted 11 lines · In message <[email protected]> you wrote:
This is my third try for Olimex SAM9-L9260/61 board support patches.
Here follows the first patch.
---Boards utilizing the Atmel LCD driver can now specify that the LCD clock must be inverted by defining the macro
CONFIG_LCD_INVERTED_CLOCK.--- README | 5 +++++ drivers/video/atmel_lcdfb.c | 3 +++ 2 files changed, 8 insertions(+), 0 deletions(-)
Quoted 7 lines
I think we are stillw aiting for a re-submit of this patch after cleaning up?
Best regards,
Wolfgang Denk
I can regenerate the patches for the latest GIT. If someone is willing to try them please let me know.
Unfortunately I don't have the boards anymore so I can't verify that the new patches and new u-boot will work. That's why I avoid resubmission in this RC window.
Regards,
Dimitar
PATCH 1/1 Add inverted clock polarity support for Atmel LCD driver
Dear Dimitar Dimitrov,
Quoted 4 lines · In message <[email protected]> you wrote:
I can regenerate the patches for the latest GIT. If someone is willing to try them please let me know.
Unfortunately I don't have the boards anymore so I can't verify that the new patches and new u-boot will work. That's why I avoid resubmission in this RC window.
Please clean up and resubmit, and mark the patches as "for `next'" so we know they should go into the "next" branch. Thanks in advance.
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Keep your eyes wide open before marriage, half shut afterwards.
-- Benjamin Franklin