Skip to contentSkip to conversation

acpi: remove superfluous NULL pointer check from acpi_processor_get_throttling_info()

PATCH RESEND New Bartlomiej Zolnierkiewicz 1 participant 1 message Jan 5, 2010 ACPI

lore
Share & tools
lore

Bartlomiej Zolnierkiewicz

author
#0 lore raw

PATCH RESEND 1/1 acpi: remove superfluous NULL pointer check from acpi_processor_get_throttling_info()

Quoted 1 line

From Dan's list:

drivers/acpi/processor_throttling.c +1139 acpi_processor_get_throttling_info(11) warning: variable derefenced before check 'pr'

acpi_processor_get_throttling_info() is never called with pr == NULL.

[ bart: the potential NULL pointer dereference was finally fixed in
(much later than mine) commit 5cfa245 but my patch is still valid ]

Reported-by Dan Carpenter <[email protected]>
Cc Jonathan Corbet <[email protected]>
Cc Eugene Teo <[email protected]>
Signed-off-by Bartlomiej Zolnierkiewicz <[email protected]>
---
 drivers/acpi/processor_throttling.c |    3 ---
 1 file changed, 3 deletions(-)
drivers/acpi/processor_throttling.c +0 -3
Index: b/drivers/acpi/processor_throttling.c
===================================================================
@@ -1133,9 +1133,6 @@ int acpi_processor_get_throttling_info(s
 	int result = 0;
 	struct acpi_processor_throttling *pthrottling;
 
-	if (!pr)
-		return -EINVAL;
-
 	ACPI_DEBUG_PRINT((ACPI_DB_INFO,
 			  "pblk_address[0x%08x] duty_offset[%d] duty_width[%d]\n",
 			  pr->throttling.address,