per-bdi flushing model improvements. reiser4
cover per-bdi flushing model improvements. reiser4
Hello.
Quoted 6 lines · Andrew Morton
reiser4 is currently disabled in -mm (via reiser4-disable.patch) because recent changes to
fs/fs/writeback.cwrecked the build. I fixed it about ten times as the underlying code was churning, then gave up. It would be nice if you take a look at that sometime please.
I have taken a look at fs/fs-writeback.c and found that per-superblock flushing interface is eliminated. However migrating to per-bdi flushing model doesn't necessarily means that such interface doesn't exist or is not needed anymore. Flushing in accordance with the scheme "data-inode- data-inode-..." would be very suboptimal for reiser4. Also xfs people were unhappy with such flushing model:
http://article.gmane.org/gmane.linux.file-systems/30153
Moreover, current stuff doesn't look fine. Why do we pin/unpin superblock for every inode? It would be more reasonable to pin it for the whole group of inodes and call a flushing handler for them. The patch 4 introduces such handler writeback_sb_inodes (which resembles dropped sync_sb_inodes, the difference is that the newer version doesn't flush necessarily all inodes of the superblock). Please, consider pushing this patch to mainline.
The patch 5 adds a super operation .writeback_inodes (former .sync_inodes) which allows a file system to make optimizations. It can happen that reiser4 will flush a bit more inodes then generic implementation suggests. "a bit more" doesn't mean "all dirty inodes of the superblock" (see a comment about atoms in the header of patch 6).
Finally, some file systems have its own means for periodical writeout of dirty data. Since b_io contains inodes of many superblocks we need to evict our inodes back to dirty list when flushing is going on with for_kupdate flag installed. The new library function writeback_skip_sb_inodes() provides such possibility.
Please, apply.
Thanks,
Edward.
I got this introduction twice, but patches 1-3 didn't make it to any of the lists.
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
Quoted 5 lines · Christoph Hellwig
I got this introduction twice, but patches 1-3 didn't make it to any of the lists.
done
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
Quoted 7 lines · Edward Shishkin
Quoted 5 lines · Christoph Hellwig
I got this introduction twice, but patches 1-3 didn't make it to any of the lists.
done
Where?
Signature · 6 lines
Jens Axboe _______________________________________________ xfs mailing list [email protected] http://oss.sgi.com/mailman/listinfo/xfs
To clarify (being a ReiserFS subscriber):
patch 0, 4-6 sent to Andrew, ReiserFS, linux-fsdevel, linux-kernel, xfs, jens.axboe
patch 1-3, 7 sent to Andrew, ReiserFS
- Ronni
Quoted 20 lines · Jens Axboe
Quoted 7 lines · Edward Shishkin
Quoted 5 lines · Christoph Hellwig
I got this introduction twice, but patches 1-3 didn't make it to any of the lists.
done
Where?
--
Jens Axboe--
To unsubscribe from this list: send the line "unsubscribe reiserfs-devel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Signature · 2 lines
Venlig hilsen Ronni
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
Quoted 6 lines · Jens Axboe
Quoted 3 lines · Edward Shishkin
Quoted 2 lines · Christoph Hellwig
I got this introduction twice, but patches 1-3 didn't make it to any of the lists.
Where?
To clarify (being a ReiserFS subscriber):
patch 0, 4-6 sent to Andrew, ReiserFS, linux-fsdevel, linux-kernel, xfs, jens.axboe
patch 1-3, 7 sent to Andrew, ReiserFS
- Ronni
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
Hello everyone.
The patches 1-3 are reverses for the following -mm stuff:
http://userweb.kernel.org/~akpm/mmotm/broken-out/reiser4-fixed-null-pointer-dereference.patch
http://userweb.kernel.org/~akpm/mmotm/broken-out/reiser4-generic_sync_sb_inodes-doesnt-exist-anymore.patch
http://userweb.kernel.org/~akpm/mmotm/broken-out/reiser4-vfs-add-super_operationssync_inodes-2.patch
This is incorrect attempts to adjust reiser4 to the new per-bdi flushing model. The authors are cc-ed,
any comments, suggestions are welcome.
Thanks,
Edward.
Quoted 39 lines · Ronni Holm-Nielsen
To clarify (being a ReiserFS subscriber):
patch 0, 4-6 sent to Andrew, ReiserFS, linux-fsdevel, linux-kernel, xfs, jens.axboe
patch 1-3, 7 sent to Andrew, ReiserFS- Ronni
Quoted 24 lines · Jens Axboe
Quoted 10 lines · Edward Shishkin
Quoted 6 lines · Christoph Hellwig
I got this introduction twice, but patches 1-3 didn't make it to any of the lists.
done
Where?
--
Jens Axboe--
To unsubscribe from this list: send the line "unsubscribe reiserfs-devel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
Hi.
Thank you Edward. The related bug was/is
http://bugzilla.kernel.org/show_bug.cgi?id=14915
It'd be great if someone could solve this, as the reiser4 patch is not usable in its current state, with or without my illfated attempts to fix it.
Kind regards,
Johannes
Quoted 58 lines · On Tue, 02 Feb 2010 23:26:20 +0100 Edward Shishkin <[email protected]>…
Hello everyone.
The patches 1-3 are reverses for the following -mm stuff:
http://userweb.kernel.org/~akpm/mmotm/broken-out/reiser4-fixed-null-pointer-dereference.patch
http://userweb.kernel.org/~akpm/mmotm/broken-out/reiser4-generic_sync_sb_inodes-doesnt-exist-anymore.patch
http://userweb.kernel.org/~akpm/mmotm/broken-out/reiser4-vfs-add-super_operationssync_inodes-2.patchThis is incorrect attempts to adjust reiser4 to the new per-bdi flushing model.
The authors are cc-ed,
any comments, suggestions are welcome.Thanks,
Edward.Quoted 40 lines · Ronni Holm-Nielsen
To clarify (being a ReiserFS subscriber):
patch 0, 4-6 sent to Andrew, ReiserFS, linux-fsdevel, linux-kernel, xfs, jens.axboe
patch 1-3, 7 sent to Andrew, ReiserFS- Ronni
Quoted 24 lines · Jens Axboe
Quoted 10 lines · Edward Shishkin
Quoted 6 lines · Christoph Hellwig
I got this introduction twice, but patches 1-3 didn't make it to any of the lists.
done
Where?
--
Jens Axboe--
To unsubscribe from this list: send the line "unsubscribe reiserfs-devel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Signature · 3 lines
Emails können geändert, gefälscht und eingesehen werden. Signiere oder verschüssele deine Mails mit GPG. http://web.student.tuwien.ac.at/~e0625457/pgp.html
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
Hello.
Everything should work now (at least it works for me). Please check the latest -mm or reiser4-for-2.6.32 stuff If no problems then let's close this BZ..
Thanks,
Edward.
Quoted 8 lines · Johannes Buchner
Hi.
Thank you Edward. The related bug was/is
http://bugzilla.kernel.org/show_bug.cgi?id=14915
It'd be great if someone could solve this, as the reiser4 patch is not usable in its current state, with or without my illfated attempts to fix it.
Quoted 74 lines
Kind regards,
JohannesQuoted 64 lines · On Tue, 02 Feb 2010 23:26:20 +0100 Edward Shishkin <[email protected]>…
Hello everyone.
The patches 1-3 are reverses for the following -mm stuff:
http://userweb.kernel.org/~akpm/mmotm/broken-out/reiser4-fixed-null-pointer-dereference.patch
http://userweb.kernel.org/~akpm/mmotm/broken-out/reiser4-generic_sync_sb_inodes-doesnt-exist-anymore.patch
http://userweb.kernel.org/~akpm/mmotm/broken-out/reiser4-vfs-add-super_operationssync_inodes-2.patchThis is incorrect attempts to adjust reiser4 to the new per-bdi flushing model.
The authors are cc-ed,
any comments, suggestions are welcome.Thanks,
Edward.Quoted 45 lines · Ronni Holm-Nielsen
To clarify (being a ReiserFS subscriber):
patch 0, 4-6 sent to Andrew, ReiserFS, linux-fsdevel, linux-kernel, xfs, jens.axboe
patch 1-3, 7 sent to Andrew, ReiserFS- Ronni
Quoted 29 lines · Jens Axboe
Quoted 13 lines · Edward Shishkin
Quoted 7 lines · Christoph Hellwig
I got this introduction twice, but patches 1-3 didn't make it to any of the lists.
done
Where?
--
Jens Axboe--
To unsubscribe from this list: send the line "unsubscribe reiserfs-devel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
Quoted 3 lines · Johannes Buchner
It'd be great if someone could solve this, as the reiser4 patch is not usable in its current state, with or without my illfated attempts to fix it.
FWIW, I'm running Linus' latest -git with refs/heads/reiser4 on top[0], no issues during 2.6.33-git so far. Try it, if you don't like manually applying patches either :-)
Christian.
[0] http://git.zen-kernel.org/?p=kernel/zen.git;a=shortlog;h=refs/heads/reiser4
Signature · 8 lines
BOFH excuse #275: Bit rot _______________________________________________ xfs mailing list [email protected] http://oss.sgi.com/mailman/listinfo/xfs