drm: dereferencing before checking for null
Subsystems (2)
PATCH 1/1 drm: dereferencing before checking for null
The original code dereferences "fb_helper_conn" before verifying that it's non-null.
Signed-off-by Dan Carpenter <[email protected]>
---
It's never null here actually. I could send a patch to remove the check instead if that's prefered.
drivers/gpu/drm/drm_fb_helper.c +2 -1
@@ -96,11 +96,12 @@ static bool drm_fb_helper_connector_parse_command_line(struct drm_fb_helper_connint i;enum drm_connector_force force =DRM_FORCE_UNSPECIFIED ;struct drm_fb_helper_cmdline_mode *cmdline_mode; -struct drm_connector *connector = fb_helper_conn->connector; +struct drm_connector *connector;if (!fb_helper_conn)return false; + connector = fb_helper_conn->connector; cmdline_mode = &fb_helper_conn->cmdline_mode;if (!mode_option) mode_option = fb_mode_option;
------------------------------------------------------------------------------
--